coreboot-gerrit April 2022

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

Change in coreboot[master]: drivers/intel/dptf: Add support for Battery participant
by Varshit B Pandya (Code Review) 03 Apr '22

03 Apr '22

Attention is currently required from: Lance Zhao, Paul Menzel, Rizwan Qureshi, Tim Wawrzynczak. Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63315 ) Change subject: drivers/intel/dptf: Add support for Battery participant ...................................................................... Patch Set 4: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/63315/comment/9508e79a_d7a91f19 PS3, Line 10: Add > add Done https://review.coreboot.org/c/coreboot/+/63315/comment/38ad6871_2da37332 PS3, Line 9: As per Intel Dynamic Tuning revision 1.3.13 (Doc no: 541817) : Add support for TBAT device under \_SB.DPTF > Please use the full textwidth of 72 characters per line. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/63315 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9104318fd838f30253ab1eeac4e212b3b917f516 Gerrit-Change-Number: 63315 Gerrit-PatchSet: 4 Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Attention: Lance Zhao Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Sun, 03 Apr 2022 07:17:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake: Add HID for DPTF Battery Participant
by Varshit B Pandya (Code Review) 03 Apr '22

03 Apr '22

Attention is currently required from: Subrata Banik, Rizwan Qureshi, Tim Wawrzynczak. Hello build bot (Jenkins), Subrata Banik, Rizwan Qureshi, Tim Wawrzynczak, Sumeet R Pawnikar, Eric Lai, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63316 to look at the new patch set (#4). Change subject: soc/intel/alderlake: Add HID for DPTF Battery Participant ...................................................................... soc/intel/alderlake: Add HID for DPTF Battery Participant HID is defined in Intel Dynamic Tuning revision 1.3.13 (Doc no: 541817) BUG=b:205928013 TEST=Build, boot brya0 and dump SSDT to check BAT1 device HID Signed-off-by: Varshit B Pandya <varshit.b.pandya(a)intel.com> Change-Id: Ie1fff53f938a5f13423e360c24c7181fa7613492 --- M src/soc/intel/alderlake/dptf.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/63316/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/63316 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie1fff53f938a5f13423e360c24c7181fa7613492 Gerrit-Change-Number: 63316 Gerrit-PatchSet: 4 Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: drivers/intel/dptf: Add support for Battery participant
by Varshit B Pandya (Code Review) 03 Apr '22

03 Apr '22

Attention is currently required from: Varshit B Pandya, Lance Zhao, Rizwan Qureshi, Tim Wawrzynczak. Hello Lance Zhao, build bot (Jenkins), Subrata Banik, Rizwan Qureshi, Tim Wawrzynczak, Sumeet R Pawnikar, Eric Lai, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63315 to look at the new patch set (#4). Change subject: drivers/intel/dptf: Add support for Battery participant ...................................................................... drivers/intel/dptf: Add support for Battery participant As per Intel Dynamic Tuning revision 1.3.13 (Doc no: 541817) add support for TBAT device under \_SB.DPTF BUG=b:205928013 TEST=Build, boot brya0 and dump SSDT to check TBAT device Device (TBAT) { Name (_HID, "INTC1061") // _HID: Hardware ID Name (_UID, "TBAT") // _UID: Unique ID Name (_STR, "Battery Participant") // _STR: Description String Name (PTYP, 0xC) Method (_STA, 0, NotSerialized) // _STA: Status { Return (0x0F) } } Signed-off-by: Varshit B Pandya <varshit.b.pandya(a)intel.com> Change-Id: I9104318fd838f30253ab1eeac4e212b3b917f516 --- M src/acpi/acpigen_dptf.c M src/drivers/intel/dptf/Kconfig M src/drivers/intel/dptf/dptf.c M src/drivers/intel/dptf/dptf.h M src/include/acpi/acpigen_dptf.h 5 files changed, 36 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/63315/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/63315 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9104318fd838f30253ab1eeac4e212b3b917f516 Gerrit-Change-Number: 63315 Gerrit-PatchSet: 4 Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Attention: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Attention: Lance Zhao Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util/cbmem: add type cast
by Paul Menzel (Code Review) 03 Apr '22

03 Apr '22

Attention is currently required from: Paul Fagerburg. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63317 ) Change subject: util/cbmem: add type cast ...................................................................... Patch Set 3: (1 comment) File util/cbmem/cbmem.c: https://review.coreboot.org/c/coreboot/+/63317/comment/cd35d033_3a9fa00b PS3, Line 642: printf(" %llu\n", (long long)arch_convert_raw_ts_entry(stamp)); > I think the cast should have been `unsigned long long`, and is unneeded, as `src/include/stdint. […] Oh, it’s user space program, then please use the "%"PRIu64 format specifier. -- To view, visit https://review.coreboot.org/c/coreboot/+/63317 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I87a83758b7f122b77f9631c669c7cd8df66f8d1b Gerrit-Change-Number: 63317 Gerrit-PatchSet: 3 Gerrit-Owner: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-Comment-Date: Sun, 03 Apr 2022 06:31:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/cbmem: add type cast
by Paul Menzel (Code Review) 03 Apr '22

03 Apr '22

Attention is currently required from: Paul Fagerburg. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63317 ) Change subject: util/cbmem: add type cast ...................................................................... Patch Set 3: (1 comment) File util/cbmem/cbmem.c: https://review.coreboot.org/c/coreboot/+/63317/comment/eb201c75_84d54b94 PS3, Line 642: printf(" %llu\n", (long long)arch_convert_raw_ts_entry(stamp)); I think the cast should have been `unsigned long long`, and is unneeded, as `src/include/stdint.h` has: typedef unsigned long long uint64_t; -- To view, visit https://review.coreboot.org/c/coreboot/+/63317 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I87a83758b7f122b77f9631c669c7cd8df66f8d1b Gerrit-Change-Number: 63317 Gerrit-PatchSet: 3 Gerrit-Owner: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-Comment-Date: Sun, 03 Apr 2022 06:28:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: amdfwtool: Add a macro to set explicitly second gen for old SOCs
by Bao Zheng (Code Review) 03 Apr '22

03 Apr '22

Attention is currently required from: Zheng Bao. Hello Zheng Bao, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/63319 to review the following change. Change subject: amdfwtool: Add a macro to set explicitly second gen for old SOCs ...................................................................... amdfwtool: Add a macro to set explicitly second gen for old SOCs It is more reasonable than getting the value from memset. Change-Id: I65caa11e835d2ff52bec4b8904057bbced434891 Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> --- M util/amdfwtool/amdfwtool.c M util/amdfwtool/amdfwtool.h 2 files changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/63319/1 diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c index 80595ddb..bdb18b9 100644 --- a/util/amdfwtool/amdfwtool.c +++ b/util/amdfwtool/amdfwtool.c @@ -1383,6 +1383,7 @@ } switch (soc_id) { case PLATFORM_STONEYRIDGE: + amd_romsig->efs_gen.gen = EFS_BEFORE_SECOND_GEN; amd_romsig->spi_readmode_f15_mod_60_6f = efs_spi_readmode; amd_romsig->fast_speed_new_f15_mod_60_6f = efs_spi_speed; break; @@ -1390,6 +1391,7 @@ case PLATFORM_PICASSO: /* amd_romsig->efs_gen introduced after RAVEN/PICASSO. * Leave as 0xffffffff for first gen */ + amd_romsig->efs_gen.gen = EFS_BEFORE_SECOND_GEN; amd_romsig->spi_readmode_f17_mod_00_2f = efs_spi_readmode; amd_romsig->spi_fastspeed_f17_mod_00_2f = efs_spi_speed; switch (efs_spi_micron_flag) { diff --git a/util/amdfwtool/amdfwtool.h b/util/amdfwtool/amdfwtool.h index a241316..3af4e94 100644 --- a/util/amdfwtool/amdfwtool.h +++ b/util/amdfwtool/amdfwtool.h @@ -88,6 +88,7 @@ } __attribute__((packed)); #define EFS_SECOND_GEN 0 +#define EFS_BEFORE_SECOND_GEN 1 typedef struct _embedded_firmware { uint32_t signature; /* 0x55aa55aa */ -- To view, visit https://review.coreboot.org/c/coreboot/+/63319 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I65caa11e835d2ff52bec4b8904057bbced434891 Gerrit-Change-Number: 63319 Gerrit-PatchSet: 1 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Attention: Zheng Bao Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: drivers/intel/dptf: Add support for Battery participant
by Paul Menzel (Code Review) 02 Apr '22

02 Apr '22

Attention is currently required from: Varshit B Pandya, Lance Zhao, Rizwan Qureshi, Tim Wawrzynczak. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63315 ) Change subject: drivers/intel/dptf: Add support for Battery participant ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/63315/comment/0b3e36e7_89f5a19a PS3, Line 10: Add add https://review.coreboot.org/c/coreboot/+/63315/comment/d379b4a4_225e454e PS3, Line 9: As per Intel Dynamic Tuning revision 1.3.13 (Doc no: 541817) : Add support for TBAT device under \_SB.DPTF Please use the full textwidth of 72 characters per line. -- To view, visit https://review.coreboot.org/c/coreboot/+/63315 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9104318fd838f30253ab1eeac4e212b3b917f516 Gerrit-Change-Number: 63315 Gerrit-PatchSet: 3 Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Attention: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Attention: Lance Zhao Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Sun, 03 Apr 2022 05:42:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake: Add HID for DPTF Battery Participant
by Paul Menzel (Code Review) 02 Apr '22

02 Apr '22

Attention is currently required from: Varshit B Pandya, Subrata Banik, Rizwan Qureshi, Tim Wawrzynczak. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63316 ) Change subject: soc/intel/alderlake: Add HID for DPTF Battery Participant ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/63316/comment/3929a01b_903a3446 PS3, Line 8: Please document, where that HID is defined. -- To view, visit https://review.coreboot.org/c/coreboot/+/63316 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie1fff53f938a5f13423e360c24c7181fa7613492 Gerrit-Change-Number: 63316 Gerrit-PatchSet: 3 Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Attention: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Sun, 03 Apr 2022 05:40:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: doc/mb/hp/z220_sff: Add flash override jumper info
by Paul Menzel (Code Review) 02 Apr '22

02 Apr '22

Attention is currently required from: Damien Zammit. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63318 ) Change subject: doc/mb/hp/z220_sff: Add flash override jumper info ...................................................................... Patch Set 1: (1 comment) File Documentation/mainboard/hp/z220_sff.md: https://review.coreboot.org/c/coreboot/+/63318/comment/111ee21c_b16c8006 PS1, Line 43: there is a jumper on the board Maybe give a rough location (bottom-right or next to CPU socket). -- To view, visit https://review.coreboot.org/c/coreboot/+/63318 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia23f73d97d2fab0c561b33656a09709d42cb2f73 Gerrit-Change-Number: 63318 Gerrit-PatchSet: 1 Gerrit-Owner: Damien Zammit Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Damien Zammit Gerrit-Comment-Date: Sun, 03 Apr 2022 05:38:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: doc/mb/hp/z220_sff: Add flash override jumper info
by Paul Menzel (Code Review) 02 Apr '22

02 Apr '22

Attention is currently required from: Damien Zammit. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63318 ) Change subject: doc/mb/hp/z220_sff: Add flash override jumper info ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File Documentation/mainboard/hp/z220_sff.md: https://review.coreboot.org/c/coreboot/+/63318/comment/f8f3ed78_02b3ba6b PS1, Line 43: However, there is a jumper on the board marked `FDO` (flash descriptor override). Nit: Please do not wrap lines after sentences. -- To view, visit https://review.coreboot.org/c/coreboot/+/63318 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia23f73d97d2fab0c561b33656a09709d42cb2f73 Gerrit-Change-Number: 63318 Gerrit-PatchSet: 1 Gerrit-Owner: Damien Zammit Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Damien Zammit Gerrit-Comment-Date: Sun, 03 Apr 2022 05:37:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2022