coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: i2c: Configurable I2C transfer timeout
by Hung-Te Lin (Code Review) 05 Mar '22

05 Mar '22

Attention is currently required from: Jes Klinke, Patrick Rudolph. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62278 ) Change subject: i2c: Configurable I2C transfer timeout ...................................................................... Patch Set 7: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/62278 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6423122f32aad1dbcee0bfe240cdaa8cb512791f Gerrit-Change-Number: 62278 Gerrit-PatchSet: 7 Gerrit-Owner: Jes Klinke <jbk(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Qii Wang <qii.wang(a)mediatek.corp-partner.google.com> Gerrit-CC: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Jes Klinke <jbk(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sat, 05 Mar 2022 00:35:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush: Enable EC SMI handler
by Raul Rangel (Code Review) 05 Mar '22

05 Mar '22

Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/62599 ) Change subject: mb/google/guybrush: Enable EC SMI handler ...................................................................... mb/google/guybrush: Enable EC SMI handler This change allows the EC to send SMM interrupts to the AP. SMM interrupts are only enabled during boot, and are disabled once ACPI is enabled. The only event that is currently handled by `chromeec_process_one_event` is EC_HOST_EVENT_LID_CLOSED. This is used to power off the system in case the OS never loaded and the lid was closed. BUG=b:222694093 TEST=Boot guybrush, run `lpc smi` on EC console. Verify SMM handler runs. Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> Change-Id: I52b96b1b7c3c25a8355eaba4e84dbce49451b7f8 --- M src/mainboard/google/guybrush/ec.c M src/mainboard/google/guybrush/smihandler.c 2 files changed, 19 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/62599/1 diff --git a/src/mainboard/google/guybrush/ec.c b/src/mainboard/google/guybrush/ec.c index f62ca20..da3f420 100644 --- a/src/mainboard/google/guybrush/ec.c +++ b/src/mainboard/google/guybrush/ec.c @@ -21,6 +21,7 @@ const struct google_chromeec_event_info info = { .log_events = MAINBOARD_EC_LOG_EVENTS, .sci_events = MAINBOARD_EC_SCI_EVENTS, + .smi_events = MAINBOARD_EC_SMI_EVENTS, .s3_wake_events = MAINBOARD_EC_S3_WAKE_EVENTS, .s5_wake_events = MAINBOARD_EC_S5_WAKE_EVENTS, .s0ix_wake_events = MAINBOARD_EC_S0IX_WAKE_EVENTS, @@ -30,4 +31,6 @@ /* Configure eSPI VW SCI events */ gpe_configure_sci(espi_sci_sources, ARRAY_SIZE(espi_sci_sources)); + + configure_smi(SMITYPE_ESPI_SMI, SMI_MODE_SMI); } diff --git a/src/mainboard/google/guybrush/smihandler.c b/src/mainboard/google/guybrush/smihandler.c index f67ff31..bcf883a 100644 --- a/src/mainboard/google/guybrush/smihandler.c +++ b/src/mainboard/google/guybrush/smihandler.c @@ -1,11 +1,13 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ +#include <amdblocks/smm.h> #include <baseboard/variants.h> #include <console/console.h> #include <cpu/x86/smm.h> #include <ec/google/chromeec/ec.h> #include <ec/google/chromeec/smm.h> #include <elog.h> +#include <soc/smi.h> #include <variant/ec.h> void mainboard_smi_gpi(u32 gpi_sts) @@ -36,3 +38,17 @@ { google_chromeec_log_events(MAINBOARD_EC_LOG_EVENTS | MAINBOARD_EC_S0IX_WAKE_EVENTS); } + +void mainboard_handle_smi(int event) +{ + switch (event) { + case SMITYPE_ESPI_SMI: + printk(BIOS_DEBUG, "Processing EC SMI\n"); + + chromeec_smi_process_events(); + break; + default: + printk(BIOS_WARNING, "SMI event %d is missing handler\n", event); + return; + } +} -- To view, visit https://review.coreboot.org/c/coreboot/+/62599 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I52b96b1b7c3c25a8355eaba4e84dbce49451b7f8 Gerrit-Change-Number: 62599 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/amd/common/block: Add mainboard_handle_smi
by Raul Rangel (Code Review) 05 Mar '22

05 Mar '22

Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/62598 ) Change subject: soc/amd/common/block: Add mainboard_handle_smi ...................................................................... soc/amd/common/block: Add mainboard_handle_smi The current SMM framework only allows the mainboard code to handle GPEs. i.e., Events 0 - 23. This change allows the mainboard code to handle any SMI events not handled by the SoC code. This will allow the mainboard code to handle `SMITYPE_ESPI_SMI`. BUG=b:222694093 TEST=Build guybrush Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> Change-Id: I81943e8cb31e998f29cc60b565d3ca0a8dfe9cb2 --- M src/soc/amd/common/block/cpu/smm/smi_handler.c M src/soc/amd/common/block/include/amdblocks/smm.h 2 files changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/62598/1 diff --git a/src/soc/amd/common/block/cpu/smm/smi_handler.c b/src/soc/amd/common/block/cpu/smm/smi_handler.c index e535cb0..f662a75 100644 --- a/src/soc/amd/common/block/cpu/smm/smi_handler.c +++ b/src/soc/amd/common/block/cpu/smm/smi_handler.c @@ -7,6 +7,11 @@ #include <cpu/x86/smm.h> #include <soc/smi.h> +__weak void mainboard_handle_smi(int event) +{ + printk(BIOS_WARNING, "SMI event %d is missing handler\n", event); +} + static void process_smi_sources(uint32_t reg) { const uint32_t status = smi_read32(reg); @@ -19,6 +24,8 @@ source_handler = get_smi_source_handler(i + bit_zero); if (source_handler) source_handler(); + else + mainboard_handle_smi(i + bit_zero); } } diff --git a/src/soc/amd/common/block/include/amdblocks/smm.h b/src/soc/amd/common/block/include/amdblocks/smm.h index 187eddf..09d499b 100644 --- a/src/soc/amd/common/block/include/amdblocks/smm.h +++ b/src/soc/amd/common/block/include/amdblocks/smm.h @@ -14,3 +14,5 @@ void handle_smi_gsmi(void); void handle_smi_store(void); void clear_tvalid(void); +/* See SMITYPE_* for list possible of events */ +void mainboard_handle_smi(int event); -- To view, visit https://review.coreboot.org/c/coreboot/+/62598 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I81943e8cb31e998f29cc60b565d3ca0a8dfe9cb2 Gerrit-Change-Number: 62598 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/mediatek: Add PCIe support
by Yu-Ping Wu (Code Review) 04 Mar '22

04 Mar '22

Attention is currently required from: Hung-Te Lin, Arthur Heymans, Shelley Chen, Furquan Shaikh, Paul Menzel, Angel Pons, Jianjun Wang. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56791 ) Change subject: soc/mediatek: Add PCIe support ...................................................................... Patch Set 13: Code-Review+1 (2 comments) File src/soc/mediatek/common/pcie.c: https://review.coreboot.org/c/coreboot/+/56791/comment/f6d6430a_dae33305 PS11, Line 3: arch > No need, removed don't we need it for write32p? File src/soc/mediatek/common/pcie.c: https://review.coreboot.org/c/coreboot/+/56791/comment/683854e0_0bb850f0 PS13, Line 190: __func__, range_type, mmio_res->cpu_addr, mmio_res->pci_addr, indentation -- To view, visit https://review.coreboot.org/c/coreboot/+/56791 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib9b6adaafa20aeee136372ec9564273f86776da0 Gerrit-Change-Number: 56791 Gerrit-PatchSet: 13 Gerrit-Owner: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-CC: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Fri, 04 Mar 2022 23:14:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Comment-In-Reply-To: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: i2c: Configurable I2C transfer timeout
by Felix Singer (Code Review) 04 Mar '22

04 Mar '22

Attention is currently required from: Hung-Te Lin, Jes Klinke, Patrick Rudolph. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62278 ) Change subject: i2c: Configurable I2C transfer timeout ...................................................................... Patch Set 7: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/62278/comment/8d958530_198acc37 PS7, Line 7: Configurable Add configurable ... -- To view, visit https://review.coreboot.org/c/coreboot/+/62278 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6423122f32aad1dbcee0bfe240cdaa8cb512791f Gerrit-Change-Number: 62278 Gerrit-PatchSet: 7 Gerrit-Owner: Jes Klinke <jbk(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Qii Wang <qii.wang(a)mediatek.corp-partner.google.com> Gerrit-CC: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Jes Klinke <jbk(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Fri, 04 Mar 2022 23:10:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: i2c: Configurable I2C transfer timeout
by Julius Werner (Code Review) 04 Mar '22

04 Mar '22

Attention is currently required from: Hung-Te Lin, Jes Klinke, Patrick Rudolph. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62278 ) Change subject: i2c: Configurable I2C transfer timeout ...................................................................... Patch Set 7: (1 comment) File src/soc/mediatek/common/i2c.c: https://review.coreboot.org/c/coreboot/+/62278/comment/b9cfd818_0ebcf450 PS7, Line 242: CONFIG_I2C_TRANSFER_TIMEOUT_US > Just saw Julius' comment about (transfer timeout) "but that's the one really generic kind of timeout […] I would suggest we change all affected timeouts to the new default unless someone has an explicit reason why the timeout for some board should be different. Usually people just make a random high-sounding number for these timeouts when writing an I2C driver, because they don't get hit under normal operation anyway. They just need to be "high enough", and 500ms is pretty high. So I think we should discourage platforms from all making up their own thing here unless they have an explicit, documented reason. -- To view, visit https://review.coreboot.org/c/coreboot/+/62278 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6423122f32aad1dbcee0bfe240cdaa8cb512791f Gerrit-Change-Number: 62278 Gerrit-PatchSet: 7 Gerrit-Owner: Jes Klinke <jbk(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Qii Wang <qii.wang(a)mediatek.corp-partner.google.com> Gerrit-CC: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Jes Klinke <jbk(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Fri, 04 Mar 2022 23:03:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/hatch/scout: i2c HID driver for Ilitek touchscreen
by Felix Singer (Code Review) 04 Mar '22

04 Mar '22

Attention is currently required from: Tim Wawrzynczak, Rehan Ghori. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62591 ) Change subject: mb/google/hatch/scout: i2c HID driver for Ilitek touchscreen ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/62591 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9e42c36a35654cf3e2b41f78b209f4b89e8b05bd Gerrit-Change-Number: 62591 Gerrit-PatchSet: 5 Gerrit-Owner: Rehan Ghori <rehang(a)google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Joe Tessler <jrt(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Rehan Ghori <rehang(a)google.com> Gerrit-Comment-Date: Fri, 04 Mar 2022 22:33:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/hatch/scout: i2c HID driver for Ilitek touchscreen
by Rehan Ghori (Code Review) 04 Mar '22

04 Mar '22

Attention is currently required from: Felix Singer, Tim Wawrzynczak. Rehan Ghori has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62591 ) Change subject: mb/google/hatch/scout: i2c HID driver for Ilitek touchscreen ...................................................................... Patch Set 5: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/62591/comment/db4725bc_5ee59321 PS4, Line 7: scout > mb/google/hatch/scout Done -- To view, visit https://review.coreboot.org/c/coreboot/+/62591 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9e42c36a35654cf3e2b41f78b209f4b89e8b05bd Gerrit-Change-Number: 62591 Gerrit-PatchSet: 5 Gerrit-Owner: Rehan Ghori <rehang(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Joe Tessler <jrt(a)google.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Fri, 04 Mar 2022 22:33:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/hatch/scout: i2c HID driver for Ilitek touchscreen
by Rehan Ghori (Code Review) 04 Mar '22

04 Mar '22

Attention is currently required from: Tim Wawrzynczak, Rehan Ghori. Hello build bot (Jenkins), Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62591 to look at the new patch set (#5). Change subject: mb/google/hatch/scout: i2c HID driver for Ilitek touchscreen ...................................................................... mb/google/hatch/scout: i2c HID driver for Ilitek touchscreen Add HID driver for i2c-1 for Ilitek touchscreen. BRANCH=None BUG=b:187289163 TEST=Build and flash coreboot; confirm an entry for hidraw for I2C-1 for Ilitek touchscreen. Change-Id: I9e42c36a35654cf3e2b41f78b209f4b89e8b05bd Signed-off-by: Rehan Ghori <rehang(a)google.com> --- M src/mainboard/google/hatch/variants/scout/gpio.c M src/mainboard/google/hatch/variants/scout/overridetree.cb 2 files changed, 17 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/62591/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/62591 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9e42c36a35654cf3e2b41f78b209f4b89e8b05bd Gerrit-Change-Number: 62591 Gerrit-PatchSet: 5 Gerrit-Owner: Rehan Ghori <rehang(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Joe Tessler <jrt(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Rehan Ghori <rehang(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: scout: i2c HID driver for Ilitek touchscreen
by Felix Singer (Code Review) 04 Mar '22

04 Mar '22

Attention is currently required from: Tim Wawrzynczak, Rehan Ghori. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62591 ) Change subject: scout: i2c HID driver for Ilitek touchscreen ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/62591/comment/86f04411_491f6117 PS4, Line 7: scout mb/google/hatch/scout -- To view, visit https://review.coreboot.org/c/coreboot/+/62591 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9e42c36a35654cf3e2b41f78b209f4b89e8b05bd Gerrit-Change-Number: 62591 Gerrit-PatchSet: 4 Gerrit-Owner: Rehan Ghori <rehang(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Joe Tessler <jrt(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Rehan Ghori <rehang(a)google.com> Gerrit-Comment-Date: Fri, 04 Mar 2022 22:29:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022