coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: ec/starlabs: Store the correct value for KLSE when suspending
by Sean Rhodes (Code Review) 05 Mar '22

05 Mar '22

Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62605 ) Change subject: ec/starlabs: Store the correct value for KLSE when suspending ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/62605 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I62e0fc3b6fcae72f2d8eacf37a390b4e4b1f0783 Gerrit-Change-Number: 62605 Gerrit-PatchSet: 4 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 05 Mar 2022 10:49:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/starlabs: Store the correct value for KLBE when suspending
by Sean Rhodes (Code Review) 05 Mar '22

05 Mar '22

Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62606 ) Change subject: ec/starlabs: Store the correct value for KLBE when suspending ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/62606 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic2a83df9a270de6d7bab295e732a6c13accbe17c Gerrit-Change-Number: 62606 Gerrit-PatchSet: 5 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 05 Mar 2022 10:49:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/starlabs: Write the correct value for TPLE when suspending
by Sean Rhodes (Code Review) 05 Mar '22

05 Mar '22

Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62607 ) Change subject: ec/starlabs: Write the correct value for TPLE when suspending ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/62607 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iabeec47bf492b698f95d86aa2d08ba9caedd75f6 Gerrit-Change-Number: 62607 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Sat, 05 Mar 2022 10:49:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/starlabs: Write the correct value for KLBE when suspending
by Sean Rhodes (Code Review) 05 Mar '22

05 Mar '22

Sean Rhodes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/62609 ) Change subject: ec/starlabs: Write the correct value for KLBE when suspending ...................................................................... ec/starlabs: Write the correct value for KLBE when suspending The current code will write the raw value from the CMOS, which doesn't match the respective setting in EC. Switch argument will write the correct value, and prevent the setting being reset. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I40dc78c743f4201a11ea0c26a8af716cab42b805 --- M src/ec/starlabs/merlin/acpi/suspend.asl 1 file changed, 23 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/62609/1 diff --git a/src/ec/starlabs/merlin/acpi/suspend.asl b/src/ec/starlabs/merlin/acpi/suspend.asl index 438c3a6..c0eaa7c 100644 --- a/src/ec/starlabs/merlin/acpi/suspend.asl +++ b/src/ec/starlabs/merlin/acpi/suspend.asl @@ -105,5 +105,27 @@ } } - \_SB.PCI0.LPCB.EC.KLBE = \_SB.PCI0.LPCB.KLBC + Switch (\_SB.PCI0.LPCB.KLBC) + { + // 0x00 == On == 0xdd + // 0x01 == Off == 0xcc + // 0x02 == Low == 0xbb + // 0x03 == High == 0xaa + Case (0x00) + { + \_SB.PCI0.LPCB.EC.KLBE 0xdd + } + Case (0x01) + { + \_SB.PCI0.LPCB.EC.KLBE = 0xcc + } + Case (0x02) + { + \_SB.PCI0.LPCB.EC.KLBE = 0xbb + } + Case (0x03) + { + \_SB.PCI0.LPCB.EC.KLBE = 0xaa + } + } } -- To view, visit https://review.coreboot.org/c/coreboot/+/62609 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I40dc78c743f4201a11ea0c26a8af716cab42b805 Gerrit-Change-Number: 62609 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: ec/starlabs: Write the correct value for KLSE when suspending
by Sean Rhodes (Code Review) 05 Mar '22

05 Mar '22

Sean Rhodes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/62608 ) Change subject: ec/starlabs: Write the correct value for KLSE when suspending ...................................................................... ec/starlabs: Write the correct value for KLSE when suspending The current code will write the raw value from the CMOS, which doesn't match the respective setting in EC. Switch argument will write the correct value, and prevent the setting being reset. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I93444cdb96eaf729630b48551d0853511b584634 --- M src/ec/starlabs/merlin/acpi/suspend.asl 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/62608/1 diff --git a/src/ec/starlabs/merlin/acpi/suspend.asl b/src/ec/starlabs/merlin/acpi/suspend.asl index cf6741a..438c3a6 100644 --- a/src/ec/starlabs/merlin/acpi/suspend.asl +++ b/src/ec/starlabs/merlin/acpi/suspend.asl @@ -90,6 +90,20 @@ } \_SB.PCI0.LPCB.EC.FLKE = \_SB.PCI0.LPCB.FLKC - \_SB.PCI0.LPCB.EC.KLSE = \_SB.PCI0.LPCB.KLSC + + Switch (\_SB.PCI0.LPCB.KLSC) + { + // 0x00 == Disabled == 0x00 + // 0x01 == Enabled == 0xdd + Case (0x00) + { + \_SB.PCI0.LPCB.EC.KLSE = 0x00 + ) + Case (0x01) + { + \_SB.PCI0.LPCB.EC.KLSE = 0xdd + } + } + \_SB.PCI0.LPCB.EC.KLBE = \_SB.PCI0.LPCB.KLBC } -- To view, visit https://review.coreboot.org/c/coreboot/+/62608 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I93444cdb96eaf729630b48551d0853511b584634 Gerrit-Change-Number: 62608 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: ec/starlabs: Write the correct value for TPLE when suspending
by Sean Rhodes (Code Review) 05 Mar '22

05 Mar '22

Sean Rhodes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/62607 ) Change subject: ec/starlabs: Write the correct value for TPLE when suspending ...................................................................... ec/starlabs: Write the correct value for TPLE when suspending The current code will write the raw value from the CMOS, which doesn't match the respective setting in EC. Switch argument will write the correct value, and prevent the setting being reset. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: Iabeec47bf492b698f95d86aa2d08ba9caedd75f6 --- M src/ec/starlabs/merlin/acpi/suspend.asl 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/62607/1 diff --git a/src/ec/starlabs/merlin/acpi/suspend.asl b/src/ec/starlabs/merlin/acpi/suspend.asl index 607bea2..cf6741a 100644 --- a/src/ec/starlabs/merlin/acpi/suspend.asl +++ b/src/ec/starlabs/merlin/acpi/suspend.asl @@ -74,7 +74,21 @@ \_SB.PCI0.LPCB.EC.OSFG = 0x01 /* Restore EC settings from CMOS */ - \_SB.PCI0.LPCB.EC.TPLE = \_SB.PCI0.LPCB.TPLC + Switch (\_SB.PCI0.LPCB.TPLC) + { + // 0x00 == Enabled == 0x00 + // 0x00 == Re-enabled == 0x11 + // 0x01 == Disabled == 0x22 + Case (0x00) + { + \_SB.PCI0.LPCB.EC.TPLE = 0x00 + } + Case (0x01) + { + \_SB.PCI0.LPCB.EC.TPLE = 0x22 + } + } + \_SB.PCI0.LPCB.EC.FLKE = \_SB.PCI0.LPCB.FLKC \_SB.PCI0.LPCB.EC.KLSE = \_SB.PCI0.LPCB.KLSC \_SB.PCI0.LPCB.EC.KLBE = \_SB.PCI0.LPCB.KLBC -- To view, visit https://review.coreboot.org/c/coreboot/+/62607 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iabeec47bf492b698f95d86aa2d08ba9caedd75f6 Gerrit-Change-Number: 62607 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: ec/starlabs: Store the correct value for KLBE when suspending
by Sean Rhodes (Code Review) 05 Mar '22

05 Mar '22

Sean Rhodes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/62606 ) Change subject: ec/starlabs: Store the correct value for KLBE when suspending ...................................................................... ec/starlabs: Store the correct value for KLBE when suspending The current code will read the raw value from the EC, which doesn't match the respective setting in CMOS. Switch argument will store the correct value. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: Ic2a83df9a270de6d7bab295e732a6c13accbe17c --- M src/ec/starlabs/merlin/acpi/suspend.asl 1 file changed, 13 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/62606/1 diff --git a/src/ec/starlabs/merlin/acpi/suspend.asl b/src/ec/starlabs/merlin/acpi/suspend.asl index e33201b..453e153 100644 --- a/src/ec/starlabs/merlin/acpi/suspend.asl +++ b/src/ec/starlabs/merlin/acpi/suspend.asl @@ -51,8 +51,19 @@ } } - \_SB.PCI0.LPCB.KLBC = - \_SB.PCI0.LPCB.EC.ECRD (RefOf (\_SB.PCI0.LPCB.EC.KLBE)) + Switch (\_SB.PCI0.LPCB.EC.ECRD (RefOf (\_SB.PCI0.LPCB.EC.KLBE))) + { + // 0x00 == Disabled == 0x00 + // 0xdd == Enabled == 0x01 + Case (0x00) + { + \_SB.PCI0.LPCB.KLBC = 0x00 + ) + Case (0xdd) + { + \_SB.PCI0.LPCB.KLBC = 0x01 + } + } } \_SB.PCI0.LPCB.EC.OSFG = 0x00 -- To view, visit https://review.coreboot.org/c/coreboot/+/62606 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic2a83df9a270de6d7bab295e732a6c13accbe17c Gerrit-Change-Number: 62606 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: ec/starlabs: Store the correct value for KLSE when suspending
by Sean Rhodes (Code Review) 05 Mar '22

05 Mar '22

Sean Rhodes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/62605 ) Change subject: ec/starlabs: Store the correct value for KLSE when suspending ...................................................................... ec/starlabs: Store the correct value for KLSE when suspending The current code will read the raw value from the EC, which doesn't match the respective setting in CMOS. Switch argument will store the correct value. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I62e0fc3b6fcae72f2d8eacf37a390b4e4b1f0783 --- M src/ec/starlabs/merlin/acpi/suspend.asl 1 file changed, 25 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/62605/1 diff --git a/src/ec/starlabs/merlin/acpi/suspend.asl b/src/ec/starlabs/merlin/acpi/suspend.asl index 68f727a..e33201b 100644 --- a/src/ec/starlabs/merlin/acpi/suspend.asl +++ b/src/ec/starlabs/merlin/acpi/suspend.asl @@ -26,8 +26,31 @@ \_SB.PCI0.LPCB.FLKC = \_SB.PCI0.LPCB.EC.ECRD (RefOf (\_SB.PCI0.LPCB.EC.FLKE)) - \_SB.PCI0.LPCB.KLSC = - \_SB.PCI0.LPCB.EC.ECRD (RefOf (\_SB.PCI0.LPCB.EC.KLSE)) + + Switch (\_SB.PCI0.LPCB.EC.ECRD (RefOf (\_SB.PCI0.LPCB.EC.KLSE))) + { + // 0xdd == On == 0x00 + // 0xcc == Off == 0x01 + // 0xbb == Low == 0x02 + // 0xaa == High == 0x03 + Case (0xdd) + { + \_SB.PCI0.LPCB.KLSC = 0x00 + } + Case (0xcc) + { + \_SB.PCI0.LPCB.KLSC = 0x01 + } + Case (0xbb) + { + \_SB.PCI0.LPCB.KLSC = 0x02 + } + Case (0xaa) + { + \_SB.PCI0.LPCB.KLSC = 0x03 + } + } + \_SB.PCI0.LPCB.KLBC = \_SB.PCI0.LPCB.EC.ECRD (RefOf (\_SB.PCI0.LPCB.EC.KLBE)) } -- To view, visit https://review.coreboot.org/c/coreboot/+/62605 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I62e0fc3b6fcae72f2d8eacf37a390b4e4b1f0783 Gerrit-Change-Number: 62605 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: ec/starlabs: Store the correct value for TPLE when suspending
by Sean Rhodes (Code Review) 05 Mar '22

05 Mar '22

Sean Rhodes has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/62604 ) Change subject: ec/starlabs: Store the correct value for TPLE when suspending ...................................................................... ec/starlabs: Store the correct value for TPLE when suspending The current code will read the raw value from the EC, which doesn't match the respective setting in CMOS. Switch argument will store the correct value. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I921be8aea55b95f1ba233d2640d9bae80f8c3703 --- M src/ec/starlabs/merlin/acpi/suspend.asl 1 file changed, 19 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/62604/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62604 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I921be8aea55b95f1ba233d2640d9bae80f8c3703 Gerrit-Change-Number: 62604 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: ec/starlabs: Store the correct value for TPLE when suspending
by Sean Rhodes (Code Review) 05 Mar '22

05 Mar '22

Sean Rhodes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/62604 ) Change subject: ec/starlabs: Store the correct value for TPLE when suspending ...................................................................... ec/starlabs: Store the correct value for TPLE when suspending The current code will read the raw value from the EC, which doesn't match the respective setting in CMOS. Switch argument will store the correct value. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I921be8aea55b95f1ba233d2640d9bae80f8c3703 --- M src/ec/starlabs/merlin/acpi/suspend.asl 1 file changed, 19 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/62604/1 diff --git a/src/ec/starlabs/merlin/acpi/suspend.asl b/src/ec/starlabs/merlin/acpi/suspend.asl index bbbd05d..68f727a 100644 --- a/src/ec/starlabs/merlin/acpi/suspend.asl +++ b/src/ec/starlabs/merlin/acpi/suspend.asl @@ -5,8 +5,25 @@ If ((Arg0 == 0x04) || (Arg0 == 0x05)) { /* Store current EC settings in CMOS */ - \_SB.PCI0.LPCB.TPLC = - \_SB.PCI0.LPCB.EC.ECRD (RefOf (\_SB.PCI0.LPCB.EC.TPLE)) + Switch (\_SB.PCI0.LPCB.EC.ECRD (RefOf (\_SB.PCI0.LPCB.EC.TPLE))) + { + // 0x00 == Enabled == 0x01 + // 0x11 == Re-enabled == 0x00 + // 0x22 == Disabled == 0x01 + Case (0x00) + { + \_SB.PCI0.LPCB.TPLC = 0x00 + } + Case (0x11) + { + \_SB.PCI0.LPCB.TPLC = 0x00 + } + Case (0x22) + { + \_SB.PCI0.LPCB.TPLC = 0x01 + } + } + \_SB.PCI0.LPCB.FLKC = \_SB.PCI0.LPCB.EC.ECRD (RefOf (\_SB.PCI0.LPCB.EC.FLKE)) \_SB.PCI0.LPCB.KLSC = -- To view, visit https://review.coreboot.org/c/coreboot/+/62604 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I921be8aea55b95f1ba233d2640d9bae80f8c3703 Gerrit-Change-Number: 62604 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022