Attention is currently required from: Lance Zhao, Tim Wawrzynczak, Patrick Rudolph, Felix Held.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62362 )
Change subject: treewide: Drop unused Kconfig symbols
......................................................................
Patch Set 5:
(2 comments)
Patchset:
PS5:
Done, even if I think removing INTEL_GMA_OPREGION_2_0 will not change returned "opregion_version opregion_get_version(void)" value.
File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/62362/comment/ce2ebb49_6ce0ed7b
PS2, Line 104:
: config INTEL_GMA_OPREGION_2_0
: bool
: default n if INTEL_GMA_OPREGION_2_1
: default y
> what I see is "INTEL_GMA_OPREGION_2_1" set to no by default here : […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/62362
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I96380d4567356c81e17de469fd78cec2fcb7e5c9
Gerrit-Change-Number: 62362
Gerrit-PatchSet: 5
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Sun, 06 Mar 2022 11:02:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-MessageType: comment
Attention is currently required from: Lance Zhao, Tim Wawrzynczak, Patrick Rudolph, Felix Held.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62362 )
Change subject: treewide: Drop unused Kconfig symbols
......................................................................
Patch Set 4:
(1 comment)
File src/soc/intel/common/block/tcss/Kconfig:
https://review.coreboot.org/c/coreboot/+/62362/comment/63106de2_bde9b170
PS2, Line 20: config SOC_INTEL_COMMON_BLOCK_TCSS_REG_ACCESS_SBI
> $ grep -r SOC_INTEL_COMMON_BLOCK_TCSS_REG_ACCESS_SBI :)
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/62362
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I96380d4567356c81e17de469fd78cec2fcb7e5c9
Gerrit-Change-Number: 62362
Gerrit-PatchSet: 4
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Sun, 06 Mar 2022 10:55:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment
Attention is currently required from: Jakub Czapiga, Patrick Rudolph, Elyes Haouas.
Hello build bot (Jenkins), Jakub Czapiga, Angel Pons, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/62181
to look at the new patch set (#4).
Change subject: src/device/dram/ddr: Deduplicate enum spd_dimm_type_ddr{2,3,4}
......................................................................
src/device/dram/ddr: Deduplicate enum spd_dimm_type_ddr{2,3,4}
While on it, fix SPD_DDR4_DIMM_TYPE_72B_SO_RDIMM and SPD_DDR4_DIMM_TYPE_72B_SO_UDIMM values
respectively to 0x08 and 0x09.
Change-Id: Iaffa84704d2a627394b2aae4d35d47d1358a2621
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M src/device/dram/ddr2.c
M src/device/dram/ddr3.c
M src/device/dram/ddr4.c
M src/device/dram/spd.c
M src/include/device/dram/ddr2.h
M src/include/device/dram/ddr3.h
M src/include/device/dram/ddr4.h
M src/include/spd.h
M src/mainboard/scaleway/tagada/ramstage.c
M src/northbridge/intel/haswell/haswell_mrc/raminit.c
M src/northbridge/intel/sandybridge/raminit_mrc.c
M tests/lib/dimm_info_util-test.c
12 files changed, 97 insertions(+), 174 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/62181/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/62181
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaffa84704d2a627394b2aae4d35d47d1358a2621
Gerrit-Change-Number: 62181
Gerrit-PatchSet: 4
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-MessageType: newpatchset
Attention is currently required from: Lance Zhao, Tim Wawrzynczak, Patrick Rudolph, Felix Held.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62362 )
Change subject: treewide: Drop unused Kconfig symbols
......................................................................
Patch Set 4:
(1 comment)
File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/62362/comment/377a4d3b_c892edc4
PS2, Line 104:
: config INTEL_GMA_OPREGION_2_0
: bool
: default n if INTEL_GMA_OPREGION_2_1
: default y
> Sure, but look at the way these two Kconfigs are structured; OPREGION_2_0 is the default, unless INT […]
what I see is "INTEL_GMA_OPREGION_2_1" set to no by default here :
src/drivers/intel/gma/Kconfig:
"config INTEL_GMA_OPREGION_2_1
bool
default n"
meaning the function
static struct opregion_version opregion_get_version(void)
{
if (CONFIG(INTEL_GMA_OPREGION_2_1))
return (struct opregion_version) { .major = 2, .minor = 1 };
return (struct opregion_version) { .major = 2, .minor = 0 };
}
returns "(struct opregion_version) { .major = 2, .minor = 0 }" unless INTEL_GMA_OPREGION_2_1 is selected
--
To view, visit https://review.coreboot.org/c/coreboot/+/62362
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I96380d4567356c81e17de469fd78cec2fcb7e5c9
Gerrit-Change-Number: 62362
Gerrit-PatchSet: 4
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Sun, 06 Mar 2022 10:45:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-MessageType: comment
Attention is currently required from: Lance Zhao, Arthur Heymans, Tim Wawrzynczak, Julius Werner, Angel Pons, Patrick Rudolph, Jianjun Wang.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62561 )
Change subject: device/mmio.h: Move readXp/writeXp helpers to device/mmio.h
......................................................................
Patch Set 4:
(2 comments)
File src/arch/arm/include/armv4/arch/mmio.h:
https://review.coreboot.org/c/coreboot/+/62561/comment/1463b467_8095b142
PS4, Line 27: static inline uint64_t read64(const void *addr)
this architecture doesn't support 64bit data stores
File src/arch/arm/include/armv7/arch/mmio.h:
https://review.coreboot.org/c/coreboot/+/62561/comment/51ea8e3c_d4110c7a
PS4, Line 32: static inline uint64_t read64(const void *addr)
this architecture doesn't support 64bit data stores
--
To view, visit https://review.coreboot.org/c/coreboot/+/62561
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic13a94d91affb7cf65a2f22f08ea39ed671bc8e8
Gerrit-Change-Number: 62561
Gerrit-PatchSet: 4
Gerrit-Owner: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Rudolph
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com>
Gerrit-Comment-Date: Sun, 06 Mar 2022 09:02:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Justin van Son, Patrick Rudolph, Paul Menzel, Christian Walter.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60535 )
Change subject: [WIP]mb/prodrive/hermes: Fix BMC PCIe KVM
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Works on latest hermes and makes the BMC appear again.
--
To view, visit https://review.coreboot.org/c/coreboot/+/60535
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iecf6fba5c37cc5834dac8a4437e893ca76bb87dc
Gerrit-Change-Number: 60535
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Justin van Son <justin.van.son(a)prodrive-technologies.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Rudolph
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Attention: Justin van Son <justin.van.son(a)prodrive-technologies.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Sun, 06 Mar 2022 08:59:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Paul Menzel, Tim Wawrzynczak.
Rehan Ghori has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62591 )
Change subject: mb/google/hatch/scout: Add i2c HID driver
......................................................................
Patch Set 7:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62591/comment/b9b6ca42_041ed97e
PS6, Line 7: .
> Remove the dot.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/62591
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9e42c36a35654cf3e2b41f78b209f4b89e8b05bd
Gerrit-Change-Number: 62591
Gerrit-PatchSet: 7
Gerrit-Owner: Rehan Ghori <rehang(a)google.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Joe Tessler <jrt(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Sun, 06 Mar 2022 00:48:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Rehan Ghori.
Hello Felix Singer, build bot (Jenkins), Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/62591
to look at the new patch set (#7).
Change subject: mb/google/hatch/scout: Add i2c HID driver
......................................................................
mb/google/hatch/scout: Add i2c HID driver
Add HID driver for i2c-1 for Ilitek touchscreen.
BRANCH=None
BUG=b:187289163
TEST=Build and flash coreboot; confirm an entry for hidraw for I2C-1 for
Ilitek touchscreen.
Change-Id: I9e42c36a35654cf3e2b41f78b209f4b89e8b05bd
Signed-off-by: Rehan Ghori <rehang(a)google.com>
---
M src/mainboard/google/hatch/variants/scout/gpio.c
M src/mainboard/google/hatch/variants/scout/overridetree.cb
2 files changed, 17 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/62591/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/62591
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9e42c36a35654cf3e2b41f78b209f4b89e8b05bd
Gerrit-Change-Number: 62591
Gerrit-PatchSet: 7
Gerrit-Owner: Rehan Ghori <rehang(a)google.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Joe Tessler <jrt(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Rehan Ghori <rehang(a)google.com>
Gerrit-MessageType: newpatchset