coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: soc/intel/common/thermal: Allow thermal configuration over PMC
by Michael Niewöhner (Code Review) 06 Mar '22

06 Mar '22

Attention is currently required from: Subrata Banik. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59209 ) Change subject: soc/intel/common/thermal: Allow thermal configuration over PMC ...................................................................... Patch Set 14: (2 comments) Patchset: PS14: I wonder how this could ever work on TGL, where TTSuggestedSetting is 1 by default, causing TT registers to be set and locked by fsp in PEI... File src/soc/intel/common/block/thermal/thermal_pmc.c: https://review.coreboot.org/c/coreboot/+/59209/comment/c15db1f7_bd0e673c PS14, Line 78: { : .offset = PMC_PWRM_THERMAL_PHLC, : .value = PMC_PWRM_THERMAL_PHLC_PHLCLOCK, : }, : { : .offset = PMC_PWRM_THERMAL_TLEN, : .value = PMC_PWRM_THERMAL_TLEN_TLENLOCK, : }, set by FSP unconditionally -- To view, visit https://review.coreboot.org/c/coreboot/+/59209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0c6ae72610da39fc18ff252c440d006e83c570a0 Gerrit-Change-Number: 59209 Gerrit-PatchSet: 14 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Comment-Date: Sun, 06 Mar 2022 19:11:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common/thermal: Refactor thermal block to improve reusability
by Michael Niewöhner (Code Review) 06 Mar '22

06 Mar '22

Attention is currently required from: Subrata Banik. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59509 ) Change subject: soc/intel/common/thermal: Refactor thermal block to improve reusability ...................................................................... Patch Set 8: (2 comments) Patchset: PS8: oh, actually I wanted to comment on CB:59209 File src/soc/intel/common/block/thermal/thermal_pmc.c: https://review.coreboot.org/c/coreboot/+/59509/comment/c9c25453_4105363f PS8, Line 42: .offset = PMC_PWRM_THERMAL_PHLC, : .value = PMC_PWRM_THERMAL_PHLC_PHLCLOCK, : }, : { : .offset = PMC_PWRM_THERMAL_TLEN, : .value = PMC_PWRM_THERMAL_TLEN_TLENLOCK, : > set by FSP unconditionally Done -- To view, visit https://review.coreboot.org/c/coreboot/+/59509 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14df5145629ef03f358b98e824bca6a5b8ebdfc6 Gerrit-Change-Number: 59509 Gerrit-PatchSet: 8 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Subrata Banik <subi.banik(a)gmail.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Comment-Date: Sun, 06 Mar 2022 19:11:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common/thermal: Refactor thermal block to improve reusability
by Michael Niewöhner (Code Review) 06 Mar '22

06 Mar '22

Attention is currently required from: Subrata Banik. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59509 ) Change subject: soc/intel/common/thermal: Refactor thermal block to improve reusability ...................................................................... Patch Set 8: (1 comment) File src/soc/intel/common/block/thermal/thermal_pmc.c: https://review.coreboot.org/c/coreboot/+/59509/comment/ef09f1e0_27cdd205 PS8, Line 42: .offset = PMC_PWRM_THERMAL_PHLC, : .value = PMC_PWRM_THERMAL_PHLC_PHLCLOCK, : }, : { : .offset = PMC_PWRM_THERMAL_TLEN, : .value = PMC_PWRM_THERMAL_TLEN_TLENLOCK, : set by FSP unconditionally -- To view, visit https://review.coreboot.org/c/coreboot/+/59509 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14df5145629ef03f358b98e824bca6a5b8ebdfc6 Gerrit-Change-Number: 59509 Gerrit-PatchSet: 8 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Subrata Banik <subi.banik(a)gmail.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Comment-Date: Sun, 06 Mar 2022 19:05:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common/thermal: Refactor thermal block to improve reusability
by Michael Niewöhner (Code Review) 06 Mar '22

06 Mar '22

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59509 ) Change subject: soc/intel/common/thermal: Refactor thermal block to improve reusability ...................................................................... Patch Set 8: (1 comment) Patchset: PS8: I wonder how this could ever work on TGL, where TTSuggestedSetting is 1 by default, causing TT registers to be set and locked by fsp in PEI... -- To view, visit https://review.coreboot.org/c/coreboot/+/59509 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14df5145629ef03f358b98e824bca6a5b8ebdfc6 Gerrit-Change-Number: 59509 Gerrit-PatchSet: 8 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Subrata Banik <subi.banik(a)gmail.com> Gerrit-Comment-Date: Sun, 06 Mar 2022 18:56:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: include/devices/pci_ids.h: Fix indentations
by build bot (Jenkins) (Code Review) 06 Mar '22

06 Mar '22

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62621 ) Change subject: include/devices/pci_ids.h: Fix indentations ...................................................................... Patch Set 3: (3 comments) File src/include/device/pci_ids.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143239): https://review.coreboot.org/c/coreboot/+/62621/comment/611b979e_5ec9cfbc PS3, Line 2117: #define PCI_VID_AKS 0x416c 'AKS' may be misspelled - perhaps 'ASK'? Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143239): https://review.coreboot.org/c/coreboot/+/62621/comment/53f6e7a5_c1a48d5f PS3, Line 2118: #define PCI_DID_AKS_ALADDINCARD 0x0100 'AKS' may be misspelled - perhaps 'ASK'? Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143239): https://review.coreboot.org/c/coreboot/+/62621/comment/6a07f8e2_d8415882 PS3, Line 2119: #define PCI_DID_AKS_CPC 0x0200 'AKS' may be misspelled - perhaps 'ASK'? -- To view, visit https://review.coreboot.org/c/coreboot/+/62621 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9aba9d6405f14f0db0516b0c29952ff31c49b889 Gerrit-Change-Number: 62621 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 06 Mar 2022 16:50:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: include/devices/pci_ids.h: Fix indentations
by Elyes Haouas (Code Review) 06 Mar '22

06 Mar '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62621 to look at the new patch set (#3). Change subject: include/devices/pci_ids.h: Fix indentations ...................................................................... include/devices/pci_ids.h: Fix indentations Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: I9aba9d6405f14f0db0516b0c29952ff31c49b889 --- M src/include/device/pci_ids.h 1 file changed, 2,619 insertions(+), 2,620 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/62621/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/62621 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9aba9d6405f14f0db0516b0c29952ff31c49b889 Gerrit-Change-Number: 62621 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: include/devices/pci_ids.h: Fix indentations
by build bot (Jenkins) (Code Review) 06 Mar '22

06 Mar '22

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62621 ) Change subject: include/devices/pci_ids.h: Fix indentations ...................................................................... Patch Set 2: (3 comments) File src/include/device/pci_ids.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143238): https://review.coreboot.org/c/coreboot/+/62621/comment/f1176cc1_1c7d777d PS2, Line 2117: #define PCI_VID_AKS 0x416c 'AKS' may be misspelled - perhaps 'ASK'? Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143238): https://review.coreboot.org/c/coreboot/+/62621/comment/e8b9b0f2_d44ef2c3 PS2, Line 2118: #define PCI_DID_AKS_ALADDINCARD 0x0100 'AKS' may be misspelled - perhaps 'ASK'? Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143238): https://review.coreboot.org/c/coreboot/+/62621/comment/88684abd_00d95209 PS2, Line 2119: #define PCI_DID_AKS_CPC 0x0200 'AKS' may be misspelled - perhaps 'ASK'? -- To view, visit https://review.coreboot.org/c/coreboot/+/62621 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9aba9d6405f14f0db0516b0c29952ff31c49b889 Gerrit-Change-Number: 62621 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 06 Mar 2022 16:44:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: include/devices/pci_ids.h: Fix indentations
by Elyes Haouas (Code Review) 06 Mar '22

06 Mar '22

Elyes Haouas has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/62621 ) Change subject: include/devices/pci_ids.h: Fix indentations ...................................................................... include/devices/pci_ids.h: Fix indentations Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: I9aba9d6405f14f0db0516b0c29952ff31c49b889 --- M src/include/device/pci_ids.h 1 file changed, 2,620 insertions(+), 2,621 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/62621/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62621 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9aba9d6405f14f0db0516b0c29952ff31c49b889 Gerrit-Change-Number: 62621 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Signed-off-by: Elyes Haouas <ehaouas@noos.fr> Change-Id: Id9b906d4842...
by Elyes Haouas (Code Review) 06 Mar '22

06 Mar '22

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/62620 ) Change subject: Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: Id9b906d4842a401e8227115e815d9eaaadbaf580 ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/62620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id9b906d4842a401e8227115e815d9eaaadbaf580 Gerrit-Change-Number: 62620 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: Signed-off-by: Elyes Haouas <ehaouas@noos.fr> Change-Id: I80f1b65071c...
by Elyes Haouas (Code Review) 06 Mar '22

06 Mar '22

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/62619 ) Change subject: Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: I80f1b65071c2c7dec2c73a208bf4a9f5d11a6ccb ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/62619 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I80f1b65071c2c7dec2c73a208bf4a9f5d11a6ccb Gerrit-Change-Number: 62619 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022