coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: mb/google/hatch/var/jinlon: Merge duplicate pci 02.0 in devicetree
by Nico Huber (Code Review) 04 Mar '22

04 Mar '22

Nico Huber has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/62594 ) Change subject: mb/google/hatch/var/jinlon: Merge duplicate pci 02.0 in devicetree ...................................................................... Abandoned duplicate of CB:62593 -- To view, visit https://review.coreboot.org/c/coreboot/+/62594 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic5e8a172e28b8de5c9b46d116a6a5a03f1f5b7a1 Gerrit-Change-Number: 62594 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: scout: i2c HID driver for Ilitek touchscreen
by Tim Wawrzynczak (Code Review) 04 Mar '22

04 Mar '22

Attention is currently required from: Rehan Ghori. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62591 ) Change subject: scout: i2c HID driver for Ilitek touchscreen ...................................................................... Patch Set 1: (3 comments) File src/mainboard/google/hatch/variants/scout/gpio.c: https://review.coreboot.org/c/coreboot/+/62591/comment/d302e16d_2297719f PS1, Line 3: #include <gpio.h> : #include <baseboard/gpio.h> : #include <baseboard/variants.h> : #include <commonlib/helpers.h> : #include <types.h> : #include <soc/gpio.h> : #include <vendorcode/google/chromeos/chromeos.h> nit: please keep alphabetical, i.e. ``` #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> #include <gpio.h> #include <soc/gpio.h> #include <types.h> #include <vendorcode/google/chromeos/chromeos.h> ``` File src/mainboard/google/hatch/variants/scout/overridetree.cb: https://review.coreboot.org/c/coreboot/+/62591/comment/2b15b85b_cd897e1d PS1, Line 389: register "generic.probed" = "1" Are you running with a ChromeOS kernel? If not, then you will not need this, this is for a patch we keep in our local trees (nacked upstream) https://review.coreboot.org/c/coreboot/+/62591/comment/808c5b75_44fac343 PS1, Line 392: "GPE0_DW0_16 Shouldn't this be `DPE0_DW2_16` ? IIUC, you are trying to refer to GPP_D16 as the wake pin? DW0 is mapped to A group, DW1 is mapped to C group, DW2 is mapped to the D group, see https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/sr… -- To view, visit https://review.coreboot.org/c/coreboot/+/62591 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9e42c36a35654cf3e2b41f78b209f4b89e8b05bd Gerrit-Change-Number: 62591 Gerrit-PatchSet: 1 Gerrit-Owner: Rehan Ghori <rehang(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Joe Tessler <jrt(a)google.com> Gerrit-Attention: Rehan Ghori <rehang(a)google.com> Gerrit-Comment-Date: Fri, 04 Mar 2022 21:47:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/hatch/var/jinlon: Merge duplicate pci 02.0 in devicetree
by Nico Huber (Code Review) 04 Mar '22

04 Mar '22

Attention is currently required from: Matt DeVillier. Hello Matt DeVillier, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/62594 to review the following change. Change subject: mb/google/hatch/var/jinlon: Merge duplicate pci 02.0 in devicetree ...................................................................... mb/google/hatch/var/jinlon: Merge duplicate pci 02.0 in devicetree The second entry is ignored, otherwise. Change-Id: Ic5e8a172e28b8de5c9b46d116a6a5a03f1f5b7a1 Signed-off-by: Nico Huber <nico.h(a)gmx.de> Fixes: commit c5a3a4a602 (mb/google/hatch (baseboard): add ACPI backlight support) --- M src/mainboard/google/hatch/variants/jinlon/overridetree.cb 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/62594/1 diff --git a/src/mainboard/google/hatch/variants/jinlon/overridetree.cb b/src/mainboard/google/hatch/variants/jinlon/overridetree.cb index b3887d4..633d98f 100644 --- a/src/mainboard/google/hatch/variants/jinlon/overridetree.cb +++ b/src/mainboard/google/hatch/variants/jinlon/overridetree.cb @@ -71,8 +71,6 @@ device domain 0 on device pci 02.0 alias igpu on # Integrated Graphics Device register "gfx" = "GMA_DEFAULT_PANEL(0)" - end - device pci 02.0 on chip drivers/gfx/generic register "device_count" = "1" register "device[0].name" = ""LCD"" -- To view, visit https://review.coreboot.org/c/coreboot/+/62594 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic5e8a172e28b8de5c9b46d116a6a5a03f1f5b7a1 Gerrit-Change-Number: 62594 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/hatch/var/jinlon: Fix disabling iGPU when EPS not present
by Matt DeVillier (Code Review) 04 Mar '22

04 Mar '22

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/62593 ) Change subject: mb/google/hatch/var/jinlon: Fix disabling iGPU when EPS not present ...................................................................... mb/google/hatch/var/jinlon: Fix disabling iGPU when EPS not present Commit ebf14826 [mb/google/hatch/var/jinlon: Switch to using device pointers] inadvertently broke jinlon boards without an electronic privacy screen (EPS) by disabling the parent device (iGPU) instead of the EPS when determined to be not present via SKU ID. Fix this by assigning the device alias to the EPS child device, not the parent (iGPU). Rename the alias for clarity, and clean up the duplicate device definition for the iGPU by combining them. Test: build/boot google/jinlon SKU w/o EPS, observe GPU functional in both firmware boot screens and Linux OS. Change-Id: I0615ce361497abe6872085b0dec83292607e53dd Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/google/hatch/variants/jinlon/mainboard.c M src/mainboard/google/hatch/variants/jinlon/overridetree.cb 2 files changed, 5 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/62593/1 diff --git a/src/mainboard/google/hatch/variants/jinlon/mainboard.c b/src/mainboard/google/hatch/variants/jinlon/mainboard.c index d2e5b43..51ef346 100644 --- a/src/mainboard/google/hatch/variants/jinlon/mainboard.c +++ b/src/mainboard/google/hatch/variants/jinlon/mainboard.c @@ -20,20 +20,20 @@ static void check_for_eps(uint32_t sku_id) { - struct device *gfx_dev = DEV_PTR(igpu); + struct device *eps_dev = DEV_PTR(eps); if (eps_sku(sku_id)) { printk(BIOS_INFO, "SKU ID %u has EPS\n", sku_id); return; } - if (!gfx_dev) { + if (!eps_dev) { printk(BIOS_ERR, "Error! No EPS dev, view-angle-management won't work\n"); return; } printk(BIOS_INFO, "SKU ID %u doesn't have EPS, disabling...\n", sku_id); - gfx_dev->enabled = 0; + eps_dev->enabled = 0; } void variant_devtree_update(void) diff --git a/src/mainboard/google/hatch/variants/jinlon/overridetree.cb b/src/mainboard/google/hatch/variants/jinlon/overridetree.cb index b3887d4..88c9a54 100644 --- a/src/mainboard/google/hatch/variants/jinlon/overridetree.cb +++ b/src/mainboard/google/hatch/variants/jinlon/overridetree.cb @@ -69,10 +69,8 @@ register "ScsEmmcHs400Enabled" = "1" device domain 0 on - device pci 02.0 alias igpu on # Integrated Graphics Device - register "gfx" = "GMA_DEFAULT_PANEL(0)" - end device pci 02.0 on + register "gfx" = "GMA_DEFAULT_PANEL(0)" chip drivers/gfx/generic register "device_count" = "1" register "device[0].name" = ""LCD"" @@ -80,7 +78,7 @@ register "device[0].addr" = "0x80010400" register "device[0].privacy.enabled" = "1" register "device[0].privacy.gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E0)" - device generic 0 on end + device generic 0 alias eps on end end end # Integrated Graphics Device device pci 14.0 on -- To view, visit https://review.coreboot.org/c/coreboot/+/62593 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0615ce361497abe6872085b0dec83292607e53dd Gerrit-Change-Number: 62593 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/hatch/var/jinlon: Fix EPS disabling procedure
by Nico Huber (Code Review) 04 Mar '22

04 Mar '22

Attention is currently required from: Matt DeVillier. Hello Matt DeVillier, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/62592 to review the following change. Change subject: mb/google/hatch/var/jinlon: Fix EPS disabling procedure ...................................................................... mb/google/hatch/var/jinlon: Fix EPS disabling procedure It looks like commit ebf1482627 (mb/google/hatch/var/jinlon: Switch to using device pointers) accidentally switched off the iGPU instead of the generic device representing the Electronic Privacy Screen (EPS) below it. The find_gfx_dev() function used prior to ebf1482627 should have returned the generic device, too. Change-Id: Iaf5dcb85fbee4386851f822e0087a92cf3434e47 Signed-off-by: Nico Huber <nico.h(a)gmx.de> Fixes: commit ebf1482627 (mb/google/hatch/var/jinlon: Switch to using device pointers) --- M src/mainboard/google/hatch/variants/jinlon/mainboard.c M src/mainboard/google/hatch/variants/jinlon/overridetree.cb 2 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/62592/1 diff --git a/src/mainboard/google/hatch/variants/jinlon/mainboard.c b/src/mainboard/google/hatch/variants/jinlon/mainboard.c index d2e5b43..51ef346 100644 --- a/src/mainboard/google/hatch/variants/jinlon/mainboard.c +++ b/src/mainboard/google/hatch/variants/jinlon/mainboard.c @@ -20,20 +20,20 @@ static void check_for_eps(uint32_t sku_id) { - struct device *gfx_dev = DEV_PTR(igpu); + struct device *eps_dev = DEV_PTR(eps); if (eps_sku(sku_id)) { printk(BIOS_INFO, "SKU ID %u has EPS\n", sku_id); return; } - if (!gfx_dev) { + if (!eps_dev) { printk(BIOS_ERR, "Error! No EPS dev, view-angle-management won't work\n"); return; } printk(BIOS_INFO, "SKU ID %u doesn't have EPS, disabling...\n", sku_id); - gfx_dev->enabled = 0; + eps_dev->enabled = 0; } void variant_devtree_update(void) diff --git a/src/mainboard/google/hatch/variants/jinlon/overridetree.cb b/src/mainboard/google/hatch/variants/jinlon/overridetree.cb index b3887d4..a51f892 100644 --- a/src/mainboard/google/hatch/variants/jinlon/overridetree.cb +++ b/src/mainboard/google/hatch/variants/jinlon/overridetree.cb @@ -69,7 +69,7 @@ register "ScsEmmcHs400Enabled" = "1" device domain 0 on - device pci 02.0 alias igpu on # Integrated Graphics Device + device pci 02.0 on # Integrated Graphics Device register "gfx" = "GMA_DEFAULT_PANEL(0)" end device pci 02.0 on @@ -80,7 +80,7 @@ register "device[0].addr" = "0x80010400" register "device[0].privacy.enabled" = "1" register "device[0].privacy.gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E0)" - device generic 0 on end + device generic 0 alias eps on end end end # Integrated Graphics Device device pci 14.0 on -- To view, visit https://review.coreboot.org/c/coreboot/+/62592 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaf5dcb85fbee4386851f822e0087a92cf3434e47 Gerrit-Change-Number: 62592 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: Documentation: Move firmware flashing tutorial to tutorial section
by Felix Singer (Code Review) 04 Mar '22

04 Mar '22

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62424 ) Change subject: Documentation: Move firmware flashing tutorial to tutorial section ...................................................................... Patch Set 10: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/62424/comment/d529665f_9ba6840d PS2, Line 8: > Blocking. I will push another patch fixing some links first and this will one will be rebased. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/62424 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ife6d97254af4c006fe01480a78c76303f9cb34bb Gerrit-Change-Number: 62424 Gerrit-PatchSet: 10 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Fri, 04 Mar 2022 21:07:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/cbmem: Add FlameGraph-compatible timestamps output
by Tim Wawrzynczak (Code Review) 04 Mar '22

04 Mar '22

Attention is currently required from: Jakub Czapiga, Alex Levin, Julius Werner, Jan Dabros. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62474 ) Change subject: util/cbmem: Add FlameGraph-compatible timestamps output ...................................................................... Patch Set 4: (1 comment) File src/commonlib/include/commonlib/timestamp_serialized.h: PS4: nit: I think this change could be split out by itself, also, if we're going to go with this mechanism in the future, does it make sense to automate creating the strings to represent the timestamp names, e.g. with X-macros or similar? -- To view, visit https://review.coreboot.org/c/coreboot/+/62474 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a4e20a267e9e0fbc6b3a4d6a2409b32ce8fca33 Gerrit-Change-Number: 62474 Gerrit-PatchSet: 4 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Alex Levin <levinale(a)google.com> Gerrit-Reviewer: Jan Dabros <jsd(a)semihalf.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Alex Levin <levinale(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Jan Dabros <jsd(a)semihalf.com> Gerrit-Comment-Date: Fri, 04 Mar 2022 21:04:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/kinox: update overridetree
by Tim Wawrzynczak (Code Review) 04 Mar '22

04 Mar '22

Attention is currently required from: Dtrain Hsu, Nick Vaccaro, Zhuohao Lee. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62553 ) Change subject: mb/google/brya/var/kinox: update overridetree ...................................................................... Patch Set 6: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/62553/comment/ff1ac662_afe0dd61 PS6, Line 8: : 1. Update override devicetree based on schematics. : 2. ALC5682I-VS is for audio codec. : 3. Update 15W SOC default PL2/PL4(39W/100W). : 4. Update DPTF table. : 5. Enable Bayhub LV2 driver : Could you please split these up into their own commits? This is quite a big patch -- To view, visit https://review.coreboot.org/c/coreboot/+/62553 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I08a1c2f784175b208ccdc562668041f432618dfc Gerrit-Change-Number: 62553 Gerrit-PatchSet: 6 Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Comment-Date: Fri, 04 Mar 2022 21:02:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/denverton_ns: enable Denverton to use common SoC XHCI code
by Jeff Daly (Code Review) 04 Mar '22

04 Mar '22

Attention is currently required from: Felix Singer, Mariusz Szafrański, Suresh Bellampalli, Vanessa Eusebio, Michal Motyl, Patrick Rudolph. Jeff Daly has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60992 ) Change subject: soc/intel/denverton_ns: enable Denverton to use common SoC XHCI code ...................................................................... Patch Set 10: (1 comment) Patchset: PS10: well, i see that i suffered a bad rebase yesterday from the wrong branch or something, so all the patches that cause an unstable build are bogus and i'll have to be rebasing again using previous versions of the patches. -- To view, visit https://review.coreboot.org/c/coreboot/+/60992 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I505b3a7761cb3719697626e1f272d0928fdd29f1 Gerrit-Change-Number: 60992 Gerrit-PatchSet: 10 Gerrit-Owner: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Reviewer: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Attention: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Attention: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Fri, 04 Mar 2022 21:01:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Move ACPI MPTS method from DSDT to SSDT for Brya and ...
by Tim Wawrzynczak (Code Review) 04 Mar '22

04 Mar '22

Attention is currently required from: Bora Guvendik, Cliff Huang, Selma Bensaid, Paul Menzel. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61887 ) Change subject: mb/google/brya: Move ACPI MPTS method from DSDT to SSDT for Brya and Redrix ...................................................................... Patch Set 14: Code-Review+2 (1 comment) File src/mainboard/google/brya/variants/brya4es/overridetree.cb: https://review.coreboot.org/c/coreboot/+/61887/comment/3567b67a_29b2bf42 PS14, Line 142: nit: no need for a tab here -- To view, visit https://review.coreboot.org/c/coreboot/+/61887 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0f0b7638e90a7862173fca99305398bb250373e9 Gerrit-Change-Number: 61887 Gerrit-PatchSet: 14 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Cliff Huang <cliff.huang(a)intel.corp-partner.google.com> Gerrit-CC: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Fri, 04 Mar 2022 20:58:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022