coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: Documentation: Use file paths to flashing firmware tutorial
by Felix Singer (Code Review) 07 Mar '22

07 Mar '22

Attention is currently required from: Angel Pons. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62452 to look at the new patch set (#9). Change subject: Documentation: Use file paths to flashing firmware tutorial ...................................................................... Documentation: Use file paths to flashing firmware tutorial In preperation to CB:62424, replace HTTP links pointing to the flashing firmware tutorial with file paths to the Markdown files. Change-Id: I6a271a912348cbe002bc9cced9922ed743e1133c Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M Documentation/mainboard/asus/p5q.md M Documentation/mainboard/lenovo/ivb_internal_flashing.md M Documentation/mainboard/msi/ms7707/ms7707.md M Documentation/mainboard/supermicro/x9sae.md 4 files changed, 13 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/62452/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/62452 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6a271a912348cbe002bc9cced9922ed743e1133c Gerrit-Change-Number: 62452 Gerrit-PatchSet: 9 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: docs/releases: Fix warning "document isn't included in any toctree"
by Felix Singer (Code Review) 07 Mar '22

07 Mar '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62584 to look at the new patch set (#2). Change subject: docs/releases: Fix warning "document isn't included in any toctree" ...................................................................... docs/releases: Fix warning "document isn't included in any toctree" While running Sphinx, it shows the warning "document isn't included in any toctree" for the documents checklist.md and templates.md. This are not meant to be listed in ToC trees. Thus, mark them as orphaned excluding them from ToC trees. Change-Id: I1ff8f7c24ac9b3c3a120914c0c72ab73e85c4873 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M Documentation/releases/checklist.md M Documentation/releases/templates.md 2 files changed, 8 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/62584/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62584 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1ff8f7c24ac9b3c3a120914c0c72ab73e85c4873 Gerrit-Change-Number: 62584 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/dedede/var/lantis: Add ELAN touchscreen support for Landrid
by Shou-Chieh Hsu (Code Review) 07 Mar '22

07 Mar '22

Attention is currently required from: Tony Huang, Robert Chen, Karthik Ramasubramanian. Shou-Chieh Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62002 ) Change subject: mb/google/dedede/var/lantis: Add ELAN touchscreen support for Landrid ...................................................................... Patch Set 13: (1 comment) Patchset: PS13: If we want to create new field in coreboot SSFC, please also add comment in cbi_ssfc.h: https://chromium.googlesource.com/chromiumos/platform/ec/+/refs/heads/main/… So we won't have conflict in the future. -- To view, visit https://review.coreboot.org/c/coreboot/+/62002 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I23d3de5e45aa2876c1590a1e09679d652a3f2906 Gerrit-Change-Number: 62002 Gerrit-PatchSet: 13 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-CC: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 07 Mar 2022 05:12:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: libpayload: Parse DDR information through coreboot tables
by Ravi Kumar Bokka (Code Review) 07 Mar '22

07 Mar '22

Attention is currently required from: Hung-Te Lin, Shelley Chen, Ravi kumar, Paul Menzel, mturney mturney, Angel Pons, Julius Werner, Arthur Heymans, Xixi Chen, Yu-Ping Wu. Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59193 ) Change subject: libpayload: Parse DDR information through coreboot tables ...................................................................... Patch Set 35: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/59193/comment/f89ea6a1_0319fad7 PS34, Line 7: Information > information Done File src/commonlib/bsd/include/commonlib/bsd/mem_chip_info.h: https://review.coreboot.org/c/coreboot/+/59193/comment/bd0616aa_951c5ec0 PS32, Line 13: dram_info > Not done yet. […] Done https://review.coreboot.org/c/coreboot/+/59193/comment/7ac55b06_e8e95244 PS32, Line 14: : 8 > Not done. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/59193 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieca7e9fc0e1a018fcb2e9315aebee088edac858e Gerrit-Change-Number: 59193 Gerrit-PatchSet: 35 Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Hung-Te Lin <hungte(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Gerrit-CC: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-CC: Xixi Chen <xixi.chen(a)mediatek.corp-partner.google.com> Gerrit-CC: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: mturney mturney <quic_mturney(a)quicinc.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Xixi Chen <xixi.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 07 Mar 2022 05:08:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alder lake: Allow mainboard to configure C state auto-demotion
by Maulik V Vaghela (Code Review) 07 Mar '22

07 Mar '22

Maulik V Vaghela has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/62629 ) Change subject: soc/intel/alder lake: Allow mainboard to configure C state auto-demotion ...................................................................... soc/intel/alder lake: Allow mainboard to configure C state auto-demotion FSP has parameter to enable/disable C1 state autodemotion feature. Boards/Baseboard can choose to use this feature as per requirement. This patch enables mainboard to configure the feature from devicetree BUG=b:221876248 BRANCH=firmware-brya-14505.B TEST=Check code compiles and correct value has been passed to FSP. Change-Id: I2d7839d8fecd7b5403f52f3926d1d0bc06728ed9 Signed-off-by: MAULIK V VAGHELA <maulik.v.vaghela(a)intel.com> --- M src/soc/intel/alderlake/chip.h M src/soc/intel/alderlake/fsp_params.c 2 files changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/62629/1 diff --git a/src/soc/intel/alderlake/chip.h b/src/soc/intel/alderlake/chip.h index aad45df..dc10b31 100644 --- a/src/soc/intel/alderlake/chip.h +++ b/src/soc/intel/alderlake/chip.h @@ -564,6 +564,12 @@ * Default 0. Setting this to 1 enable CNVi DDR RFIM. */ bool CnviDdrRfim; + + /* + * Enable or Disable C1 Cstate Demotion. + * Default 0. Set this to 1 in order to disable C state demotion. + */ + bool DisableC1StateAutoDemotion; }; typedef struct soc_intel_alderlake_config config_t; diff --git a/src/soc/intel/alderlake/fsp_params.c b/src/soc/intel/alderlake/fsp_params.c index dac3693..3e5af3f 100644 --- a/src/soc/intel/alderlake/fsp_params.c +++ b/src/soc/intel/alderlake/fsp_params.c @@ -717,6 +717,9 @@ /* PsysPmax is in unit of 1/8 Watt */ s_cfg->PsysPmax = config->PsysPmax * 8; } + + /* Program C state auto-demotion */ + s_cfg->C1StateAutoDemotion = !config->DisableC1StateAutoDemotion; } static void fill_fsps_irq_params(FSP_S_CONFIG *s_cfg, -- To view, visit https://review.coreboot.org/c/coreboot/+/62629 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2d7839d8fecd7b5403f52f3926d1d0bc06728ed9 Gerrit-Change-Number: 62629 Gerrit-PatchSet: 1 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: Documentation: Move services page to infrastructure section
by Felix Singer (Code Review) 07 Mar '22

07 Mar '22

Attention is currently required from: Paul Menzel. Hello build bot (Jenkins), Paul Menzel, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62442 to look at the new patch set (#12). Change subject: Documentation: Move services page to infrastructure section ...................................................................... Documentation: Move services page to infrastructure section The services page documents various services and tools which are provided by the project. It's more related to the infrastructure and less related to the community section. Thus, move it to the infrastructure section. Change-Id: I0ca2aba8ae817cf874367fa17e567065aec99a93 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M Documentation/community/index.md M Documentation/infrastructure/index.md R Documentation/infrastructure/services.md 3 files changed, 5 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/62442/12 -- To view, visit https://review.coreboot.org/c/coreboot/+/62442 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0ca2aba8ae817cf874367fa17e567065aec99a93 Gerrit-Change-Number: 62442 Gerrit-PatchSet: 12 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Documentation: Rename infrastructure section
by Felix Singer (Code Review) 07 Mar '22

07 Mar '22

Attention is currently required from: Paul Menzel, Angel Pons. Hello build bot (Jenkins), Paul Menzel, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62441 to look at the new patch set (#11). Change subject: Documentation: Rename infrastructure section ...................................................................... Documentation: Rename infrastructure section In preparation to CB:62442, rename the section for infrastructure related things to "Project infrastructure & services". Change-Id: I1ba8a2e2070a79d8c9e955133203f9bb9f58cb8e Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M Documentation/index.md M Documentation/infrastructure/index.md 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/62441/11 -- To view, visit https://review.coreboot.org/c/coreboot/+/62441 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1ba8a2e2070a79d8c9e955133203f9bb9f58cb8e Gerrit-Change-Number: 62441 Gerrit-PatchSet: 11 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Documentation: Move services page to infrastructure section
by Felix Singer (Code Review) 07 Mar '22

07 Mar '22

Attention is currently required from: Paul Menzel. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62442 ) Change subject: Documentation: Move services page to infrastructure section ...................................................................... Patch Set 10: (1 comment) This change is ready for review. Commit Message: https://review.coreboot.org/c/coreboot/+/62442/comment/495a57e1_be19f5dd PS6, Line 7: site > page Done -- To view, visit https://review.coreboot.org/c/coreboot/+/62442 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0ca2aba8ae817cf874367fa17e567065aec99a93 Gerrit-Change-Number: 62442 Gerrit-PatchSet: 10 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 07 Mar 2022 04:57:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: Rename infrastructure page
by Felix Singer (Code Review) 07 Mar '22

07 Mar '22

Attention is currently required from: Paul Menzel, Angel Pons. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62441 ) Change subject: Documentation: Rename infrastructure page ...................................................................... Patch Set 10: (3 comments) This change is ready for review. Commit Message: https://review.coreboot.org/c/coreboot/+/62441/comment/cfc975d5_24f1221f PS6, Line 7: Documentation: Rename infrastructure site > … to *Project infrastructure & services* That makes the title too long. I rather would like to leave it. https://review.coreboot.org/c/coreboot/+/62441/comment/7cc72503_1ca13abc PS6, Line 7: site > page Done Patchset: PS6: > What's the rationale for this change? Added a proper commit message. -- To view, visit https://review.coreboot.org/c/coreboot/+/62441 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1ba8a2e2070a79d8c9e955133203f9bb9f58cb8e Gerrit-Change-Number: 62441 Gerrit-PatchSet: 10 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 07 Mar 2022 04:56:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: Move firmware flashing tutorial to tutorial section
by Felix Singer (Code Review) 07 Mar '22

07 Mar '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62424 to look at the new patch set (#11). Change subject: Documentation: Move firmware flashing tutorial to tutorial section ...................................................................... Documentation: Move firmware flashing tutorial to tutorial section There is no need that the tutorial for flashing firmware has its own point in the main menu. Thus, move it to the tutorial section. Change-Id: Ife6d97254af4c006fe01480a78c76303f9cb34bb Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M Documentation/contributing/gsoc.md M Documentation/index.md M Documentation/mainboard/acer/g43t-am3.md M Documentation/mainboard/asrock/h110m-dvs.md M Documentation/mainboard/asrock/h77pro4-m.md M Documentation/mainboard/asus/p5q.md M Documentation/mainboard/gigabyte/ga-g41m-es2l.md M Documentation/mainboard/hp/2560p.md M Documentation/mainboard/lenovo/Ivy_Bridge_series.md M Documentation/mainboard/lenovo/Sandy_Bridge_series.md M Documentation/mainboard/lenovo/ivb_internal_flashing.md M Documentation/mainboard/lenovo/t410.md M Documentation/mainboard/lenovo/t420.md M Documentation/mainboard/lenovo/t430.md M Documentation/mainboard/lenovo/w530.md M Documentation/mainboard/lenovo/x1.md M Documentation/mainboard/lenovo/x230s.md M Documentation/mainboard/lenovo/x301.md M Documentation/mainboard/msi/ms7707/ms7707.md M Documentation/mainboard/prodrive/hermes.md M Documentation/mainboard/supermicro/x10slm-f.md M Documentation/mainboard/supermicro/x11-lga1151-series/x11-lga1151-series.md M Documentation/mainboard/supermicro/x9sae.md M Documentation/northbridge/intel/sandybridge/me_cleaner.md R Documentation/tutorial/flashing_firmware/ext_power.md R Documentation/tutorial/flashing_firmware/ext_standalone.md R Documentation/tutorial/flashing_firmware/flash_ic_diode.svg R Documentation/tutorial/flashing_firmware/flash_ic_no_diode.svg R Documentation/tutorial/flashing_firmware/index.md R Documentation/tutorial/flashing_firmware/int_flashrom.md R Documentation/tutorial/flashing_firmware/no_ext_power.md M Documentation/tutorial/index.md 32 files changed, 26 insertions(+), 26 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/62424/11 -- To view, visit https://review.coreboot.org/c/coreboot/+/62424 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ife6d97254af4c006fe01480a78c76303f9cb34bb Gerrit-Change-Number: 62424 Gerrit-PatchSet: 11 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022