build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61531 )
Change subject: include/devices/pci_ids.h: Rework indentations
......................................................................
Patch Set 5:
(1 comment)
File src/include/device/pci_ids.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143251):
https://review.coreboot.org/c/coreboot/+/61531/comment/4370c1c8_af0d7fbb
PS5, Line 832: #define PCI_DID_PCTECH_SAMURAI_IDE 0x3020
please, no space before tabs
--
To view, visit https://review.coreboot.org/c/coreboot/+/61531
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I070d5fbeece570aa410637d3b5b2d24137c9401f
Gerrit-Change-Number: 61531
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 07 Mar 2022 03:31:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61531 )
Change subject: include/devices/pci_ids.h: Rework indentations
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/61531
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I070d5fbeece570aa410637d3b5b2d24137c9401f
Gerrit-Change-Number: 61531
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 07 Mar 2022 03:31:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak.
Hello Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/62627
to look at the new patch set (#2).
Change subject: mb/google/brya/var/kinox: Modify 15W SOC PL2/PL4 default setting
......................................................................
mb/google/brya/var/kinox: Modify 15W SOC PL2/PL4 default setting
Modify 15W SOC PL2/PL4 default setting to 39W/100W for Kinox.
BUG=b:213417026
TEST=emerge-brask coreboot
Signed-off-by: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Change-Id: I2956705f7d26929c7cf2dd4e852fc61b619a83e5
---
M src/mainboard/google/brya/variants/kinox/Makefile.inc
A src/mainboard/google/brya/variants/kinox/ramstage.c
2 files changed, 69 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/62627/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/62627
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2956705f7d26929c7cf2dd4e852fc61b619a83e5
Gerrit-Change-Number: 62627
Gerrit-PatchSet: 2
Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Hung-Te Lin, Rex-BC Chen.
Hello Hung-Te Lin, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/blobs/+/62583
to look at the new patch set (#2).
Change subject: soc/mediatek/mt8195: Update dram.elf from 1.8.1 to 1.9.1
......................................................................
soc/mediatek/mt8195: Update dram.elf from 1.8.1 to 1.9.1
Refactor dramc_param to share more structures (CB:61293).
BUG=b:218577927
TEST=dram calibration pass
Cq-Depend: chromium:3504704
Signed-off-by: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Change-Id: I05aac544fa3749c6d43dec2df034e1ebe265ebeb
---
M soc/mediatek/mt8195/dram.elf
M soc/mediatek/mt8195/dram.elf.md5
M soc/mediatek/mt8195/dram_release_notes.txt
3 files changed, 9 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/blobs refs/changes/83/62583/2
--
To view, visit https://review.coreboot.org/c/blobs/+/62583
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: blobs
Gerrit-Branch: master
Gerrit-Change-Id: I05aac544fa3749c6d43dec2df034e1ebe265ebeb
Gerrit-Change-Number: 62583
Gerrit-PatchSet: 2
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jakub Czapiga, Julius Werner, Tim Wawrzynczak, Felix Held.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62600 )
Change subject: commonlib/bsd: Remove cb_err_t
......................................................................
Patch Set 1:
(4 comments)
File payloads/libpayload/tests/libcbfs/cbfs-verification-test.c:
https://review.coreboot.org/c/coreboot/+/62600/comment/334afa7d_d418ad92
PS1, Line 63: size_t *data_offset_out, struct vb2_hash *metadata_hash)
Indentation.
File src/commonlib/bsd/cbfs_mcache.c:
https://review.coreboot.org/c/coreboot/+/62600/comment/d517d9cb_f1ed10a2
PS1, Line 44: size_t already_read, void *arg)
Indentation.
File src/commonlib/bsd/cbfs_private.c:
https://review.coreboot.org/c/coreboot/+/62600/comment/790a5fd1_80f38f93
PS1, Line 7: const size_t devsize)
Indentation.
File src/soc/qualcomm/sc7180/display/dsi.c:
https://review.coreboot.org/c/coreboot/+/62600/comment/8549c76a_b66a7d98
PS1, Line 207: static enum cb_err mdss_dsi_send_init_cmd(enum mipi_dsi_transaction type, const u8 *body, u8 len)
> line over 96 characters
Please fix.
--
To view, visit https://review.coreboot.org/c/coreboot/+/62600
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaec36210d129db26d51f0a105d3de070c03b686b
Gerrit-Change-Number: 62600
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Mon, 07 Mar 2022 03:13:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment