coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: Extend BIOS Directory Table Entries | Update PSP Firmware Integration...
by Al Hirani (Code Review) 21 Mar '22

21 Mar '22

Attention is currently required from: Al Hirani. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62910 to look at the new patch set (#5). Change subject: Extend BIOS Directory Table Entries | Update PSP Firmware Integration Guide Documentation ...................................................................... Extend BIOS Directory Table Entries | Update PSP Firmware Integration Guide Documentation Update PSP Firmware Documentation with current internal PSP documentation Extend BIOS Directory Table Entries with updated and accurate values from internal PSP Documentation Signed-off-by: Altamshali Hirani <al.hirani(a)amd.corp-partner.google.com> Change-Id: I677f86614b0fdc6377fb2e27932ed3a8ded27102 --- M Documentation/soc/amd/psp_integration.md 1 file changed, 12 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/62910/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/62910 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I677f86614b0fdc6377fb2e27932ed3a8ded27102 Gerrit-Change-Number: 62910 Gerrit-PatchSet: 5 Gerrit-Owner: Al Hirani <al.hirani13(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Al Hirani <al.hirani13(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Extend BIOS Directory Table Entries | Update PSP Firmware Integration...
by Al Hirani (Code Review) 21 Mar '22

21 Mar '22

Attention is currently required from: Al Hirani. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62910 to look at the new patch set (#4). Change subject: Extend BIOS Directory Table Entries | Update PSP Firmware Integration Guide Documentation ...................................................................... Extend BIOS Directory Table Entries | Update PSP Firmware Integration Guide Documentation Update PSP Firmware Documentation with current internal PSP documentation Extend BIOS Directory Table Entries with updated and accurate values from internal PSP Documentation Signed-off-by: Altamshali Hirani <al.hirani(a)amd.corp-partner.google.com> Change-Id: I677f86614b0fdc6377fb2e27932ed3a8ded27102 --- M Documentation/soc/amd/psp_integration.md 1 file changed, 12 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/62910/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/62910 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I677f86614b0fdc6377fb2e27932ed3a8ded27102 Gerrit-Change-Number: 62910 Gerrit-PatchSet: 4 Gerrit-Owner: Al Hirani <al.hirani13(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Al Hirani <al.hirani13(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: [RFC]device/device.h: Remove struct bus linked list
by Arthur Heymans (Code Review) 21 Mar '22

21 Mar '22

Attention is currently required from: Nico Huber, Arthur Heymans. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62965 ) Change subject: [RFC]device/device.h: Remove struct bus linked list ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: It looks like there is a lot of sibling bus ops in coreboot... -- To view, visit https://review.coreboot.org/c/coreboot/+/62965 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib757957d6470111651f88b550df06c4c953b777f Gerrit-Change-Number: 62965 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 21 Mar 2022 19:40:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common: Configure TCSS access through IOE P2SB
by John Zhao (Code Review) 21 Mar '22

21 Mar '22

Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Paul Menzel, Eric Lai, Angel Pons, Patrick Rudolph, EricR Lai. John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62723 ) Change subject: soc/intel/common: Configure TCSS access through IOE P2SB ...................................................................... Patch Set 9: (1 comment) Patchset: PS9: > possible to split this cl into 2 parts […] It would be fine to split into soc and platforms for new functions. I recall it would be preferable to put them together in order to avoid breaking existent functions. Subrata, I am off this week. So please feel free to update. -- To view, visit https://review.coreboot.org/c/coreboot/+/62723 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3302aabfb5f540c41da6359f11376b4202c6310b Gerrit-Change-Number: 62723 Gerrit-PatchSet: 9 Gerrit-Owner: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Mon, 21 Mar 2022 19:34:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/cbmem: Add FlameGraph-compatible timestamps output
by Julius Werner (Code Review) 21 Mar '22

21 Mar '22

Attention is currently required from: Jakub Czapiga, Tim Wawrzynczak, Paul Menzel, Alex Levin, Jan Dabros. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62474 ) Change subject: util/cbmem: Add FlameGraph-compatible timestamps output ...................................................................... Patch Set 11: (6 comments) File src/commonlib/include/commonlib/timestamp_serialized.h: https://review.coreboot.org/c/coreboot/+/62474/comment/2b1adfe7_0d5c82a3 PS7, Line 454: uint32_t id_end; > It won't work. Look at TS_COPYVPD_START. It has two possible ends. […] Hmm... okay, that's an odd case. Is that the only one? Even though the code is written like that I don't think there's actually any board that has an RW VPD but no RO VPD in practice. I think having them all in one macro has the benefit that when people add new timestamps, they are more explicitly prompted to add a possible end symbol by the structure of the table. If you have the ranges hidden somewhere else in another table, I think it's a lot more likely people will forget to add new entries down there. If you lay out the struct as uint32_t, uint32_t, char *, char *, then the second uint32_t will be hidden by padding anyway on 64-bit systems and doesn't make the table larger. Also, I wouldn't worry about the size too much... coreboot shouldn't really be including that list anyway. (CONFIG_TIMESTAMPS_ON_CONSOLE is a really terrible design one way or another tbh. If anyone actually wants to use that and have it be efficient, they should redesign it to a point where it only includes strings for timestamps that each stage actually uses, rather than every possible special vendor timestamp there is.) File util/cbmem/cbmem.c: https://review.coreboot.org/c/coreboot/+/62474/comment/74dd0894_fd4f680f PS8, Line 629: :: > yeah I kinda like the `::`, I can't think of anything better Oh, I thought this was given by the flame graph tool? Or is this how it will look like in the flame graph (i.e. it will show `TS_VBOOT_START::TS_VBOOT_END` as the label of one section)? Could maybe also use `->` or `<->`? (I assume spaces are illegal? Otherwise some spaces would probably help readability.) File util/cbmem/cbmem.c: https://review.coreboot.org/c/coreboot/+/62474/comment/4c6cdd3c_96b78b23 PS11, Line 630: if (i < stacklvl) nit: I think if you add ` || last_part` here... https://review.coreboot.org/c/coreboot/+/62474/comment/758c6476_5dfdb168 PS11, Line 634: if (stacklvl > 0) ...you can take this out. https://review.coreboot.org/c/coreboot/+/62474/comment/d4185804_c4f9479e PS11, Line 727: sorted_tst_p->entries[match].entry_stamp; nit: I think adding base_time here would make it easier to understand than subtracting it below (because then stamp and match_stamp are constructed in a more symmetrical way). https://review.coreboot.org/c/coreboot/+/62474/comment/961388ff_d7f54bf3 PS11, Line 1384: enum timestamps_print_type timestamp_type = TIMESTAMPS_PRINT_NORMAL; If you have an enum anyway maybe also roll print_timestamps into that (i.e. default to TIMESTAMPS_PRINT_NONE)? -- To view, visit https://review.coreboot.org/c/coreboot/+/62474 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a4e20a267e9e0fbc6b3a4d6a2409b32ce8fca33 Gerrit-Change-Number: 62474 Gerrit-PatchSet: 11 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Alex Levin <levinale(a)google.com> Gerrit-Reviewer: Jan Dabros <jsd(a)semihalf.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Alex Levin <levinale(a)google.com> Gerrit-Attention: Jan Dabros <jsd(a)semihalf.com> Gerrit-Comment-Date: Mon, 21 Mar 2022 19:27:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jakub Czapiga <jacz(a)semihalf.com> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/tpm/cr50: Use cr50_get_firmware_version in get_board_cfg
by Subrata Banik (Code Review) 21 Mar '22

21 Mar '22

Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62964 ) Change subject: drivers/tpm/cr50: Use cr50_get_firmware_version in get_board_cfg ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62964 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6e5f4965a8852793d2f95e6eb21ea87860335a9 Gerrit-Change-Number: 62964 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Mon, 21 Mar 2022 19:26:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/common/block/psp: Add platform secure boot support
by ritul guru (Code Review) 21 Mar '22

21 Mar '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Paul Menzel, Angel Pons, Aamir Bohra, Fred Reitberger. ritul guru has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60968 ) Change subject: soc/amd/common/block/psp: Add platform secure boot support ...................................................................... Patch Set 14: (1 comment) File src/soc/amd/common/block/psp/Kconfig: https://review.coreboot.org/c/coreboot/+/60968/comment/07b2e085_7e707a85 PS12, Line 55: coreboot ROM is properly signed and can not be disabled once fused. > Updated document reference for PSB Feature. […] Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/60968 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I30aac29a22a5800d5995a78c50fdecd660a3d4eb Gerrit-Change-Number: 60968 Gerrit-PatchSet: 14 Gerrit-Owner: ritul guru <ritul.bits(a)gmail.com> Gerrit-Reviewer: Aamir Bohra <aamirbohra(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Aamir Bohra <aamirbohra(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Comment-Date: Mon, 21 Mar 2022 19:26:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: ritul guru <ritul.bits(a)gmail.com> Comment-In-Reply-To: Marshall Dawson <marshalldawson3rd(a)gmail.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [RFC]device/device.h: Remove struct bus linked list
by Arthur Heymans (Code Review) 21 Mar '22

21 Mar '22

Attention is currently required from: Nico Huber, Arthur Heymans. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62965 ) Change subject: [RFC]device/device.h: Remove struct bus linked list ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Let's see if this blows up somewhere... -- To view, visit https://review.coreboot.org/c/coreboot/+/62965 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib757957d6470111651f88b550df06c4c953b777f Gerrit-Change-Number: 62965 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 21 Mar 2022 19:24:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Reorder PSP Directory Table Types | Update PSP Firmware Integration G...
by Al Hirani (Code Review) 21 Mar '22

21 Mar '22

Al Hirani has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/62966 ) Change subject: Reorder PSP Directory Table Types | Update PSP Firmware Integration Guide Documentation ...................................................................... Reorder PSP Directory Table Types | Update PSP Firmware Integration Guide Documentation Update PSP Firmware Documentation with current internal PSP documentation Reorder PSP Directory Table Types - move 0x22 after 0x21 Signed-off-by: Altamshali Hirani <al.hirani(a)amd.corp-partner.google.com> Change-Id: I5fb893a769fe0d870e14e68183fc7e49421605bd --- M Documentation/soc/amd/psp_integration.md 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/62966/1 diff --git a/Documentation/soc/amd/psp_integration.md b/Documentation/soc/amd/psp_integration.md index dd57e46..c85948c 100755 --- a/Documentation/soc/amd/psp_integration.md +++ b/Documentation/soc/amd/psp_integration.md @@ -172,6 +172,10 @@ * Intermediate Key Encryption Key, used to decrypt encrypted firmware images. This is mandatory in order to support encrypted firmware. +**0x22**: PSP Token Unlock data +* Used to support time-bound Secure Debug unlock during boot. This entry may + be omitted if the Token Unlock debug feature is not required. + **0x24**: Security policy binary * A security policy is applied to restrict the untrusted access to security sensitive regions. @@ -200,10 +204,6 @@ **0x52**: PSP boot loader usermode OEM application * Supported only in certain SKUs. -**0x22**: PSP Token Unlock data -* Used to support time-bound Secure Debug unlock during boot. This entry may - be omitted if the Token Unlock debug feature is not required. - ### Firmware Version of Binaries Every firmware binary contains 256 bytes of a PSP Header, which includes -- To view, visit https://review.coreboot.org/c/coreboot/+/62966 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5fb893a769fe0d870e14e68183fc7e49421605bd Gerrit-Change-Number: 62966 Gerrit-PatchSet: 1 Gerrit-Owner: Al Hirani <al.hirani13(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: [RFC]device/device.h: Remove struct bus linked list
by Arthur Heymans (Code Review) 21 Mar '22

21 Mar '22

Attention is currently required from: Arthur Heymans. Hello Arthur Heymans, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/62965 to review the following change. Change subject: [RFC]device/device.h: Remove struct bus linked list ...................................................................... [RFC]device/device.h: Remove struct bus linked list The current allocator code never loops over the next busses so remove this linked list and always assume one downstream bus per device. Change-Id: Ib757957d6470111651f88b550df06c4c953b777f Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/include/device/device.h 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/62965/1 diff --git a/src/include/device/device.h b/src/include/device/device.h index 237d836..938ab5e 100644 --- a/src/include/device/device.h +++ b/src/include/device/device.h @@ -77,7 +77,6 @@ DEVTREE_CONST struct device *dev; /* This bridge device */ DEVTREE_CONST struct device *children; /* devices behind this bridge */ - DEVTREE_CONST struct bus *next; /* The next bridge on this device */ unsigned int bridge_ctrl; /* Bridge control register */ uint16_t bridge_cmd; /* Bridge command register */ unsigned char link_num; /* The index of this link */ -- To view, visit https://review.coreboot.org/c/coreboot/+/62965 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib757957d6470111651f88b550df06c4c953b777f Gerrit-Change-Number: 62965 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022