coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: device/resource_allocator_v4.c: Loop over struct bus linked list
by Paul Menzel (Code Review) 21 Mar '22

21 Mar '22

Attention is currently required from: Arthur Heymans. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62967 ) Change subject: device/resource_allocator_v4.c: Loop over struct bus linked list ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/62967/comment/32c83a15_b14cfe3a PS1, Line 7: .c Nit: Could be removed. https://review.coreboot.org/c/coreboot/+/62967/comment/686c42bd_92221f4b PS1, Line 12: Tested? -- To view, visit https://review.coreboot.org/c/coreboot/+/62967 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie4eec48c7008c19896996a40b1fa9b09008b3354 Gerrit-Change-Number: 62967 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 21 Mar 2022 21:32:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: payloads/tianocore: Add missing CONFIG_
by Sean Rhodes (Code Review) 21 Mar '22

21 Mar '22

Attention is currently required from: Martin Roth, Matt DeVillier, Paul Menzel, Stefan Reinauer. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62920 ) Change subject: payloads/tianocore: Add missing CONFIG_ ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/62920 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I88f4aa0286a77f6c94b5e5ec97a0034ea7594b4f Gerrit-Change-Number: 62920 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Mon, 21 Mar 2022 21:27:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/google: Add PSRC and PBOK method
by Tim Wawrzynczak (Code Review) 21 Mar '22

21 Mar '22

Attention is currently required from: Varshit B Pandya, Subrata Banik, Rizwan Qureshi. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62945 ) Change subject: ec/google: Add PSRC and PBOK method ...................................................................... Patch Set 2: (1 comment) File src/ec/google/chromeec/ec_dptf_helpers.c: https://review.coreboot.org/c/coreboot/+/62945/comment/c49a3bc6_e15d7aaf PS2, Line 138: cpigen_write_store(); : acpigen_emit_byte(ARG0_OP); : acpigen_emit_byte(LOCAL0_OP); : : acpigen_emit_byte(AND_OP); : acpigen_emit_byte(LOCAL0_OP); : acpigen_write_byte(0x0F); : acpigen_emit_byte(LOCAL0_OP); I think what Eric means if you can simplify this to: ``` /* Local0 = Arg0 & 0x0f acpigen_emit_byte(AND_OP); acpigen_emit_byte(ARG0_OP); acpigen_write_byte(0x0f); acpigen_emit_byte(LOCAL0_OP); ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/62945 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia536a9e1528f6e415247eca9ed2b0b685eb73196 Gerrit-Change-Number: 62945 Gerrit-PatchSet: 2 Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Comment-Date: Mon, 21 Mar 2022 21:20:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/dptf: Add support for Power participant
by Tim Wawrzynczak (Code Review) 21 Mar '22

21 Mar '22

Attention is currently required from: Varshit B Pandya, Lance Zhao, Subrata Banik, Rizwan Qureshi. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62944 ) Change subject: drivers/intel/dptf: Add support for Power participant ...................................................................... Patch Set 2: (1 comment) File src/drivers/intel/dptf/dptf.c: https://review.coreboot.org/c/coreboot/+/62944/comment/1c687c64_1a64b227 PS2, Line 387: acpigen_write_device_end(); /* TPWR Power Participant Device */ this is kind of awkward, having the write_device_end() in a separate function, why can't this just go in write_create_tpwr? -- To view, visit https://review.coreboot.org/c/coreboot/+/62944 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I437e509f58df1777d75e5981f0a5a63095ccb6a3 Gerrit-Change-Number: 62944 Gerrit-PatchSet: 2 Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Attention: Lance Zhao Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Comment-Date: Mon, 21 Mar 2022 21:18:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: $top/Makefile.inc: "-include" the folder common before other subdirs
by Julius Werner (Code Review) 21 Mar '22

21 Mar '22

Attention is currently required from: Bao Zheng, Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson, Paul Menzel, Zheng Bao, Elyes Haouas, Felix Held. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62750 ) Change subject: $top/Makefile.inc: "-include" the folder common before other subdirs ...................................................................... Patch Set 8: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/62750/comment/594bbbb9_f7a8c3dd PS3, Line 13: The duplicated "common" in the result string can be eliminated finally. > all the Makefile.inc in "subdir" will be included as […] So, sorry, are you saying that `-include` would somehow magically keep track of which files it has already included before and avoid including them a second time? I'm pretty sure that's not how it works. Just try it out: ==== Makefile ==== -include Makefile.test -include Makefile.test -include Makefile.test ==== Makefile.test ==== $(info "Included!") ================== $ make "Included!" "Included!" "Included!" -- To view, visit https://review.coreboot.org/c/coreboot/+/62750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I99597af22cac6d12aaef348789664cd7db02ba06 Gerrit-Change-Number: 62750 Gerrit-PatchSet: 8 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Zheng Bao Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 21 Mar 2022 21:08:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Bao Zheng <fishbaozi(a)gmail.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in blobs[master]: mb/google/guybrush: Update APCB file
by Robert Zieba (Code Review) 21 Mar '22

21 Mar '22

Attention is currently required from: Raul Rangel, Martin Roth, Patrick Georgi, Rob Barnes, Felix Held. Robert Zieba has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/62963 ) Change subject: mb/google/guybrush: Update APCB file ...................................................................... Patch Set 4: (2 comments) Commit Message: https://review.coreboot.org/c/blobs/+/62963/comment/371f818d_dba83669 PS3, Line 11: enough > Maybe say how many? Done https://review.coreboot.org/c/blobs/+/62963/comment/bec9656e_357982a2 PS3, Line 13: : BUG=b:224884904 > Add TEST= line? Done -- To view, visit https://review.coreboot.org/c/blobs/+/62963 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: master Gerrit-Change-Id: Ifbfe2c61c42cd503a70fd84c51ce184c40fed318 Gerrit-Change-Number: 62963 Gerrit-PatchSet: 4 Gerrit-Owner: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-CC: Eric Peers <epeers(a)google.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 21 Mar 2022 21:08:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin Roth <martinroth(a)google.com> Gerrit-MessageType: comment

1 0

Change in blobs[master]: mb/google/guybrush: Update APCB file
by Robert Zieba (Code Review) 21 Mar '22

21 Mar '22

Attention is currently required from: Robert Zieba, Raul Rangel, Patrick Georgi, Rob Barnes, Felix Held. Hello Raul Rangel, Martin Roth, Patrick Georgi, Rob Barnes, Karthik Ramasubramanian, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/blobs/+/62963 to look at the new patch set (#4). Change subject: mb/google/guybrush: Update APCB file ...................................................................... mb/google/guybrush: Update APCB file The existing APCB file only has 4 SPD slots. This will not be enough for DeWatt devices due to upcoming changes in how RAM IDs are allocated for that variant. This commit updates the APCB file to have 16 slots which is sufficient for DeWatt. BUG=b:224884904 TEST=Used apcb_v3_edit to verify that the APCB file has 16 slots, checked that AP firmware images built with this file boot correctly Signed-off-by: Robert Zieba <robertzieba(a)google.com> Change-Id: Ifbfe2c61c42cd503a70fd84c51ce184c40fed318 --- M mainboard/google/guybrush/APCB_CZN_D4.bin M mainboard/google/guybrush/Release.txt 2 files changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/blobs refs/changes/63/62963/4 -- To view, visit https://review.coreboot.org/c/blobs/+/62963 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: master Gerrit-Change-Id: Ifbfe2c61c42cd503a70fd84c51ce184c40fed318 Gerrit-Change-Number: 62963 Gerrit-PatchSet: 4 Gerrit-Owner: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-CC: Eric Peers <epeers(a)google.com> Gerrit-Attention: Robert Zieba <robertzieba(a)google.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: src/acpi/acpigen_usb.c: Fix Memory leak error
by vaibhav (Code Review) 21 Mar '22

21 Mar '22

vaibhav has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/62968 ) Change subject: src/acpi/acpigen_usb.c: Fix Memory leak error ...................................................................... src/acpi/acpigen_usb.c: Fix Memory leak error Fix Memory leak error detected by scan-build for: https://coreboot.org/scan-build/EMULATION_QEMU_X86_I440FX-scanbuild/ Signed-off-by: Vaibhav Sethia <vrockz747(a)gmail.com> Change-Id: Ifed611bd0b9c1da3678386bff33bca3eac0311b4 --- M src/acpi/acpigen_usb.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/62968/1 diff --git a/src/acpi/acpigen_usb.c b/src/acpi/acpigen_usb.c index e32dfc4..ae175d0 100644 --- a/src/acpi/acpigen_usb.c +++ b/src/acpi/acpigen_usb.c @@ -4,6 +4,7 @@ #include <acpi/acpi_pld.h> #include <acpi/acpigen.h> #include <acpi/acpigen_usb.h> +#include <stdlib.h> static const char *power_role_to_str(enum usb_typec_power_role power_role) { @@ -85,6 +86,7 @@ fresh = strdup(path); if (fresh) acpi_dp_add_reference(dsd, prop_name, fresh); + free(fresh); } } -- To view, visit https://review.coreboot.org/c/coreboot/+/62968 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifed611bd0b9c1da3678386bff33bca3eac0311b4 Gerrit-Change-Number: 62968 Gerrit-PatchSet: 1 Gerrit-Owner: vaibhav <vrockz747(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in blobs[master]: mb/google/guybrush: Update APCB file
by Martin Roth (Code Review) 21 Mar '22

21 Mar '22

Attention is currently required from: Robert Zieba, Raul Rangel, Patrick Georgi, Rob Barnes, Felix Held. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/62963 ) Change subject: mb/google/guybrush: Update APCB file ...................................................................... Patch Set 3: (3 comments) Commit Message: https://review.coreboot.org/c/blobs/+/62963/comment/30df021e_dc17e8ac PS3, Line 11: enough Maybe say how many? https://review.coreboot.org/c/blobs/+/62963/comment/b65fd068_405ab4ec PS3, Line 13: : BUG=b:224884904 Add TEST= line? Patchset: PS3: Add -- To view, visit https://review.coreboot.org/c/blobs/+/62963 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: master Gerrit-Change-Id: Ifbfe2c61c42cd503a70fd84c51ce184c40fed318 Gerrit-Change-Number: 62963 Gerrit-PatchSet: 3 Gerrit-Owner: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-CC: Eric Peers <epeers(a)google.com> Gerrit-Attention: Robert Zieba <robertzieba(a)google.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 21 Mar 2022 20:45:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google: Remove unused cpu device
by Julius Werner (Code Review) 21 Mar '22

21 Mar '22

Julius Werner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/62805 ) Change subject: mb/google: Remove unused cpu device ...................................................................... mb/google: Remove unused cpu device The cpu device listed in MediaTek platforms' devicetree.cb doesn't actually do anything, except causing an error during device initialization: CPU: 00 missing read_resources Therefore, remove it from the devicetree. BUG=b:224419346 TEST=emerge-corsola coreboot TEST=Krabby booted up successfully BRANCH=none Change-Id: Ibf9f7cf65da6a0dd0a0e1f556d5772573ba3e930 Signed-off-by: Yu-Ping Wu <yupingso(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/62805 Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> Reviewed-by: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Reviewed-by: Hung-Te Lin <hungte(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/google/asurada/devicetree.cb M src/mainboard/google/cherry/devicetree.cb M src/mainboard/google/corsola/devicetree.cb M src/mainboard/google/kukui/devicetree.cb M src/mainboard/google/oak/devicetree.cb 5 files changed, 5 insertions(+), 15 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, but someone else must approve Paul Menzel: Looks good to me, but someone else must approve Hung-Te Lin: Looks good to me, approved Rex-BC Chen: Looks good to me, approved diff --git a/src/mainboard/google/asurada/devicetree.cb b/src/mainboard/google/asurada/devicetree.cb index 0bdeec2..91ff9ce 100644 --- a/src/mainboard/google/asurada/devicetree.cb +++ b/src/mainboard/google/asurada/devicetree.cb @@ -1,7 +1,5 @@ ## SPDX-License-Identifier: GPL-2.0-only chip soc/mediatek/mt8192 - device cpu_cluster 0 on - device cpu 0 on end - end + device cpu_cluster 0 on end end diff --git a/src/mainboard/google/cherry/devicetree.cb b/src/mainboard/google/cherry/devicetree.cb index 17fccc2..c16350c 100644 --- a/src/mainboard/google/cherry/devicetree.cb +++ b/src/mainboard/google/cherry/devicetree.cb @@ -1,7 +1,5 @@ ## SPDX-License-Identifier: GPL-2.0-only chip soc/mediatek/mt8195 - device cpu_cluster 0 on - device cpu 0 on end - end + device cpu_cluster 0 on end end diff --git a/src/mainboard/google/corsola/devicetree.cb b/src/mainboard/google/corsola/devicetree.cb index 0c4bcb5..0e8bb91 100644 --- a/src/mainboard/google/corsola/devicetree.cb +++ b/src/mainboard/google/corsola/devicetree.cb @@ -1,7 +1,5 @@ ## SPDX-License-Identifier: GPL-2.0-only chip soc/mediatek/mt8186 - device cpu_cluster 0 on - device cpu 0 on end - end + device cpu_cluster 0 on end end diff --git a/src/mainboard/google/kukui/devicetree.cb b/src/mainboard/google/kukui/devicetree.cb index 8efab95..45f2aad 100644 --- a/src/mainboard/google/kukui/devicetree.cb +++ b/src/mainboard/google/kukui/devicetree.cb @@ -1,7 +1,5 @@ ## SPDX-License-Identifier: GPL-2.0-only chip soc/mediatek/mt8183 - device cpu_cluster 0 on - device cpu 0 on end - end + device cpu_cluster 0 on end end diff --git a/src/mainboard/google/oak/devicetree.cb b/src/mainboard/google/oak/devicetree.cb index f021ab2..c11a901 100644 --- a/src/mainboard/google/oak/devicetree.cb +++ b/src/mainboard/google/oak/devicetree.cb @@ -1,7 +1,5 @@ ## SPDX-License-Identifier: GPL-2.0-only chip soc/mediatek/mt8173 - device cpu_cluster 0 on - device cpu 0 on end - end + device cpu_cluster 0 on end end -- To view, visit https://review.coreboot.org/c/coreboot/+/62805 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibf9f7cf65da6a0dd0a0e1f556d5772573ba3e930 Gerrit-Change-Number: 62805 Gerrit-PatchSet: 2 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022