coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: include/spd.h: Fix DDR4_SPD_72B_SO_{R,U}DIMM values
by Felix Held (Code Review) 28 Mar '22

28 Mar '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/62647 ) Change subject: include/spd.h: Fix DDR4_SPD_72B_SO_{R,U}DIMM values ...................................................................... include/spd.h: Fix DDR4_SPD_72B_SO_{R,U}DIMM values Regarding JEDEC Standard No. 21-C, Release 30, page 13, DDR4_SPD_72B_SO_RDIMM and DDR4_SPD_72B_SO_UDIMM values are respectively 0x08 and 0x09. There is no affected board in coreboot tree. Signed-off-by: Elyes Haouas … [View More]

1 0

Change in coreboot[master]: amdfwtool: Clear the whole byte of EFS_GEN
by Felix Held (Code Review) 28 Mar '22

28 Mar '22

Attention is currently required from: Bao Zheng, Zheng Bao. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63138 ) Change subject: amdfwtool: Clear the whole byte of EFS_GEN ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63138 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: … [View More]

1 0

Change in coreboot[master]: soc/intel/alderlake/pmc_descriptor.c: Add static assert on FMAP
by build bot (Jenkins) (Code Review) 28 Mar '22

28 Mar '22

Attention is currently required from: Tim Wawrzynczak. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63141 ) Change subject: soc/intel/alderlake/pmc_descriptor.c: Add static assert on FMAP ...................................................................... Patch Set 1: (1 comment) File src/soc/intel/alderlake/bootblock/pmc_descriptor.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144872): https://review.coreboot.… [View More]

1 0

Change in coreboot[master]: soc/intel/alderlake/pmc_descriptor.c: Add static assert on FMAP
by Arthur Heymans (Code Review) 28 Mar '22

28 Mar '22

Attention is currently required from: Tim Wawrzynczak. Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63141 ) Change subject: soc/intel/alderlake/pmc_descriptor.c: Add static assert on FMAP ...................................................................... soc/intel/alderlake/pmc_descriptor.c: Add static assert on FMAP Change-Id: I2d180353bfd69601ce03feb59101fb425859e779 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/… [View More]

1 0

Change in coreboot[master]: Revert "soc/intel/alderlake: Define Kconfigs for Descriptor Region"
by Arthur Heymans (Code Review) 28 Mar '22

28 Mar '22

Attention is currently required from: Tim Wawrzynczak. Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63140 ) Change subject: Revert "soc/intel/alderlake: Define Kconfigs for Descriptor Region" ...................................................................... Revert "soc/intel/alderlake: Define Kconfigs for Descriptor Region" No reason to put this in an Alderlake specific Kconfig file. This reverts commit … [View More]

1 0

Change in coreboot[master]: Revert "soc/intel/alderlake: Use Kconfigs for Descriptor Region"
by Arthur Heymans (Code Review) 28 Mar '22

28 Mar '22

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63139 ) Change subject: Revert "soc/intel/alderlake: Use Kconfigs for Descriptor Region" ...................................................................... Revert "soc/intel/alderlake: Use Kconfigs for Descriptor Region" USe FMAP offsets directly with static asserts instead of defining a Kconfig variable. This reverts commit be082fe9f401304c29a839c63a835e793b9f41ff. Change-Id: … [View More]Ie858341f0723a6b278ea53960f1e09b37bc82d83 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/soc/intel/alderlake/bootblock/pmc_descriptor.c 1 file changed, 9 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/63139/1 diff --git a/src/soc/intel/alderlake/bootblock/pmc_descriptor.c b/src/soc/intel/alderlake/bootblock/pmc_descriptor.c index c585f70..4e80957 100644 --- a/src/soc/intel/alderlake/bootblock/pmc_descriptor.c +++ b/src/soc/intel/alderlake/bootblock/pmc_descriptor.c @@ -11,6 +11,8 @@ #include <soc/bootblock.h> #include <types.h> +#define SI_DESC_REGION "SI_DESC" +#define SI_DESC_REGION_SZ 4096 #define PMC_DESC_7_BYTE3 0xc32 /* Flash Master 1 : HOST/BIOS */ @@ -42,19 +44,18 @@ /* It updates PMC Descriptor in the Descriptor Region */ void configure_pmc_descriptor(void) { - uint8_t si_desc_buf[CONFIG_SI_DESC_REGION_SZ]; + uint8_t si_desc_buf[SI_DESC_REGION_SZ]; struct region_device desc_rdev; if (cpu_get_cpuid() != CPUID_ALDERLAKE_A0) return; - if (fmap_locate_area_as_rdev_rw(CONFIG_SI_DESC_REGION, &desc_rdev) < 0) { - printk(BIOS_ERR, "Failed to locate %s in the FMAP\n", CONFIG_SI_DESC_REGION); + if (fmap_locate_area_as_rdev_rw(SI_DESC_REGION, &desc_rdev) < 0) { + printk(BIOS_ERR, "Failed to locate %s in the FMAP\n", SI_DESC_REGION); return; } - if (rdev_readat(&desc_rdev, si_desc_buf, 0, CONFIG_SI_DESC_REGION_SZ) != - CONFIG_SI_DESC_REGION_SZ) { + if (rdev_readat(&desc_rdev, si_desc_buf, 0, SI_DESC_REGION_SZ) != SI_DESC_REGION_SZ) { printk(BIOS_ERR, "Failed to read Descriptor Region from SPI Flash\n"); return; } @@ -69,13 +70,13 @@ si_desc_buf[PMC_DESC_7_BYTE3] = 0x44; - if (rdev_eraseat(&desc_rdev, 0, CONFIG_SI_DESC_REGION_SZ) != CONFIG_SI_DESC_REGION_SZ) { + if (rdev_eraseat(&desc_rdev, 0, SI_DESC_REGION_SZ) != SI_DESC_REGION_SZ) { printk(BIOS_ERR, "Failed to erase Descriptor Region area\n"); return; } - if (rdev_writeat(&desc_rdev, si_desc_buf, 0, CONFIG_SI_DESC_REGION_SZ) - != CONFIG_SI_DESC_REGION_SZ) { + if (rdev_writeat(&desc_rdev, si_desc_buf, 0, SI_DESC_REGION_SZ) + != SI_DESC_REGION_SZ) { printk(BIOS_ERR, "Failed to update Descriptor Region\n"); return; } -- To view, visit https://review.coreboot.org/c/coreboot/+/63139 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie858341f0723a6b278ea53960f1e09b37bc82d83 Gerrit-Change-Number: 63139 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange [View Less]

1 0

Change in coreboot[master]: soc/intel/common: Add support to control coreboot and Intel SoC features
by Arthur Heymans (Code Review) 28 Mar '22

28 Mar '22

Attention is currently required from: Nico Huber, Subrata Banik, Sridhar Siricilla, Patrick Rudolph. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61380 ) Change subject: soc/intel/common: Add support to control coreboot and Intel SoC features ...................................................................... Patch Set 16: Code-Review-1 -- To view, visit https://review.coreboot.org/c/coreboot/+/61380 To unsubscribe, or for help writing … [View More]

1 0

Change in coreboot[master]: soc/intel/common: Add support to control coreboot and Intel SoC features
by Arthur Heymans (Code Review) 28 Mar '22

28 Mar '22

Attention is currently required from: Nico Huber, Subrata Banik, Sridhar Siricilla, Patrick Rudolph. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61380 ) Change subject: soc/intel/common: Add support to control coreboot and Intel SoC features ...................................................................... Patch Set 16: (1 comment) Patchset: PS16: Can you please squash this work with some of CB:62715. None if it makes a lot of sense … [View More]

1 0

Change in coreboot[master]: soc/intel/alderlake: Enable FSP_USES_CB_DEBUG_EVENT_HANDLER Kconfig
by Subrata Banik (Code Review) 28 Mar '22

28 Mar '22

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63009 ) Change subject: soc/intel/alderlake: Enable FSP_USES_CB_DEBUG_EVENT_HANDLER Kconfig ...................................................................... Patch Set 4: (1 comment) Patchset: PS3: > > Like to share one observation before we enable this feature on ADL. > > > > Currently we have fixed size cbmem console which is 8K in size and for sure not enough to hold … [View More]

1 0

Change in blobs[master]: Revert "soc/mediatek/mt8186: Update SPM firmware to pcm_suspend_v0215...
by Yu-Ping Wu (Code Review) 28 Mar '22

28 Mar '22

Attention is currently required from: Rex-BC Chen, Paul Menzel. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/63097 ) Change subject: Revert "soc/mediatek/mt8186: Update SPM firmware to pcm_suspend_v0215_v10" ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: > @hung-te and @yu-ping, […] What's the impact of disabling 26M clock? -- To view, visit https://review.coreboot.org/c/blobs/… [View More]

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022