coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: soc/intel/common: Add Kconfig SOC_INTEL_CSE_SET_EOP
by Subrata Banik (Code Review) 29 Mar '22

29 Mar '22

Attention is currently required from: John Zhao, Tim Wawrzynczak, EricR Lai. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63159 ) Change subject: soc/intel/common: Add Kconfig SOC_INTEL_CSE_SET_EOP ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63159 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib52404d9ad4c01a460e4cfef331c529d2a53337a Gerrit-Change-Number: 63159 Gerrit-PatchSet: 1 Gerrit-Owner: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: John Zhao <john.zhao(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Tue, 29 Mar 2022 12:41:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Revert "mb/google/brya/var/kano: adjust I2C3 speed"
by David Wu (Code Review) 29 Mar '22

29 Mar '22

Attention is currently required from: Paul Menzel, Ren Kuo, Tim Wawrzynczak. David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63168 ) Change subject: Revert "mb/google/brya/var/kano: adjust I2C3 speed" ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/63168/comment/20ff378b_9d746db1 PS2, Line 10: Reason: Measure DVT I2C3 speed is 397KHz after revert this CL. > What was the speed before? What happened? Did the hardware change? This change is mainly to address firmware messages show [ERROR] dw_i2c:invalid bus speed 390000. Thanks. -- To view, visit https://review.coreboot.org/c/coreboot/+/63168 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5982c82a55710824692b41e263418e4b4d420b02 Gerrit-Change-Number: 63168 Gerrit-PatchSet: 4 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Tue, 29 Mar 2022 12:28:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Revert "mb/google/brya/var/kano: adjust I2C3 speed"
by David Wu (Code Review) 29 Mar '22

29 Mar '22

Attention is currently required from: Ren Kuo, Tim Wawrzynczak. Hello build bot (Jenkins), Ren Kuo, Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63168 to look at the new patch set (#4). Change subject: Revert "mb/google/brya/var/kano: adjust I2C3 speed" ...................................................................... Revert "mb/google/brya/var/kano: adjust I2C3 speed" This reverts commit 65aaccda5910e9c74aaa2a44ea84119d9476c902. Reason: 1. Fix firmware messages show [ERROR] dw_i2c:invalid bus speed 390000 2. Measure DVT I2C3 speed < 400KHz. BUG=b:215095284 TEST=There isn't ERROR messages and verify I2C3 speed < 400KHz. Signed-off-by: David Wu <david_wu(a)quanta.corp-partner.google.com> Change-Id: I5982c82a55710824692b41e263418e4b4d420b02 --- M src/mainboard/google/brya/variants/kano/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/63168/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/63168 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5982c82a55710824692b41e263418e4b4d420b02 Gerrit-Change-Number: 63168 Gerrit-PatchSet: 4 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Revert "mb/google/brya/var/kano: adjust I2C3 speed"
by David Wu (Code Review) 29 Mar '22

29 Mar '22

Attention is currently required from: David Wu, Ren Kuo, Tim Wawrzynczak. Hello build bot (Jenkins), Ren Kuo, Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63168 to look at the new patch set (#3). Change subject: Revert "mb/google/brya/var/kano: adjust I2C3 speed" ...................................................................... Revert "mb/google/brya/var/kano: adjust I2C3 speed" This reverts commit 65aaccda5910e9c74aaa2a44ea84119d9476c902. Reason: 1. Fixfirmware messages show [ERROR] dw_i2c:invalid bus speed 390000 2. Measure DVT I2C3 speed < 400KHz. BUG=b:215095284 TEST=There isn't ERROR messages and verify I2C3 speed < 400KHz. Signed-off-by: David Wu <david_wu(a)quanta.corp-partner.google.com> Change-Id: I5982c82a55710824692b41e263418e4b4d420b02 --- M src/mainboard/google/brya/variants/kano/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/63168/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/63168 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5982c82a55710824692b41e263418e4b4d420b02 Gerrit-Change-Number: 63168 Gerrit-PatchSet: 3 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: ec/starlabs/merlin: Add support for Nuvoton EC's
by Paul Menzel (Code Review) 29 Mar '22

29 Mar '22

Attention is currently required from: Sean Rhodes, Angel Pons. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62702 ) Change subject: ec/starlabs/merlin: Add support for Nuvoton EC's ...................................................................... Patch Set 13: (1 comment) File src/ec/starlabs/merlin/Kconfig: https://review.coreboot.org/c/coreboot/+/62702/comment/c41ea4ca_0e9417f8 PS13, Line 7: Interface to Nuvoton embedded controller Also mention the EC firmware here? -- To view, visit https://review.coreboot.org/c/coreboot/+/62702 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib66baf1e88f5d548ce955dffa00c9b88255b2f95 Gerrit-Change-Number: 62702 Gerrit-PatchSet: 13 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 29 Mar 2022 12:07:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/starlabs/merlin: Add support for Nuvoton EC's
by Paul Menzel (Code Review) 29 Mar '22

29 Mar '22

Attention is currently required from: Sean Rhodes, Angel Pons. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62702 ) Change subject: ec/starlabs/merlin: Add support for Nuvoton EC's ...................................................................... Patch Set 13: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/62702/comment/4748134b_e459cc42 PS13, Line 12: Do you know the EC firmware version/string? -- To view, visit https://review.coreboot.org/c/coreboot/+/62702 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib66baf1e88f5d548ce955dffa00c9b88255b2f95 Gerrit-Change-Number: 62702 Gerrit-PatchSet: 13 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 29 Mar 2022 12:06:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/fsp2_0: Allow coreboot to control FSP serial redirection
by Paul Menzel (Code Review) 29 Mar '22

29 Mar '22

Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Angel Pons, Nick Vaccaro, Arthur Heymans, Lean Sheng Tan, Andrey Petrov. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63166 ) Change subject: drivers/intel/fsp2_0: Allow coreboot to control FSP serial redirection ...................................................................... Patch Set 1: (11 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/63166/comment/b38aec54_74721918 PS1, Line 9: coreboot has implemented native FSP debug handler with commit hash : 3ba6f8cdf (drivers/intel/fsp2_0: Add native implementation for FSP : Debug Handler). Maybe: Commit 3ba6f8cdf (drivers/intel/fsp2_0: Add native implementation for FSP Debug Handler) implements a native FSP debug handler. https://review.coreboot.org/c/coreboot/+/63166/comment/1ad83bb0_16728fd6 PS1, Line 12: However, coreboot still can't control when to redirect FSP debug Please add a blank line above to separate paragraphs. https://review.coreboot.org/c/coreboot/+/63166/comment/01ebf5f0_665674b8 PS1, Line 12: One space. https://review.coreboot.org/c/coreboot/+/63166/comment/0cbe7a4a_0f728b89 PS1, Line 15: wish wishes https://review.coreboot.org/c/coreboot/+/63166/comment/01b51fe2_e0c9e18c PS1, Line 15: to see FSP debug log : with all the coreboot serial image Please rephrase, as I do not understand it. https://review.coreboot.org/c/coreboot/+/63166/comment/a3b72a23_a1044f5e PS1, Line 19: an a https://review.coreboot.org/c/coreboot/+/63166/comment/35a7391d_d208b88f PS1, Line 21: incase in case https://review.coreboot.org/c/coreboot/+/63166/comment/a32cea0e_6266af57 PS1, Line 26: Non-serial coreboot image Maybe mention console, or rephrase. https://review.coreboot.org/c/coreboot/+/63166/comment/05f47460_079c58e4 PS1, Line 55: Redrix google/redrix https://review.coreboot.org/c/coreboot/+/63166/comment/dd28155b_c0e929b6 PS1, Line 55: #1- #3 #1–#3 or #1--#3 https://review.coreboot.org/c/coreboot/+/63166/comment/540e6f34_75caadbe PS1, Line 57: Can FSP messages be put into CBMEM console or is only serial supported? -- To view, visit https://review.coreboot.org/c/coreboot/+/63166 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0b008ca9d4f40bfa6a989a6fd655c234f91fde65 Gerrit-Change-Number: 63166 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Comment-Date: Tue, 29 Mar 2022 12:04:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common: Update CSE sub partition update
by Paul Menzel (Code Review) 29 Mar '22

29 Mar '22

Attention is currently required from: Sridhar Siricilla, Kane Chen. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63169 ) Change subject: soc/intel/common: Update CSE sub partition update ...................................................................... Patch Set 2: (3 comments) File src/soc/intel/common/block/cse/cse_lite.c: https://review.coreboot.org/c/coreboot/+/63169/comment/bb538a00_e23b2bb3 PS2, Line 3: #include <arch/cpu.h> Unrelated. https://review.coreboot.org/c/coreboot/+/63169/comment/d67eada5_6513ad0b PS2, Line 786: uint32_t size; : uint32_t start_offset; : uint32_t end_offset; Why not `unsigned int`, `size_t` or `off_t`? https://review.coreboot.org/c/coreboot/+/63169/comment/9f82abd8_909b8ee6 PS2, Line 804: region_name, (uint32_t)start_offset, (uint32_t)size); Why are these casts needed? -- To view, visit https://review.coreboot.org/c/coreboot/+/63169 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie9a83b77ab44ea6ffe5bb20673e109a89a148629 Gerrit-Change-Number: 63169 Gerrit-PatchSet: 2 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Kane Chen <kane.chen(a)intel.com> Gerrit-Comment-Date: Tue, 29 Mar 2022 11:57:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Docs/project_ideas: Implement the ARM BBR spec in coreboot
by Paul Menzel (Code Review) 29 Mar '22

29 Mar '22

Attention is currently required from: Arthur Heymans, Felix Singer, Angel Pons, Julius Werner, ron minnich. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63034 ) Change subject: Docs/project_ideas: Implement the ARM BBR spec in coreboot ...................................................................... Patch Set 4: Code-Review+1 (3 comments) File Documentation/contributing/project_ideas.md: https://review.coreboot.org/c/coreboot/+/63034/comment/42302fc9_a5724e5a PS4, Line 236: Operating operating https://review.coreboot.org/c/coreboot/+/63034/comment/ba3b3672_26841c64 PS4, Line 241: Currently coreboot has no support for SMBIOS or ACPI. : coreboot also does not support runtime services by design. : The mandated UEFI runtime services seem only useful to provide Linux both : SMBIOS & ACPI. Re-flow? https://review.coreboot.org/c/coreboot/+/63034/comment/4814c9a2_285faf4f PS4, Line 259: Payloads payloads -- To view, visit https://review.coreboot.org/c/coreboot/+/63034 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0f5f1f0a613ed0ed3f8ecdf3c1330a0d78efe399 Gerrit-Change-Number: 63034 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Tue, 29 Mar 2022 11:52:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/starlabs/merlin: Rename ec.c to more specific ite.c
by Paul Menzel (Code Review) 29 Mar '22

29 Mar '22

Attention is currently required from: Sean Rhodes, Angel Pons. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62677 ) Change subject: ec/starlabs/merlin: Rename ec.c to more specific ite.c ...................................................................... Patch Set 10: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/62677 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0bac5e4c101792dd4c6a0d4a1ae4a4c7fcd837d5 Gerrit-Change-Number: 62677 Gerrit-PatchSet: 10 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Comment-Date: Tue, 29 Mar 2022 11:49:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022