coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: Documentation: gpio: Provide minor fixes to the table
by Subrata Banik (Code Review) 29 Mar '22

29 Mar '22

Attention is currently required from: Subrata Banik, Eric Lai. Hello build bot (Jenkins), Michael Niewöhner, Eric Lai, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63177 to look at the new patch set (#2). Change subject: Documentation: gpio: Provide minor fixes to the table ...................................................................... Documentation: gpio: Provide minor fixes to the table This patch fixes the table issue in markdown file identified with commit 96481066 (Documentation: gpio: Update table as per coreboot guidelines). BUG=b:211573253, b:211950520 Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: Ifd8265b92b5ef0dcabb754371591477ca19c39be --- M Documentation/getting_started/gpio.md 1 file changed, 7 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/63177/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63177 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifd8265b92b5ef0dcabb754371591477ca19c39be Gerrit-Change-Number: 63177 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Documentation: gpio: Provide minor fixes to the table
by Michael Niewöhner (Code Review) 29 Mar '22

29 Mar '22

Attention is currently required from: Subrata Banik, Eric Lai. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63177 ) Change subject: Documentation: gpio: Provide minor fixes to the table ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/63177 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifd8265b92b5ef0dcabb754371591477ca19c39be Gerrit-Change-Number: 63177 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Tue, 29 Mar 2022 18:47:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: gpio: Provide minor fixes to the table
by Michael Niewöhner (Code Review) 29 Mar '22

29 Mar '22

Attention is currently required from: Subrata Banik, Eric Lai. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63177 ) Change subject: Documentation: gpio: Provide minor fixes to the table ...................................................................... Patch Set 1: (1 comment) File Documentation/getting_started/gpio.md: https://review.coreboot.org/c/coreboot/+/63177/comment/7e1bce14_0ce64179 PS1, Line 212: NA I don't know if NA is common, n/a is, though -- To view, visit https://review.coreboot.org/c/coreboot/+/63177 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifd8265b92b5ef0dcabb754371591477ca19c39be Gerrit-Change-Number: 63177 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Tue, 29 Mar 2022 18:47:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/(cnl, jsl, tgl): Enable SOC_INTEL_COMMON_BASECODE
by Tim Wawrzynczak (Code Review) 29 Mar '22

29 Mar '22

Attention is currently required from: Sridhar Siricilla. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62843 ) Change subject: soc/intel/(cnl, jsl, tgl): Enable SOC_INTEL_COMMON_BASECODE ...................................................................... Patch Set 2: (1 comment) File src/soc/intel/jasperlake/Kconfig: https://review.coreboot.org/c/coreboot/+/62843/comment/a0320256_977ea4da PS2, Line 71: SOC_INTEL_COMMON_BASECODE should these also be qualified with `if SOC_INTEL_CSE_LITE_SKU` ? -- To view, visit https://review.coreboot.org/c/coreboot/+/62843 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie55ded673c8fa0edf2ca6789b15771bd2e56c95e Gerrit-Change-Number: 62843 Gerrit-PatchSet: 2 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sridhar Siricilla <sridhar.siricilla(a)gmail.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Comment-Date: Tue, 29 Mar 2022 18:41:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: gpio: Update table as per coreboot guidelines
by Subrata Banik (Code Review) 29 Mar '22

29 Mar '22

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63126 ) Change subject: Documentation: gpio: Update table as per coreboot guidelines ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > > column 3, lines 212 and following > > How about replacing `-` with `NA`? > +------------------------+----------------+-------------+-------------+ > | | 11 - Resume Reset | Warm Reset | NA | N | > | | (GPP: Reserved, +----------------+-------------+-------------+ > | | GPD: RSMRST) | Cold Reset | NA | N | > | +----------------+-------------+-------------+ > | | S3/S4/S5 | NA | N | > | +----------------+-------------+-------------+ > | | Global Reset | NA | N | > | +----------------+-------------+-------------+ > | | Deep Sx | NA | Y | > | +----------------+-------------+-------------+ > | | G3 | NA | Y | > +------------------------+----------------+-------------+-------------+ Submitted CL here: CB:63177 -- To view, visit https://review.coreboot.org/c/coreboot/+/63126 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic4f27f46a9d219098612d8b7747ae26116506fce Gerrit-Change-Number: 63126 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Subrata Banik <subi.banik(a)gmail.com> Gerrit-Comment-Date: Tue, 29 Mar 2022 18:38:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: gpio: Provide minor fixes to the table
by Subrata Banik (Code Review) 29 Mar '22

29 Mar '22

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63177 ) Change subject: Documentation: gpio: Provide minor fixes to the table ...................................................................... Documentation: gpio: Provide minor fixes to the table This patch fixes the table issue in markdown file identified with commit 96481066 (Documentation: gpio: Update table as per coreboot guidelines). BUG=b:211573253, b:211950520 Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: Ifd8265b92b5ef0dcabb754371591477ca19c39be --- M Documentation/getting_started/gpio.md 1 file changed, 7 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/63177/1 diff --git a/Documentation/getting_started/gpio.md b/Documentation/getting_started/gpio.md index 216ba5d..0f28e61 100644 --- a/Documentation/getting_started/gpio.md +++ b/Documentation/getting_started/gpio.md @@ -176,7 +176,7 @@ | | 00 - Power Good | Warm Reset | N | N | | | (GPP: RSMRST, +----------------+-------------+-------------+ | | GPD: DSW_PWROK) | Cold Reset | N | N | -| |----------------+-------------+-------------+ +| +----------------+-------------+-------------+ | | S3/S4/S5 | N | N | | +----------------+-------------+-------------+ | | Global Reset | N | N | @@ -209,17 +209,17 @@ | +----------------+-------------+-------------+ | | G3 | Y | Y | +------------------------+----------------+-------------+-------------+ -| | 11 - Resume Reset | Warm Reset | - | N | +| | 11 - Resume Reset | Warm Reset | NA | N | | | (GPP: Reserved, +----------------+-------------+-------------+ -| | GPD: RSMRST) | Cold Reset | - | N | +| | GPD: RSMRST) | Cold Reset | NA | N | | +----------------+-------------+-------------+ -| | S3/S4/S5 | - | N | +| | S3/S4/S5 | NA | N | | +----------------+-------------+-------------+ -| | Global Reset | - | N | +| | Global Reset | NA | N | | +----------------+-------------+-------------+ -| | Deep Sx | - | Y | +| | Deep Sx | NA | Y | | +----------------+-------------+-------------+ -| | G3 | - | Y | +| | G3 | NA | Y | +------------------------+----------------+-------------+-------------+ ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/63177 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifd8265b92b5ef0dcabb754371591477ca19c39be Gerrit-Change-Number: 63177 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/intel/common: Abstract the common TCSS functions
by Wonkyu Kim (Code Review) 29 Mar '22

29 Mar '22

Attention is currently required from: Subrata Banik, John Zhao, Tim Wawrzynczak, Paul Menzel, Eric Lai, Angel Pons, Patrick Rudolph, EricR Lai. Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62723 ) Change subject: soc/intel/common: Abstract the common TCSS functions ...................................................................... Patch Set 13: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/62723 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3302aabfb5f540c41da6359f11376b4202c6310b Gerrit-Change-Number: 62723 Gerrit-PatchSet: 13 Gerrit-Owner: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: John Zhao <john.zhao(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Tue, 29 Mar 2022 18:29:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src/acpi/acpigen_usb.c: Fix False Memory leak error
by Tim Wawrzynczak (Code Review) 29 Mar '22

29 Mar '22

Attention is currently required from: Felix Singer, Nico Huber, Paul Menzel, Angel Pons, vaibhav. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62968 ) Change subject: src/acpi/acpigen_usb.c: Fix False Memory leak error ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: + some other folks for other opinions on clang_analyzer File src/acpi/acpigen_usb.c: https://review.coreboot.org/c/coreboot/+/62968/comment/36a44ba0_2fe3ce3e PS2, Line 92: #ifdef __clang_analyzer__ : free(fresh); : #endif Hmm, right now we do not have any instances of this in the code I can found, other than vendorcode, not sure if this is worth cluttering up the code with or not. The whole heap area is kept in CBMEM and marked as RESERVED in cbmem table (which most payloads recognize as RESERVED for e820 map), thus there can't be any leaks, by definition, so it seems that just ignoring these may be the best course. -- To view, visit https://review.coreboot.org/c/coreboot/+/62968 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifed611bd0b9c1da3678386bff33bca3eac0311b4 Gerrit-Change-Number: 62968 Gerrit-PatchSet: 2 Gerrit-Owner: vaibhav <vrockz747(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: vaibhav <vrockz747(a)gmail.com> Gerrit-Comment-Date: Tue, 29 Mar 2022 18:27:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ChromeoS: Retain ACPI CNVS contents on S3 resume
by Tim Wawrzynczak (Code Review) 29 Mar '22

29 Mar '22

Attention is currently required from: Julius Werner, Kyösti Mälkki. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61619 ) Change subject: ChromeoS: Retain ACPI CNVS contents on S3 resume ...................................................................... Patch Set 5: Code-Review+2 (1 comment) Patchset: PS5: > Also the boards in CB:58896 were affected, for S3 resume path ECFW_RO is unconditionally set, while […] Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/61619 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iea71a51aba7ab1b6966389c17a1e06ccc96ae0e9 Gerrit-Change-Number: 61619 Gerrit-PatchSet: 5 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Tue, 29 Mar 2022 18:19:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/kano: Remove SAR sensor
by David Wu (Code Review) 29 Mar '22

29 Mar '22

Attention is currently required from: Ren Kuo, Nick Vaccaro. David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63165 ) Change subject: mb/google/brya/var/kano: Remove SAR sensor ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/63165/comment/27863562_3fd502c2 PS1, Line 9: . > `, therefore remove the corresponding entries from the devicetree. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/63165 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I31faf18563848f8d6787fe70bfb28006efea8427 Gerrit-Change-Number: 63165 Gerrit-PatchSet: 2 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Tue, 29 Mar 2022 17:58:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022