coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: mb/google/brya/: Add PEG and initial Nvidia dGPU ASL support
by Subrata Banik (Code Review) 29 Mar '22

29 Mar '22

Attention is currently required from: Tim Wawrzynczak, Paul Menzel, Michael Niewöhner. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62931 ) Change subject: mb/google/brya/: Add PEG and initial Nvidia dGPU ASL support ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/62931 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifce1610210e9636e87dda4b55c8287334adfcc42 Gerrit-Change-Number: 62931 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Tue, 29 Mar 2022 19:32:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/agah: Add GPU power sequencing
by Tim Wawrzynczak (Code Review) 29 Mar '22

29 Mar '22

Attention is currently required from: Subrata Banik, Angel Pons, Nick Vaccaro. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62384 ) Change subject: mb/google/brya/var/agah: Add GPU power sequencing ...................................................................... Patch Set 3: (1 comment) File src/mainboard/google/brya/variants/agah/variant.c: https://review.coreboot.org/c/coreboot/+/62384/comment/b91c7bd6_1fb4324b PS1, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */ > WDYT about this? […] Incorporated some of your ideas 👍 -- To view, visit https://review.coreboot.org/c/coreboot/+/62384 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1072be12ef58af5859e2a2d19c4a9c1adc0b0f88 Gerrit-Change-Number: 62384 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Tue, 29 Mar 2022 19:26:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/: Add PEG and initial Nvidia dGPU ASL support
by Tim Wawrzynczak (Code Review) 29 Mar '22

29 Mar '22

Attention is currently required from: Subrata Banik, Paul Menzel, Michael Niewöhner. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62931 ) Change subject: mb/google/brya/: Add PEG and initial Nvidia dGPU ASL support ...................................................................... Patch Set 3: (5 comments) Patchset: PS2: > one more thought, if `nvjt/nvop` can exist inside `driver/nvidia/acpi` so we could reuse the same be […] Yeah we'll see how the driver ends up looking, and extend it if needed. PS2: > erm, oh. brain was slow and fingers were faster than my eyes. […] Once we all have an upstream driver I would love to switch to that 😊 File src/mainboard/google/brya/acpi/gpu_top.asl: https://review.coreboot.org/c/coreboot/+/62931/comment/af0889f2_fdb3c9b9 PS2, Line 3: #define NV_ERROR_SUCCESS 0x0 : #define NV_ERROR_UNSPECIFIED 0x80000001 : #define NV_ERROR_UNSUPPORTED 0x80000002 > suggestion: may be `enum`? Moved to a header file (I don't think ASL has enums) https://review.coreboot.org/c/coreboot/+/62931/comment/76150427_4a1fbf49 PS2, Line 45: Device (PEGP) > if code block inside `PEGP` remains generic then I would suggest to split this file into 3 files […] Done File src/mainboard/google/brya/acpi/power.asl: https://review.coreboot.org/c/coreboot/+/62931/comment/33131a81_5d5248ae PS2, Line 227: > multiple blank line? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/62931 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifce1610210e9636e87dda4b55c8287334adfcc42 Gerrit-Change-Number: 62931 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Tue, 29 Mar 2022 19:26:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/taeko{4es}: Remove extraneous __weak attributes
by Tim Wawrzynczak (Code Review) 29 Mar '22

29 Mar '22

Tim Wawrzynczak has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63179 ) Change subject: mb/google/brya/var/taeko{4es}: Remove extraneous __weak attributes ...................................................................... mb/google/brya/var/taeko{4es}: Remove extraneous __weak attributes Functions that are intended to override weak ones defined in the baseboard should not also be declared weak, otherwise how would the linker know which copy to keep. Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Change-Id: Ia2ceee77d00a5baa915fd1f306d76e79aa609e65 --- M src/mainboard/google/brya/variants/taeko/memory.c M src/mainboard/google/brya/variants/taeko4es/memory.c 2 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/63179/1 diff --git a/src/mainboard/google/brya/variants/taeko/memory.c b/src/mainboard/google/brya/variants/taeko/memory.c index 9a7ef5c..e9e8533 100644 --- a/src/mainboard/google/brya/variants/taeko/memory.c +++ b/src/mainboard/google/brya/variants/taeko/memory.c @@ -66,12 +66,12 @@ .ect = 1, /* Enable Early Command Training */ }; -const struct mb_cfg *__weak variant_memory_params(void) +const struct mb_cfg *variant_memory_params(void) { return &baseboard_memcfg; } -int __weak variant_memory_sku(void) +int variant_memory_sku(void) { /* * Memory configuration board straps @@ -90,7 +90,7 @@ return gpio_base2_value(spd_gpios, ARRAY_SIZE(spd_gpios)); } -bool __weak variant_is_half_populated(void) +bool variant_is_half_populated(void) { /* GPIO_MEM_CH_SEL GPP_E13 */ return gpio_get(GPP_E13); diff --git a/src/mainboard/google/brya/variants/taeko4es/memory.c b/src/mainboard/google/brya/variants/taeko4es/memory.c index 9a7ef5c..37f07d8 100644 --- a/src/mainboard/google/brya/variants/taeko4es/memory.c +++ b/src/mainboard/google/brya/variants/taeko4es/memory.c @@ -66,12 +66,12 @@ .ect = 1, /* Enable Early Command Training */ }; -const struct mb_cfg *__weak variant_memory_params(void) +const struct mb_cfg * variant_memory_params(void) { return &baseboard_memcfg; } -int __weak variant_memory_sku(void) +int variant_memory_sku(void) { /* * Memory configuration board straps @@ -90,7 +90,7 @@ return gpio_base2_value(spd_gpios, ARRAY_SIZE(spd_gpios)); } -bool __weak variant_is_half_populated(void) +bool variant_is_half_populated(void) { /* GPIO_MEM_CH_SEL GPP_E13 */ return gpio_get(GPP_E13); -- To view, visit https://review.coreboot.org/c/coreboot/+/63179 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia2ceee77d00a5baa915fd1f306d76e79aa609e65 Gerrit-Change-Number: 63179 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/brya: Make __weak usage consistent
by Tim Wawrzynczak (Code Review) 29 Mar '22

29 Mar '22

Tim Wawrzynczak has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63178 ) Change subject: mb/google/brya: Make __weak usage consistent ...................................................................... mb/google/brya: Make __weak usage consistent Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Change-Id: Ic59cccdf0fb88fc71a440170ee40b73dd8736a33 --- M src/mainboard/google/brya/mainboard.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/63178/1 diff --git a/src/mainboard/google/brya/mainboard.c b/src/mainboard/google/brya/mainboard.c index 44e192c..61296d7 100644 --- a/src/mainboard/google/brya/mainboard.c +++ b/src/mainboard/google/brya/mainboard.c @@ -59,12 +59,12 @@ variant_update_soc_chip_config(config); } -__weak void variant_update_soc_chip_config(struct soc_intel_alderlake_config *config) +void __weak variant_update_soc_chip_config(struct soc_intel_alderlake_config *config) { /* default implementation does nothing */ } -__weak void variant_init(void) +void __weak variant_init(void) { /* default implementation does nothing */ } -- To view, visit https://review.coreboot.org/c/coreboot/+/63178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic59cccdf0fb88fc71a440170ee40b73dd8736a33 Gerrit-Change-Number: 63178 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/brya/: Add PEG and initial Nvidia dGPU ASL support
by Tim Wawrzynczak (Code Review) 29 Mar '22

29 Mar '22

Attention is currently required from: Paul Menzel. Hello build bot (Jenkins), Subrata Banik, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62931 to look at the new patch set (#3). Change subject: mb/google/brya/: Add PEG and initial Nvidia dGPU ASL support ...................................................................... mb/google/brya/: Add PEG and initial Nvidia dGPU ASL support Some brya variants will use a GN20 series Nvidia GPU, which requires quite a bit of ACPI support code to be written for it. This patch lands a decent bit of the initial code for it on the brya platform, including: 1) PEG RTD3 methods 2) DGPU power operations (RTD3 and GCOFF, NVJT _DSM and other Methods) 3) NVOP _DSM method There will be more support to come later, this is all written to specifications from the Nvidia Software Design Guide for GN20. BUG=b:214581763 TEST=build patch train Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Change-Id: Ifce1610210e9636e87dda4b55c8287334adfcc42 --- M src/mainboard/google/brya/Kconfig A src/mainboard/google/brya/acpi/common_defs.h A src/mainboard/google/brya/acpi/gpu.asl A src/mainboard/google/brya/acpi/gpu_top.asl A src/mainboard/google/brya/acpi/nvjt.asl A src/mainboard/google/brya/acpi/nvop.asl A src/mainboard/google/brya/acpi/peg.asl A src/mainboard/google/brya/acpi/power.asl A src/mainboard/google/brya/acpi/utility.asl M src/mainboard/google/brya/dsdt.asl 10 files changed, 727 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/62931/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/62931 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifce1610210e9636e87dda4b55c8287334adfcc42 Gerrit-Change-Number: 62931 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya/var/agah: Add GPU power sequencing
by Tim Wawrzynczak (Code Review) 29 Mar '22

29 Mar '22

Attention is currently required from: Subrata Banik, Angel Pons, Nick Vaccaro. Hello build bot (Jenkins), Subrata Banik, Nick Vaccaro, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62384 to look at the new patch set (#3). Change subject: mb/google/brya/var/agah: Add GPU power sequencing ...................................................................... mb/google/brya/var/agah: Add GPU power sequencing This patch adds support for power sequencing of the Nvidia GN3050 for agah, which uses PCH GPIOs to control the 5 power rails required for the GPU. The GPU is power sequenced on during mainboard initialization, then it is enumerated on the PCI bus and its resources are assigned. This GPU will be used in a sort of "hybrid graphics" mode, therefore during finalization, since its PCI BARs are saved into ACPI memory and the GPU is not required upon initial boot, the GPU is power sequenced off. Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Change-Id: I1072be12ef58af5859e2a2d19c4a9c1adc0b0f88 --- M src/mainboard/google/brya/variants/agah/Makefile.inc M src/mainboard/google/brya/variants/agah/overridetree.cb A src/mainboard/google/brya/variants/agah/variant.c 3 files changed, 181 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/62384/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/62384 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1072be12ef58af5859e2a2d19c4a9c1adc0b0f88 Gerrit-Change-Number: 62384 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/common: Abstract the common TCSS functions
by Tim Wawrzynczak (Code Review) 29 Mar '22

29 Mar '22

Attention is currently required from: Subrata Banik, John Zhao, Paul Menzel, Eric Lai, Angel Pons, Patrick Rudolph, EricR Lai. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62723 ) Change subject: soc/intel/common: Abstract the common TCSS functions ...................................................................... Patch Set 13: (1 comment) File src/soc/intel/common/block/include/intelblocks/cfg.h: https://review.coreboot.org/c/coreboot/+/62723/comment/12890039_3b69ca31 PS13, Line 30: struct soc_tcss_ops tcss_ops; > Probing the static.c and it shows elements assigned in the platform config struct. […] You could then add `register "common_soc_config.tcss_ops" = "{.valid_tbt_auth = intel_ht_supported}"` or something similar, for example, which is nonsense. I think the better place would be to create a new tcss.c file in tigerlake/ and alderlake/ directories; for now it can only contain ``` const struct soc_tcss_ops tcss_ops = { .configure_aux_bias_pads = tcss_configure_aux_bias_pads_regbar. .valid_tbt_auth = tcss_valid_tbt_auth, }; ``` and then the common/blocks/tcss.h can include ``` extern const struct soc_tcss_ops tcss_ops; ``` and then fsp_params.c probably doesn't need to pass the structures into the tcss_configure() function anymore; the `tcss_ops` struct could be used directly in common/block/tcss.c WDYT? -- To view, visit https://review.coreboot.org/c/coreboot/+/62723 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3302aabfb5f540c41da6359f11376b4202c6310b Gerrit-Change-Number: 62723 Gerrit-PatchSet: 13 Gerrit-Owner: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: John Zhao <john.zhao(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Tue, 29 Mar 2022 19:23:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: John Zhao <john.zhao(a)intel.com> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: gpio: Provide minor fixes to the table
by Subrata Banik (Code Review) 29 Mar '22

29 Mar '22

Attention is currently required from: Michael Niewöhner, Eric Lai. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63177 ) Change subject: Documentation: gpio: Provide minor fixes to the table ...................................................................... Patch Set 2: (1 comment) File Documentation/getting_started/gpio.md: https://review.coreboot.org/c/coreboot/+/63177/comment/5106bb58_e4969fdf PS1, Line 212: NA > I don't know if NA is common, n/a is, though Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/63177 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifd8265b92b5ef0dcabb754371591477ca19c39be Gerrit-Change-Number: 63177 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Tue, 29 Mar 2022 18:59:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: gpio: Update table as per coreboot guidelines
by Subrata Banik (Code Review) 29 Mar '22

29 Mar '22

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63126 ) Change subject: Documentation: gpio: Update table as per coreboot guidelines ...................................................................... Patch Set 4: (1 comment) File Documentation/getting_started/gpio.md: https://review.coreboot.org/c/coreboot/+/63126/comment/74266290_da70648d PS4, Line 179: | > I will fix it again Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/63126 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic4f27f46a9d219098612d8b7747ae26116506fce Gerrit-Change-Number: 63126 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Subrata Banik <subi.banik(a)gmail.com> Gerrit-Comment-Date: Tue, 29 Mar 2022 18:59:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022