coreboot-gerrit February 2022

coreboot-gerrit@coreboot.org

1 participants
7066 discussions

Change in coreboot[master]: soc/intel/xeon_sp/acpi.c: Remove unuseful 'return' in void function
by Felix Held (Code Review) 01 Feb '22

01 Feb '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/61486 ) Change subject: soc/intel/xeon_sp/acpi.c: Remove unuseful 'return' in void function ...................................................................... soc/intel/xeon_sp/acpi.c: Remove unuseful 'return' in void function Change-Id: Ib964939468ebb8cd0a537d514060ee5b8b13e320 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/61486 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin Roth <martinroth(a)google.com> --- M src/soc/intel/xeon_sp/acpi.c 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved diff --git a/src/soc/intel/xeon_sp/acpi.c b/src/soc/intel/xeon_sp/acpi.c index de9db88..0e7f6a5 100644 --- a/src/soc/intel/xeon_sp/acpi.c +++ b/src/soc/intel/xeon_sp/acpi.c @@ -93,7 +93,6 @@ printk(BIOS_DEBUG, "Adding MADT IOAPIC for socket: %d, stack: %d, ioapic_id: 0x%x, " "ioapic_base: 0x%x, gsi_base: 0x%x\n", socket, stack, ioapic_id, ioapic_base, gsi_base); - return; } const struct madt_ioapic_info *soc_get_ioapic_info(size_t *entries) -- To view, visit https://review.coreboot.org/c/coreboot/+/61486 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib964939468ebb8cd0a537d514060ee5b8b13e320 Gerrit-Change-Number: 61486 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: sb/amd/cimx/sb800/fan.c: Remove unuseful 'return' in void function
by Felix Held (Code Review) 01 Feb '22

01 Feb '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/61485 ) Change subject: sb/amd/cimx/sb800/fan.c: Remove unuseful 'return' in void function ...................................................................... sb/amd/cimx/sb800/fan.c: Remove unuseful 'return' in void function Change-Id: I458ff53bb9ae3a6c1003ee857b61fb350152cc86 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/61485 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin Roth <martinroth(a)google.com> --- M src/southbridge/amd/cimx/sb800/fan.c 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved diff --git a/src/southbridge/amd/cimx/sb800/fan.c b/src/southbridge/amd/cimx/sb800/fan.c index bbba3fa..f5e0a48 100644 --- a/src/southbridge/amd/cimx/sb800/fan.c +++ b/src/southbridge/amd/cimx/sb800/fan.c @@ -280,6 +280,4 @@ sb_config.StdHeader.Func = SB_EC_FANCONTROL; AmdSbDispatcher(&sb_config); - - return; } -- To view, visit https://review.coreboot.org/c/coreboot/+/61485 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I458ff53bb9ae3a6c1003ee857b61fb350152cc86 Gerrit-Change-Number: 61485 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: drivers/spi/spiconsole.c: Remove unuseful 'return' in void function
by Felix Held (Code Review) 01 Feb '22

01 Feb '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/61484 ) Change subject: drivers/spi/spiconsole.c: Remove unuseful 'return' in void function ...................................................................... drivers/spi/spiconsole.c: Remove unuseful 'return' in void function Change-Id: Ie5c83f16146517d0aa37cd1975de725f57323094 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/61484 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin Roth <martinroth(a)google.com> --- M src/drivers/spi/spiconsole.c 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved diff --git a/src/drivers/spi/spiconsole.c b/src/drivers/spi/spiconsole.c index 99c6aac..1fe83f6 100644 --- a/src/drivers/spi/spiconsole.c +++ b/src/drivers/spi/spiconsole.c @@ -9,7 +9,6 @@ void spiconsole_init(void) { spi_init(); spi_setup_slave(0, 0, &slave); - return; } /* @@ -49,6 +48,4 @@ msg.header.msg_length = 0; } - - return; } -- To view, visit https://review.coreboot.org/c/coreboot/+/61484 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie5c83f16146517d0aa37cd1975de725f57323094 Gerrit-Change-Number: 61484 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: ec/quanta/ene_kb3940q/ec.c: Remove unuseful 'return' in void function
by Felix Held (Code Review) 01 Feb '22

01 Feb '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/61483 ) Change subject: ec/quanta/ene_kb3940q/ec.c: Remove unuseful 'return' in void function ...................................................................... ec/quanta/ene_kb3940q/ec.c: Remove unuseful 'return' in void function Change-Id: Ifb5f848912fca4e86b6eab16a74733571a4ba26d Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/61483 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin Roth <martinroth(a)google.com> --- M src/ec/quanta/ene_kb3940q/ec.c 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved diff --git a/src/ec/quanta/ene_kb3940q/ec.c b/src/ec/quanta/ene_kb3940q/ec.c index c7b9348..4b4f532 100644 --- a/src/ec/quanta/ene_kb3940q/ec.c +++ b/src/ec/quanta/ene_kb3940q/ec.c @@ -103,7 +103,6 @@ ec_write_cmd(EC_CMD_WRITE_RAM); ec_write_ib(addr); ec_write_ib(data); - return; } static void ene_kb3940q_log_events(void) -- To view, visit https://review.coreboot.org/c/coreboot/+/61483 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifb5f848912fca4e86b6eab16a74733571a4ba26d Gerrit-Change-Number: 61483 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: drivers/net/ne2k.c: Remove unuseful 'return' in void function
by Felix Held (Code Review) 01 Feb '22

01 Feb '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/61482 ) Change subject: drivers/net/ne2k.c: Remove unuseful 'return' in void function ...................................................................... drivers/net/ne2k.c: Remove unuseful 'return' in void function Change-Id: I2313dc209eb9035f1026a1f37ef8146c57c60986 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/61482 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin Roth <martinroth(a)google.com> --- M src/drivers/net/ne2k.c 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved diff --git a/src/drivers/net/ne2k.c b/src/drivers/net/ne2k.c index 635315b..83d4ccf 100644 --- a/src/drivers/net/ne2k.c +++ b/src/drivers/net/ne2k.c @@ -307,7 +307,6 @@ res->limit = res->base + res->size - 1; res->flags = IORESOURCE_IO | IORESOURCE_FIXED | IORESOURCE_STORED | IORESOURCE_ASSIGNED; - return; } static struct device_operations ne2k_ops = { -- To view, visit https://review.coreboot.org/c/coreboot/+/61482 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2313dc209eb9035f1026a1f37ef8146c57c60986 Gerrit-Change-Number: 61482 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: soc/samsung/exynos5250: Add missing 'void' in function definition
by Felix Held (Code Review) 01 Feb '22

01 Feb '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/61481 ) Change subject: soc/samsung/exynos5250: Add missing 'void' in function definition ...................................................................... soc/samsung/exynos5250: Add missing 'void' in function definition Change-Id: I59203253ba9e66e4db3ff5dcae347b68d1203f21 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/61481 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin Roth <martinroth(a)google.com> --- M src/soc/samsung/exynos5250/usb.c 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved diff --git a/src/soc/samsung/exynos5250/usb.c b/src/soc/samsung/exynos5250/usb.c index cadc71e..27abe19 100644 --- a/src/soc/samsung/exynos5250/usb.c +++ b/src/soc/samsung/exynos5250/usb.c @@ -16,7 +16,7 @@ setbits32(&dwc3->usb2phycfg, 0x1 << 31); /* PHY soft reset */ } -void reset_usb_drd_dwc3() +void reset_usb_drd_dwc3(void) { printk(BIOS_DEBUG, "Starting DWC3 reset for USB DRD\n"); reset_dwc3(exynos_usb_drd_dwc3); @@ -52,7 +52,7 @@ 0x1 << 12); /* port capability HOST */ } -void setup_usb_drd_dwc3() +void setup_usb_drd_dwc3(void) { setup_dwc3(exynos_usb_drd_dwc3); printk(BIOS_DEBUG, "DWC3 setup for USB DRD finished\n"); @@ -109,7 +109,7 @@ clrbits32(&phy->clkrst, 0x1 << 1); /* deassert port reset */ } -void setup_usb_drd_phy() +void setup_usb_drd_phy(void) { printk(BIOS_DEBUG, "Powering up USB DRD PHY\n"); setbits32(&exynos_power->usb_drd_phy_ctrl, POWER_USB_PHY_CTRL_EN); -- To view, visit https://review.coreboot.org/c/coreboot/+/61481 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I59203253ba9e66e4db3ff5dcae347b68d1203f21 Gerrit-Change-Number: 61481 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: drivers/i2c/designware/dw_i2c: use cb_err for dw_i2c_gen_speed_config
by Raul Rangel (Code Review) 01 Feb '22

01 Feb '22

Attention is currently required from: Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61512 ) Change subject: drivers/i2c/designware/dw_i2c: use cb_err for dw_i2c_gen_speed_config ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/61512 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8d96e5f72a8b3552ab39c1d298bafcc224bf9e55 Gerrit-Change-Number: 61512 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 01 Feb 2022 18:01:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common: Define enum cpu_type type for core types
by Sridhar Siricilla (Code Review) 01 Feb '22

01 Feb '22

Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Paul Menzel, Subrata Banik, Patrick Rudolph. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61459 ) Change subject: soc/intel/common: Define enum cpu_type type for core types ...................................................................... Patch Set 3: (2 comments) File src/soc/intel/common/block/acpi/cpu_hybrid.c: https://review.coreboot.org/c/coreboot/+/61459/comment/6ca5f62e_403d47ae PS3, Line 14: cpu_type > Hm, there is already an […] correct, how about enum cpu_perf_eff_type? https://review.coreboot.org/c/coreboot/+/61459/comment/65e3a398_028c79d2 PS3, Line 94: if (global_cpu_type[core_id]) > `if (global_cpu_type[core_id] == CPU_TYPE_BIG)` Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/61459 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I740984a437da9d0518652f43180faf9b6ed4255e Gerrit-Change-Number: 61459 Gerrit-PatchSet: 3 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 01 Feb 2022 18:01:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/i2c/designware/dw_i2c: use cb_err for dw_i2c_gen_speed_config
by build bot (Jenkins) (Code Review) 01 Feb '22

01 Feb '22

Attention is currently required from: Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61512 ) Change subject: drivers/i2c/designware/dw_i2c: use cb_err for dw_i2c_gen_speed_config ...................................................................... Patch Set 2: (1 comment) File src/drivers/i2c/designware/dw_i2c.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139687): https://review.coreboot.org/c/coreboot/+/61512/comment/0a1c968e_c5d27ecb PS2, Line 832: if (dw_i2c_gen_speed_config(dw_i2c_addr, speed, bcfg, &sgen) == CB_SUCCESS) { braces {} are not necessary for single statement blocks -- To view, visit https://review.coreboot.org/c/coreboot/+/61512 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8d96e5f72a8b3552ab39c1d298bafcc224bf9e55 Gerrit-Change-Number: 61512 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 01 Feb 2022 17:58:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/i2c/designware/dw_i2c: use cb_err for dw_i2c_gen_speed_config
by Felix Held (Code Review) 01 Feb '22

01 Feb '22

Attention is currently required from: Felix Held. Hello build bot (Jenkins), Raul Rangel, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/61512 to look at the new patch set (#2). Change subject: drivers/i2c/designware/dw_i2c: use cb_err for dw_i2c_gen_speed_config ...................................................................... drivers/i2c/designware/dw_i2c: use cb_err for dw_i2c_gen_speed_config Using enum cb_err as return type instead of int improves the readability of the code. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: I8d96e5f72a8b3552ab39c1d298bafcc224bf9e55 --- M src/drivers/i2c/designware/dw_i2c.c M src/drivers/i2c/designware/dw_i2c.h 2 files changed, 6 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/61512/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/61512 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8d96e5f72a8b3552ab39c1d298bafcc224bf9e55 Gerrit-Change-Number: 61512 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2022