coreboot-gerrit February 2022

coreboot-gerrit@coreboot.org

1 participants
7066 discussions

Change in coreboot[master]: soc/intel/common: Define enum cpu_perf_eff_type type for core types
by Sridhar Siricilla (Code Review) 01 Feb '22

01 Feb '22

Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Paul Menzel, Subrata Banik, Patrick Rudolph. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61459 ) Change subject: soc/intel/common: Define enum cpu_perf_eff_type type for core types ...................................................................... Patch Set 4: (2 comments) File src/soc/intel/common/block/acpi/cpu_hybrid.c: https://review.coreboot.org/c/coreboot/+/61459/comment/79deca7a_68f53e83 PS3, Line 14: cpu_type > correct, how about enum cpu_perf_eff_type? Ack https://review.coreboot.org/c/coreboot/+/61459/comment/6d96528a_a272c42a PS3, Line 94: if (global_cpu_type[core_id]) > Ack Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/61459 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I740984a437da9d0518652f43180faf9b6ed4255e Gerrit-Change-Number: 61459 Gerrit-PatchSet: 4 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 01 Feb 2022 18:33:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common: Define enum cpu_perf_eff_type type for core types
by Sridhar Siricilla (Code Review) 01 Feb '22

01 Feb '22

Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Paul Menzel, Subrata Banik, Patrick Rudolph. Hello Maulik V Vaghela, Paul Menzel, Subrata Banik, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/61459 to look at the new patch set (#4). Change subject: soc/intel/common: Define enum cpu_perf_eff_type type for core types ...................................................................... soc/intel/common: Define enum cpu_perf_eff_type type for core types The patch defines enum values for small and big cores and uses them to indicate the big or small core. TEST=Verify the build for Brya Signed-off-by: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Change-Id: I740984a437da9d0518652f43180faf9b6ed4255e --- M src/soc/intel/common/block/acpi/cpu_hybrid.c 1 file changed, 7 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/61459/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/61459 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I740984a437da9d0518652f43180faf9b6ed4255e Gerrit-Change-Number: 61459 Gerrit-PatchSet: 4 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Revert "util/crossgcc: Update gcc to 11.2"
by HAOUAS Elyes (Code Review) 01 Feb '22

01 Feb '22

Attention is currently required from: Nico Huber, Branden Waldner, Idwer Vollering, Paul Menzel, Jacob Garber, Arthur Heymans, Mike Banon, Werner Zeh, Iru Cai, Harshit Sharma. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59636 ) Change subject: Revert "util/crossgcc: Update gcc to 11.2" ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: if you have time, can you give a try to gcc-12? https://review.coreboot.org/c/coreboot/+/61533 -- To view, visit https://review.coreboot.org/c/coreboot/+/59636 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I09a789f9ccb284ac7cad32b12bbf60ecb82efb44 Gerrit-Change-Number: 59636 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Branden Waldner <scruffy99(a)gmail.com> Gerrit-Reviewer: Harshit Sharma <harshitsharmajs(a)gmail.com> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-CC: Michal Zygowski <miczyg94(a)gmail.com> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Branden Waldner <scruffy99(a)gmail.com> Gerrit-Attention: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Attention: Harshit Sharma <harshitsharmajs(a)gmail.com> Gerrit-Comment-Date: Tue, 01 Feb 2022 18:33:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/fsp2_0/include/fsp: fix fsp_header
by Tim Wawrzynczak (Code Review) 01 Feb '22

01 Feb '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Subrata Banik, Marshall Dawson, Paul Menzel, Name of user not set #1003801, Andrey Petrov, Julian Schroeder, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58869 ) Change subject: drivers/intel/fsp2_0/include/fsp: fix fsp_header ...................................................................... Patch Set 9: Code-Review+2 (1 comment) Patchset: PS9: This still works on FSP 2.2 boards (i.e., google/brya0, Intel Alder Lake, multi-phase SI initialization still works), and also FSP 2.0 (i.e. google/dratini, Intel Comet Lake) -- To view, visit https://review.coreboot.org/c/coreboot/+/58869 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibf50f16b5e9793d946a95970fcdabc4c07289646 Gerrit-Change-Number: 58869 Gerrit-PatchSet: 9 Gerrit-Owner: Name of user not set #1003801 Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Julian Schroeder <julianmarcusschroeder(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Name of user not set #1003801 Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Julian Schroeder <julianmarcusschroeder(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 01 Feb 2022 18:32:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [only for test] test gcc-12 snapshot
by HAOUAS Elyes (Code Review) 01 Feb '22

01 Feb '22

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/61533 ) Change subject: [only for test] test gcc-12 snapshot ...................................................................... [only for test] test gcc-12 snapshot Change-Id: I2545f4119a20eec6482fbdf8993eb842af96a0a7 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M Makefile.inc M util/crossgcc/buildgcc D util/crossgcc/patches/gcc-11.2.0_gnat.patch R util/crossgcc/patches/gcc-12-20220130_ada-musl_workaround.patch R util/crossgcc/patches/gcc-12-20220130_asan_shadow_offset_callback.patch A util/crossgcc/patches/gcc-12-20220130_gnat.patch R util/crossgcc/patches/gcc-12-20220130_libcpp.patch R util/crossgcc/patches/gcc-12-20220130_libgcc.patch D util/crossgcc/sum/gcc-11.2.0.tar.xz.cksum A util/crossgcc/sum/gcc-12-20220130.tar.xz.cksum 10 files changed, 27 insertions(+), 27 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/61533/1 diff --git a/Makefile.inc b/Makefile.inc index f584189..4fe13b5 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -432,7 +432,7 @@ CFLAGS_common += -nostdlib -Wall -Wundef -Wstrict-prototypes -Wmissing-prototypes CFLAGS_common += -Wwrite-strings -Wredundant-decls -Wno-trigraphs -Wimplicit-fallthrough CFLAGS_common += -Wshadow -Wdate-time -Wtype-limits -Wvla -CFLAGS_common += -Wdangling-else +CFLAGS_common += -Wdangling-else -Wno-array-bounds -Wno-array-compare CFLAGS_common += -fno-common -ffreestanding -fno-builtin -fomit-frame-pointer CFLAGS_common += -fstrict-aliasing -ffunction-sections -fdata-sections -fno-pie ifeq ($(CONFIG_COMPILER_GCC),y) diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index b0c7707..017285e 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -35,7 +35,7 @@ GMP_VERSION=6.2.1 MPFR_VERSION=4.1.0 MPC_VERSION=1.2.1 -GCC_VERSION=11.2.0 +GCC_VERSION=12-20220130 BINUTILS_VERSION=2.37 IASL_VERSION=20211217 # CLANG version number @@ -50,7 +50,7 @@ GMP_ARCHIVE="https://ftpmirror.gnu.org/gmp/gmp-${GMP_VERSION}.tar.xz" MPFR_ARCHIVE="https://ftpmirror.gnu.org/mpfr/mpfr-${MPFR_VERSION}.tar.xz" MPC_ARCHIVE="https://ftpmirror.gnu.org/mpc/mpc-${MPC_VERSION}.tar.gz" -GCC_ARCHIVE="https://ftpmirror.gnu.org/gcc/gcc-${GCC_VERSION}/gcc-${GCC_VERSION}.tar.xz" +GCC_ARCHIVE="https://gcc.gnu.org/pub/gcc/snapshots/LATEST-12/gcc-${GCC_VERSION}.tar.xz" BINUTILS_ARCHIVE="https://ftpmirror.gnu.org/binutils/binutils-${BINUTILS_VERSION}.tar.xz" IASL_ARCHIVE="https://acpica.org/sites/acpica/files/acpica-unix2-${IASL_VERSION}.tar.gz" # CLANG toolchain archive locations diff --git a/util/crossgcc/patches/gcc-11.2.0_gnat.patch b/util/crossgcc/patches/gcc-11.2.0_gnat.patch deleted file mode 100644 index 2d7cece..0000000 --- a/util/crossgcc/patches/gcc-11.2.0_gnat.patch +++ /dev/null @@ -1,11 +0,0 @@ ---- gcc-6.1.0/gcc/ada/gcc-interface/Make-lang.in.bak 2015-08-24 16:23:25.004493665 +0200 -+++ gcc-6.1.0/gcc/ada/gcc-interface/Make-lang.in 2015-08-24 17:53:52.496636113 +0200 -@@ -45,7 +45,7 @@ - - - # Extra flags to pass to recursive makes. --COMMON_ADAFLAGS= -gnatpg -+COMMON_ADAFLAGS= -gnatpg -gnatwGUR - ifeq ($(TREECHECKING),) - CHECKING_ADAFLAGS= - else diff --git a/util/crossgcc/patches/gcc-11.2.0_ada-musl_workaround.patch b/util/crossgcc/patches/gcc-12-20220130_ada-musl_workaround.patch similarity index 100% rename from util/crossgcc/patches/gcc-11.2.0_ada-musl_workaround.patch rename to util/crossgcc/patches/gcc-12-20220130_ada-musl_workaround.patch diff --git a/util/crossgcc/patches/gcc-11.2.0_asan_shadow_offset_callback.patch b/util/crossgcc/patches/gcc-12-20220130_asan_shadow_offset_callback.patch similarity index 95% rename from util/crossgcc/patches/gcc-11.2.0_asan_shadow_offset_callback.patch rename to util/crossgcc/patches/gcc-12-20220130_asan_shadow_offset_callback.patch index 25963b3..126c0d3 100644 --- a/util/crossgcc/patches/gcc-11.2.0_asan_shadow_offset_callback.patch +++ b/util/crossgcc/patches/gcc-12-20220130_asan_shadow_offset_callback.patch @@ -33,10 +33,10 @@ Signed-off-by: Harshit Sharma <harshitsharmajs(a)gmail.com> Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> -diff --git a/gcc/asan.c b/gcc/asan.c +diff --git a/gcc/asan.cc b/gcc/asan.cc index 235e21947..713bf994d 100644 ---- a/gcc/asan.c -+++ b/gcc/asan.c +--- a/gcc/asan.cc ++++ b/gcc/asan.cc @@ -1389,13 +1389,28 @@ asan_emit_stack_protection (rtx base, rtx pbase, unsigned int alignb, TREE_ASM_WRITTEN (decl) = 1; TREE_ASM_WRITTEN (id) = 1; @@ -73,8 +73,8 @@ gcc_assert (asan_shadow_set != -1 && (ASAN_RED_ZONE_SIZE >> ASAN_SHADOW_SHIFT) == 4); shadow_mem = gen_rtx_MEM (SImode, shadow_base); ---- gcc-11.1.0/gcc/params.opt~ 2021-05-11 09:02:51.897508677 +0200 -+++ gcc-11.1.0/gcc/params.opt 2021-05-11 09:10:43.692610696 +0200 +--- gcc-12/gcc/params.opt~ 2021-05-11 09:02:51.897508677 +0200 ++++ gcc-12/gcc/params.opt 2021-05-11 09:10:43.692610696 +0200 @@ -50,6 +50,10 @@ Common Joined UInteger Var(param_asan_instrumentation_with_call_threshold) Init(7000) Param Optimization Use callbacks instead of inline code if number of accesses in function becomes greater or equal to this number. diff --git a/util/crossgcc/patches/gcc-12-20220130_gnat.patch b/util/crossgcc/patches/gcc-12-20220130_gnat.patch new file mode 100644 index 0000000..b1db062 --- /dev/null +++ b/util/crossgcc/patches/gcc-12-20220130_gnat.patch @@ -0,0 +1,11 @@ +--- gcc-12/gcc/ada/gcc-interface/Make-lang.in.bak 2015-08-24 16:23:25.004493665 +0200 ++++ gcc-12/gcc/ada/gcc-interface/Make-lang.in 2015-08-24 17:53:52.496636113 +0200 +@@ -45,7 +45,7 @@ + + + # Extra flags to pass to recursive makes. +-COMMON_ADAFLAGS= -gnatpg ++COMMON_ADAFLAGS= -gnatpg -gnatwGUR + ifeq ($(TREECHECKING),) + CHECKING_ADAFLAGS= + else diff --git a/util/crossgcc/patches/gcc-11.2.0_libcpp.patch b/util/crossgcc/patches/gcc-12-20220130_libcpp.patch similarity index 85% rename from util/crossgcc/patches/gcc-11.2.0_libcpp.patch rename to util/crossgcc/patches/gcc-12-20220130_libcpp.patch index df28c01..7fb1fab 100644 --- a/util/crossgcc/patches/gcc-11.2.0_libcpp.patch +++ b/util/crossgcc/patches/gcc-12-20220130_libcpp.patch @@ -1,8 +1,8 @@ GCC with `-Wformat-security -Werror=format-security` hardening options enabled by default rejects some codes in libcpp. This patch fixes them. ---- gcc-8.3.0/libcpp/expr.c.bak 2020-09-11 15:44:45.770000000 +0900 -+++ gcc-8.3.0/libcpp/expr.c 2020-09-11 15:46:22.370000000 +0900 +--- gcc-12/libcpp/expr.cc.bak 2020-09-11 15:44:45.770000000 +0900 ++++ gcc-12/libcpp/expr.cc 2020-09-11 15:46:22.370000000 +0900 @@ -794,10 +794,10 @@ if (CPP_OPTION (pfile, c99)) @@ -16,8 +16,8 @@ } result |= CPP_N_INTEGER; ---- gcc-8.3.0/libcpp/macro.c.bak 2020-09-11 16:01:42.550000000 +0900 -+++ gcc-8.3.0/libcpp/macro.c 2020-09-11 16:03:47.850000000 +0900 +--- gcc-12/libcpp/macro.cc.bak 2020-09-11 16:01:42.550000000 +0900 ++++ gcc-12/libcpp/macro.cc 2020-09-11 16:03:47.850000000 +0900 @@ -160,7 +160,7 @@ if (m_state == 2 && token->type == CPP_PASTE) { diff --git a/util/crossgcc/patches/gcc-11.2.0_libgcc.patch b/util/crossgcc/patches/gcc-12-20220130_libgcc.patch similarity index 89% rename from util/crossgcc/patches/gcc-11.2.0_libgcc.patch rename to util/crossgcc/patches/gcc-12-20220130_libgcc.patch index 2f75c92..4ff391d 100644 --- a/util/crossgcc/patches/gcc-11.2.0_libgcc.patch +++ b/util/crossgcc/patches/gcc-12-20220130_libgcc.patch @@ -1,9 +1,9 @@ This enables building on Mac OS and FreeBSD by adding support to their variants of the sed utility. -diff -urN gcc-5.2.0.orig/libgcc/config/t-hardfp gcc-5.2.0/libgcc/config/t-hardfp ---- gcc-5.2.0.orig/libgcc/config/t-hardfp 2015-01-05 04:33:28.000000000 -0800 -+++ gcc-8.1.0/libgcc/config/t-hardfp 2016-04-06 12:04:51.000000000 -0700 +diff -urN gcc-12.orig/libgcc/config/t-hardfp gcc-12/libgcc/config/t-hardfp +--- gcc-12.orig/libgcc/config/t-hardfp 2015-01-05 04:33:28.000000000 -0800 ++++ gcc-12/libgcc/config/t-hardfp 2016-04-06 12:04:51.000000000 -0700 @@ -59,21 +59,52 @@ hardfp_func_list := $(filter-out $(hardfp_exclusions),$(hardfp_func_list)) diff --git a/util/crossgcc/sum/gcc-11.2.0.tar.xz.cksum b/util/crossgcc/sum/gcc-11.2.0.tar.xz.cksum deleted file mode 100644 index 071c352..0000000 --- a/util/crossgcc/sum/gcc-11.2.0.tar.xz.cksum +++ /dev/null @@ -1 +0,0 @@ -f902ccacecf8949978d6261e9f1d034cff73ffdb tarballs/gcc-11.2.0.tar.xz diff --git a/util/crossgcc/sum/gcc-12-20220130.tar.xz.cksum b/util/crossgcc/sum/gcc-12-20220130.tar.xz.cksum new file mode 100644 index 0000000..e809296 --- /dev/null +++ b/util/crossgcc/sum/gcc-12-20220130.tar.xz.cksum @@ -0,0 +1 @@ +4928208590010b85e665bffb3c42e9c59bdb3f5a tarballs/gcc-12-20220130.tar.xz -- To view, visit https://review.coreboot.org/c/coreboot/+/61533 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2545f4119a20eec6482fbdf8993eb842af96a0a7 Gerrit-Change-Number: 61533 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/samsung/exynos5420: Remove unuseful 'return' in void function
by Felix Held (Code Review) 01 Feb '22

01 Feb '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/61491 ) Change subject: soc/samsung/exynos5420: Remove unuseful 'return' in void function ...................................................................... soc/samsung/exynos5420: Remove unuseful 'return' in void function Change-Id: I6c093e8326733a079ab3c41dfd2c77fe1883a9d4 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/61491 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin Roth <martinroth(a)google.com> --- M src/soc/samsung/exynos5420/dp_lowlevel.c 1 file changed, 0 insertions(+), 16 deletions(-) Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved diff --git a/src/soc/samsung/exynos5420/dp_lowlevel.c b/src/soc/samsung/exynos5420/dp_lowlevel.c index b6d9e0b..6144544 100644 --- a/src/soc/samsung/exynos5420/dp_lowlevel.c +++ b/src/soc/samsung/exynos5420/dp_lowlevel.c @@ -49,8 +49,6 @@ reg |= VIDEO_EN_MASK; lwrite32(reg, &dp_regs->video_ctl1); - - return; } void exynos_dp_disable_video_bist(void) @@ -71,8 +69,6 @@ reg |= VIDEO_MUTE_MASK; lwrite32(reg, &dp_regs->video_ctl1); - - return; } static void exynos_dp_init_analog_param(void) @@ -174,8 +170,6 @@ exynos_dp_init_analog_param(); exynos_dp_init_interrupt(); - - return; } void exynos_dp_enable_sw_func(unsigned int enable) @@ -189,8 +183,6 @@ reg |= SW_FUNC_EN_N; lwrite32(reg, &dp_regs->func_en1); - - return; } unsigned int exynos_dp_set_analog_power_down(unsigned int block, u32 enable) @@ -336,8 +328,6 @@ reg = lread32(&dp_regs->sys_ctl3); reg &= ~(F_HPD | HPD_CTRL); lwrite32(reg, &dp_regs->sys_ctl3); - - return; } static inline void exynos_dp_reset_aux(void) @@ -348,8 +338,6 @@ reg = lread32(&dp_regs->func_en2); reg |= AUX_FUNC_EN_N; lwrite32(reg, &dp_regs->func_en2); - - return; } void exynos_dp_init_aux(void) @@ -375,8 +363,6 @@ reg = lread32(&dp_regs->func_en2); reg &= ~AUX_FUNC_EN_N; lwrite32(reg, &dp_regs->func_en2); - - return; } void exynos_dp_config_interrupt(void) @@ -398,8 +384,6 @@ reg = INT_STA_MASK; lwrite32(reg, &dp_regs->int_sta_mask); - - return; } unsigned int exynos_dp_get_plug_in_status(void) -- To view, visit https://review.coreboot.org/c/coreboot/+/61491 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6c093e8326733a079ab3c41dfd2c77fe1883a9d4 Gerrit-Change-Number: 61491 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: soc/nvidia/tegra124/sor.c: Remove unuseful 'return' in void function
by Felix Held (Code Review) 01 Feb '22

01 Feb '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/61490 ) Change subject: soc/nvidia/tegra124/sor.c: Remove unuseful 'return' in void function ...................................................................... soc/nvidia/tegra124/sor.c: Remove unuseful 'return' in void function Change-Id: I8539eb9028f3141dfbeb926a1e19e3ad94be3edf Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/61490 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin Roth <martinroth(a)google.com> --- M src/soc/nvidia/tegra124/sor.c 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved diff --git a/src/soc/nvidia/tegra124/sor.c b/src/soc/nvidia/tegra124/sor.c index 2cf16b0..9e56c68 100644 --- a/src/soc/nvidia/tegra124/sor.c +++ b/src/soc/nvidia/tegra124/sor.c @@ -581,8 +581,6 @@ DUMP_REG(NV_SOR_DP_SPARE(0)); DUMP_REG(NV_SOR_DP_SPARE(1)); DUMP_REG(NV_SOR_DP_TPG); - - return; } #endif -- To view, visit https://review.coreboot.org/c/coreboot/+/61490 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8539eb9028f3141dfbeb926a1e19e3ad94be3edf Gerrit-Change-Number: 61490 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: soc/nvidia/tegra210/sor.c: Remove unuseful 'return' in void function
by Felix Held (Code Review) 01 Feb '22

01 Feb '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/61489 ) Change subject: soc/nvidia/tegra210/sor.c: Remove unuseful 'return' in void function ...................................................................... soc/nvidia/tegra210/sor.c: Remove unuseful 'return' in void function Change-Id: Ifaaf8a240436758a83216037994493255935f158 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/61489 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin Roth <martinroth(a)google.com> --- M src/soc/nvidia/tegra210/sor.c 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved diff --git a/src/soc/nvidia/tegra210/sor.c b/src/soc/nvidia/tegra210/sor.c index 9b50d93..fe89d14 100644 --- a/src/soc/nvidia/tegra210/sor.c +++ b/src/soc/nvidia/tegra210/sor.c @@ -579,8 +579,6 @@ DUMP_REG(NV_SOR_DP_SPARE(0)); DUMP_REG(NV_SOR_DP_SPARE(1)); DUMP_REG(NV_SOR_DP_TPG); - - return; } #endif -- To view, visit https://review.coreboot.org/c/coreboot/+/61489 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifaaf8a240436758a83216037994493255935f158 Gerrit-Change-Number: 61489 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: soc/rockchip/rk3399/display.c: Remove unuseful 'return' in void function
by Felix Held (Code Review) 01 Feb '22

01 Feb '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/61488 ) Change subject: soc/rockchip/rk3399/display.c: Remove unuseful 'return' in void function ...................................................................... soc/rockchip/rk3399/display.c: Remove unuseful 'return' in void function Change-Id: I8b5537bb6d0cb934aadb0eba8ba4f51dd53026c2 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/61488 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin Roth <martinroth(a)google.com> --- M src/soc/rockchip/rk3399/display.c 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved diff --git a/src/soc/rockchip/rk3399/display.c b/src/soc/rockchip/rk3399/display.c index 1d263ef..c300726 100644 --- a/src/soc/rockchip/rk3399/display.c +++ b/src/soc/rockchip/rk3399/display.c @@ -162,6 +162,4 @@ } mainboard_power_on_backlight(); fb_new_framebuffer_info_from_edid(&edid, (uintptr_t)0); - - return; } -- To view, visit https://review.coreboot.org/c/coreboot/+/61488 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b5537bb6d0cb934aadb0eba8ba4f51dd53026c2 Gerrit-Change-Number: 61488 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: soc/qualcomm/ipq40xx/spi.c: Remove unuseful 'return' in void function
by Felix Held (Code Review) 01 Feb '22

01 Feb '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/61487 ) Change subject: soc/qualcomm/ipq40xx/spi.c: Remove unuseful 'return' in void function ...................................................................... soc/qualcomm/ipq40xx/spi.c: Remove unuseful 'return' in void function Change-Id: I0ca7cbbf6c4884b58b4ec8a8e3cbc77f118a42f2 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/61487 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin Roth <martinroth(a)google.com> --- M src/soc/qualcomm/ipq40xx/spi.c 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved diff --git a/src/soc/qualcomm/ipq40xx/spi.c b/src/soc/qualcomm/ipq40xx/spi.c index 31677e4..0893dfc 100644 --- a/src/soc/qualcomm/ipq40xx/spi.c +++ b/src/soc/qualcomm/ipq40xx/spi.c @@ -298,7 +298,6 @@ clrsetbits32(ds->regs->io_control, SPI_IO_CTRL_FORCE_CS_MSK, SPI_IO_CTRL_FORCE_CS_DIS); - return; } /* @@ -372,7 +371,6 @@ QUP_CONF_INPUT_MSK, QUP_CONF_NO_INPUT); } - return; } /* -- To view, visit https://review.coreboot.org/c/coreboot/+/61487 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0ca7cbbf6c4884b58b4ec8a8e3cbc77f118a42f2 Gerrit-Change-Number: 61487 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2022