coreboot-gerrit February 2022

coreboot-gerrit@coreboot.org

1 participants
7066 discussions

Change in coreboot[master]: drivers/pcie/generic: Add new pcie generic chip driver
by Tim Wawrzynczak (Code Review) 04 Feb '22

04 Feb '22

Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Angel Pons. Hello build bot (Jenkins), Subrata Banik, Angel Pons, Nick Vaccaro, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/61627 to look at the new patch set (#3). Change subject: drivers/pcie/generic: Add new pcie generic chip driver ...................................................................... drivers/pcie/generic: Add new pcie generic chip driver This new chip driver will be used for attaching ACPI properties to PCIe endpoints. The first property it supports is "UntrustedDevice." This property can be used by a payload to, e.g., restrict the device to its own IOMMU domain for security purposes. The new property is added by adding a _DSD and an integer property set to 1. Example of the property from google/brya0: Scope (\_SB.PCI0.RP01) { Device (DEV0) { Name (_ADR, 0x0000000000000000) // _ADR: Address Name (_DSD, Package (0x02) // _DSD: Device-Specific Data { ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301") /* Device Properties for _DSD */, Package (0x01) { Package (0x02) { "UntrustedDevice", One } } }) } } BUG=b:215424986 TEST=boot patch train on google/brya0, dump SSDT, see above for snippet Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Change-Id: I53986614dcbf4d10a6bb4010e131f5ff5a9d25cf --- A src/drivers/pcie/generic/Kconfig A src/drivers/pcie/generic/Makefile.inc A src/drivers/pcie/generic/chip.h A src/drivers/pcie/generic/generic.c 4 files changed, 87 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/61627/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/61627 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I53986614dcbf4d10a6bb4010e131f5ff5a9d25cf Gerrit-Change-Number: 61627 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: drivers/wwan/fm: Add Fibocom 5G WWAN ACPI support
by Tim Wawrzynczak (Code Review) 04 Feb '22

04 Feb '22

Attention is currently required from: Bora Guvendik, Anil Kumar K, Cliff Huang, Subrata Banik, Paul Menzel, Thejaswani Putta. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61354 ) Change subject: drivers/wwan/fm: Add Fibocom 5G WWAN ACPI support ...................................................................... Patch Set 11: (1 comment) Patchset: PS11: Thanks Cliff! That was a gnarly bit of ACPI! -- To view, visit https://review.coreboot.org/c/coreboot/+/61354 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e0b9fd405f6cfb1e216ea27558bb9299a09e566 Gerrit-Change-Number: 61354 Gerrit-PatchSet: 11 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Thejaswani Putta <thejaswani.putta(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thejaswani Putta <thejaswani.putta(a)intel.com> Gerrit-Comment-Date: Fri, 04 Feb 2022 23:44:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/wwan/fm: Add Fibocom 5G WWAN ACPI support
by Tim Wawrzynczak (Code Review) 04 Feb '22

04 Feb '22

Attention is currently required from: Bora Guvendik, Anil Kumar K, Cliff Huang, Subrata Banik, Paul Menzel, Thejaswani Putta. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61354 ) Change subject: drivers/wwan/fm: Add Fibocom 5G WWAN ACPI support ...................................................................... Patch Set 11: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/61354 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e0b9fd405f6cfb1e216ea27558bb9299a09e566 Gerrit-Change-Number: 61354 Gerrit-PatchSet: 11 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Thejaswani Putta <thejaswani.putta(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thejaswani Putta <thejaswani.putta(a)intel.com> Gerrit-Comment-Date: Fri, 04 Feb 2022 23:44:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common/block/pcie/rtd3: Add optional _OFF and _ON skip control
by Tim Wawrzynczak (Code Review) 04 Feb '22

04 Feb '22

Attention is currently required from: Bora Guvendik, Anil Kumar K, Cliff Huang, Subrata Banik, Paul Menzel, Thejaswani Putta, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61353 ) Change subject: soc/intel/common/block/pcie/rtd3: Add optional _OFF and _ON skip control ...................................................................... Patch Set 8: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/61353/comment/48c97297_58826c0b PS7, Line 69: metheds > `methods` Done -- To view, visit https://review.coreboot.org/c/coreboot/+/61353 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic32d151d65107bfc220258c383a575e40a496b6f Gerrit-Change-Number: 61353 Gerrit-PatchSet: 8 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Thejaswani Putta <thejaswani.putta(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thejaswani Putta <thejaswani.putta(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Fri, 04 Feb 2022 23:43:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common/block/pcie/rtd3: Add PM methods to the device.
by Tim Wawrzynczak (Code Review) 04 Feb '22

04 Feb '22

Attention is currently required from: Lance Zhao, Anil Kumar K, Cliff Huang, Subrata Banik, Paul Menzel, Thejaswani Putta, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61352 ) Change subject: soc/intel/common/block/pcie/rtd3: Add PM methods to the device. ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/61352 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79de76f26c8424b036cb7d2719df68937599ca2f Gerrit-Change-Number: 61352 Gerrit-PatchSet: 7 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Thejaswani Putta <thejaswani.putta(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Lance Zhao Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Lance Zhao Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thejaswani Putta <thejaswani.putta(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Fri, 04 Feb 2022 23:43:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/wwan/fm: Add Fibocom 5G WWAN ACPI support
by Cliff Huang (Code Review) 04 Feb '22

04 Feb '22

Attention is currently required from: Bora Guvendik, Anil Kumar K, Subrata Banik, Tim Wawrzynczak, Paul Menzel, Thejaswani Putta. Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61354 ) Change subject: drivers/wwan/fm: Add Fibocom 5G WWAN ACPI support ...................................................................... Patch Set 10: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/61354/comment/6ff29509_1601e7ba PS10, Line 11: > will add: […] Done File src/drivers/wwan/fm/Kconfig: https://review.coreboot.org/c/coreboot/+/61354/comment/50b37ef5_f91f853a PS10, Line 9: > will do. Done https://review.coreboot.org/c/coreboot/+/61354/comment/9e4c4405_f07e1f0c PS10, Line 9: > will do. Done File src/drivers/wwan/fm/acpi_fm350gl.c: https://review.coreboot.org/c/coreboot/+/61354/comment/627ae01e_83c4da7e PS10, Line 103: : /* : Generate second half reset flow (SHRF) method. : */ > will fix. Done. Also do the same changes for other functions. -- To view, visit https://review.coreboot.org/c/coreboot/+/61354 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e0b9fd405f6cfb1e216ea27558bb9299a09e566 Gerrit-Change-Number: 61354 Gerrit-PatchSet: 10 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Thejaswani Putta <thejaswani.putta(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thejaswani Putta <thejaswani.putta(a)intel.com> Gerrit-Comment-Date: Fri, 04 Feb 2022 23:37:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Cliff Huang <cliff.huang(a)intel.com> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/wwan/fm: Add Fibocom 5G WWAN ACPI support
by Cliff Huang (Code Review) 04 Feb '22

04 Feb '22

Attention is currently required from: Bora Guvendik, Anil Kumar K, Subrata Banik, Tim Wawrzynczak, Paul Menzel, Thejaswani Putta. Hello Bora Guvendik, build bot (Jenkins), Anil Kumar K, Subrata Banik, Selma Bensaid, Tim Wawrzynczak, Thejaswani Putta, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/61354 to look at the new patch set (#11). Change subject: drivers/wwan/fm: Add Fibocom 5G WWAN ACPI support ...................................................................... drivers/wwan/fm: Add Fibocom 5G WWAN ACPI support Support PXSX._RST and PXSX.MRST._RST for warm and cold reset. PXSX._RST is invoked on driver removal. build dependency: soc/intel/common/block/pcie/rtd3 This driver will use the rtd3 methods for the same parent in the device tree. The rtd3 chip needs to be added on the same root port in the devicetree separately. Test: Add chip entry to the corresponding root port and check PXSX Device is generated in ssdt. Signed-off-by: Cliff Huang <cliff.huang(a)intel.com> Change-Id: I1e0b9fd405f6cfb1e216ea27558bb9299a09e566 --- A src/drivers/wwan/fm/Kconfig A src/drivers/wwan/fm/Makefile.inc A src/drivers/wwan/fm/acpi_fm350gl.c A src/drivers/wwan/fm/chip.h 4 files changed, 294 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/61354/11 -- To view, visit https://review.coreboot.org/c/coreboot/+/61354 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e0b9fd405f6cfb1e216ea27558bb9299a09e566 Gerrit-Change-Number: 61354 Gerrit-PatchSet: 11 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Thejaswani Putta <thejaswani.putta(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thejaswani Putta <thejaswani.putta(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: drivers/uart/uart8250reg.h: use shifts in constants
by Felix Held (Code Review) 04 Feb '22

04 Feb '22

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/61644 ) Change subject: drivers/uart/uart8250reg.h: use shifts in constants ...................................................................... drivers/uart/uart8250reg.h: use shifts in constants The UART8250_FCR_TRIGGER bits are bits 6 and 7 in the register, so rewrite the mask and constants as constants shifted by 6. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: I0663c1a641355b7bfb59f41479d17117178fb895 --- M src/drivers/uart/uart8250reg.h 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/61644/1 diff --git a/src/drivers/uart/uart8250reg.h b/src/drivers/uart/uart8250reg.h index 170c90e..35a6845 100644 --- a/src/drivers/uart/uart8250reg.h +++ b/src/drivers/uart/uart8250reg.h @@ -30,11 +30,11 @@ #define UART8250_FCR_CLEAR_RCVR BIT(1) /* Clear the RCVR FIFO */ #define UART8250_FCR_CLEAR_XMIT BIT(2) /* Clear the XMIT FIFO */ #define UART8250_FCR_DMA_SELECT BIT(3) /* For DMA applications */ -#define UART8250_FCR_TRIGGER_MASK 0xC0 /* Mask for the FIFO trigger range */ -#define UART8250_FCR_TRIGGER_1 0x00 /* Mask for trigger set at 1 */ -#define UART8250_FCR_TRIGGER_4 0x40 /* Mask for trigger set at 4 */ -#define UART8250_FCR_TRIGGER_8 0x80 /* Mask for trigger set at 8 */ -#define UART8250_FCR_TRIGGER_14 0xC0 /* Mask for trigger set at 14 */ +#define UART8250_FCR_TRIGGER_MASK (3 << 6) /* Mask for the FIFO trigger range */ +#define UART8250_FCR_TRIGGER_1 (0 << 6) /* Mask for trigger set at 1 */ +#define UART8250_FCR_TRIGGER_4 (1 << 6) /* Mask for trigger set at 4 */ +#define UART8250_FCR_TRIGGER_8 (2 << 6) /* Mask for trigger set at 8 */ +#define UART8250_FCR_TRIGGER_14 (3 << 6) /* Mask for trigger set at 14 */ #define UART8250_LCR 0x03 #define UART8250_LCR_WLS_MSK 0x03 /* character length select mask */ -- To view, visit https://review.coreboot.org/c/coreboot/+/61644 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0663c1a641355b7bfb59f41479d17117178fb895 Gerrit-Change-Number: 61644 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: drivers/uart/uart8250reg.h: use BIT() macro for bit definitions
by Felix Held (Code Review) 04 Feb '22

04 Feb '22

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/61643 ) Change subject: drivers/uart/uart8250reg.h: use BIT() macro for bit definitions ...................................................................... drivers/uart/uart8250reg.h: use BIT() macro for bit definitions Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: Ib726dd77eaf1a4f8a7d9fbf8ab6d46a7bb1de6c0 --- M src/drivers/uart/uart8250reg.h 1 file changed, 37 insertions(+), 35 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/61643/1 diff --git a/src/drivers/uart/uart8250reg.h b/src/drivers/uart/uart8250reg.h index 573eb6f..170c90e 100644 --- a/src/drivers/uart/uart8250reg.h +++ b/src/drivers/uart/uart8250reg.h @@ -3,16 +3,18 @@ #ifndef UART8250REG_H #define UART8250REG_H +#include <types.h> + /* Data */ #define UART8250_RBR 0x00 #define UART8250_TBR 0x00 /* Control */ #define UART8250_IER 0x01 -#define UART8250_IER_MSI 0x08 /* Enable Modem status interrupt */ -#define UART8250_IER_RLSI 0x04 /* Enable receiver line status interrupt */ -#define UART8250_IER_THRI 0x02 /* Enable Transmitter holding register int. */ -#define UART8250_IER_RDI 0x01 /* Enable receiver data interrupt */ +#define UART8250_IER_MSI BIT(3) /* Enable Modem status interrupt */ +#define UART8250_IER_RLSI BIT(2) /* Enable receiver line status interrupt */ +#define UART8250_IER_THRI BIT(1) /* Enable Transmitter holding register int. */ +#define UART8250_IER_RDI BIT(0) /* Enable receiver data interrupt */ #define UART8250_IIR 0x02 #define UART8250_IIR_NO_INT 0x01 /* No interrupts pending */ @@ -24,10 +26,10 @@ #define UART8250_IIR_RLSI 0x06 /* Receiver line status interrupt */ #define UART8250_FCR 0x02 -#define UART8250_FCR_FIFO_EN 0x01 /* Fifo enable */ -#define UART8250_FCR_CLEAR_RCVR 0x02 /* Clear the RCVR FIFO */ -#define UART8250_FCR_CLEAR_XMIT 0x04 /* Clear the XMIT FIFO */ -#define UART8250_FCR_DMA_SELECT 0x08 /* For DMA applications */ +#define UART8250_FCR_FIFO_EN BIT(0) /* Fifo enable */ +#define UART8250_FCR_CLEAR_RCVR BIT(1) /* Clear the RCVR FIFO */ +#define UART8250_FCR_CLEAR_XMIT BIT(2) /* Clear the XMIT FIFO */ +#define UART8250_FCR_DMA_SELECT BIT(3) /* For DMA applications */ #define UART8250_FCR_TRIGGER_MASK 0xC0 /* Mask for the FIFO trigger range */ #define UART8250_FCR_TRIGGER_1 0x00 /* Mask for trigger set at 1 */ #define UART8250_FCR_TRIGGER_4 0x40 /* Mask for trigger set at 4 */ @@ -40,19 +42,19 @@ #define UART8250_LCR_WLS_6 0x01 /* 6 bit character length */ #define UART8250_LCR_WLS_7 0x02 /* 7 bit character length */ #define UART8250_LCR_WLS_8 0x03 /* 8 bit character length */ -#define UART8250_LCR_STB 0x04 /* Number of stop Bits, off = 1, on = 1.5 or 2) */ -#define UART8250_LCR_PEN 0x08 /* Parity enable */ -#define UART8250_LCR_EPS 0x10 /* Even Parity Select */ -#define UART8250_LCR_STKP 0x20 /* Stick Parity */ -#define UART8250_LCR_SBRK 0x40 /* Set Break */ -#define UART8250_LCR_DLAB 0x80 /* Divisor latch access bit */ +#define UART8250_LCR_STB BIT(2) /* Number of stop Bits, off = 1, on = 1.5 or 2) */ +#define UART8250_LCR_PEN BIT(3) /* Parity enable */ +#define UART8250_LCR_EPS BIT(4) /* Even Parity Select */ +#define UART8250_LCR_STKP BIT(5) /* Stick Parity */ +#define UART8250_LCR_SBRK BIT(6) /* Set Break */ +#define UART8250_LCR_DLAB BIT(7) /* Divisor latch access bit */ #define UART8250_MCR 0x04 -#define UART8250_MCR_DTR 0x01 /* DTR */ -#define UART8250_MCR_RTS 0x02 /* RTS */ -#define UART8250_MCR_OUT1 0x04 /* Out 1 */ -#define UART8250_MCR_OUT2 0x08 /* Out 2 */ -#define UART8250_MCR_LOOP 0x10 /* Enable loopback test mode */ +#define UART8250_MCR_DTR BIT(0) /* DTR */ +#define UART8250_MCR_RTS BIT(1) /* RTS */ +#define UART8250_MCR_OUT1 BIT(2) /* Out 1 */ +#define UART8250_MCR_OUT2 BIT(3) /* Out 2 */ +#define UART8250_MCR_LOOP BIT(4) /* Enable loopback test mode */ #define UART8250_MCR_DMA_EN 0x04 #define UART8250_MCR_TX_DFR 0x08 @@ -62,24 +64,24 @@ /* Status */ #define UART8250_LSR 0x05 -#define UART8250_LSR_DR 0x01 /* Data ready */ -#define UART8250_LSR_OE 0x02 /* Overrun */ -#define UART8250_LSR_PE 0x04 /* Parity error */ -#define UART8250_LSR_FE 0x08 /* Framing error */ -#define UART8250_LSR_BI 0x10 /* Break */ -#define UART8250_LSR_THRE 0x20 /* Xmit holding register empty */ -#define UART8250_LSR_TEMT 0x40 /* Xmitter empty */ -#define UART8250_LSR_ERR 0x80 /* Error */ +#define UART8250_LSR_DR BIT(0) /* Data ready */ +#define UART8250_LSR_OE BIT(1) /* Overrun */ +#define UART8250_LSR_PE BIT(2) /* Parity error */ +#define UART8250_LSR_FE BIT(3) /* Framing error */ +#define UART8250_LSR_BI BIT(4) /* Break */ +#define UART8250_LSR_THRE BIT(5) /* Xmit holding register empty */ +#define UART8250_LSR_TEMT BIT(6) /* Xmitter empty */ +#define UART8250_LSR_ERR BIT(7) /* Error */ #define UART8250_MSR 0x06 -#define UART8250_MSR_DCD 0x80 /* Data Carrier Detect */ -#define UART8250_MSR_RI 0x40 /* Ring Indicator */ -#define UART8250_MSR_DSR 0x20 /* Data Set Ready */ -#define UART8250_MSR_CTS 0x10 /* Clear to Send */ -#define UART8250_MSR_DDCD 0x08 /* Delta DCD */ -#define UART8250_MSR_TERI 0x04 /* Trailing edge ring indicator */ -#define UART8250_MSR_DDSR 0x02 /* Delta DSR */ -#define UART8250_MSR_DCTS 0x01 /* Delta CTS */ +#define UART8250_MSR_DCD BIT(7) /* Data Carrier Detect */ +#define UART8250_MSR_RI BIT(6) /* Ring Indicator */ +#define UART8250_MSR_DSR BIT(5) /* Data Set Ready */ +#define UART8250_MSR_CTS BIT(4) /* Clear to Send */ +#define UART8250_MSR_DDCD BIT(3) /* Delta DCD */ +#define UART8250_MSR_TERI BIT(2) /* Trailing edge ring indicator */ +#define UART8250_MSR_DDSR BIT(1) /* Delta DSR */ +#define UART8250_MSR_DCTS BIT(0) /* Delta CTS */ #define UART8250_SCR 0x07 #define UART8250_SPR 0x07 -- To view, visit https://review.coreboot.org/c/coreboot/+/61643 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib726dd77eaf1a4f8a7d9fbf8ab6d46a7bb1de6c0 Gerrit-Change-Number: 61643 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: drivers/uart/uart8250reg.h: remove duplicate bit definitions
by Felix Held (Code Review) 04 Feb '22

04 Feb '22

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/61642 ) Change subject: drivers/uart/uart8250reg.h: remove duplicate bit definitions ...................................................................... drivers/uart/uart8250reg.h: remove duplicate bit definitions UART8250_FCR_RXSR is a redefinition of UART8250_FCR_CLEAR_RCVR, UART8250_FCR_TXSR a redefinition of UART8250_FCR_CLEAR_XMIT and UART8250_LCR_BKSE a redefinition of UART8250_LCR_DLAB. None of those redefinitions are used, so just drop them. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: I6b9edae67180b04ff1c887c5742c07c774fc9c59 --- M src/drivers/uart/uart8250reg.h 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/61642/1 diff --git a/src/drivers/uart/uart8250reg.h b/src/drivers/uart/uart8250reg.h index 28dc21c..573eb6f 100644 --- a/src/drivers/uart/uart8250reg.h +++ b/src/drivers/uart/uart8250reg.h @@ -34,9 +34,6 @@ #define UART8250_FCR_TRIGGER_8 0x80 /* Mask for trigger set at 8 */ #define UART8250_FCR_TRIGGER_14 0xC0 /* Mask for trigger set at 14 */ -#define UART8250_FCR_RXSR 0x02 /* Receiver soft reset */ -#define UART8250_FCR_TXSR 0x04 /* Transmitter soft reset */ - #define UART8250_LCR 0x03 #define UART8250_LCR_WLS_MSK 0x03 /* character length select mask */ #define UART8250_LCR_WLS_5 0x00 /* 5 bit character length */ @@ -48,7 +45,6 @@ #define UART8250_LCR_EPS 0x10 /* Even Parity Select */ #define UART8250_LCR_STKP 0x20 /* Stick Parity */ #define UART8250_LCR_SBRK 0x40 /* Set Break */ -#define UART8250_LCR_BKSE 0x80 /* Bank select enable */ #define UART8250_LCR_DLAB 0x80 /* Divisor latch access bit */ #define UART8250_MCR 0x04 -- To view, visit https://review.coreboot.org/c/coreboot/+/61642 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6b9edae67180b04ff1c887c5742c07c774fc9c59 Gerrit-Change-Number: 61642 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2022