Attention is currently required from: Ravi kumar, Sudheer Amrabadi, mturney mturney.
Sudheer Amrabadi has uploaded a new patch set (#15) to the change originally created by Ravi kumar. ( https://review.coreboot.org/c/coreboot/+/59611 )
Change subject: qualcomm/sc7280: Add display external clock support in coreboot
......................................................................
qualcomm/sc7280: Add display external clock support in coreboot
Add support for EDP (Embedded DisplayPort) clocks in coreboot.
This change supports the configuration and enablement of
EDP PIXEL, LINK, LINK_INTF and AUX clocks.
BUG=b:182963902,b:216687885
TEST=Validated on qualcomm sc7280 development board.
Signed-off-by: Taniya Das <quic_tdas(a)quicinc.com>
Change-Id: Ia6872ede515401e95ea2dadc9766e3e70fb66144
---
M src/soc/qualcomm/sc7280/clock.c
M src/soc/qualcomm/sc7280/include/soc/clock.h
2 files changed, 53 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/59611/15
--
To view, visit https://review.coreboot.org/c/coreboot/+/59611
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia6872ede515401e95ea2dadc9766e3e70fb66144
Gerrit-Change-Number: 59611
Gerrit-PatchSet: 15
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Taniya Das <quic_tdas(a)quicinc.com>
Gerrit-CC: Taniya Das <tdas(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org>
Gerrit-Attention: mturney mturney <quic_mturney(a)quicinc.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tim Wawrzynczak, Angel Pons.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61151 )
Change subject: mb/google/brya/var/gimble: Group fw_config pad tables
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Patchset:
PS1:
LGTM with minor modification.
File src/mainboard/google/brya/variants/gimble/fw_config.c:
https://review.coreboot.org/c/coreboot/+/61151/comment/e5c394fe_371a7264
PS1, Line 70: 0
can we use enum instead `0` or `1`
Isn't it more like `0` for disable and `1` for enable?
--
To view, visit https://review.coreboot.org/c/coreboot/+/61151
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9888950db254c6ccd9040ea7a61c049fd4a519c7
Gerrit-Change-Number: 61151
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Mon, 07 Feb 2022 05:47:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, Patrick Rudolph.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61655 )
Change subject: soc/intel/common/gpio: Add PAD_NC_LOCK support
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61655/comment/00ba4e3a_ace49c1a
PS2, Line 9: lock needs for NC pins.
> to lock NC PINs as applicable ?
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/61655
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie44d72f4152b55183d900228df3e3670358f7518
Gerrit-Change-Number: 61655
Gerrit-PatchSet: 3
Gerrit-Owner: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Mon, 07 Feb 2022 05:38:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, Patrick Rudolph, EricR Lai.
Hello build bot (Jenkins), Subrata Banik, Tim Wawrzynczak, Nick Vaccaro, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/61655
to look at the new patch set (#3).
Change subject: soc/intel/common/gpio: Add PAD_NC_LOCK support
......................................................................
soc/intel/common/gpio: Add PAD_NC_LOCK support
Add PAD_NC_LOCK macro to support mainboard to lock NC pins as
applicable.
BUG=b:216583542
TEST=build passed
Signed-off-by: Eric Lai <ericr_lai(a)compal.corp-partner.google.com>
Change-Id: Ie44d72f4152b55183d900228df3e3670358f7518
---
M src/soc/intel/common/block/include/intelblocks/gpio_defs.h
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/61655/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/61655
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie44d72f4152b55183d900228df3e3670358f7518
Gerrit-Change-Number: 61655
Gerrit-PatchSet: 3
Gerrit-Owner: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, EricR Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61656 )
Change subject: mb/google/brya: Add more gpios to lock
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
LGTM
--
To view, visit https://review.coreboot.org/c/coreboot/+/61656
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I41393e7a0e8bacb3cc98610f7101dabe66308f94
Gerrit-Change-Number: 61656
Gerrit-PatchSet: 1
Gerrit-Owner: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Mon, 07 Feb 2022 05:37:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, Patrick Rudolph, EricR Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61655 )
Change subject: soc/intel/common/gpio: Add PAD_NC_LOCK support
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61655/comment/b01abced_d0103f7f
PS2, Line 9: lock needs for NC pins.
to lock NC PINs as applicable ?
--
To view, visit https://review.coreboot.org/c/coreboot/+/61655
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie44d72f4152b55183d900228df3e3670358f7518
Gerrit-Change-Number: 61655
Gerrit-PatchSet: 2
Gerrit-Owner: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Mon, 07 Feb 2022 05:36:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Tim Wawrzynczak, Paul Menzel, Meera Ravindranath.
Casper Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60417 )
Change subject: mb/google/brya/var/primus4es: reconfig USE_PM_ACPI_TIMER
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> I tried latest coreboot on primus4es, the eMMC SKUs (PCIe3) could suspend properly but SSD SKUs (PCI […]
Could we submit this CL to enable S0iX on ES CPU?
--
To view, visit https://review.coreboot.org/c/coreboot/+/60417
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d19c10e2029e233542a8ceec272f8ede2b4bfac
Gerrit-Change-Number: 60417
Gerrit-PatchSet: 2
Gerrit-Owner: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com>
Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-Comment-Date: Mon, 07 Feb 2022 05:28:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Comment-In-Reply-To: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Ravindra, Mark Hsieh, Patrick Rudolph.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61586 )
Change subject: soc/intel/alderlake, mb/google/brya: Update Type-C USB2 port config
......................................................................
Patch Set 6:
(1 comment)
File src/soc/intel/alderlake/include/soc/usb.h:
https://review.coreboot.org/c/coreboot/+/61586/comment/d771973d_f6ff4a21
PS6, Line 98: #define USB2_PORT_MAX_TYPE_C(pin) { \
: .enable = 1, \
: .ocpin = (pin), \
: .tx_bias = USB2_BIAS_56P3MV, \
: .tx_emp_enable = USB2_PRE_EMP_ON, \
: .pre_emp_bias = USB2_BIAS_56P3MV, \
: .pre_emp_bit = USB2_HALF_BIT_PRE_EMP, \
: .type_c = 1, \
: }
:
> I guess we could split this into two macros, […]
Since there are consumers (across Brya family boards) of USB2_PORT_MAX, so I removed the macro intentionally. I think this is ok.
--
To view, visit https://review.coreboot.org/c/coreboot/+/61586
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If54faa63a983c859bf26a6a779751a6c3c85c43d
Gerrit-Change-Number: 61586
Gerrit-PatchSet: 6
Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Ravindra <ravindra(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Ravindra <ravindra(a)intel.com>
Gerrit-Attention: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Mon, 07 Feb 2022 05:28:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Bao Zheng has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/61450 )
Change subject: temp
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/c/coreboot/+/61450
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd5dbd1ca061fcc20e45dbc8fb1211a5a8144bbc
Gerrit-Change-Number: 61450
Gerrit-PatchSet: 1
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: abandon