Attention is currently required from: Reka Norman, Tim Wawrzynczak, Krishna P Bhat D, Usha P.
Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61605 )
Change subject: mb/google/brya/var/nivviks: Initialise overridetree
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/61605
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id3ecd184415a20a3a52da8bb5e60fe2ce0495b44
Gerrit-Change-Number: 61605
Gerrit-PatchSet: 5
Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Usha P <usha.p(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Reka Norman <rekanorman(a)google.com>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Attention: Usha P <usha.p(a)intel.com>
Gerrit-Comment-Date: Fri, 11 Feb 2022 10:22:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Werner Zeh.
Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61827 )
Change subject: mb/siemens/mc_apl{2,4,5,6}: Enable recovery MRC cache
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/61827
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2ea4993f05dd87a0e637f55e84b4fc06f5e29ecc
Gerrit-Change-Number: 61827
Gerrit-PatchSet: 1
Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Comment-Date: Fri, 11 Feb 2022 10:10:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Patrick Rudolph.
Hello Arthur Heymans, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/61853
to look at the new patch set (#5).
Change subject: src/device/azalia_device.c: Make codec_detect(u8 *base) common and use it
......................................................................
src/device/azalia_device.c: Make codec_detect(u8 *base) common and use it
Change-Id: I349b35dbf4d5851af71703239781c196945c6cae
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M src/device/azalia_device.c
M src/include/device/azalia_device.h
M src/northbridge/intel/haswell/minihd.c
M src/soc/intel/broadwell/minihd.c
M src/soc/intel/broadwell/pch/Makefile.inc
M src/soc/intel/broadwell/pch/hda.c
M src/southbridge/intel/bd82x6x/azalia.c
M src/southbridge/intel/i82801gx/azalia.c
M src/southbridge/intel/i82801ix/azalia.c
M src/southbridge/intel/i82801jx/azalia.c
M src/southbridge/intel/ibexpeak/azalia.c
M src/southbridge/intel/lynxpoint/Kconfig
M src/southbridge/intel/lynxpoint/Makefile.inc
M src/southbridge/intel/lynxpoint/azalia.c
D src/southbridge/intel/lynxpoint/hda_verb.c
D src/southbridge/intel/lynxpoint/hda_verb.h
16 files changed, 7 insertions(+), 201 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/61853/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/61853
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I349b35dbf4d5851af71703239781c196945c6cae
Gerrit-Change-Number: 61853
Gerrit-PatchSet: 5
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans, Patrick Rudolph.
Hello Arthur Heymans, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/61853
to look at the new patch set (#4).
Change subject: sb/intel/*/azalia.c: Make codec_detect(u8 *base) common and use it
......................................................................
sb/intel/*/azalia.c: Make codec_detect(u8 *base) common and use it
Change-Id: I349b35dbf4d5851af71703239781c196945c6cae
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M src/device/azalia_device.c
M src/include/device/azalia_device.h
M src/southbridge/intel/bd82x6x/azalia.c
M src/southbridge/intel/i82801gx/azalia.c
M src/southbridge/intel/i82801ix/azalia.c
M src/southbridge/intel/i82801jx/azalia.c
M src/southbridge/intel/ibexpeak/azalia.c
M src/southbridge/intel/lynxpoint/Kconfig
M src/southbridge/intel/lynxpoint/Makefile.inc
M src/southbridge/intel/lynxpoint/azalia.c
D src/southbridge/intel/lynxpoint/hda_verb.c
D src/southbridge/intel/lynxpoint/hda_verb.h
12 files changed, 4 insertions(+), 194 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/61853/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/61853
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I349b35dbf4d5851af71703239781c196945c6cae
Gerrit-Change-Number: 61853
Gerrit-PatchSet: 4
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans, Patrick Rudolph.
Hello Arthur Heymans, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/61853
to look at the new patch set (#3).
Change subject: sb/intel/*/azalia.c: Make codec_detect(u8 *base) common and use it
......................................................................
sb/intel/*/azalia.c: Make codec_detect(u8 *base) common and use it
Change-Id: I349b35dbf4d5851af71703239781c196945c6cae
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M src/device/azalia_device.c
M src/include/device/azalia_device.h
M src/southbridge/intel/bd82x6x/azalia.c
M src/southbridge/intel/i82801gx/azalia.c
M src/southbridge/intel/i82801ix/azalia.c
M src/southbridge/intel/i82801jx/azalia.c
M src/southbridge/intel/ibexpeak/azalia.c
M src/southbridge/intel/lynxpoint/Kconfig
M src/southbridge/intel/lynxpoint/azalia.c
D src/southbridge/intel/lynxpoint/hda_verb.c
D src/southbridge/intel/lynxpoint/hda_verb.h
11 files changed, 4 insertions(+), 193 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/61853/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/61853
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I349b35dbf4d5851af71703239781c196945c6cae
Gerrit-Change-Number: 61853
Gerrit-PatchSet: 3
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans, Patrick Rudolph.
Hello Arthur Heymans, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/61853
to look at the new patch set (#2).
Change subject: sb/intel/*/azalia.c: Make codec_detect(u8 *base) common and use it
......................................................................
sb/intel/*/azalia.c: Make codec_detect(u8 *base) common and use it
Change-Id: I349b35dbf4d5851af71703239781c196945c6cae
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M src/device/azalia_device.c
M src/include/device/azalia_device.h
M src/southbridge/intel/bd82x6x/azalia.c
M src/southbridge/intel/i82801gx/azalia.c
M src/southbridge/intel/i82801ix/azalia.c
M src/southbridge/intel/i82801jx/azalia.c
M src/southbridge/intel/ibexpeak/azalia.c
M src/southbridge/intel/lynxpoint/Kconfig
M src/southbridge/intel/lynxpoint/azalia.c
D src/southbridge/intel/lynxpoint/hda_verb.c
D src/southbridge/intel/lynxpoint/hda_verb.h
11 files changed, 4 insertions(+), 192 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/61853/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/61853
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I349b35dbf4d5851af71703239781c196945c6cae
Gerrit-Change-Number: 61853
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Patrick Rudolph.
Hello Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/61852
to look at the new patch set (#3).
Change subject: sb/intel/i82801ix/azalia.c: Read 16 bits on HDA_STATESTS_REG
......................................................................
sb/intel/i82801ix/azalia.c: Read 16 bits on HDA_STATESTS_REG
HDA_STATESTS_REG is a 16 bits register, so correct the codec_mask
and read 16bits.
Change-Id: I6945b1461a12ca2b07c05ee90246a199e7447435
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M src/southbridge/intel/i82801ix/azalia.c
1 file changed, 8 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/61852/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/61852
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6945b1461a12ca2b07c05ee90246a199e7447435
Gerrit-Change-Number: 61852
Gerrit-PatchSet: 3
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset