Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Bhanu Prakash Maiya, Tim Wawrzynczak, Paul Menzel, Rob Barnes, Eric Peers, Felix Held.
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61125 )
Change subject: mb/google/guybrush/var/nipperkin: Add _HID for privacy screen device
......................................................................
Patch Set 5:
(1 comment)
File src/soc/amd/common/block/graphics/graphics.c:
PS4:
> +1. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/61125
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f45fabac1548cca39379f91cc42fed0cd04f8a3
Gerrit-Change-Number: 61125
Gerrit-PatchSet: 5
Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com>
Gerrit-Reviewer: Eric Peers <epeers(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Bhanu Prakash Maiya <bhanumaiya(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Rob Barnes <robbarnes(a)google.com>
Gerrit-Attention: Eric Peers <epeers(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Fri, 11 Feb 2022 12:12:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org>
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Paul Menzel.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61729 )
Change subject: soc/mediatek: Only update required bits when triggering WDT reset
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
@hung-te, could we merge this patch?
Thanks
--
To view, visit https://review.coreboot.org/c/coreboot/+/61729
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I743c1af3583c18ec8500fc1eb89f31cdbce5317c
Gerrit-Change-Number: 61729
Gerrit-PatchSet: 3
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Fri, 11 Feb 2022 12:06:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61859 )
Change subject: drivers/smmstore/store.c: Fix static assertion for memory mapped SOCs
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
These assertions are triggered for CB:60980, the first is obvious why, but I'm oblivous to the second.
--
To view, visit https://review.coreboot.org/c/coreboot/+/61859
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I902abd97c0d81ee7c13fa32e57279c8e55c36122
Gerrit-Change-Number: 61859
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Fri, 11 Feb 2022 11:54:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Sean Rhodes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/61859 )
Change subject: drivers/smmstore/store.c: Fix static assertion for memory mapped SOCs
......................................................................
drivers/smmstore/store.c: Fix static assertion for memory mapped SOCs
This will assert for APL/GLK boards that do not align SMMStore intentionally
so that they are aligned when memory mapped.
Both asserts are triggered for the below config, where SMMStore is aligned
and sized correctly when memory mapped.
#define FMAP_SECTION_SMMSTORE_START 0x63f000
#define FMAP_SECTION_SMMSTORE_SIZE 0x40000
Signed-off-by: Sean Rhodes <sean(a)starlabs.systems>
Change-Id: I902abd97c0d81ee7c13fa32e57279c8e55c36122
---
M src/drivers/smmstore/store.c
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/61859/1
diff --git a/src/drivers/smmstore/store.c b/src/drivers/smmstore/store.c
index 6ba3f53..e77fbd0 100644
--- a/src/drivers/smmstore/store.c
+++ b/src/drivers/smmstore/store.c
@@ -11,9 +11,10 @@
#define SMMSTORE_REGION "SMMSTORE"
-
+#if !CONFIG(BOOT_DEVICE_MEMORY_MAPPED)
_Static_assert(IS_ALIGNED(FMAP_SECTION_SMMSTORE_START, SMM_BLOCK_SIZE),
"SMMSTORE FMAP region not aligned to 64K");
+#endif
_Static_assert(SMM_BLOCK_SIZE <= FMAP_SECTION_SMMSTORE_SIZE,
"SMMSTORE FMAP region must be at least 64K");
--
To view, visit https://review.coreboot.org/c/coreboot/+/61859
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I902abd97c0d81ee7c13fa32e57279c8e55c36122
Gerrit-Change-Number: 61859
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-MessageType: newchange
Attention is currently required from: Patrick Rudolph.
Hello Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/61856
to look at the new patch set (#2).
Change subject: sb/intel/i82801jx/azalia.c: Use azalia_audio_init(dev)
......................................................................
sb/intel/i82801jx/azalia.c: Use azalia_audio_init(dev)
Change-Id: I790332b31c356edfe3e2dcb270ea9fcd643befb0
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M src/southbridge/intel/i82801jx/azalia.c
1 file changed, 1 insertion(+), 18 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/61856/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/61856
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I790332b31c356edfe3e2dcb270ea9fcd643befb0
Gerrit-Change-Number: 61856
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Patrick Rudolph.
Hello Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/61855
to look at the new patch set (#3).
Change subject: sb/intel/i82801gx/azalia.c: Use azalia_audio_init(dev)
......................................................................
sb/intel/i82801gx/azalia.c: Use azalia_audio_init(dev)
Change-Id: Ia87eac9f3d267f25b2fd4cc423811641c5c544f0
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M src/southbridge/intel/i82801gx/azalia.c
1 file changed, 1 insertion(+), 17 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/61855/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/61855
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia87eac9f3d267f25b2fd4cc423811641c5c544f0
Gerrit-Change-Number: 61855
Gerrit-PatchSet: 3
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Patrick Rudolph.
Hello Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/61855
to look at the new patch set (#2).
Change subject: sb/intel/i82801gx/azalia.c: Use azalia_audio_init(dev)
......................................................................
sb/intel/i82801gx/azalia.c: Use azalia_audio_init(dev)
Change-Id: Ia87eac9f3d267f25b2fd4cc423811641c5c544f0
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M src/southbridge/intel/i82801gx/azalia.c
1 file changed, 1 insertion(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/61855/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/61855
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia87eac9f3d267f25b2fd4cc423811641c5c544f0
Gerrit-Change-Number: 61855
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset