Attention is currently required from: Subrata Banik, Angel Pons, Werner Zeh, Patrick Rudolph.
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61519 )
Change subject: soc/intel/common/cse: Add `cse_send_end_of_post()` as a public function
......................................................................
Patch Set 10: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/61519
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I837c5723eca766d21b191b98e39eb52889498bfc
Gerrit-Change-Number: 61519
Gerrit-PatchSet: 10
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Fri, 11 Feb 2022 13:33:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Patrick Rudolph, Elyes Haouas.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61853 )
Change subject: src/device/azalia_device.c: Make codec_detect(u8 *base) common and use it
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
Patchset:
PS5:
I didn't deduplicate this function because there are multiple implementations. Has this been tested?
--
To view, visit https://review.coreboot.org/c/coreboot/+/61853
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I349b35dbf4d5851af71703239781c196945c6cae
Gerrit-Change-Number: 61853
Gerrit-PatchSet: 5
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Fri, 11 Feb 2022 13:33:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Jan Dabros has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/61863 )
Change subject: soc/amd/cezanne/acpi/mmio: Add support for shared I2C3 controller
......................................................................
soc/amd/cezanne/acpi/mmio: Add support for shared I2C3 controller
There are platforms equipped with AMD Cezanne SoC where I2C3 controller
is shared between X86 and PSP. In order to handle this, PSP acts as an
i2c-arbitrator, where x86(kernel) sends acquire and release requests to
be accepted by PSP.
There is a need to introduce new ACPI_ID so that dedicated driver on OS
side can bind to it and handle this special setup. Since PSP takes care
of i2c controller power management, we need to remove PowerResource
object from DSDT.
BUG=b:204508404
Signed-off-by: Jan Dabros <jsd(a)semihalf.com>
Change-Id: Iccfc09d8c580d7ab2acb69d26b9c293cf625fb34
---
M src/soc/amd/cezanne/Kconfig
M src/soc/amd/cezanne/acpi/mmio.asl
2 files changed, 14 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/61863/1
diff --git a/src/soc/amd/cezanne/Kconfig b/src/soc/amd/cezanne/Kconfig
index 19f0266..45fca16 100644
--- a/src/soc/amd/cezanne/Kconfig
+++ b/src/soc/amd/cezanne/Kconfig
@@ -274,6 +274,14 @@
int
default 150
+config SOC_AMD_CEZANNE_I2C3_SHARED_WITH_PSP
+ bool "I2C3 controller shared with PSP"
+ default n
+ help
+ Enable PSP i2c arbitration if there is I2C3 controller shared between
+ x86 and PSP. This is necessary to ensure proper communication with i2c
+ clients connected to such bus.
+
config DISABLE_SPI_FLASH_ROM_SHARING
def_bool n
help
diff --git a/src/soc/amd/cezanne/acpi/mmio.asl b/src/soc/amd/cezanne/acpi/mmio.asl
index 9e587b7..a4975a9b 100644
--- a/src/soc/amd/cezanne/acpi/mmio.asl
+++ b/src/soc/amd/cezanne/acpi/mmio.asl
@@ -232,7 +232,11 @@
Device (I2C3)
{
+#if CONFIG(SOC_AMD_CEZANNE_I2C3_SHARED_WITH_PSP)
+ Name (_HID, "AMDI0019")
+#else
Name (_HID, "AMDI0010")
+#endif
Name (_UID, 0x3)
Method (_CRS, 0) {
Local0 = ResourceTemplate() {
@@ -263,7 +267,9 @@
Return (0x0F)
}
+#if !CONFIG(SOC_AMD_CEZANNE_I2C3_SHARED_WITH_PSP)
AOAC_DEVICE(FCH_AOAC_DEV_I2C3, 0)
+#endif
}
Device (MISC)
--
To view, visit https://review.coreboot.org/c/coreboot/+/61863
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iccfc09d8c580d7ab2acb69d26b9c293cf625fb34
Gerrit-Change-Number: 61863
Gerrit-PatchSet: 1
Gerrit-Owner: Jan Dabros <jsd(a)semihalf.com>
Gerrit-MessageType: newchange
Attention is currently required from: Martin Roth - Personal, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52564 )
Change subject: [WIP]drivers/efi: Add UEFI variable store option support
......................................................................
Patch Set 4:
(15 comments)
File src/commonlib/bsd/include/commonlib/bsd/cb_err.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140598):
https://review.coreboot.org/c/coreboot/+/52564/comment/dc0d3fac_29aaadd8
PS4, Line 29: CB_EFI_VS_NOT_FORMATED_INVALID = -107, /**< UEFI variable store not formated */
'FORMATED' may be misspelled - perhaps 'FORMATTED'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140598):
https://review.coreboot.org/c/coreboot/+/52564/comment/09e53c0d_4f9c34b3
PS4, Line 29: CB_EFI_VS_NOT_FORMATED_INVALID = -107, /**< UEFI variable store not formated */
'formated' may be misspelled - perhaps 'formatted'?
File src/drivers/efi/efi.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140598):
https://review.coreboot.org/c/coreboot/+/52564/comment/b86cc4ae_7653687e
PS4, Line 9: enum cb_err efi_fv_get_option(struct region_device *rdev, const char *name, void *dest, uint32_t *size);
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140598):
https://review.coreboot.org/c/coreboot/+/52564/comment/b96713ba_b231f9f8
PS4, Line 10: enum cb_err efi_fv_set_option(struct region_device *rdev, const char *name, void *data, size_t size);
line over 96 characters
File src/drivers/efi/efi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140598):
https://review.coreboot.org/c/coreboot/+/52564/comment/fd7a9943_a79c5dcf
PS4, Line 82: if ( (fw_vol_hdr->Revision != EFI_FVH_REVISION)
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140598):
https://review.coreboot.org/c/coreboot/+/52564/comment/1d9db851_abca5caf
PS4, Line 82: if ( (fw_vol_hdr->Revision != EFI_FVH_REVISION)
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140598):
https://review.coreboot.org/c/coreboot/+/52564/comment/33c1a03a_e97ae849
PS4, Line 147: return CB_EFI_VS_NOT_FORMATED_INVALID;
'FORMATED' may be misspelled - perhaps 'FORMATTED'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140598):
https://review.coreboot.org/c/coreboot/+/52564/comment/0830d93f_2a4c46e3
PS4, Line 235: !name ) {
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140598):
https://review.coreboot.org/c/coreboot/+/52564/comment/1ab7e553_93ffdfcd
PS4, Line 250: if (rdev_readat(rdev, data, header_size + name_size, data_size) != data_size)
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140598):
https://review.coreboot.org/c/coreboot/+/52564/comment/9de6d678_4fe47a1e
PS4, Line 250: if (rdev_readat(rdev, data, header_size + name_size, data_size) != data_size)
Too many leading tabs - consider code refactoring
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140598):
https://review.coreboot.org/c/coreboot/+/52564/comment/1249b4fa_68885212
PS4, Line 275: enum cb_err efi_fv_get_option(struct region_device *rdev, const char *name, void *dest, uint32_t *size)
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140598):
https://review.coreboot.org/c/coreboot/+/52564/comment/a28b3aaf_4e15c6b4
PS4, Line 307: enum cb_err efi_fv_set_option(struct region_device *rdev, const char *name, void *data, size_t size)
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140598):
https://review.coreboot.org/c/coreboot/+/52564/comment/825f16d3_dd9888ac
PS4, Line 345: auth_hdr.Attributes = EFI_VARIABLE_NON_VOLATILE|EFI_VARIABLE_BOOTSERVICE_ACCESS|EFI_VARIABLE_RUNTIME_ACCESS;
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140598):
https://review.coreboot.org/c/coreboot/+/52564/comment/04a27ed6_c9e5b8a0
PS4, Line 357: if (rdev_writeat(rdev, &auth_hdr.State, offsetof(AUTHENTICATED_VARIABLE_HEADER, State),
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140598):
https://review.coreboot.org/c/coreboot/+/52564/comment/4f0f42fc_680b4b50
PS4, Line 369: hdr.Attributes = EFI_VARIABLE_NON_VOLATILE|EFI_VARIABLE_BOOTSERVICE_ACCESS|EFI_VARIABLE_RUNTIME_ACCESS;
line over 96 characters
--
To view, visit https://review.coreboot.org/c/coreboot/+/52564
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8079f71d29da5dc2db956fc68bef1486fe3906bb
Gerrit-Change-Number: 52564
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Martin Roth - Personal <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin Roth - Personal <martinroth(a)google.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Fri, 11 Feb 2022 13:09:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth - Personal, Patrick Rudolph.
Hello build bot (Jenkins), Martin Roth - Personal, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52564
to look at the new patch set (#4).
Change subject: [WIP]drivers/efi: Add UEFI variable store option support
......................................................................
[WIP]drivers/efi: Add UEFI variable store option support
Add a driver to read UEFI variables stored in the SMMSTORE region.
This is particullary useful for EDK2 as payload and allows to reuse existing
tools to set/get options used by the firmware.
Test: Could enumerate all existing variables.
Change-Id: I8079f71d29da5dc2db956fc68bef1486fe3906bb
Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com>
---
M src/Kconfig
M src/commonlib/bsd/include/commonlib/bsd/cb_err.h
A src/drivers/efi/Kconfig
A src/drivers/efi/Makefile.inc
A src/drivers/efi/efi.c
A src/drivers/efi/efi.h
A src/drivers/efi/option.c
M src/drivers/smmstore/Makefile.inc
M src/drivers/smmstore/store.c
M src/include/smmstore.h
M src/vendorcode/intel/Makefile.inc
A src/vendorcode/intel/edk2/UDK2017/MdeModulePkg/Include/Guid/VariableFormat.h
A src/vendorcode/intel/edk2/option/option.h
13 files changed, 726 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/52564/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/52564
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8079f71d29da5dc2db956fc68bef1486fe3906bb
Gerrit-Change-Number: 52564
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Martin Roth - Personal <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin Roth - Personal <martinroth(a)google.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Martin Roth - Personal, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52564 )
Change subject: [WIP]drivers/efi: Add UEFI variable store option support
......................................................................
Patch Set 3:
(15 comments)
File src/commonlib/bsd/include/commonlib/bsd/cb_err.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140597):
https://review.coreboot.org/c/coreboot/+/52564/comment/b9a90b03_0bc44e09
PS3, Line 29: CB_EFI_VS_NOT_FORMATED_INVALID = -107, /**< UEFI variable store not formated */
'FORMATED' may be misspelled - perhaps 'FORMATTED'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140597):
https://review.coreboot.org/c/coreboot/+/52564/comment/f0964dea_6b1e62dd
PS3, Line 29: CB_EFI_VS_NOT_FORMATED_INVALID = -107, /**< UEFI variable store not formated */
'formated' may be misspelled - perhaps 'formatted'?
File src/drivers/efi/efi.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140597):
https://review.coreboot.org/c/coreboot/+/52564/comment/099528ed_c7550de3
PS3, Line 9: enum cb_err efi_fv_get_option(struct region_device *rdev, const char *name, void *dest, uint32_t *size);
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140597):
https://review.coreboot.org/c/coreboot/+/52564/comment/244ef90c_d300db92
PS3, Line 10: enum cb_err efi_fv_set_option(struct region_device *rdev, const char *name, void *data, size_t size);
line over 96 characters
File src/drivers/efi/efi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140597):
https://review.coreboot.org/c/coreboot/+/52564/comment/e5a5dad9_b037068f
PS3, Line 82: if ( (fw_vol_hdr->Revision != EFI_FVH_REVISION)
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140597):
https://review.coreboot.org/c/coreboot/+/52564/comment/6e672ec2_92884c90
PS3, Line 82: if ( (fw_vol_hdr->Revision != EFI_FVH_REVISION)
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140597):
https://review.coreboot.org/c/coreboot/+/52564/comment/469eef9a_d6fbe109
PS3, Line 147: return CB_EFI_VS_NOT_FORMATED_INVALID;
'FORMATED' may be misspelled - perhaps 'FORMATTED'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140597):
https://review.coreboot.org/c/coreboot/+/52564/comment/82a12b5a_5fdc0956
PS3, Line 235: !name ) {
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140597):
https://review.coreboot.org/c/coreboot/+/52564/comment/cca5d7a8_a07d0dbb
PS3, Line 250: if (rdev_readat(rdev, data, header_size + name_size, data_size) != data_size)
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140597):
https://review.coreboot.org/c/coreboot/+/52564/comment/dc915bfa_b00dcbe5
PS3, Line 250: if (rdev_readat(rdev, data, header_size + name_size, data_size) != data_size)
Too many leading tabs - consider code refactoring
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140597):
https://review.coreboot.org/c/coreboot/+/52564/comment/e36364ea_6002f796
PS3, Line 275: enum cb_err efi_fv_get_option(struct region_device *rdev, const char *name, void *dest, uint32_t *size)
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140597):
https://review.coreboot.org/c/coreboot/+/52564/comment/abfe4ce3_967de833
PS3, Line 307: enum cb_err efi_fv_set_option(struct region_device *rdev, const char *name, void *data, size_t size)
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140597):
https://review.coreboot.org/c/coreboot/+/52564/comment/ffe33224_f9f98048
PS3, Line 345: auth_hdr.Attributes = EFI_VARIABLE_NON_VOLATILE|EFI_VARIABLE_BOOTSERVICE_ACCESS|EFI_VARIABLE_RUNTIME_ACCESS;
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140597):
https://review.coreboot.org/c/coreboot/+/52564/comment/781c6c49_22062b0c
PS3, Line 357: if (rdev_writeat(rdev, &auth_hdr.State, offsetof(AUTHENTICATED_VARIABLE_HEADER, State),
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140597):
https://review.coreboot.org/c/coreboot/+/52564/comment/378cecad_1c8278df
PS3, Line 369: hdr.Attributes = EFI_VARIABLE_NON_VOLATILE|EFI_VARIABLE_BOOTSERVICE_ACCESS|EFI_VARIABLE_RUNTIME_ACCESS;
line over 96 characters
--
To view, visit https://review.coreboot.org/c/coreboot/+/52564
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8079f71d29da5dc2db956fc68bef1486fe3906bb
Gerrit-Change-Number: 52564
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Martin Roth - Personal <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin Roth - Personal <martinroth(a)google.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Fri, 11 Feb 2022 13:04:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth - Personal, Patrick Rudolph.
Hello build bot (Jenkins), Martin Roth - Personal, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52564
to look at the new patch set (#3).
Change subject: [WIP]drivers/efi: Add UEFI variable store option support
......................................................................
[WIP]drivers/efi: Add UEFI variable store option support
Add a driver to read UEFI variables stored in the SMMSTORE region.
This is particullary useful for EDK2 as payload and allows to reuse existing
tools to set/get options used by the firmware.
Test: Could enumerate all existing variables.
Change-Id: I8079f71d29da5dc2db956fc68bef1486fe3906bb
Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com>
---
M src/Kconfig
M src/commonlib/bsd/include/commonlib/bsd/cb_err.h
A src/drivers/efi/Kconfig
A src/drivers/efi/Makefile.inc
A src/drivers/efi/efi.c
A src/drivers/efi/efi.h
A src/drivers/efi/option.c
M src/drivers/smmstore/Makefile.inc
M src/drivers/smmstore/store.c
M src/include/smmstore.h
M src/vendorcode/intel/Makefile.inc
A src/vendorcode/intel/edk2/UDK2017/MdeModulePkg/Include/Guid/VariableFormat.h
A src/vendorcode/intel/edk2/option/option.h
13 files changed, 727 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/52564/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/52564
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8079f71d29da5dc2db956fc68bef1486fe3906bb
Gerrit-Change-Number: 52564
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Martin Roth - Personal <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin Roth - Personal <martinroth(a)google.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Sean Rhodes, Arthur Heymans.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61859 )
Change subject: drivers/smmstore/store.c: Fix static assertion for memory mapped SOCs
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> > If the address is aligned in FMAP, then it won't be aligned when its memory-mapped and problems en […]
The check is probably correct. If the flash chip only supports erasing 64KiB blocks, you want the SMMSTORE to be 64KiB aligned in flash. Flash chips supporting erase a 4KiB block aren't that common.
--
To view, visit https://review.coreboot.org/c/coreboot/+/61859
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I902abd97c0d81ee7c13fa32e57279c8e55c36122
Gerrit-Change-Number: 61859
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Rudolph
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Fri, 11 Feb 2022 13:02:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Rhodes <sean(a)starlabs.systems>
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: comment
Attention is currently required from: Subrata Banik, Ethan Tsao, Ravishankar Sarawadi, Tim Wawrzynczak, Paul Menzel, Raj Astekar, Patrick Rudolph.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61389 )
Change subject: soc/intel/graphics: Create Kconfig for mapping graphic memory base
......................................................................
Patch Set 21:
(3 comments)
Patchset:
PS21:
> LGTM, will wait for Nico to share his thoughts.
Looks ok, just the commit message needs an update, e.g. `soc/intel/graphics:
Repurpose graphics_get_memory_base()`.
File src/soc/intel/common/block/graphics/Kconfig:
https://review.coreboot.org/c/coreboot/+/61389/comment/33fbd869_0fdd6e3e
PS21, Line 22: MEMBASE
MEMBASE seems very vague, and if it's only used for the framebuffer, I'd just
call it like that.
File src/soc/intel/common/block/graphics/graphics.c:
https://review.coreboot.org/c/coreboot/+/61389/comment/3847ec64_7e0e4195
PS21, Line 119: */
Now this comment doesn't say more than the code, could drop it.
--
To view, visit https://review.coreboot.org/c/coreboot/+/61389
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6b1e34ada9b895dabcdc8116d2470e8831ed0a9e
Gerrit-Change-Number: 61389
Gerrit-PatchSet: 21
Gerrit-Owner: Ethan Tsao <ethan.tsao(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Ethan Tsao <ethan.tsao(a)intel.com>
Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Raj Astekar <raj.astekar(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Fri, 11 Feb 2022 13:01:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Gerrit-MessageType: comment