Mike Banon has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44637 )
Change subject: mb/asus/a88xm-e: Disable SeaBIOS options unsupported by hardware
......................................................................
mb/asus/a88xm-e: Disable SeaBIOS options unsupported by hardware
A88XM-E doesn't have any SAS or NVMe controllers and couldn't have a TPM
so it makes sense to disable the related SeaBIOS options for this board.
This reduces the size of compiled SeaBIOS by 129344-110048=19296 bytes.
Signed-off-by: Mike Banon <mikebdp2(a)gmail.com>
Change-Id: Ie9760449734499628637e015cacc0541ec0002a2
---
M src/mainboard/asus/a88xm-e/Kconfig
A src/mainboard/asus/a88xm-e/config_seabios
2 files changed, 11 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/44637/1
diff --git a/src/mainboard/asus/a88xm-e/Kconfig b/src/mainboard/asus/a88xm-e/Kconfig
index 6874e9e..139f989 100644
--- a/src/mainboard/asus/a88xm-e/Kconfig
+++ b/src/mainboard/asus/a88xm-e/Kconfig
@@ -56,4 +56,8 @@
bool
default n
+config PAYLOAD_CONFIGFILE
+ string
+ default "$(top)/src/mainboard/$(MAINBOARDDIR)/config_seabios" if PAYLOAD_SEABIOS
+
endif # BOARD_ASUS_A88XM_E
diff --git a/src/mainboard/asus/a88xm-e/config_seabios b/src/mainboard/asus/a88xm-e/config_seabios
new file mode 100644
index 0000000..03bf0e8
--- /dev/null
+++ b/src/mainboard/asus/a88xm-e/config_seabios
@@ -0,0 +1,7 @@
+###
+### SeaBIOS custom configuration for ASUS A88XM-E
+###
+# CONFIG_MEGASAS is not set
+# CONFIG_NVME is not set
+# CONFIG_TCGBIOS is not set
+#
--
To view, visit https://review.coreboot.org/c/coreboot/+/44637
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie9760449734499628637e015cacc0541ec0002a2
Gerrit-Change-Number: 44637
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-MessageType: newchange
Attention is currently required from: Shelley Chen, Arthur Heymans.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69753 )
Change subject: util/cbfstool: Add zstd support
......................................................................
Patch Set 2:
(2 comments)
File src/commonlib/bsd/zstd/common/bitstream.h:
https://review.coreboot.org/c/coreboot/+/69753/comment/9ba44006_c31ce6ba
PS2, Line 1: /* ******************************************************************
I know we want to keep these as close to the original as possible, but can we add SPDX headers for the files in commonlib? The files in utils I don't mind excluding from the linter, but I'd like to have the SPDX headers on everything in src (outside of vendorcode).
File util/cbfstool/zstd/common/bitstream.h:
https://review.coreboot.org/c/coreboot/+/69753/comment/7d1d2c96_5bebf699
PS2, Line 1: /* ******************************************************************
Do we need two copies of all of these? Can we use the version in commonlib instead?
--
To view, visit https://review.coreboot.org/c/coreboot/+/69753
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I34508268f8767008ef25cb9e466d201345881232
Gerrit-Change-Number: 69753
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Tue, 29 Nov 2022 18:30:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Mike Banon has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44636 )
Change subject: mb/asus/am1i-a: Disable SeaBIOS options unsupported by hardware
......................................................................
mb/asus/am1i-a: Disable SeaBIOS options unsupported by hardware
AM1I-A does not have any SAS or NVMe controllers, so it makes sense
to disable the related SeaBIOS options for this board. This
reduces the size of compiled SeaBIOS by 129344-124096 = 5248 bytes.
Signed-off-by: Mike Banon <mikebdp2(a)gmail.com>
Change-Id: Ideec5d8cf3cf4cc7fba0787e56ab38b5172a5314
---
M src/mainboard/asus/am1i-a/Kconfig
A src/mainboard/asus/am1i-a/config_seabios
2 files changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/44636/1
diff --git a/src/mainboard/asus/am1i-a/Kconfig b/src/mainboard/asus/am1i-a/Kconfig
index 172d808..ff12d74 100644
--- a/src/mainboard/asus/am1i-a/Kconfig
+++ b/src/mainboard/asus/am1i-a/Kconfig
@@ -51,4 +51,8 @@
bool
default n
+config PAYLOAD_CONFIGFILE
+ string
+ default "$(top)/src/mainboard/$(MAINBOARDDIR)/config_seabios" if PAYLOAD_SEABIOS
+
endif # BOARD_ASUS_AM1I_A
diff --git a/src/mainboard/asus/am1i-a/config_seabios b/src/mainboard/asus/am1i-a/config_seabios
new file mode 100644
index 0000000..0ee9cea
--- /dev/null
+++ b/src/mainboard/asus/am1i-a/config_seabios
@@ -0,0 +1,6 @@
+###
+### SeaBIOS custom configuration for ASUS AM1I-A
+###
+# CONFIG_MEGASAS is not set
+# CONFIG_NVME is not set
+#
--
To view, visit https://review.coreboot.org/c/coreboot/+/44636
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ideec5d8cf3cf4cc7fba0787e56ab38b5172a5314
Gerrit-Change-Number: 44636
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-MessageType: newchange
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58745 )
Change subject: G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches
......................................................................
Patch Set 4: Verified+1
(3 comments)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164836):
https://review.coreboot.org/c/coreboot/+/58745/comment/db652b39_b5e128d4
PS4, Line 9: These scripts will help you to securely and conveniently apply three changes
Possible unwrapped commit description (prefer a maximum 72 chars per line)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164836):
https://review.coreboot.org/c/coreboot/+/58745/comment/210f2142_f082353f
PS4, Line 10: CB:57319, CB:58652, CB:58653 - to enable the discrete GPU of AMD Lenovo G505S.
Possible unwrapped commit description (prefer a maximum 72 chars per line)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164836):
https://review.coreboot.org/c/coreboot/+/58745/comment/3d45e130_ca43e4d9
PS4, Line 11: Save to ./coreboot/ then run ./get_dgpu_patches.sh , ./check... and ./apply...
Possible unwrapped commit description (prefer a maximum 72 chars per line)
--
To view, visit https://review.coreboot.org/c/coreboot/+/58745
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I25e1ec5e8bd32cf32d606e5272a4d0383a57ba81
Gerrit-Change-Number: 58745
Gerrit-PatchSet: 4
Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Tue, 29 Nov 2022 18:29:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: AlexandruX Gagniuc, Mike Banon, Alexandru Gagniuc.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58654 )
Change subject: hp/pavilion_m6_1035dx: enable the AMD_DGPU_WITHOUT_EEPROM discrete VGA adapter
......................................................................
Patch Set 3: Verified+1
(1 comment)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164835):
https://review.coreboot.org/c/coreboot/+/58654/comment/f853684e_3be7b6a5
PS3, Line 13: https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/message/KVX…
Possible unwrapped commit description (prefer a maximum 72 chars per line)
--
To view, visit https://review.coreboot.org/c/coreboot/+/58654
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If1b60e83158f64ebc9cf885b629ff89c168b8156
Gerrit-Change-Number: 58654
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: Alexandru Gagniuc <alexandrux.gagniuc(a)intel.com>
Gerrit-Reviewer: AlexandruX Gagniuc <alexandrux.gagniuc(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: AlexandruX Gagniuc <alexandrux.gagniuc(a)intel.com>
Gerrit-Attention: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Attention: Alexandru Gagniuc <alexandrux.gagniuc(a)intel.com>
Gerrit-Comment-Date: Tue, 29 Nov 2022 18:28:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, Alexander Couzens, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58653 )
Change subject: lenovo/g505s: enable the AMD_DGPU_WITHOUT_EEPROM discrete VGA adapter
......................................................................
Patch Set 4: Verified+1
(1 comment)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164834):
https://review.coreboot.org/c/coreboot/+/58653/comment/eca7f034_49ae2044
PS4, Line 13: https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/message/KVX…
Possible unwrapped commit description (prefer a maximum 72 chars per line)
--
To view, visit https://review.coreboot.org/c/coreboot/+/58653
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I53eeef073c15bdcc2a2c76195edb1fa80b00f1a7
Gerrit-Change-Number: 58653
Gerrit-PatchSet: 4
Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Tue, 29 Nov 2022 18:28:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: awokd(a)danwin1210.me, Paul Menzel, Mike Banon.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58652 )
Change subject: src/device/pci: add support for AMD_DGPU_WITHOUT_EEPROM init and OpROM loading
......................................................................
Patch Set 3: Verified+1
(1 comment)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164833):
https://review.coreboot.org/c/coreboot/+/58652/comment/e4e1eaeb_5cfa2e78
PS3, Line 25: Change-Id: Ic0d989185acb83c0987b2d7b6c6d04fb26094290
Possible unwrapped commit description (prefer a maximum 72 chars per line)
--
To view, visit https://review.coreboot.org/c/coreboot/+/58652
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic0d989185acb83c0987b2d7b6c6d04fb26094290
Gerrit-Change-Number: 58652
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: awokd(a)danwin1210.me
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: awokd(a)danwin1210.me
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Comment-Date: Tue, 29 Nov 2022 18:27:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment