coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: soc/amd/mendocino: Update XHCI GPE to use constant
by Matt DeVillier (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Robert Zieba, Jason Glenesk, Raul Rangel, Paul Menzel, Fred Reitberger, Felix Held. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69916 ) Change subject: soc/amd/mendocino: Update XHCI GPE to use constant ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/69916 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3bfc2256ea2ca851afe88f2cdb419f39eee76fdd Gerrit-Change-Number: 69916 Gerrit-PatchSet: 5 Gerrit-Owner: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Robert Zieba <robertzieba(a)google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 29 Nov 2022 17:47:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/amd/mendocino: Enhance DPTC_INPUT to support 13 DPTC thermal para...
by Tim Van Patten (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Jason Glenesk, Jason Nien, EricKY Cheng, Matt DeVillier, Chris Wang, Martin Roth, Fred Reitberger, Felix Held. Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68649 ) Change subject: soc/amd/mendocino: Enhance DPTC_INPUT to support 13 DPTC thermal parameters ...................................................................... Patch Set 31: (1 comment) File src/soc/amd/mendocino/root_complex.c: https://review.coreboot.org/c/coreboot/+/68649/comment/56309812_d9f5a44b PS16, Line 393: #else > IMO we need to refactor the parameter code and allow us to specify the parameters we want to change in the device tree. I like the idea of simplifying in this area and reducing duplication of values, but it needs to be done carefully. For example, low/no battery will throttle the current limits (among others), while the thermal tables will modify other limits. In that case, this type of scenario could occur: 1. Normal Mode, fully unthrottled 1. Thermal limit reached, throttle based on tables B-E 1. Battery drains, throttle SOC 1. Charger is plugged in, battery charges, unthrottle the SOC Step (4) is where the complexity comes in: which parameters need to be restored (and to what values) when there is overlap of modified values between the tables (e.g., `sustained_power_limit_mW`)? Setting every value for each table means we don't need to know which table was previously applied, since none of the old values will persist. In this case, using your example tables, we need to apply both `stt_default_config` (to restore everything, including the VRM limits) and then the appropriate thermal table to apply the desired `sustained_power_limit_mW` (among others). Currently, we only support setting one (full) table at a time, so that logic would need to be updated as well. It's just code, so anything is possible. I'd prefer to leave this as a follow-on improvement though, so we can make progress here and then refactor once we have all of the requirements. -- To view, visit https://review.coreboot.org/c/coreboot/+/68649 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6d6a00f0eca0b0941860b9bc75da41d7a10d60e8 Gerrit-Change-Number: 68649 Gerrit-PatchSet: 31 Gerrit-Owner: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nelson Ye <nelson_ye(a)compal.corp-partner.google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 29 Nov 2022 17:45:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Comment-In-Reply-To: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Comment-In-Reply-To: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Comment-In-Reply-To: Tim Van Patten <timvp(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: util/crossgcc: Add option to get packages from coreboot's mirror
by Martin L Roth (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Felix Singer, Patrick Georgi, Paul Menzel, Angel Pons. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70053 ) Change subject: util/crossgcc: Add option to get packages from coreboot's mirror ...................................................................... Patch Set 2: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/70053/comment/8368464b_6d95e829 PS1, Line 7: util/crossgcc: Add option to get packages from coreboot's mirror > Thank you. I started this one too, to use a local GNU (FTP) mirror [1], and GCC mirror [2]. […] I'm not in favor about adding a flag to override individual URLs, but we could look at letting the BASEURLs be overridden in the environment. We could also look at adding a list of mirrors to try. I'll look at adding those options in a follow-on patch. https://review.coreboot.org/c/coreboot/+/70053/comment/98fca387_f80b3013 PS1, Line 12: > Maybe mention, that sometimes there are problems with the GNU FTP mirrors. Done Patchset: PS1: > It's not just this patch. Others of mine are also affected. […] This was a server issue. It's fixed now. -- To view, visit https://review.coreboot.org/c/coreboot/+/70053 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7df58dca152e7bfe9fde34d290e05b52515b20d9 Gerrit-Change-Number: 70053 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 29 Nov 2022 17:39:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: util/crossgcc: Add option to get packages from coreboot's mirror
by Martin L Roth (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Martin L Roth, Patrick Georgi, Angel Pons. Hello Felix Singer, build bot (Jenkins), Patrick Georgi, Paul Menzel, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70053 to look at the new patch set (#2). Change subject: util/crossgcc: Add option to get packages from coreboot's mirror ...................................................................... util/crossgcc: Add option to get packages from coreboot's mirror coreboot has been keeping a mirror of all the toolchain packages used for releases for quite a while now. This adds an option to fetch the packages from the coreboot mirror directly to buildgcc. This can help with both our releases and when one of the various servers experiences interruptions or changes a path. To do this, the URL and filename needed to be split apart, which led to quite a few changes in the buildgcc script. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I7df58dca152e7bfe9fde34d290e05b52515b20d9 --- M util/crossgcc/Makefile.inc M util/crossgcc/buildgcc 2 files changed, 83 insertions(+), 43 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/70053/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70053 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7df58dca152e7bfe9fde34d290e05b52515b20d9 Gerrit-Change-Number: 70053 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: soc/intel/meteorlake: Refactor `pmc_lockdown_cfg` function
by Kapil Porwal (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Tarun Tuli, Subrata Banik. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70132 ) Change subject: soc/intel/meteorlake: Refactor `pmc_lockdown_cfg` function ...................................................................... Patch Set 5: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/70132 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3622748d8fecef69c60bb3fe9bfe68fc126764b7 Gerrit-Change-Number: 70132 Gerrit-PatchSet: 5 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Tue, 29 Nov 2022 17:28:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/xcompile: Add --no-warn-rwx-segments to arm64 LD params
by Martin L Roth (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Felix Singer. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67820 ) Change subject: util/xcompile: Add --no-warn-rwx-segments to arm64 LD params ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Felix, Please go ahead and take over the patch, I haven't had time to work on it. -- To view, visit https://review.coreboot.org/c/coreboot/+/67820 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5ca9f0cc6cdc45161b0edf892c4b4a76d50e57bf Gerrit-Change-Number: 67820 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Tue, 29 Nov 2022 17:17:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/skyrim/var/frostflow: Update RAM ID table
by Karthik Ramasubramanian (Code Review) 29 Nov '22

29 Nov '22

Karthik Ramasubramanian has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68664 ) Change subject: mb/google/skyrim/var/frostflow: Update RAM ID table ...................................................................... mb/google/skyrim/var/frostflow: Update RAM ID table Add new ram_id:0100 for memory Samsung K3LKBKB0BM-MGCP. Add new ram_id:0101 for memory Samsung K3LKCKC0BM-MGCP. The RAM ID table has been assigned as: DRAM Part Name ID to assign MT62F512M32D2DR-031 WT:B 0 (0000) H9JCNNNBK3MLYR-N6E 0 (0000) MT62F1G32D4DR-031 WT:B 1 (0001) H9JCNNNCP3MLYR-N6E 1 (0001) MT62F2G32D8DR-031 WT:B 2 (0010) H9JCNNNFA5MLYR-N6E 3 (0011) K3LKBKB0BM-MGCP 4 (0100) K3LKCKC0BM-MGCP 5 (0101) BUG=b:254758998 BRANCH=None TEST=FW_NAME=frostflow emerge-skyrim coreboot Signed-off-by: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Change-Id: I8ff879ff7185f5a0ca1b9632820aba3b0f5d02c6 Reviewed-on: https://review.coreboot.org/c/coreboot/+/68664 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Karthik Ramasubramanian <kramasub(a)google.com> Reviewed-by: Jon Murphy <jpmurphy(a)google.com> Reviewed-by: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Reviewed-by: John Su <john_su(a)compal.corp-partner.google.com> --- M src/mainboard/google/skyrim/variants/frostflow/memory/Makefile.inc M src/mainboard/google/skyrim/variants/frostflow/memory/dram_id.generated.txt M src/mainboard/google/skyrim/variants/frostflow/memory/mem_parts_used.txt 3 files changed, 39 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified John Su: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved Dtrain Hsu: Looks good to me, approved Jon Murphy: Looks good to me, approved diff --git a/src/mainboard/google/skyrim/variants/frostflow/memory/Makefile.inc b/src/mainboard/google/skyrim/variants/frostflow/memory/Makefile.inc index f6c1d1a..23382dc 100644 --- a/src/mainboard/google/skyrim/variants/frostflow/memory/Makefile.inc +++ b/src/mainboard/google/skyrim/variants/frostflow/memory/Makefile.inc @@ -8,3 +8,5 @@ SPD_SOURCES += spd/lp5/set-1/spd-2.hex # ID = 1(0b0001) Parts = MT62F1G32D4DR-031 WT:B, H9JCNNNCP3MLYR-N6E SPD_SOURCES += spd/lp5/set-1/spd-4.hex # ID = 2(0b0010) Parts = MT62F2G32D8DR-031 WT:B SPD_SOURCES += spd/lp5/set-1/spd-9.hex # ID = 3(0b0011) Parts = H9JCNNNFA5MLYR-N6E +SPD_SOURCES += spd/lp5/set-1/spd-3.hex # ID = 4(0b0100) Parts = K3LKBKB0BM-MGCP +SPD_SOURCES += spd/lp5/set-1/spd-6.hex # ID = 5(0b0101) Parts = K3LKCKC0BM-MGCP diff --git a/src/mainboard/google/skyrim/variants/frostflow/memory/dram_id.generated.txt b/src/mainboard/google/skyrim/variants/frostflow/memory/dram_id.generated.txt index 1384f14..8a415d4 100644 --- a/src/mainboard/google/skyrim/variants/frostflow/memory/dram_id.generated.txt +++ b/src/mainboard/google/skyrim/variants/frostflow/memory/dram_id.generated.txt @@ -10,3 +10,5 @@ H9JCNNNCP3MLYR-N6E 1 (0001) MT62F2G32D8DR-031 WT:B 2 (0010) H9JCNNNFA5MLYR-N6E 3 (0011) +K3LKBKB0BM-MGCP 4 (0100) +K3LKCKC0BM-MGCP 5 (0101) diff --git a/src/mainboard/google/skyrim/variants/frostflow/memory/mem_parts_used.txt b/src/mainboard/google/skyrim/variants/frostflow/memory/mem_parts_used.txt index c1e7c07..a0e7ae0 100644 --- a/src/mainboard/google/skyrim/variants/frostflow/memory/mem_parts_used.txt +++ b/src/mainboard/google/skyrim/variants/frostflow/memory/mem_parts_used.txt @@ -4,3 +4,5 @@ H9JCNNNCP3MLYR-N6E, MT62F2G32D8DR-031 WT:B, H9JCNNNFA5MLYR-N6E, +K3LKBKB0BM-MGCP, +K3LKCKC0BM-MGCP, -- To view, visit https://review.coreboot.org/c/coreboot/+/68664 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8ff879ff7185f5a0ca1b9632820aba3b0f5d02c6 Gerrit-Change-Number: 68664 Gerrit-PatchSet: 3 Gerrit-Owner: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[master]: Documentation: Add wake source info to device tree documentation
by Jon Murphy (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Raul Rangel, Dmitry Torokhov, Tim Wawrzynczak, Paul Menzel, Tim Van Patten, Karthik Ramasubramanian. Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67385 ) Change subject: Documentation: Add wake source info to device tree documentation ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67385 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifcdbd5371408784bf9b81c1ade90263de8c60e0f Gerrit-Change-Number: 67385 Gerrit-PatchSet: 6 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Dmitry Torokhov <dtor(a)chromium.org> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Mark Hasemeyer <markhas(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Robert Zieba <robertzieba(a)google.com> Gerrit-CC: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Dmitry Torokhov <dtor(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Tue, 29 Nov 2022 17:12:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Documentation: Add wake source info to device tree documentation
by Raul Rangel (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Dmitry Torokhov, Tim Wawrzynczak, Paul Menzel, Tim Van Patten, Karthik Ramasubramanian. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67385 ) Change subject: Documentation: Add wake source info to device tree documentation ...................................................................... Patch Set 5: (1 comment) File Documentation/drivers/dt_entries.md: https://review.coreboot.org/c/coreboot/+/67385/comment/6be1c686_60d4edc7 PS5, Line 233: feasible. The other option is to wake a wake capable GPIO as describes below. > 'wake a wake' is confusing, can we say use a wake capable GPIO or something similar? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/67385 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifcdbd5371408784bf9b81c1ade90263de8c60e0f Gerrit-Change-Number: 67385 Gerrit-PatchSet: 5 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Dmitry Torokhov <dtor(a)chromium.org> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Mark Hasemeyer <markhas(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Robert Zieba <robertzieba(a)google.com> Gerrit-CC: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Dmitry Torokhov <dtor(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Tue, 29 Nov 2022 17:10:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jon Murphy <jpmurphy(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Documentation: Add wake source info to device tree documentation
by Raul Rangel (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Raul Rangel, Dmitry Torokhov, Tim Wawrzynczak, Paul Menzel, Tim Van Patten, Karthik Ramasubramanian. Hello build bot (Jenkins), Dmitry Torokhov, Jon Murphy, Tim Wawrzynczak, Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/67385 to look at the new patch set (#6). Change subject: Documentation: Add wake source info to device tree documentation ...................................................................... Documentation: Add wake source info to device tree documentation The device tree documentation was promoting using a GPIO wake event and a GPE wake event. We should only ever have one. This wasn't actually causing a problem because the wake bit was set on the `irq` property, but the IO-APIC can't actually wake the system, so it was a no-op. This change fixes up the markdown so it's formatted correctly, and also adds a section explaining what the different wake configurations are. BUG=b:243700486 TEST=mdformat Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> Change-Id: Ifcdbd5371408784bf9b81c1ade90263de8c60e0f --- M Documentation/drivers/dt_entries.md 1 file changed, 113 insertions(+), 22 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/67385/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/67385 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifcdbd5371408784bf9b81c1ade90263de8c60e0f Gerrit-Change-Number: 67385 Gerrit-PatchSet: 6 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Dmitry Torokhov <dtor(a)chromium.org> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Mark Hasemeyer <markhas(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Robert Zieba <robertzieba(a)google.com> Gerrit-CC: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Dmitry Torokhov <dtor(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022