Attention is currently required from: Shelley Chen, Arthur Heymans.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69753 )
Change subject: util/cbfstool: Add zstd support ......................................................................
Patch Set 2:
(2 comments)
File src/commonlib/bsd/zstd/common/bitstream.h:
https://review.coreboot.org/c/coreboot/+/69753/comment/9ba44006_c31ce6ba PS2, Line 1: /* ****************************************************************** I know we want to keep these as close to the original as possible, but can we add SPDX headers for the files in commonlib? The files in utils I don't mind excluding from the linter, but I'd like to have the SPDX headers on everything in src (outside of vendorcode).
File util/cbfstool/zstd/common/bitstream.h:
https://review.coreboot.org/c/coreboot/+/69753/comment/7d1d2c96_5bebf699 PS2, Line 1: /* ****************************************************************** Do we need two copies of all of these? Can we use the version in commonlib instead?
-
Martin L Roth (Code Review)