Attention is currently required from: Raul Rangel, Dmitry Torokhov, Tim Wawrzynczak, Paul Menzel, Tim Van Patten.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67385 )
Change subject: Documentation: Add wake source info to device tree documentation
......................................................................
Patch Set 7:
(2 comments)
File Documentation/drivers/dt_entries.md:
https://review.coreboot.org/c/coreboot/+/67385/comment/ecbe8f7d_cf35e1e0
PS7, Line 130: "Level" and "Active"
Nit: "Trigger" and "Polarity"
https://review.coreboot.org/c/coreboot/+/67385/comment/760f9477_e55b19e5
PS7, Line 208: method
Nit: methods
--
To view, visit https://review.coreboot.org/c/coreboot/+/67385
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifcdbd5371408784bf9b81c1ade90263de8c60e0f
Gerrit-Change-Number: 67385
Gerrit-PatchSet: 7
Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Dmitry Torokhov <dtor(a)chromium.org>
Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Mark Hasemeyer <markhas(a)google.com>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Robert Zieba <robertzieba(a)google.com>
Gerrit-CC: Tim Van Patten <timvp(a)google.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Dmitry Torokhov <dtor(a)chromium.org>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Van Patten <timvp(a)google.com>
Gerrit-Comment-Date: Wed, 30 Nov 2022 05:58:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Subrata Banik, Angel Pons, Arthur Heymans, Eric Lai, Lean Sheng Tan.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69978 )
Change subject: soc/intel/cmn/cse: Allow to perform essential CSE operations post EOP
......................................................................
Patch Set 5:
(1 comment)
File src/soc/intel/common/block/cse/cse_eop.c:
https://review.coreboot.org/c/coreboot/+/69978/comment/cda7e074_ed8eb88d
PS5, Line 244: if (CONFIG(SOC_INTEL_CSE_SEND_EOP_LATE))
: cse_late_finalize();
> > This code has to be decoupled or function name must be renamed to reflect new addition. […]
You may rename the function as cse_send_eop_and_late_finalize ..
--
To view, visit https://review.coreboot.org/c/coreboot/+/69978
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If4c4564befcd38732368b21f1ca3e24b68c30e0c
Gerrit-Change-Number: 69978
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Comment-Date: Wed, 30 Nov 2022 04:40:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-MessageType: comment
Attention is currently required from: Shelley Chen, Taniya Das, Paul Menzel, Julius Werner, Sudheer Amrabadi.
Venkat Thogaru has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68384 )
Change subject: soc/qualcomm/sc7280: Add API to differentialize PRO and NON_PRO SKUs
......................................................................
Patch Set 15:
(1 comment)
File src/soc/qualcomm/sc7280/socinfo.c:
https://review.coreboot.org/c/coreboot/+/68384/comment/401039f4_392f7924
PS4, Line 12: static struct chipinfo chipinfolut[] = {
> Sure. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/68384
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id9f23696384a6c1a89000292eafebd8a16c273ca
Gerrit-Change-Number: 68384
Gerrit-PatchSet: 15
Gerrit-Owner: Sudheer Amrabadi <samrabad(a)codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Taniya Das <quic_tdas(a)quicinc.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Taniya Das <tdas(a)qualcomm.corp-partner.google.com>
Gerrit-CC: Venkat Thogaru <thogaru(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Taniya Das <quic_tdas(a)quicinc.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Taniya Das <tdas(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org>
Gerrit-Comment-Date: Wed, 30 Nov 2022 04:38:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen <shchen(a)google.com>
Comment-In-Reply-To: Venkat Thogaru <thogaru(a)qualcomm.corp-partner.google.com>
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Comment-In-Reply-To: Taniya Das <tdas(a)qualcomm.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Yu-Ping Wu.
Hsuan-ting Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70145 )
Change subject: commonlib: Add essential comments for ELOG_CROS_DIAG_RESULT
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/70145/comment/07cafeaa_61e7755d
PS1, Line 13: guidelines
The guideline is at https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/his…
Not knowing how to put long URL on commit message.
--
To view, visit https://review.coreboot.org/c/coreboot/+/70145
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1a1a7c863d5aa9496649f81dc94fd79a6ad482df
Gerrit-Change-Number: 70145
Gerrit-PatchSet: 1
Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-CC: Hsuan Ting Chen <roccochen(a)chromium.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Wed, 30 Nov 2022 03:57:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Hsuan-ting Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/70145 )
Change subject: commonlib: Add essential comments for ELOG_CROS_DIAG_RESULT
......................................................................
commonlib: Add essential comments for ELOG_CROS_DIAG_RESULT
ELOG_CROS_DIAG_RESULT_* codes should be consistent with the enum
definition of enumerated histograms.
Hence add comments based on the requirements of enum histograms in
histogram guidelines.
BUG=b:4047421
TEST=none
Change-Id: I1a1a7c863d5aa9496649f81dc94fd79a6ad482df
---
M src/commonlib/bsd/include/commonlib/bsd/elog.h
1 file changed, 24 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/70145/1
diff --git a/src/commonlib/bsd/include/commonlib/bsd/elog.h b/src/commonlib/bsd/include/commonlib/bsd/elog.h
index 06ea5a7..1f39090 100644
--- a/src/commonlib/bsd/include/commonlib/bsd/elog.h
+++ b/src/commonlib/bsd/include/commonlib/bsd/elog.h
@@ -316,7 +316,12 @@
#define ELOG_CROS_DIAG_TYPE_STORAGE_TEST_EXTENDED 0x03
#define ELOG_CROS_DIAG_TYPE_MEMORY_QUICK 0x04
#define ELOG_CROS_DIAG_TYPE_MEMORY_FULL 0x05
-/* Result codes for elog_event_cros_diag_log in ELOG_CROS_DIAGNOSTICS_LOGS */
+/*
+ * Result codes for elog_event_cros_diag_log in ELOG_CROS_DIAGNOSTICS_LOGS
+ *
+ * These values are persisted to logs. Entries should not be renumbered and
+ * numeric values should never be reused.
+ */
#define ELOG_CROS_DIAG_RESULT_PASSED 0x01
#define ELOG_CROS_DIAG_RESULT_ERROR 0x02
#define ELOG_CROS_DIAG_RESULT_FAILED 0x03
--
To view, visit https://review.coreboot.org/c/coreboot/+/70145
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1a1a7c863d5aa9496649f81dc94fd79a6ad482df
Gerrit-Change-Number: 70145
Gerrit-PatchSet: 1
Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com>
Gerrit-CC: Hsuan Ting Chen <roccochen(a)chromium.org>
Gerrit-MessageType: newchange
Attention is currently required from: Tarun Tuli, Raymond Chung, Paul Menzel, Zhuohao Lee.
Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69964 )
Change subject: mb/google/brya/var/gaelin: Configure audio in devicetree
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/brya/variants/gaelin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/69964/comment/b6a3b4e8_2afcf009
PS3, Line 239: device ref hda on
does it necessary to turn hda on? I think it's for sound wire device, ALC1015 uses i2s only?
--
To view, visit https://review.coreboot.org/c/coreboot/+/69964
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc8cacce6cb4b3e55fc7332bb9eb9ac20848fc5b
Gerrit-Change-Number: 69964
Gerrit-PatchSet: 3
Gerrit-Owner: Raymond Chung <raymondchung(a)ami.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com>
Gerrit-Reviewer: Raymond Chung <raymondchung(a)ami.corp-partner.google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Bruce Chiang <brucechiang(a)msi.corp-partner.google.com>
Gerrit-CC: Eason Chang <easonchang(a)msi.corp-partner.google.com>
Gerrit-CC: Eddy Lu <eddylu(a)ami.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Raymond Chung <raymondchung(a)ami.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Comment-Date: Wed, 30 Nov 2022 03:23:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment