coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: nb/intel/pineview: Use {true,false} instead of {0,1}
by Eric Lai (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Angel Pons, Elyes Haouas. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70148 ) Change subject: nb/intel/pineview: Use {true,false} instead of {0,1} ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70148 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5b5b42c27351331ad40fbe92fb87390cb1284aa9 Gerrit-Change-Number: 70148 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Wed, 30 Nov 2022 07:32:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex: Add PCIe based SD controller
by Subrata Banik (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Tarun Tuli, Kapil Porwal, Ivy Jian. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70064 ) Change subject: mb/google/rex: Add PCIe based SD controller ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/rex/variants/rex0/gpio.c: https://review.coreboot.org/c/coreboot/+/70064/comment/592af4ad_cd3a3fcf PS2, Line 434: static const struct pad_config romstage_gpio_table_id0[] = { > Will we increase board_id to 1 or keepping 0 for proto 1 ?, I see b/245158908#comment13 from YH, BOARD_VERSION: 1 Good point @Ivy, can you please create a bug and assign to me ? -- To view, visit https://review.coreboot.org/c/coreboot/+/70064 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I23d53e4d61ec36d2145f9e5816d97d13eb5b219e Gerrit-Change-Number: 70064 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 30 Nov 2022 07:30:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: google/veyron: Fix add type to function definition
by Eric Lai (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Arthur Heymans. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70138 ) Change subject: google/veyron: Fix add type to function definition ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70138 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2efb42e653b0deb56ba6b0c9789764a9cabc552e Gerrit-Change-Number: 70138 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Wed, 30 Nov 2022 07:30:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: google/veyron: Fix add type to function definition
by Elyes Haouas (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Arthur Heymans. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70138 ) Change subject: google/veyron: Fix add type to function definition ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70138 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2efb42e653b0deb56ba6b0c9789764a9cabc552e Gerrit-Change-Number: 70138 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Wed, 30 Nov 2022 07:27:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: drivers/intel/gma/gma.h: Use bool for use_spread_spectrum_clock
by Elyes Haouas (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Stefan Ott, Felix Singer, Tim Crawford, Jeremy Soller, Jonathon Hall, Michael Niewöhner, Evgeny Zinoviev, Alexander Couzens. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70150 ) Change subject: drivers/intel/gma/gma.h: Use bool for use_spread_spectrum_clock ...................................................................... Patch Set 2: Code-Review-1 -- To view, visit https://review.coreboot.org/c/coreboot/+/70150 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie330ec2258c0083e225032ed0d53d51163491378 Gerrit-Change-Number: 70150 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Stefan Ott <coreboot(a)desire.ch> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Stefan Ott <coreboot(a)desire.ch> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 30 Nov 2022 07:26:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: drivers/intel/gma/gma.h: Use bool for use_spread_spectrum_clock
by Elyes Haouas (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Stefan Ott, Felix Singer, Tim Crawford, Jeremy Soller, Jonathon Hall, Michael Niewöhner, Evgeny Zinoviev, Alexander Couzens. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70150 ) Change subject: drivers/intel/gma/gma.h: Use bool for use_spread_spectrum_clock ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Humm ... it needs to change also the bdb_general_features struct -- To view, visit https://review.coreboot.org/c/coreboot/+/70150 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie330ec2258c0083e225032ed0d53d51163491378 Gerrit-Change-Number: 70150 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Stefan Ott <coreboot(a)desire.ch> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Stefan Ott <coreboot(a)desire.ch> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 30 Nov 2022 07:24:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/cmn/cse: Allow to perform essential CSE operations post EOP
by Subrata Banik (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Tarun Tuli, Sridhar Siricilla, Angel Pons, Arthur Heymans, Eric Lai, Lean Sheng Tan. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69978 ) Change subject: soc/intel/cmn/cse: Allow to perform essential CSE operations post EOP ...................................................................... Patch Set 6: (1 comment) File src/soc/intel/common/block/cse/cse_eop.c: https://review.coreboot.org/c/coreboot/+/69978/comment/f1dc11cd_d30067b2 PS6, Line 241: send_cse_eop_with_late_finalize > nit: It is better function prefixed with cse_*. I would prefer to keep the name starting with a `verb` instead of `cse` at starting. Refer to the line #174, #202. -- To view, visit https://review.coreboot.org/c/coreboot/+/69978 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If4c4564befcd38732368b21f1ca3e24b68c30e0c Gerrit-Change-Number: 69978 Gerrit-PatchSet: 6 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Wed, 30 Nov 2022 07:21:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: drivers/intel/gma/gma.h: Use bool for use_spread_spectrum_clock
by Elyes Haouas (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Stefan Ott, Felix Singer, Tim Crawford, Jeremy Soller, Jonathon Hall, Michael Niewöhner, Evgeny Zinoviev, Alexander Couzens. Hello Felix Singer, Stefan Ott, Tim Crawford, Jeremy Soller, Jonathon Hall, Michael Niewöhner, Alexander Couzens, Evgeny Zinoviev, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70150 to look at the new patch set (#2). Change subject: drivers/intel/gma/gma.h: Use bool for use_spread_spectrum_clock ...................................................................... drivers/intel/gma/gma.h: Use bool for use_spread_spectrum_clock Change-Id: Ie330ec2258c0083e225032ed0d53d51163491378 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/drivers/intel/gma/gma.h M src/mainboard/acer/aspire_vn7_572g/devicetree.cb M src/mainboard/apple/macbook21/devicetree.cb M src/mainboard/apple/macbookair4_2/devicetree.cb M src/mainboard/asrock/b75pro3-m/devicetree.cb M src/mainboard/clevo/kbl-u/variants/n13xwu/devicetree.cb M src/mainboard/compulab/intense_pc/devicetree.cb M src/mainboard/foxconn/d41s/devicetree.cb M src/mainboard/google/auron/devicetree.cb M src/mainboard/google/butterfly/devicetree.cb M src/mainboard/google/cyan/devicetree.cb M src/mainboard/google/eve/devicetree.cb M src/mainboard/google/glados/devicetree.cb M src/mainboard/google/link/devicetree.cb M src/mainboard/google/parrot/devicetree.cb M src/mainboard/google/poppy/variants/atlas/devicetree.cb M src/mainboard/google/poppy/variants/baseboard/devicetree.cb M src/mainboard/google/poppy/variants/nami/devicetree.cb M src/mainboard/google/poppy/variants/nautilus/devicetree.cb M src/mainboard/google/poppy/variants/nocturne/devicetree.cb M src/mainboard/google/poppy/variants/rammus/devicetree.cb M src/mainboard/google/poppy/variants/soraka/devicetree.cb M src/mainboard/google/rambi/devicetree.cb M src/mainboard/google/slippy/devicetree.cb M src/mainboard/google/stout/devicetree.cb M src/mainboard/hp/compaq_8200_elite_sff/devicetree.cb M src/mainboard/hp/folio_9480m/devicetree.cb M src/mainboard/hp/snb_ivb_laptops/devicetree.cb M src/mainboard/hp/z220_series/devicetree.cb M src/mainboard/ibase/mb899/devicetree.cb M src/mainboard/intel/baskingridge/devicetree.cb M src/mainboard/intel/d510mo/devicetree.cb M src/mainboard/intel/dcp847ske/devicetree.cb M src/mainboard/intel/emeraldlake2/devicetree.cb M src/mainboard/kontron/986lcd-m/devicetree.cb M src/mainboard/kontron/ktqm77/devicetree.cb M src/mainboard/lenovo/haswell/variants/t440p/devicetree.cb M src/mainboard/lenovo/haswell/variants/w541/devicetree.cb M src/mainboard/lenovo/l520/devicetree.cb M src/mainboard/lenovo/s230u/devicetree.cb M src/mainboard/lenovo/t400/devicetree.cb M src/mainboard/lenovo/t410/devicetree.cb M src/mainboard/lenovo/t420/devicetree.cb M src/mainboard/lenovo/t420s/devicetree.cb M src/mainboard/lenovo/t430/devicetree.cb M src/mainboard/lenovo/t430s/devicetree.cb M src/mainboard/lenovo/t520/devicetree.cb M src/mainboard/lenovo/t530/devicetree.cb M src/mainboard/lenovo/t60/devicetree.cb M src/mainboard/lenovo/x131e/devicetree.cb M src/mainboard/lenovo/x1_carbon_gen1/devicetree.cb M src/mainboard/lenovo/x200/devicetree.cb M src/mainboard/lenovo/x201/devicetree.cb M src/mainboard/lenovo/x220/devicetree.cb M src/mainboard/lenovo/x230/devicetree.cb M src/mainboard/lenovo/x60/devicetree.cb M src/mainboard/packardbell/ms2290/devicetree.cb M src/mainboard/purism/librem_bdw/devicetree.cb M src/mainboard/purism/librem_skl/devicetree.cb M src/mainboard/roda/rk886ex/devicetree.cb M src/mainboard/roda/rk9/devicetree.cb M src/mainboard/samsung/lumpy/devicetree.cb M src/mainboard/supermicro/x9sae/devicetree.cb M src/mainboard/system76/whl-u/devicetree.cb 64 files changed, 75 insertions(+), 65 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/70150/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70150 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie330ec2258c0083e225032ed0d53d51163491378 Gerrit-Change-Number: 70150 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Stefan Ott <coreboot(a)desire.ch> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Stefan Ott <coreboot(a)desire.ch> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[master]: mb/intel/mtlrvp: Enable EC and building ChromeOS
by Subrata Banik (Code Review) 29 Nov '22

29 Nov '22

Attention is currently required from: Wonkyu Kim, Ravishankar Sarawadi, Rizwan Qureshi, Paul Menzel, Angel Pons, Krishna P Bhat D, Tim Wawrzynczak, Tarun Tuli, Jamie Ryu, Harsha B R, Kapil Porwal, Nick Vaccaro, Ronak Kanabar, Usha P, Raj Astekar. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66101 ) Change subject: mb/intel/mtlrvp: Enable EC and building ChromeOS ...................................................................... Patch Set 17: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/66101/comment/b874617f_b897191d PS17, Line 12: util/abuild/abuild -p none -t intel/mtlrvp -a -c max I don't agree that this code is actually created based on the abuild. Sample CL: https://review.coreboot.org/c/coreboot/+/64591 -- To view, visit https://review.coreboot.org/c/coreboot/+/66101 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I662d7f79050d35e152d97dc5c2118a4af56223bc Gerrit-Change-Number: 66101 Gerrit-PatchSet: 17 Gerrit-Owner: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-CC: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Usha P <usha.p(a)intel.com> Gerrit-Attention: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Comment-Date: Wed, 30 Nov 2022 07:18:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: drivers/intel/gma/gma.h: Use bool for use_spread_spectrum_clock
by Elyes Haouas (Code Review) 29 Nov '22

29 Nov '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/70150 ) Change subject: drivers/intel/gma/gma.h: Use bool for use_spread_spectrum_clock ...................................................................... drivers/intel/gma/gma.h: Use bool for use_spread_spectrum_clock Change-Id: Ie330ec2258c0083e225032ed0d53d51163491378 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/drivers/intel/gma/gma.h M src/mainboard/apple/macbook21/devicetree.cb M src/mainboard/clevo/kbl-u/variants/n13xwu/devicetree.cb M src/mainboard/compulab/intense_pc/devicetree.cb M src/mainboard/google/auron/devicetree.cb M src/mainboard/google/butterfly/devicetree.cb M src/mainboard/google/cyan/devicetree.cb M src/mainboard/google/eve/devicetree.cb M src/mainboard/google/glados/devicetree.cb M src/mainboard/google/link/devicetree.cb M src/mainboard/google/parrot/devicetree.cb M src/mainboard/google/poppy/variants/atlas/devicetree.cb M src/mainboard/google/poppy/variants/baseboard/devicetree.cb M src/mainboard/google/poppy/variants/nami/devicetree.cb M src/mainboard/google/poppy/variants/nautilus/devicetree.cb M src/mainboard/google/poppy/variants/nocturne/devicetree.cb M src/mainboard/google/poppy/variants/rammus/devicetree.cb M src/mainboard/google/poppy/variants/soraka/devicetree.cb M src/mainboard/google/rambi/devicetree.cb M src/mainboard/google/slippy/devicetree.cb M src/mainboard/google/stout/devicetree.cb M src/mainboard/hp/folio_9480m/devicetree.cb M src/mainboard/ibase/mb899/devicetree.cb M src/mainboard/intel/baskingridge/devicetree.cb M src/mainboard/intel/dcp847ske/devicetree.cb M src/mainboard/intel/emeraldlake2/devicetree.cb M src/mainboard/kontron/986lcd-m/devicetree.cb M src/mainboard/kontron/ktqm77/devicetree.cb M src/mainboard/lenovo/haswell/variants/t440p/devicetree.cb M src/mainboard/lenovo/haswell/variants/w541/devicetree.cb M src/mainboard/lenovo/l520/devicetree.cb M src/mainboard/lenovo/s230u/devicetree.cb M src/mainboard/lenovo/t400/devicetree.cb M src/mainboard/lenovo/t410/devicetree.cb M src/mainboard/lenovo/t420/devicetree.cb M src/mainboard/lenovo/t420s/devicetree.cb M src/mainboard/lenovo/t430/devicetree.cb M src/mainboard/lenovo/t430s/devicetree.cb M src/mainboard/lenovo/t520/devicetree.cb M src/mainboard/lenovo/t530/devicetree.cb M src/mainboard/lenovo/t60/devicetree.cb M src/mainboard/lenovo/x131e/devicetree.cb M src/mainboard/lenovo/x1_carbon_gen1/devicetree.cb M src/mainboard/lenovo/x200/devicetree.cb M src/mainboard/lenovo/x201/devicetree.cb M src/mainboard/lenovo/x220/devicetree.cb M src/mainboard/lenovo/x230/devicetree.cb M src/mainboard/lenovo/x60/devicetree.cb M src/mainboard/packardbell/ms2290/devicetree.cb M src/mainboard/purism/librem_bdw/devicetree.cb M src/mainboard/purism/librem_skl/devicetree.cb M src/mainboard/roda/rk886ex/devicetree.cb M src/mainboard/roda/rk9/devicetree.cb M src/mainboard/samsung/lumpy/devicetree.cb M src/mainboard/supermicro/x9sae/devicetree.cb M src/mainboard/system76/whl-u/devicetree.cb 56 files changed, 67 insertions(+), 57 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/70150/1 diff --git a/src/drivers/intel/gma/gma.h b/src/drivers/intel/gma/gma.h index a39198c..46dacb4 100644 --- a/src/drivers/intel/gma/gma.h +++ b/src/drivers/intel/gma/gma.h @@ -3,10 +3,10 @@ #ifndef _GMA_H_ #define _GMA_H_ -#include <stdint.h> +#include <types.h> struct i915_gpu_controller_info { - int use_spread_spectrum_clock; + bool use_spread_spectrum_clock; int ndid; u32 did[5]; }; diff --git a/src/mainboard/apple/macbook21/devicetree.cb b/src/mainboard/apple/macbook21/devicetree.cb index ab29a15..a4c35f0 100644 --- a/src/mainboard/apple/macbook21/devicetree.cb +++ b/src/mainboard/apple/macbook21/devicetree.cb @@ -2,7 +2,7 @@ chip northbridge/intel/i945 # IGD Displays - register "gfx" = "GMA_STATIC_DISPLAYS(0)" + register "gfx" = "GMA_STATIC_DISPLAYS(false)" register "gpu_hotplug" = "0x00000220" register "gpu_lvds_use_spread_spectrum_clock" = "true" diff --git a/src/mainboard/clevo/kbl-u/variants/n13xwu/devicetree.cb b/src/mainboard/clevo/kbl-u/variants/n13xwu/devicetree.cb index d22f574..6eabe60 100644 --- a/src/mainboard/clevo/kbl-u/variants/n13xwu/devicetree.cb +++ b/src/mainboard/clevo/kbl-u/variants/n13xwu/devicetree.cb @@ -11,7 +11,7 @@ }" # IGD Displays - register "gfx" = "GMA_STATIC_DISPLAYS(0)" + register "gfx" = "GMA_STATIC_DISPLAYS(false)" # FSP Configuration register "SkipExtGfxScan" = "1" diff --git a/src/mainboard/compulab/intense_pc/devicetree.cb b/src/mainboard/compulab/intense_pc/devicetree.cb index af21a72..2b51980 100644 --- a/src/mainboard/compulab/intense_pc/devicetree.cb +++ b/src/mainboard/compulab/intense_pc/devicetree.cb @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-only chip northbridge/intel/sandybridge # FIXME: check gfx - register "gfx" = "GMA_STATIC_DISPLAYS(0)" + register "gfx" = "GMA_STATIC_DISPLAYS(false)" register "gpu_dp_b_hotplug" = "4" register "gpu_dp_c_hotplug" = "4" register "gpu_dp_d_hotplug" = "4" diff --git a/src/mainboard/google/auron/devicetree.cb b/src/mainboard/google/auron/devicetree.cb index 2ded452..f0ef042 100644 --- a/src/mainboard/google/auron/devicetree.cb +++ b/src/mainboard/google/auron/devicetree.cb @@ -1,7 +1,7 @@ chip soc/intel/broadwell # IGD Displays - register "gfx" = "GMA_STATIC_DISPLAYS(0)" + register "gfx" = "GMA_STATIC_DISPLAYS(false)" # Enable eDP Hotplug with 6ms pulse register "gpu_dp_d_hotplug" = "0x06" diff --git a/src/mainboard/google/butterfly/devicetree.cb b/src/mainboard/google/butterfly/devicetree.cb index c79526e..fe14a2f 100644 --- a/src/mainboard/google/butterfly/devicetree.cb +++ b/src/mainboard/google/butterfly/devicetree.cb @@ -1,6 +1,6 @@ chip northbridge/intel/sandybridge # IGD Displays - register "gfx" = "GMA_STATIC_DISPLAYS(0)" + register "gfx" = "GMA_STATIC_DISPLAYS(false)" # Enable DisplayPort Hotplug with 6ms pulse register "gpu_dp_d_hotplug" = "0x06" diff --git a/src/mainboard/google/cyan/devicetree.cb b/src/mainboard/google/cyan/devicetree.cb index c968dfc..827039c 100644 --- a/src/mainboard/google/cyan/devicetree.cb +++ b/src/mainboard/google/cyan/devicetree.cb @@ -1,7 +1,7 @@ chip soc/intel/braswell # IGD Displays - register "gfx" = "GMA_STATIC_DISPLAYS(0)" + register "gfx" = "GMA_STATIC_DISPLAYS(false)" ############################################################ # Set the parameters for MemoryInit diff --git a/src/mainboard/google/eve/devicetree.cb b/src/mainboard/google/eve/devicetree.cb index 1e9ffd9..899f74e 100644 --- a/src/mainboard/google/eve/devicetree.cb +++ b/src/mainboard/google/eve/devicetree.cb @@ -1,7 +1,7 @@ chip soc/intel/skylake # IGD Displays - register "gfx" = "GMA_STATIC_DISPLAYS(0)" + register "gfx" = "GMA_STATIC_DISPLAYS(false)" register "panel_cfg" = "{ .up_delay_ms = 100, diff --git a/src/mainboard/google/glados/devicetree.cb b/src/mainboard/google/glados/devicetree.cb index 9a3e619..9b5198d 100644 --- a/src/mainboard/google/glados/devicetree.cb +++ b/src/mainboard/google/glados/devicetree.cb @@ -1,7 +1,7 @@ chip soc/intel/skylake # IGD Displays - register "gfx" = "GMA_STATIC_DISPLAYS(0)" + register "gfx" = "GMA_STATIC_DISPLAYS(false)" register "panel_cfg" = "{ .up_delay_ms = 200, diff --git a/src/mainboard/google/link/devicetree.cb b/src/mainboard/google/link/devicetree.cb index 49c3476..018aefc 100644 --- a/src/mainboard/google/link/devicetree.cb +++ b/src/mainboard/google/link/devicetree.cb @@ -1,6 +1,6 @@ chip northbridge/intel/sandybridge # IGD Displays - register "gfx" = "GMA_STATIC_DISPLAYS(0)" + register "gfx" = "GMA_STATIC_DISPLAYS(false)" # Enable DisplayPort Hotplug with 6ms pulse register "gpu_dp_d_hotplug" = "0x06" diff --git a/src/mainboard/google/parrot/devicetree.cb b/src/mainboard/google/parrot/devicetree.cb index 6850cf2..1399b23 100644 --- a/src/mainboard/google/parrot/devicetree.cb +++ b/src/mainboard/google/parrot/devicetree.cb @@ -1,6 +1,6 @@ chip northbridge/intel/sandybridge # IGD Displays - register "gfx" = "GMA_STATIC_DISPLAYS(0)" + register "gfx" = "GMA_STATIC_DISPLAYS(false)" # Enable DisplayPort B Hotplug with 6ms pulse register "gpu_dp_b_hotplug" = "0x06" diff --git a/src/mainboard/google/poppy/variants/atlas/devicetree.cb b/src/mainboard/google/poppy/variants/atlas/devicetree.cb index d26f6bd..aec8881 100644 --- a/src/mainboard/google/poppy/variants/atlas/devicetree.cb +++ b/src/mainboard/google/poppy/variants/atlas/devicetree.cb @@ -1,7 +1,7 @@ chip soc/intel/skylake # IGD Displays - register "gfx" = "GMA_STATIC_DISPLAYS(0)" + register "gfx" = "GMA_STATIC_DISPLAYS(false)" register "panel_cfg" = "{ .up_delay_ms = 200, diff --git a/src/mainboard/google/poppy/variants/baseboard/devicetree.cb b/src/mainboard/google/poppy/variants/baseboard/devicetree.cb index db4aeeb..5505321 100644 --- a/src/mainboard/google/poppy/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/poppy/variants/baseboard/devicetree.cb @@ -1,7 +1,7 @@ chip soc/intel/skylake # IGD Displays - register "gfx" = "GMA_STATIC_DISPLAYS(0)" + register "gfx" = "GMA_STATIC_DISPLAYS(false)" # Deep Sx states register "deep_s3_enable_ac" = "0" diff --git a/src/mainboard/google/poppy/variants/nami/devicetree.cb b/src/mainboard/google/poppy/variants/nami/devicetree.cb index 8583518..a299991 100644 --- a/src/mainboard/google/poppy/variants/nami/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nami/devicetree.cb @@ -1,7 +1,7 @@ chip soc/intel/skylake # IGD Displays - register "gfx" = "GMA_STATIC_DISPLAYS(0)" + register "gfx" = "GMA_STATIC_DISPLAYS(false)" # Deep Sx states register "deep_s3_enable_ac" = "0" diff --git a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb index b8a1812..beccb71 100644 --- a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb @@ -1,7 +1,7 @@ chip soc/intel/skylake # IGD Displays - register "gfx" = "GMA_STATIC_DISPLAYS(0)" + register "gfx" = "GMA_STATIC_DISPLAYS(false)" # Deep Sx states register "deep_s3_enable_ac" = "0" diff --git a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb index 03336f2..cb4c79f 100644 --- a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb @@ -1,7 +1,7 @@ chip soc/intel/skylake # IGD Displays - register "gfx" = "GMA_STATIC_DISPLAYS(0)" + register "gfx" = "GMA_STATIC_DISPLAYS(false)" # Deep Sx states register "deep_s3_enable_ac" = "0" diff --git a/src/mainboard/google/poppy/variants/rammus/devicetree.cb b/src/mainboard/google/poppy/variants/rammus/devicetree.cb index c6c2d3d..7885ee5 100644 --- a/src/mainboard/google/poppy/variants/rammus/devicetree.cb +++ b/src/mainboard/google/poppy/variants/rammus/devicetree.cb @@ -1,7 +1,7 @@ chip soc/intel/skylake # IGD Displays - register "gfx" = "GMA_STATIC_DISPLAYS(0)" + register "gfx" = "GMA_STATIC_DISPLAYS(false)" register "panel_cfg" = "{ .up_delay_ms = 200, diff --git a/src/mainboard/google/poppy/variants/soraka/devicetree.cb b/src/mainboard/google/poppy/variants/soraka/devicetree.cb index 5c34792..36b12c5 100644 --- a/src/mainboard/google/poppy/variants/soraka/devicetree.cb +++ b/src/mainboard/google/poppy/variants/soraka/devicetree.cb @@ -1,7 +1,7 @@ chip soc/intel/skylake # IGD Displays - register "gfx" = "GMA_STATIC_DISPLAYS(0)" + register "gfx" = "GMA_STATIC_DISPLAYS(false)" # Deep Sx states register "deep_s3_enable_ac" = "0" diff --git a/src/mainboard/google/rambi/devicetree.cb b/src/mainboard/google/rambi/devicetree.cb index 1ebf1e8..ae12f24 100644 --- a/src/mainboard/google/rambi/devicetree.cb +++ b/src/mainboard/google/rambi/devicetree.cb @@ -1,7 +1,7 @@ chip soc/intel/baytrail # IGD Displays - register "gfx" = "GMA_STATIC_DISPLAYS(0)" + register "gfx" = "GMA_STATIC_DISPLAYS(false)" # SATA port enable mask (2 ports) register "sata_port_map" = "0x1" diff --git a/src/mainboard/google/slippy/devicetree.cb b/src/mainboard/google/slippy/devicetree.cb index 0c1222c..430ef3a 100644 --- a/src/mainboard/google/slippy/devicetree.cb +++ b/src/mainboard/google/slippy/devicetree.cb @@ -1,6 +1,6 @@ chip northbridge/intel/haswell # IGD Displays - register "gfx" = "GMA_STATIC_DISPLAYS(0)" + register "gfx" = "GMA_STATIC_DISPLAYS(false)" # Enable eDP Hotplug with 6ms pulse register "gpu_dp_d_hotplug" = "0x06" diff --git a/src/mainboard/google/stout/devicetree.cb b/src/mainboard/google/stout/devicetree.cb index b38adaf..aca6e3b 100644 --- a/src/mainboard/google/stout/devicetree.cb +++ b/src/mainboard/google/stout/devicetree.cb @@ -1,6 +1,6 @@ chip northbridge/intel/sandybridge # IGD Displays - register "gfx" = "GMA_STATIC_DISPLAYS(0)" + register "gfx" = "GMA_STATIC_DISPLAYS(false)" # Enable DisplayPort Hotplug with 6ms pulse register "gpu_dp_d_hotplug" = "0x06" diff --git a/src/mainboard/hp/folio_9480m/devicetree.cb b/src/mainboard/hp/folio_9480m/devicetree.cb index 6a8e919..abd631a 100644 --- a/src/mainboard/hp/folio_9480m/devicetree.cb +++ b/src/mainboard/hp/folio_9480m/devicetree.cb @@ -1,7 +1,7 @@ chip northbridge/intel/haswell register "dq_pins_interleaved" = "true" register "ec_present" = "true" - register "gfx" = "GMA_STATIC_DISPLAYS(0)" + register "gfx" = "GMA_STATIC_DISPLAYS(false)" register "gpu_dp_b_hotplug" = "4" register "gpu_dp_c_hotplug" = "4" register "panel_cfg" = "{ diff --git a/src/mainboard/ibase/mb899/devicetree.cb b/src/mainboard/ibase/mb899/devicetree.cb index 619c0cb..bde5355 100644 --- a/src/mainboard/ibase/mb899/devicetree.cb +++ b/src/mainboard/ibase/mb899/devicetree.cb @@ -1,6 +1,6 @@ chip northbridge/intel/i945 # IGD Displays - register "gfx" = "GMA_STATIC_DISPLAYS(0)" + register "gfx" = "GMA_STATIC_DISPLAYS(false)" device cpu_cluster 0 on chip cpu/intel/socket_m diff --git a/src/mainboard/intel/baskingridge/devicetree.cb b/src/mainboard/intel/baskingridge/devicetree.cb index 3226170..3ba9ac4 100644 --- a/src/mainboard/intel/baskingridge/devicetree.cb +++ b/src/mainboard/intel/baskingridge/devicetree.cb @@ -1,6 +1,6 @@ chip northbridge/intel/haswell # IGD Displays - register "gfx" = "GMA_STATIC_DISPLAYS(0)" + register "gfx" = "GMA_STATIC_DISPLAYS(false)" # Enable DisplayPort 1 Hotplug with 6ms pulse register "gpu_dp_d_hotplug" = "0x06" diff --git a/src/mainboard/intel/dcp847ske/devicetree.cb b/src/mainboard/intel/dcp847ske/devicetree.cb index f7821d0..17359d0 100644 --- a/src/mainboard/intel/dcp847ske/devicetree.cb +++ b/src/mainboard/intel/dcp847ske/devicetree.cb @@ -1,6 +1,6 @@ chip northbridge/intel/sandybridge # IGD Displays - register "gfx" = "GMA_STATIC_DISPLAYS(0)" + register "gfx" = "GMA_STATIC_DISPLAYS(false)" # Enable DisplayPort 1 Hotplug with 6ms pulse register "gpu_dp_d_hotplug" = "0x06" diff --git a/src/mainboard/intel/emeraldlake2/devicetree.cb b/src/mainboard/intel/emeraldlake2/devicetree.cb index 170dbaa..6c8dfe8 100644 --- a/src/mainboard/intel/emeraldlake2/devicetree.cb +++ b/src/mainboard/intel/emeraldlake2/devicetree.cb @@ -1,6 +1,6 @@ chip northbridge/intel/sandybridge # IGD Displays - register "gfx" = "GMA_STATIC_DISPLAYS(0)" + register "gfx" = "GMA_STATIC_DISPLAYS(false)" # Enable DisplayPort 1 Hotplug with 6ms pulse register "gpu_dp_d_hotplug" = "0x06" diff --git a/src/mainboard/kontron/986lcd-m/devicetree.cb b/src/mainboard/kontron/986lcd-m/devicetree.cb index 98af6c6..eacf91e 100644 --- a/src/mainboard/kontron/986lcd-m/devicetree.cb +++ b/src/mainboard/kontron/986lcd-m/devicetree.cb @@ -1,6 +1,6 @@ chip northbridge/intel/i945 # IGD Displays - register "gfx" = "GMA_STATIC_DISPLAYS(0)" + register "gfx" = "GMA_STATIC_DISPLAYS(false)" device cpu_cluster 0 on chip cpu/intel/socket_m diff --git a/src/mainboard/kontron/ktqm77/devicetree.cb b/src/mainboard/kontron/ktqm77/devicetree.cb index 31bee5d..de51e77 100644 --- a/src/mainboard/kontron/ktqm77/devicetree.cb +++ b/src/mainboard/kontron/ktqm77/devicetree.cb @@ -1,6 +1,6 @@ chip northbridge/intel/sandybridge # IGD Displays - register "gfx" = "GMA_STATIC_DISPLAYS(0)" + register "gfx" = "GMA_STATIC_DISPLAYS(false)" device cpu_cluster 0 on chip cpu/intel/model_206ax diff --git a/src/mainboard/lenovo/haswell/variants/t440p/devicetree.cb b/src/mainboard/lenovo/haswell/variants/t440p/devicetree.cb index fc00734..956065d 100644 --- a/src/mainboard/lenovo/haswell/variants/t440p/devicetree.cb +++ b/src/mainboard/lenovo/haswell/variants/t440p/devicetree.cb @@ -1,5 +1,5 @@ chip northbridge/intel/haswell - register "gfx" = "GMA_STATIC_DISPLAYS(0)" + register "gfx" = "GMA_STATIC_DISPLAYS(false)" register "gpu_ddi_e_connected" = "1" register "gpu_dp_b_hotplug" = "4" register "gpu_dp_c_hotplug" = "4" diff --git a/src/mainboard/lenovo/haswell/variants/w541/devicetree.cb b/src/mainboard/lenovo/haswell/variants/w541/devicetree.cb index 292a30d..79bb0c2 100644 --- a/src/mainboard/lenovo/haswell/variants/w541/devicetree.cb +++ b/src/mainboard/lenovo/haswell/variants/w541/devicetree.cb @@ -1,5 +1,5 @@ chip northbridge/intel/haswell - register "gfx" = "GMA_STATIC_DISPLAYS(0)" + register "gfx" = "GMA_STATIC_DISPLAYS(false)" register "gpu_ddi_e_connected" = "1" register "gpu_dp_b_hotplug" = "4" register "gpu_dp_c_hotplug" = "4" diff --git a/src/mainboard/lenovo/l520/devicetree.cb b/src/mainboard/lenovo/l520/devicetree.cb index 88adf5b..467e710 100644 --- a/src/mainboard/lenovo/l520/devicetree.cb +++ b/src/mainboard/lenovo/l520/devicetree.cb @@ -1,5 +1,5 @@ chip northbridge/intel/sandybridge - register "gfx" = "GMA_STATIC_DISPLAYS(0)" + register "gfx" = "GMA_STATIC_DISPLAYS(false)" register "gpu_cpu_backlight" = "0x00000000" register "gpu_dp_b_hotplug" = "0" register "gpu_dp_c_hotplug" = "0" diff --git a/src/mainboard/lenovo/s230u/devicetree.cb b/src/mainboard/lenovo/s230u/devicetree.cb index dda8393..6cbc250 100644 --- a/src/mainboard/lenovo/s230u/devicetree.cb +++ b/src/mainboard/lenovo/s230u/devicetree.cb @@ -1,5 +1,5 @@ chip northbridge/intel/sandybridge - register "gfx" = "GMA_STATIC_DISPLAYS(1)" + register "gfx" = "GMA_STATIC_DISPLAYS(true)" register "gpu_cpu_backlight" = "0x00000060" register "gpu_dp_b_hotplug" = "4" register "gpu_dp_c_hotplug" = "4" diff --git a/src/mainboard/lenovo/t400/devicetree.cb b/src/mainboard/lenovo/t400/devicetree.cb index 4634c71..815bdc2 100644 --- a/src/mainboard/lenovo/t400/devicetree.cb +++ b/src/mainboard/lenovo/t400/devicetree.cb @@ -1,6 +1,6 @@ chip northbridge/intel/gm45 # IGD Displays - register "gfx" = "GMA_STATIC_DISPLAYS(1)" + register "gfx" = "GMA_STATIC_DISPLAYS(true)" register "gpu_panel_power_up_delay" = "250" # T1+T2: 25ms register "gpu_panel_power_down_delay" = "250" # T3: 25ms diff --git a/src/mainboard/lenovo/t410/devicetree.cb b/src/mainboard/lenovo/t410/devicetree.cb index 6bd90fb..1242658 100644 --- a/src/mainboard/lenovo/t410/devicetree.cb +++ b/src/mainboard/lenovo/t410/devicetree.cb @@ -2,7 +2,7 @@ chip northbridge/intel/ironlake # IGD Displays - register "gfx" = "GMA_STATIC_DISPLAYS(1)" + register "gfx" = "GMA_STATIC_DISPLAYS(true)" # Enable DisplayPort Hotplug with 6ms pulse register "gpu_dp_d_hotplug" = "0x06" diff --git a/src/mainboard/lenovo/t420/devicetree.cb b/src/mainboard/lenovo/t420/devicetree.cb index c934f5f..f72dac0 100644 --- a/src/mainboard/lenovo/t420/devicetree.cb +++ b/src/mainboard/lenovo/t420/devicetree.cb @@ -1,6 +1,6 @@ chip northbridge/intel/sandybridge # IGD Displays - register "gfx" = "GMA_STATIC_DISPLAYS(1)" + register "gfx" = "GMA_STATIC_DISPLAYS(true)" # Enable DisplayPort Hotplug with 6ms pulse register "gpu_dp_d_hotplug" = "0x06" diff --git a/src/mainboard/lenovo/t420s/devicetree.cb b/src/mainboard/lenovo/t420s/devicetree.cb index 1d6adaf..b5ce4b8 100644 --- a/src/mainboard/lenovo/t420s/devicetree.cb +++ b/src/mainboard/lenovo/t420s/devicetree.cb @@ -1,6 +1,6 @@ chip northbridge/intel/sandybridge # IGD Displays - register "gfx" = "GMA_STATIC_DISPLAYS(1)" + register "gfx" = "GMA_STATIC_DISPLAYS(true)" # Enable DisplayPort Hotplug with 6ms pulse register "gpu_dp_d_hotplug" = "0x06" diff --git a/src/mainboard/lenovo/t430/devicetree.cb b/src/mainboard/lenovo/t430/devicetree.cb index 7931284..da4c561 100644 --- a/src/mainboard/lenovo/t430/devicetree.cb +++ b/src/mainboard/lenovo/t430/devicetree.cb @@ -1,5 +1,5 @@ chip northbridge/intel/sandybridge - register "gfx" = "GMA_STATIC_DISPLAYS(1)" + register "gfx" = "GMA_STATIC_DISPLAYS(true)" # Enable DisplayPort Hotplug with 6ms pulse register "gpu_dp_d_hotplug" = "0x06" diff --git a/src/mainboard/lenovo/t430s/devicetree.cb b/src/mainboard/lenovo/t430s/devicetree.cb index b3635b1..815c5b5 100644 --- a/src/mainboard/lenovo/t430s/devicetree.cb +++ b/src/mainboard/lenovo/t430s/devicetree.cb @@ -1,5 +1,5 @@ chip northbridge/intel/sandybridge - register "gfx" = "GMA_STATIC_DISPLAYS(1)" + register "gfx" = "GMA_STATIC_DISPLAYS(true)" # Enable DisplayPort Hotplug with 6ms pulse register "gpu_dp_d_hotplug" = "0x06" diff --git a/src/mainboard/lenovo/t520/devicetree.cb b/src/mainboard/lenovo/t520/devicetree.cb index 9c75231..8d14763 100644 --- a/src/mainboard/lenovo/t520/devicetree.cb +++ b/src/mainboard/lenovo/t520/devicetree.cb @@ -1,6 +1,6 @@ chip northbridge/intel/sandybridge # IGD Displays - register "gfx" = "GMA_STATIC_DISPLAYS(1)" + register "gfx" = "GMA_STATIC_DISPLAYS(true)" # Enable DisplayPort Hotplug with 6ms pulse register "gpu_dp_d_hotplug" = "0x06" diff --git a/src/mainboard/lenovo/t530/devicetree.cb b/src/mainboard/lenovo/t530/devicetree.cb index afbd3ba..6e7a054 100644 --- a/src/mainboard/lenovo/t530/devicetree.cb +++ b/src/mainboard/lenovo/t530/devicetree.cb @@ -1,6 +1,6 @@ chip northbridge/intel/sandybridge # IGD Displays - register "gfx" = "GMA_STATIC_DISPLAYS(1)" + register "gfx" = "GMA_STATIC_DISPLAYS(true)" # Enable DisplayPort Hotplug with 6ms pulse register "gpu_dp_d_hotplug" = "0x06" diff --git a/src/mainboard/lenovo/t60/devicetree.cb b/src/mainboard/lenovo/t60/devicetree.cb index d046d4d..68fca7a 100644 --- a/src/mainboard/lenovo/t60/devicetree.cb +++ b/src/mainboard/lenovo/t60/devicetree.cb @@ -2,7 +2,7 @@ chip northbridge/intel/i945 # IGD Displays - register "gfx" = "GMA_STATIC_DISPLAYS(0)" + register "gfx" = "GMA_STATIC_DISPLAYS(false)" register "gpu_hotplug" = "0x00000220" register "gpu_lvds_use_spread_spectrum_clock" = "true" diff --git a/src/mainboard/lenovo/x131e/devicetree.cb b/src/mainboard/lenovo/x131e/devicetree.cb index f28212e..9282c39 100644 --- a/src/mainboard/lenovo/x131e/devicetree.cb +++ b/src/mainboard/lenovo/x131e/devicetree.cb @@ -1,6 +1,6 @@ chip northbridge/intel/sandybridge # IGD Displays - register "gfx" = "GMA_STATIC_DISPLAYS(1)" + register "gfx" = "GMA_STATIC_DISPLAYS(true)" register "gpu_dp_d_hotplug" = "0x04" diff --git a/src/mainboard/lenovo/x1_carbon_gen1/devicetree.cb b/src/mainboard/lenovo/x1_carbon_gen1/devicetree.cb index cbf1141..65178e5 100644 --- a/src/mainboard/lenovo/x1_carbon_gen1/devicetree.cb +++ b/src/mainboard/lenovo/x1_carbon_gen1/devicetree.cb @@ -1,5 +1,5 @@ chip northbridge/intel/sandybridge - register "gfx" = "GMA_STATIC_DISPLAYS(1)" + register "gfx" = "GMA_STATIC_DISPLAYS(true)" register "gpu_cpu_backlight" = "0x00001155" register "gpu_dp_b_hotplug" = "4" register "gpu_dp_c_hotplug" = "4" diff --git a/src/mainboard/lenovo/x200/devicetree.cb b/src/mainboard/lenovo/x200/devicetree.cb index e0eefe7..9b4393a 100644 --- a/src/mainboard/lenovo/x200/devicetree.cb +++ b/src/mainboard/lenovo/x200/devicetree.cb @@ -1,6 +1,6 @@ chip northbridge/intel/gm45 # IGD Displays - register "gfx" = "GMA_STATIC_DISPLAYS(1)" + register "gfx" = "GMA_STATIC_DISPLAYS(true)" register "gpu_panel_power_up_delay" = "250" # T1+T2: 25ms register "gpu_panel_power_down_delay" = "250" # T3: 25ms diff --git a/src/mainboard/lenovo/x201/devicetree.cb b/src/mainboard/lenovo/x201/devicetree.cb index e9f60b0..1dee138 100644 --- a/src/mainboard/lenovo/x201/devicetree.cb +++ b/src/mainboard/lenovo/x201/devicetree.cb @@ -2,7 +2,7 @@ chip northbridge/intel/ironlake # IGD Displays - register "gfx" = "GMA_STATIC_DISPLAYS(1)" + register "gfx" = "GMA_STATIC_DISPLAYS(true)" # Enable DisplayPort Hotplug with 6ms pulse diff --git a/src/mainboard/lenovo/x220/devicetree.cb b/src/mainboard/lenovo/x220/devicetree.cb index 923c88b..a5dc760 100644 --- a/src/mainboard/lenovo/x220/devicetree.cb +++ b/src/mainboard/lenovo/x220/devicetree.cb @@ -1,6 +1,6 @@ chip northbridge/intel/sandybridge # IGD Displays - register "gfx" = "GMA_STATIC_DISPLAYS(1)" + register "gfx" = "GMA_STATIC_DISPLAYS(true)" # Enable DisplayPort Hotplug with 6ms pulse register "gpu_dp_d_hotplug" = "0x06" diff --git a/src/mainboard/lenovo/x230/devicetree.cb b/src/mainboard/lenovo/x230/devicetree.cb index 30a7916..b29d33a 100644 --- a/src/mainboard/lenovo/x230/devicetree.cb +++ b/src/mainboard/lenovo/x230/devicetree.cb @@ -1,6 +1,6 @@ chip northbridge/intel/sandybridge # IGD Displays - register "gfx" = "GMA_STATIC_DISPLAYS(1)" + register "gfx" = "GMA_STATIC_DISPLAYS(true)" # Enable DisplayPort Hotplug with 6ms pulse register "gpu_dp_d_hotplug" = "0x06" diff --git a/src/mainboard/lenovo/x60/devicetree.cb b/src/mainboard/lenovo/x60/devicetree.cb index cd9b763..5e56a01 100644 --- a/src/mainboard/lenovo/x60/devicetree.cb +++ b/src/mainboard/lenovo/x60/devicetree.cb @@ -2,7 +2,7 @@ chip northbridge/intel/i945 # IGD Displays - register "gfx" = "GMA_STATIC_DISPLAYS(0)" + register "gfx" = "GMA_STATIC_DISPLAYS(false)" register "gpu_hotplug" = "0x00000220" register "gpu_lvds_use_spread_spectrum_clock" = "true" diff --git a/src/mainboard/packardbell/ms2290/devicetree.cb b/src/mainboard/packardbell/ms2290/devicetree.cb index db0725b..cbf0118 100644 --- a/src/mainboard/packardbell/ms2290/devicetree.cb +++ b/src/mainboard/packardbell/ms2290/devicetree.cb @@ -2,7 +2,7 @@ chip northbridge/intel/ironlake # IGD Displays - register "gfx" = "GMA_STATIC_DISPLAYS(0)" + register "gfx" = "GMA_STATIC_DISPLAYS(false)" register "gpu_dp_b_hotplug" = "0x04" register "gpu_dp_c_hotplug" = "0x04" diff --git a/src/mainboard/purism/librem_bdw/devicetree.cb b/src/mainboard/purism/librem_bdw/devicetree.cb index 45350b6..37d8a6a 100644 --- a/src/mainboard/purism/librem_bdw/devicetree.cb +++ b/src/mainboard/purism/librem_bdw/devicetree.cb @@ -1,7 +1,7 @@ chip soc/intel/broadwell # IGD Displays - register "gfx" = "GMA_STATIC_DISPLAYS(0)" + register "gfx" = "GMA_STATIC_DISPLAYS(false)" # Enable eDP Hotplug with 6ms pulse register "gpu_dp_d_hotplug" = "0x06" diff --git a/src/mainboard/purism/librem_skl/devicetree.cb b/src/mainboard/purism/librem_skl/devicetree.cb index 94b79f9..9694e9d 100644 --- a/src/mainboard/purism/librem_skl/devicetree.cb +++ b/src/mainboard/purism/librem_skl/devicetree.cb @@ -1,7 +1,7 @@ chip soc/intel/skylake # IGD Displays - register "gfx" = "GMA_STATIC_DISPLAYS(0)" + register "gfx" = "GMA_STATIC_DISPLAYS(false)" register "panel_cfg" = "{ .up_delay_ms = 200, diff --git a/src/mainboard/roda/rk886ex/devicetree.cb b/src/mainboard/roda/rk886ex/devicetree.cb index e3a6db9..7957473 100644 --- a/src/mainboard/roda/rk886ex/devicetree.cb +++ b/src/mainboard/roda/rk886ex/devicetree.cb @@ -2,7 +2,7 @@ chip northbridge/intel/i945 # IGD Displays - register "gfx" = "GMA_STATIC_DISPLAYS(0)" + register "gfx" = "GMA_STATIC_DISPLAYS(false)" device cpu_cluster 0 on chip cpu/intel/socket_m diff --git a/src/mainboard/roda/rk9/devicetree.cb b/src/mainboard/roda/rk9/devicetree.cb index fbb026b..4c59824 100644 --- a/src/mainboard/roda/rk9/devicetree.cb +++ b/src/mainboard/roda/rk9/devicetree.cb @@ -1,6 +1,6 @@ chip northbridge/intel/gm45 # IGD Displays - register "gfx" = "GMA_STATIC_DISPLAYS(0)" + register "gfx" = "GMA_STATIC_DISPLAYS(false)" device cpu_cluster 0 on chip cpu/intel/socket_BGA956 device lapic 0 on end diff --git a/src/mainboard/samsung/lumpy/devicetree.cb b/src/mainboard/samsung/lumpy/devicetree.cb index ff7f362..ab2b6d0 100644 --- a/src/mainboard/samsung/lumpy/devicetree.cb +++ b/src/mainboard/samsung/lumpy/devicetree.cb @@ -1,6 +1,6 @@ chip northbridge/intel/sandybridge # IGD Displays - register "gfx" = "GMA_STATIC_DISPLAYS(0)" + register "gfx" = "GMA_STATIC_DISPLAYS(false)" # Enable DisplayPort Hotplug with 6ms pulse register "gpu_dp_d_hotplug" = "0x06" diff --git a/src/mainboard/supermicro/x9sae/devicetree.cb b/src/mainboard/supermicro/x9sae/devicetree.cb index 05a187e..b4499c1 100644 --- a/src/mainboard/supermicro/x9sae/devicetree.cb +++ b/src/mainboard/supermicro/x9sae/devicetree.cb @@ -1,7 +1,7 @@ ## SPDX-License-Identifier: GPL-2.0-only chip northbridge/intel/sandybridge - register "gfx" = "GMA_STATIC_DISPLAYS(0)" + register "gfx" = "GMA_STATIC_DISPLAYS(false)" register "gpu_dp_b_hotplug" = "4" register "gpu_dp_c_hotplug" = "4" register "gpu_dp_d_hotplug" = "4" diff --git a/src/mainboard/system76/whl-u/devicetree.cb b/src/mainboard/system76/whl-u/devicetree.cb index 63a9016..37f36f4 100644 --- a/src/mainboard/system76/whl-u/devicetree.cb +++ b/src/mainboard/system76/whl-u/devicetree.cb @@ -61,7 +61,7 @@ device domain 0 on device pci 00.0 on end # Host Bridge device pci 02.0 on # Integrated Graphics Device - register "gfx" = "GMA_STATIC_DISPLAYS(0)" + register "gfx" = "GMA_STATIC_DISPLAYS(false)" end device pci 04.0 on # SA Thermal device register "Device4Enable" = "1" -- To view, visit https://review.coreboot.org/c/coreboot/+/70150 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie330ec2258c0083e225032ed0d53d51163491378 Gerrit-Change-Number: 70150 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022