Attention is currently required from: Arthur Heymans.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69109 )
Change subject: cpu/x86/mp_init.c: Handle failed init_bsp()
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/cpu/x86/mp_init.c:
https://review.coreboot.org/c/coreboot/+/69109/comment/f61611ab_2d142bb1
PS1, Line 590: if (init_bsp(cpu_bus) != CB_SUCCESS ) {
> space prohibited before that close parenthesis ')'
Please fix.
--
To view, visit https://review.coreboot.org/c/coreboot/+/69109
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7be5d6c32458ba98f4f8c5c9340790ff989c91e7
Gerrit-Change-Number: 69109
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Wed, 02 Nov 2022 12:31:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/38809 )
Change subject: cpu/intel/stm: Use URLs so a link is generated
......................................................................
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit https://review.coreboot.org/c/blobs/+/38809
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: blobs
Gerrit-Branch: master
Gerrit-Change-Id: I21b1f681a3e6def66149b74c62eb9b0c52bd7249
Gerrit-Change-Number: 38809
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Eugene Myers <cedarhouse1(a)comcast.net>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Wed, 02 Nov 2022 12:23:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/38808 )
Change subject: cpu/intel/stm: Mark up file name as code/monospace
......................................................................
Patch Set 2: Verified+1
--
To view, visit https://review.coreboot.org/c/blobs/+/38808
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: blobs
Gerrit-Branch: master
Gerrit-Change-Id: Ib86fb06d5b1824ae445fac2ba11a6cc54974e0f0
Gerrit-Change-Number: 38808
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Eugene Myers <cedarhouse1(a)comcast.net>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Wed, 02 Nov 2022 12:22:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/38808 )
Change subject: cpu/intel/stm: Mark up file name as code/monospace
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/blobs/+/38808
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: blobs
Gerrit-Branch: master
Gerrit-Change-Id: Ib86fb06d5b1824ae445fac2ba11a6cc54974e0f0
Gerrit-Change-Number: 38808
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Eugene Myers <cedarhouse1(a)comcast.net>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Wed, 02 Nov 2022 12:22:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/38807 )
Change subject: cpu/intel/stm: Use *firmware* over *BIOS*
......................................................................
Patch Set 2: Verified+1
--
To view, visit https://review.coreboot.org/c/blobs/+/38807
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: blobs
Gerrit-Branch: master
Gerrit-Change-Id: Icccdc30db1d473275c93ffdb0bd6d87c14181a2d
Gerrit-Change-Number: 38807
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Eugene Myers <cedarhouse1(a)comcast.net>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Wed, 02 Nov 2022 12:22:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/38807 )
Change subject: cpu/intel/stm: Use *firmware* over *BIOS*
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/blobs/+/38807
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: blobs
Gerrit-Branch: master
Gerrit-Change-Id: Icccdc30db1d473275c93ffdb0bd6d87c14181a2d
Gerrit-Change-Number: 38807
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Eugene Myers <cedarhouse1(a)comcast.net>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Wed, 02 Nov 2022 12:22:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/38806 )
Change subject: cpu/intel/stm: Use official spelling of *Kaby Lake*
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/blobs/+/38806
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: blobs
Gerrit-Branch: master
Gerrit-Change-Id: I8e049931e48eebcf66773bce3126532f0a405b38
Gerrit-Change-Number: 38806
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Eugene Myers <cedarhouse1(a)comcast.net>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Wed, 02 Nov 2022 12:22:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/38806 )
Change subject: cpu/intel/stm: Use official spelling of *Kaby Lake*
......................................................................
Patch Set 2: Verified+1
--
To view, visit https://review.coreboot.org/c/blobs/+/38806
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: blobs
Gerrit-Branch: master
Gerrit-Change-Id: I8e049931e48eebcf66773bce3126532f0a405b38
Gerrit-Change-Number: 38806
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Eugene Myers <cedarhouse1(a)comcast.net>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Wed, 02 Nov 2022 12:22:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/38805 )
Change subject: cpu/intel/stm: Remove blank line at end of README.md
......................................................................
Patch Set 2: Verified+1
--
To view, visit https://review.coreboot.org/c/blobs/+/38805
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: blobs
Gerrit-Branch: master
Gerrit-Change-Id: Ica42f20c752997df2c5a0d84e85104812f77b6cb
Gerrit-Change-Number: 38805
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Wed, 02 Nov 2022 12:21:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/38805 )
Change subject: cpu/intel/stm: Remove blank line at end of README.md
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/blobs/+/38805
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: blobs
Gerrit-Branch: master
Gerrit-Change-Id: Ica42f20c752997df2c5a0d84e85104812f77b6cb
Gerrit-Change-Number: 38805
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Wed, 02 Nov 2022 12:21:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment