Attention is currently required from: Paul Menzel.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/38804 )
Change subject: cpu/intel/stm: Remove blank line at start of README.md
......................................................................
Patch Set 2: Verified+1
--
To view, visit https://review.coreboot.org/c/blobs/+/38804
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: blobs
Gerrit-Branch: master
Gerrit-Change-Id: I2d3ba738bf40ea7ac23ac7a28e4cb3542ce825a5
Gerrit-Change-Number: 38804
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Eugene Myers <cedarhouse1(a)comcast.net>
Gerrit-Reviewer: Eugene Myers <cedarhouse(a)comcast.net>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Wed, 02 Nov 2022 12:21:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Philipp Hug, Jakub Czapiga, Matt DeVillier, Julius Werner, Andrey Petrov, ron minnich, Elyes Haouas, Felix Held.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69078 )
Change subject: cbmem_top_chipset: Change the return value to uintptr_t
......................................................................
Patch Set 1: Code-Review+1
(3 comments)
File src/northbridge/intel/i440bx/memmap.c:
https://review.coreboot.org/c/coreboot/+/69078/comment/27b2a59a_304cc80a
PS1, Line 48: int tseg_size = 128 * KiB * (1 << (tseg >> 1));
: tom -= tseg_size;
> Shouldn't this be changed too? What's the purpose of integer type here? (And above too)
If anything, this belongs to a follow-up.
File src/northbridge/intel/x4x/memmap.c:
https://review.coreboot.org/c/coreboot/+/69078/comment/5f0452ea_065278ff
PS1, Line 76: uintptr_t top_of_ram = ALIGN_DOWN(northbridge_get_tseg_base(), 4*MiB);
: return top_of_ram;
> Can it fit in one line?
+1, there are other occurrences in other Intel platforms. Could be done in a follow-up.
File src/soc/nvidia/tegra124/cbmem.c:
https://review.coreboot.org/c/coreboot/+/69078/comment/deba1af8_8b1c603b
PS1, Line 9: return ((sdram_max_addressable_mb() - FB_SIZE_MB) << 20UL);
nit: Outer set of parentheses is now unnecessary
--
To view, visit https://review.coreboot.org/c/coreboot/+/69078
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I93645ef5dd270905ce421e68e342aff4c331eae6
Gerrit-Change-Number: 69078
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 02 Nov 2022 12:20:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Arthur Heymans, Elyes Haouas.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69140 )
Change subject: device/resource_allocator_v3: Drop code
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Patchset:
PS3:
> should we rename the file "resource_allocator_v4. […]
No need, and if anything it can be done in a follow-up.
--
To view, visit https://review.coreboot.org/c/coreboot/+/69140
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifccb59ae45daa8fec41a9a2d46c628ff24a0c998
Gerrit-Change-Number: 69140
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Wed, 02 Nov 2022 12:16:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-MessageType: comment
Attention is currently required from: Raymond Chung, Derek Huang, Zhuohao Lee.
Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69136 )
Change subject: mb/google/brya/gaelin: Configure GPIO settings
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
Note, I didn't confirm each GPIO v.s. the schematic but the general structure looks good.
--
To view, visit https://review.coreboot.org/c/coreboot/+/69136
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I649ac5131393008787cbb403fc64b914de23312b
Gerrit-Change-Number: 69136
Gerrit-PatchSet: 1
Gerrit-Owner: Raymond Chung <raymondchung(a)ami.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com>
Gerrit-Reviewer: Raymond Chung <raymondchung(a)ami.corp-partner.google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Bruce Chiang <brucechiang(a)msi.corp-partner.google.com>
Gerrit-CC: Eason Chang <easonchang(a)msi.corp-partner.google.com>
Gerrit-CC: Eddy Lu <eddylu(a)ami.corp-partner.google.com>
Gerrit-Attention: Raymond Chung <raymondchung(a)ami.corp-partner.google.com>
Gerrit-Attention: Derek Huang <derekhuang(a)google.com>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Comment-Date: Wed, 02 Nov 2022 11:59:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Frank Chu.
Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69052 )
Change subject: mb/google/brya: Create marasov variant
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/69052
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe2dc442480f6a73877b40625e228cdb2038aa4d
Gerrit-Change-Number: 69052
Gerrit-PatchSet: 3
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Kyle Lin <kylelinck(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 02 Nov 2022 11:56:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Philipp Hug, Matt DeVillier, Julius Werner, Angel Pons, Andrey Petrov, ron minnich, Elyes Haouas, Felix Held.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69078 )
Change subject: cbmem_top_chipset: Change the return value to uintptr_t
......................................................................
Patch Set 1:
(3 comments)
File src/northbridge/intel/i440bx/memmap.c:
https://review.coreboot.org/c/coreboot/+/69078/comment/5c6fe0c9_a1ddc7fd
PS1, Line 48: int tseg_size = 128 * KiB * (1 << (tseg >> 1));
: tom -= tseg_size;
Shouldn't this be changed too? What's the purpose of integer type here? (And above too)
File src/northbridge/intel/x4x/memmap.c:
https://review.coreboot.org/c/coreboot/+/69078/comment/65e9f290_ad319f7c
PS1, Line 76: uintptr_t top_of_ram = ALIGN_DOWN(northbridge_get_tseg_base(), 4*MiB);
: return top_of_ram;
Can it fit in one line?
File src/soc/sifive/fu540/cbmem.c:
https://review.coreboot.org/c/coreboot/+/69078/comment/dd336fd3_2b8c3d2f
PS1, Line 11: return MIN((uintptr_t)_dram + sdram_size_mb() * MiB,
: FU540_MAXDRAM);
nit: Can it fit in one line?
--
To view, visit https://review.coreboot.org/c/coreboot/+/69078
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I93645ef5dd270905ce421e68e342aff4c331eae6
Gerrit-Change-Number: 69078
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 02 Nov 2022 11:46:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Hello Shelly Chang,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/69147
to look at the new patch set (#2).
Change subject: drivers/ocp/ewl: Add sending Meta's BMC SEL for memory training error
......................................................................
drivers/ocp/ewl: Add sending Meta's BMC SEL for memory training error
Add sending Meta's BMC SEL for memory training error occurred in EWL
type 3 error.
Change-Id: I664e9d3da7910b47260881c0df64159c8dbe2dca
Signed-off-by: Shelly Chang <Shelly_Chang(a)wiwynn.com>
Signed-off-by: Johnny Lin <johnny_lin(a)wiwynn.com>
---
M src/drivers/ipmi/ocp/Makefile.inc
M src/drivers/ipmi/ocp/ipmi_ocp.h
M src/drivers/ocp/ewl/ewl.c
3 files changed, 73 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/69147/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/69147
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I664e9d3da7910b47260881c0df64159c8dbe2dca
Gerrit-Change-Number: 69147
Gerrit-PatchSet: 2
Gerrit-Owner: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-CC: Shelly Chang <Shelly_Chang(a)wiwynn.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Nico Huber, Martin L Roth, Paul Menzel, Angel Pons.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62830 )
Change subject: Makefile.inc: Decrease minimal pagesize from 4 kB to 1 kB
......................................................................
Patch Set 3:
(4 comments)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162120):
https://review.coreboot.org/c/coreboot/+/62830/comment/fb34933c_14520096
PS3, Line 17: In function 'write_ble8',
Possible unwrapped commit description (prefer a maximum 72 chars per line)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162120):
https://review.coreboot.org/c/coreboot/+/62830/comment/62f6acce_b6e2951d
PS3, Line 20: inlined from 'setup_ebda' at src/arch/x86/ebda.c:35:2,
Possible unwrapped commit description (prefer a maximum 72 chars per line)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162120):
https://review.coreboot.org/c/coreboot/+/62830/comment/0e6af3ca_1f5406ea
PS3, Line 21: inlined from 'setup_default_ebda' at src/arch/x86/ebda.c:48:2:
Possible unwrapped commit description (prefer a maximum 72 chars per line)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162120):
https://review.coreboot.org/c/coreboot/+/62830/comment/f60ac703_6d7098a2
PS3, Line 30: pointer arithmetics from NULL while addresses equal or larger than that
Possible unwrapped commit description (prefer a maximum 72 chars per line)
--
To view, visit https://review.coreboot.org/c/coreboot/+/62830
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6e36633f42cb4dc5af53212c10c919a86e451ee0
Gerrit-Change-Number: 62830
Gerrit-PatchSet: 3
Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Wed, 02 Nov 2022 11:18:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment