Attention is currently required from: Kangheui Won, Ren Kuo, Tim Wawrzynczak, Reka Norman, Tyler Wang, Vidya Gopalakrishnan, Peter Ou.
Vidya Gopalakrishnan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68523 )
Change subject: mb/google/nissa/var/craask: Modify PL2 setting to 25w
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
Patchset:
PS4:
> Hi Vidya, […]
Yes, sure
--
To view, visit https://review.coreboot.org/c/coreboot/+/68523
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I88c8c4e6798ec5bc2930dd713e8c8b2c543cfaf9
Gerrit-Change-Number: 68523
Gerrit-PatchSet: 4
Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Peter Ou <peter.ou(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Cathy Chen <cathy_chen(a)quanta.corp-partner.google.com>
Gerrit-CC: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-CC: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-CC: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.corp-partner.google.com>
Gerrit-Attention: Kangheui Won <khwon(a)chromium.org>
Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Attention: Vidya Gopalakrishnan <vidya.gopalakrishnan(a)intel.corp-partner.google.com>
Gerrit-Attention: Peter Ou <peter.ou(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 03 Nov 2022 03:48:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Frank Chu.
Kyle Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69052 )
Change subject: mb/google/brya: Create marasov variant
......................................................................
Patch Set 8: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/69052
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe2dc442480f6a73877b40625e228cdb2038aa4d
Gerrit-Change-Number: 69052
Gerrit-PatchSet: 8
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Kyle Lin <kylelinck(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 03 Nov 2022 03:04:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Kyle Lin.
Frank Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69052 )
Change subject: mb/google/brya: Create marasov variant
......................................................................
Patch Set 8: Code-Review+1
(1 comment)
Patchset:
PS7:
> Please remove the duplicated 'Signed-off-by...' line in the commit message.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/69052
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe2dc442480f6a73877b40625e228cdb2038aa4d
Gerrit-Change-Number: 69052
Gerrit-PatchSet: 8
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Kyle Lin <kylelinck(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Kyle Lin <kylelinck(a)google.com>
Gerrit-Comment-Date: Thu, 03 Nov 2022 03:03:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Kyle Lin <kylelinck(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Frank Chu.
Hello build bot (Jenkins), Tarun Tuli, Subrata Banik, Kyle Lin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/69052
to look at the new patch set (#8).
Change subject: mb/google/brya: Create marasov variant
......................................................................
mb/google/brya: Create marasov variant
Create the marasov variant of the brya0 reference board by copying
the template files to a new directory named for the variant.
(Auto-Generated by create_coreboot_variant.sh version 4.5.0).
BUG=b:254365935
BRANCH=None
TEST=util/abuild/abuild -p none -t google/brya -x -a
make sure the build includes GOOGLE_MARASOV
Signed-off-by: Frank Chu <Frank_Chu(a)pegatron.corp-partner.google.com>
Change-Id: Ibe2dc442480f6a73877b40625e228cdb2038aa4d
---
M src/mainboard/google/brya/Kconfig
M src/mainboard/google/brya/Kconfig.name
A src/mainboard/google/brya/variants/marasov/include/variant/ec.h
A src/mainboard/google/brya/variants/marasov/include/variant/gpio.h
A src/mainboard/google/brya/variants/marasov/memory/Makefile.inc
A src/mainboard/google/brya/variants/marasov/memory/dram_id.generated.txt
A src/mainboard/google/brya/variants/marasov/memory/mem_parts_used.txt
A src/mainboard/google/brya/variants/marasov/overridetree.cb
8 files changed, 65 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/69052/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/69052
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe2dc442480f6a73877b40625e228cdb2038aa4d
Gerrit-Change-Number: 69052
Gerrit-PatchSet: 8
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Kyle Lin <kylelinck(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Frank Chu.
Kyle Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69052 )
Change subject: mb/google/brya: Create marasov variant
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS7:
Please remove the duplicated 'Signed-off-by...' line in the commit message.
--
To view, visit https://review.coreboot.org/c/coreboot/+/69052
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe2dc442480f6a73877b40625e228cdb2038aa4d
Gerrit-Change-Number: 69052
Gerrit-PatchSet: 7
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Kyle Lin <kylelinck(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 03 Nov 2022 02:49:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Yu-Ping Wu has submitted this change. ( https://review.coreboot.org/c/blobs/+/69086 )
Change subject: soc/mediatek/mt8188: Update MCUPM firmware from v1.01.02 to v1.01.03
......................................................................
soc/mediatek/mt8188: Update MCUPM firmware from v1.01.02 to v1.01.03
The efuse memory address is wrong for MCUPM to access. Add the
offset to revise the efuse memory address.
TEST=boot to shell.
BUG=b:244250440
Change-Id: I6e1b873cffa2949997ff36346266446c9380ae04
Signed-off-by: Liju-Clr Chen <liju-clr.chen(a)mediatek.com>
---
M soc/mediatek/mt8188/mcupm.bin
M soc/mediatek/mt8188/mcupm.bin.md5
M soc/mediatek/mt8188/mcupm_release_notes.txt
3 files changed, 21 insertions(+), 1 deletion(-)
Approvals:
Yu-Ping Wu: Verified; Looks good to me, approved
Yidi Lin: Looks good to me, but someone else must approve
Angel Pons: Looks good to me, but someone else must approve
Rex-BC Chen: Looks good to me, but someone else must approve
diff --git a/soc/mediatek/mt8188/mcupm.bin b/soc/mediatek/mt8188/mcupm.bin
index 6f4885e..69b3997 100644
--- a/soc/mediatek/mt8188/mcupm.bin
+++ b/soc/mediatek/mt8188/mcupm.bin
Binary files differ
diff --git a/soc/mediatek/mt8188/mcupm.bin.md5 b/soc/mediatek/mt8188/mcupm.bin.md5
index b425810..eeaedf4 100644
--- a/soc/mediatek/mt8188/mcupm.bin.md5
+++ b/soc/mediatek/mt8188/mcupm.bin.md5
@@ -1 +1 @@
-aa742e77b5cb2beae5f34d1c254a6a47 *mcupm.bin
+4425557bef387b525594455701233011 *mcupm.bin
diff --git a/soc/mediatek/mt8188/mcupm_release_notes.txt b/soc/mediatek/mt8188/mcupm_release_notes.txt
index 08e6849..4c5740b 100644
--- a/soc/mediatek/mt8188/mcupm_release_notes.txt
+++ b/soc/mediatek/mt8188/mcupm_release_notes.txt
@@ -1,4 +1,8 @@
** Build from MediaTek Internal **
+# v1.01.03
+1. The efuse memory address is wrong for MCUPM to access. Add the
+ offset to revise the efuse memory address.
+
# v1.01.02
1. Remove mtk header.
--
To view, visit https://review.coreboot.org/c/blobs/+/69086
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: blobs
Gerrit-Branch: master
Gerrit-Change-Id: I6e1b873cffa2949997ff36346266446c9380ae04
Gerrit-Change-Number: 69086
Gerrit-PatchSet: 3
Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: merged