coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: checkpatch: add Co-authored-by to signature list
by Patrick Georgi (Code Review) 03 Nov '22

03 Nov '22

Attention is currently required from: Felix Singer, Martin L Roth, Paul Menzel, Tim Wawrzynczak, Michael Niewöhner. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69166 ) Change subject: checkpatch: add Co-authored-by to signature list ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69166 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7f66824febe3be756c64ebf44c94bc653a66f1e1 Gerrit-Change-Number: 69166 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Thu, 03 Nov 2022 11:40:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/alderlake: Add support to enable PMC firmware trace
by Sridhar Siricilla (Code Review) 03 Nov '22

03 Nov '22

Attention is currently required from: Subrata Banik, Maulik Vaghela, Paul Menzel, Tim Wawrzynczak. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64436 ) Change subject: soc/intel/alderlake: Add support to enable PMC firmware trace ...................................................................... Patch Set 8: (1 comment) Patchset: PS7: > >Sorrym which one you need additionally? Are you referring to the FSP params which you need to set w […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/64436 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I146bff95945578b437f982ae033d655b3f92f7b4 Gerrit-Change-Number: 64436 Gerrit-PatchSet: 8 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Maulik Vaghela <maulikvaghela(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Maulik Vaghela <maulikvaghela(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Comment-Date: Thu, 03 Nov 2022 11:13:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/alderlake: Enable the runtime debug capability
by Sridhar Siricilla (Code Review) 03 Nov '22

03 Nov '22

Attention is currently required from: Subrata Banik, Paul Menzel, Krishna P Bhat D. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64434 ) Change subject: soc/intel/alderlake: Enable the runtime debug capability ...................................................................... Patch Set 8: (1 comment) File src/soc/intel/alderlake/fsp_params.c: https://review.coreboot.org/c/coreboot/+/64434/comment/92cebac2_2f37f0fc PS7, Line 906: cntrl > Agree, can I fix it after the patch set is up streamed? Is that fine? Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/64434 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I11d74a16bfc07ae12247f3cd1846c25268b69cc3 Gerrit-Change-Number: 64434 Gerrit-PatchSet: 8 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Comment-Date: Thu, 03 Nov 2022 11:13:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/common: Check PMC debug trace enable request
by Sridhar Siricilla (Code Review) 03 Nov '22

03 Nov '22

Attention is currently required from: Paul Menzel, Tim Wawrzynczak. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64433 ) Change subject: soc/intel/common: Check PMC debug trace enable request ...................................................................... Patch Set 8: (1 comment) File src/soc/intel/common/basecode/debug/debug_feature.c: https://review.coreboot.org/c/coreboot/+/64433/comment/c54a1f45_54aa8779 PS7, Line 46: dbg_feature_cntrl.pmc_trace_en ? "YES" : "NO"); > It logs whether user requested PMC tracing enabled or not. […] Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/64433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9718226e38233adf3de2f0df686c41caf220d246 Gerrit-Change-Number: 64433 Gerrit-PatchSet: 8 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Maulik Vaghela <maulikvaghela(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Comment-Date: Thu, 03 Nov 2022 11:12:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/common: Add support to read CPU and PCH Trace Hub modes
by Sridhar Siricilla (Code Review) 03 Nov '22

03 Nov '22

Attention is currently required from: Subrata Banik, Paul Menzel, Rizwan Qureshi, Krishna P Bhat D, Ronak Kanabar. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64437 ) Change subject: soc/intel/common: Add support to read CPU and PCH Trace Hub modes ...................................................................... Patch Set 8: (1 comment) Patchset: PS8: > Gentle Reminder? Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/64437 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61241c5c1981ddc4b21581bb3ed9f531da5f41b2 Gerrit-Change-Number: 64437 Gerrit-PatchSet: 8 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Maulik Vaghela <maulikvaghela(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Comment-Date: Thu, 03 Nov 2022 11:12:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: drivers/ocp/ewl: Set CMOS flag to enforce MRC when there's EWL type3 ...
by Johnny Lin (Code Review) 03 Nov '22

03 Nov '22

Attention is currently required from: Angel Pons. Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69148 ) Change subject: drivers/ocp/ewl: Set CMOS flag to enforce MRC when there's EWL type3 error ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/69148/comment/2758e657_f8b52c7d PS2, Line 12: Reference CPX change https://review.coreboot.org/c/coreboot/+/51230 > How about: […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/69148 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9dee0472f8e2602cecf88c6d00dec0bf02b9f7bd Gerrit-Change-Number: 69148 Gerrit-PatchSet: 4 Gerrit-Owner: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 03 Nov 2022 11:11:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: drivers/ocp/ewl: Set CMOS flag to enforce MRC when there's EWL type3 ...
by Johnny Lin (Code Review) 03 Nov '22

03 Nov '22

Attention is currently required from: Johnny Lin. Hello build bot (Jenkins), Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69148 to look at the new patch set (#4). Change subject: drivers/ocp/ewl: Set CMOS flag to enforce MRC when there's EWL type3 error ...................................................................... drivers/ocp/ewl: Set CMOS flag to enforce MRC when there's EWL type3 error If Fastboot is enabled, the next boot will skip MRC and won't be able to detect MRC error via EWL and still continues booting. Set a CMOS flag to enforce FSP MRC training in the next boot. See commit 95059b705500 (soc/intel/xeon_sp/cpx: Set the MRC "cold boot) Change-Id: I9dee0472f8e2602cecf88c6d00dec0bf02b9f7bd Signed-off-by: Johnny Lin <johnny_lin(a)wiwynn.com> --- M src/drivers/ocp/ewl/ewl.c 1 file changed, 36 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/69148/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/69148 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9dee0472f8e2602cecf88c6d00dec0bf02b9f7bd Gerrit-Change-Number: 69148 Gerrit-PatchSet: 4 Gerrit-Owner: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: soc/qualcomm/sc7280: Add API to differentialize PRO and NON_PRO SKUs
by Venkat Thogaru (Code Review) 03 Nov '22

03 Nov '22

Attention is currently required from: Shelley Chen, Taniya Das, Venkat Thogaru, Sudheer Amrabadi. Venkat Thogaru has uploaded a new patch set (#11) to the change originally created by Sudheer Amrabadi. ( https://review.coreboot.org/c/coreboot/+/68384 ) Change subject: soc/qualcomm/sc7280: Add API to differentialize PRO and NON_PRO SKUs ...................................................................... soc/qualcomm/sc7280: Add API to differentialize PRO and NON_PRO SKUs The API socinfo_pro_part() returns 1 for Pro and 0 for NON_PRO SKUs. To reduce the binary footprint for chipinfo structure, change its members range from uint32_t to uint16_t. Add helper functions for reading and matching jtagid. BUG=b:248187555 TEST=Validate boards are detected correctly on PRO and NON_PRO SKUs Signed-off-by: Taniya Das <quic_tdas(a)quicinc.com> Change-Id: Id9f23696384a6c1a89000292eafebd8a16c273ca --- M src/soc/qualcomm/sc7280/include/soc/socinfo.h M src/soc/qualcomm/sc7280/socinfo.c 2 files changed, 89 insertions(+), 33 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/68384/11 -- To view, visit https://review.coreboot.org/c/coreboot/+/68384 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id9f23696384a6c1a89000292eafebd8a16c273ca Gerrit-Change-Number: 68384 Gerrit-PatchSet: 11 Gerrit-Owner: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Taniya Das <quic_tdas(a)quicinc.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Taniya Das <tdas(a)qualcomm.corp-partner.google.com> Gerrit-CC: Venkat Thogaru <thogaru(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Taniya Das <quic_tdas(a)quicinc.com> Gerrit-Attention: Venkat Thogaru <thogaru(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Taniya Das <tdas(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: drivers/ocp/ewl: Add sending Meta's BMC SEL for memory training error
by Johnny Lin (Code Review) 03 Nov '22

03 Nov '22

Attention is currently required from: Angel Pons, Shelly Chang. Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69147 ) Change subject: drivers/ocp/ewl: Add sending Meta's BMC SEL for memory training error ...................................................................... Patch Set 3: (2 comments) File src/drivers/ipmi/ocp/ipmi_ocp.h: https://review.coreboot.org/c/coreboot/+/69147/comment/a292c061_5813b950 PS2, Line 195: #define INTEL_MEMORY_ERROR 0x21 > nit: place this so that the macro numbers are in ascending order? Done File src/drivers/ocp/ewl/ewl.c: https://review.coreboot.org/c/coreboot/+/69147/comment/c13e213d_0bb7a16b PS2, Line 12: = 0xff > Unused assignment Done -- To view, visit https://review.coreboot.org/c/coreboot/+/69147 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I664e9d3da7910b47260881c0df64159c8dbe2dca Gerrit-Change-Number: 69147 Gerrit-PatchSet: 3 Gerrit-Owner: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Shelly Chang <Shelly_Chang(a)wiwynn.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Shelly Chang <Shelly_Chang(a)wiwynn.com> Gerrit-Comment-Date: Thu, 03 Nov 2022 11:09:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/ocp/deltalake: Add EWL Hob processing for MRC error
by Johnny Lin (Code Review) 03 Nov '22

03 Nov '22

Attention is currently required from: Jonathan Zhang, Christian Walter, Angel Pons, Arthur Heymans, Tim Chu, Shelly Chang. Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69146 ) Change subject: mb/ocp/deltalake: Add EWL Hob processing for MRC error ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/69146/comment/61d343bb_98a3f06f PS1, Line 9: Override the weak function mainboard_ewl_check() and > > 'disble' may be misspelled - perhaps 'disable'? […] Done https://review.coreboot.org/c/coreboot/+/69146/comment/b1e4b8a7_7218e97d PS1, Line 10: The Intel FSP needs to disble promote : MRC Warnings > Is this an UPD? Where is it set? It's not in the public CedarIsland FSP. Please see my updated git comment. -- To view, visit https://review.coreboot.org/c/coreboot/+/69146 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4419ef43815f8181af89c49514a69bdb29858c13 Gerrit-Change-Number: 69146 Gerrit-PatchSet: 2 Gerrit-Owner: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Shelly Chang <Shelly_Chang(a)wiwynn.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Shelly Chang <Shelly_Chang(a)wiwynn.com> Gerrit-Comment-Date: Thu, 03 Nov 2022 11:08:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022