coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: arch/arm/eabi_compat.c: Add eabi_clrX and eabi_memcyX
by Arthur Heymans (Code Review) 17 Nov '22

17 Nov '22

Attention is currently required from: Julius Werner. Hello Julius Werner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69743 to look at the new patch set (#3). Change subject: arch/arm/eabi_compat.c: Add eabi_clrX and eabi_memcyX ...................................................................... arch/arm/eabi_compat.c: Add eabi_clrX and eabi_memcyX Clang generated code uses this for zero initialized variables. Change-Id: I460a0096918141c1cf8826bdf1853a3aa3aecff8 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/arch/arm/eabi_compat.c 1 file changed, 35 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/69743/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/69743 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I460a0096918141c1cf8826bdf1853a3aa3aecff8 Gerrit-Change-Number: 69743 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: ec/google/chromeec: Fix clang warnings
by Arthur Heymans (Code Review) 17 Nov '22

17 Nov '22

Attention is currently required from: Caveh Jalali, Julius Werner, Boris Mittelberg. Hello Caveh Jalali, Julius Werner, Boris Mittelberg, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69742 to look at the new patch set (#3). Change subject: ec/google/chromeec: Fix clang warnings ...................................................................... ec/google/chromeec: Fix clang warnings Clang warns about structs inside a union also needing the packed attribute. Change-Id: I8b5233618081db86caedcb2d14870974e109ed9b Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/ec/google/chromeec/ec_commands.h 1 file changed, 15 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/69742/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/69742 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b5233618081db86caedcb2d14870974e109ed9b Gerrit-Change-Number: 69742 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: arch/arm/eabi_compat.c: Add eabi_clrX and eabi_memcyX
by build bot (Jenkins) (Code Review) 17 Nov '22

17 Nov '22

Attention is currently required from: Julius Werner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69743 ) Change subject: arch/arm/eabi_compat.c: Add eabi_clrX and eabi_memcyX ...................................................................... Patch Set 2: (11 comments) File src/arch/arm/eabi_compat.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163912): https://review.coreboot.org/c/coreboot/+/69743/comment/439adc5b_1b1ef284 PS2, Line 28: void __aeabi_memcpy4 (void *dest, size_t n) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163912): https://review.coreboot.org/c/coreboot/+/69743/comment/66bfa9eb_fafc27cd PS2, Line 29: __attribute((alias ("__aeabi_memcpy"))); space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163912): https://review.coreboot.org/c/coreboot/+/69743/comment/8ed0aaff_d6bbc7c8 PS2, Line 31: void __aeabi_memcpy8 (void *dest, size_t n) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163912): https://review.coreboot.org/c/coreboot/+/69743/comment/6e34809f_37ecc2ce PS2, Line 32: __attribute((alias ("__aeabi_memcpy"))); space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163912): https://review.coreboot.org/c/coreboot/+/69743/comment/f0b6979d_1d23729e PS2, Line 48: void __aeabi_memclr4 (void *dest, size_t n) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163912): https://review.coreboot.org/c/coreboot/+/69743/comment/7bfc87cb_d1469f82 PS2, Line 49: __attribute((alias ("__aeabi_memclr"))); space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163912): https://review.coreboot.org/c/coreboot/+/69743/comment/829e08ac_67e1af58 PS2, Line 51: void __aeabi_memclr8 (void *dest, size_t n) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163912): https://review.coreboot.org/c/coreboot/+/69743/comment/8a15936e_96bac1ca PS2, Line 52: __attribute((alias ("__aeabi_memclr"))); space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163912): https://review.coreboot.org/c/coreboot/+/69743/comment/e383a303_11924ff3 PS2, Line 55: void __aeabi_memclr (void *dest, size_t n); space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163912): https://review.coreboot.org/c/coreboot/+/69743/comment/5652f244_277372da PS2, Line 56: void __aeabi_memclr (void *dest, size_t n) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163912): https://review.coreboot.org/c/coreboot/+/69743/comment/69df42d5_e8f94b14 PS2, Line 58: __aeabi_memset (dest, n, 0); space prohibited between function name and open parenthesis '(' -- To view, visit https://review.coreboot.org/c/coreboot/+/69743 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I460a0096918141c1cf8826bdf1853a3aa3aecff8 Gerrit-Change-Number: 69743 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Thu, 17 Nov 2022 11:54:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: ec/google/chromeec: Fix clang warnings
by build bot (Jenkins) (Code Review) 17 Nov '22

17 Nov '22

Attention is currently required from: Caveh Jalali, Julius Werner, Boris Mittelberg. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69742 ) Change subject: ec/google/chromeec: Fix clang warnings ...................................................................... Patch Set 2: (2 comments) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163911): https://review.coreboot.org/c/coreboot/+/69742/comment/af18516b_3a489ef6 PS2, Line 8: 'an union' may be misspelled - perhaps 'a union'? File src/ec/google/chromeec/ec_commands.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163911): https://review.coreboot.org/c/coreboot/+/69742/comment/166123b4_5221205c PS2, Line 4644: } __ec_todo_packed set_param ; space prohibited before semicolon -- To view, visit https://review.coreboot.org/c/coreboot/+/69742 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b5233618081db86caedcb2d14870974e109ed9b Gerrit-Change-Number: 69742 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Thu, 17 Nov 2022 11:54:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: google/nyan/*: Add function argument
by Arthur Heymans (Code Review) 17 Nov '22

17 Nov '22

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69748 ) Change subject: google/nyan/*: Add function argument ...................................................................... google/nyan/*: Add function argument A function declaration without a prototype is deprecated in all versions of C. Change-Id: Ie22231908233f2fba25d78f6c5f53940011e8158 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/google/foster/sdram_configs.c M src/mainboard/google/gru/sdram_configs.c M src/mainboard/google/nyan/sdram_configs.c M src/mainboard/google/nyan_big/sdram_configs.c M src/mainboard/google/nyan_blaze/sdram_configs.c M src/mainboard/google/smaug/sdram_configs.c M src/mainboard/google/veyron/sdram_configs.c M src/mainboard/google/veyron_mickey/sdram_configs.c M src/mainboard/google/veyron_rialto/sdram_configs.c 9 files changed, 22 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/69748/1 diff --git a/src/mainboard/google/foster/sdram_configs.c b/src/mainboard/google/foster/sdram_configs.c index 25d6403..c42d787 100644 --- a/src/mainboard/google/foster/sdram_configs.c +++ b/src/mainboard/google/foster/sdram_configs.c @@ -11,7 +11,7 @@ #include "bct/sdram-unused.inc" /* ram_code = 0011 */ }; -const struct sdram_params *get_sdram_config() +const struct sdram_params *get_sdram_config(void) { uint32_t ramcode = sdram_get_ram_code(); /* diff --git a/src/mainboard/google/gru/sdram_configs.c b/src/mainboard/google/gru/sdram_configs.c index 2aceb9f..aae3377 100644 --- a/src/mainboard/google/gru/sdram_configs.c +++ b/src/mainboard/google/gru/sdram_configs.c @@ -44,7 +44,7 @@ return dram_928MHz; } -const struct rk3399_sdram_params *get_sdram_config() +const struct rk3399_sdram_params *get_sdram_config(void) { char config_file[64]; uint32_t ramcode; diff --git a/src/mainboard/google/nyan/sdram_configs.c b/src/mainboard/google/nyan/sdram_configs.c index 241fbce..a7ab4c7 100644 --- a/src/mainboard/google/nyan/sdram_configs.c +++ b/src/mainboard/google/nyan/sdram_configs.c @@ -24,7 +24,7 @@ #include "bct/sdram-unused.inc" /* ram_code = 1111 */ }; -const struct sdram_params *get_sdram_config() +const struct sdram_params *get_sdram_config(void) { uint32_t ramcode = sdram_get_ram_code(); /* diff --git a/src/mainboard/google/nyan_big/sdram_configs.c b/src/mainboard/google/nyan_big/sdram_configs.c index 15ed489..ee3816a 100644 --- a/src/mainboard/google/nyan_big/sdram_configs.c +++ b/src/mainboard/google/nyan_big/sdram_configs.c @@ -24,7 +24,7 @@ #include "bct/sdram-unused.inc" /* ram_code = 1111 */ }; -const struct sdram_params *get_sdram_config() +const struct sdram_params *get_sdram_config(void) { uint32_t ramcode = sdram_get_ram_code(); /* diff --git a/src/mainboard/google/nyan_blaze/sdram_configs.c b/src/mainboard/google/nyan_blaze/sdram_configs.c index 7972255..02a374c 100644 --- a/src/mainboard/google/nyan_blaze/sdram_configs.c +++ b/src/mainboard/google/nyan_blaze/sdram_configs.c @@ -24,7 +24,7 @@ #include "bct/sdram-unused.inc" /* ram_code = 1111 */ }; -const struct sdram_params *get_sdram_config() +const struct sdram_params *get_sdram_config(void) { uint32_t ramcode = sdram_get_ram_code(); /* diff --git a/src/mainboard/google/smaug/sdram_configs.c b/src/mainboard/google/smaug/sdram_configs.c index 8d45211..92e00d6 100644 --- a/src/mainboard/google/smaug/sdram_configs.c +++ b/src/mainboard/google/smaug/sdram_configs.c @@ -22,7 +22,7 @@ #include "bct/sdram-unused.inc" /* ram_code = 1111 */ }; -const struct sdram_params *get_sdram_config() +const struct sdram_params *get_sdram_config(void) { uint32_t ramcode = sdram_get_ram_code(); /* diff --git a/src/mainboard/google/veyron/sdram_configs.c b/src/mainboard/google/veyron/sdram_configs.c index b76ed09..4b04492 100644 --- a/src/mainboard/google/veyron/sdram_configs.c +++ b/src/mainboard/google/veyron/sdram_configs.c @@ -34,7 +34,7 @@ _Static_assert(ARRAY_SIZE(sdram_configs) == 24, "Must have 24 sdram_configs!"); -const struct rk3288_sdram_params *get_sdram_config() +const struct rk3288_sdram_params *get_sdram_config(void) { u32 ramcode = ram_code(); diff --git a/src/mainboard/google/veyron_mickey/sdram_configs.c b/src/mainboard/google/veyron_mickey/sdram_configs.c index b76ed09..4b04492 100644 --- a/src/mainboard/google/veyron_mickey/sdram_configs.c +++ b/src/mainboard/google/veyron_mickey/sdram_configs.c @@ -34,7 +34,7 @@ _Static_assert(ARRAY_SIZE(sdram_configs) == 24, "Must have 24 sdram_configs!"); -const struct rk3288_sdram_params *get_sdram_config() +const struct rk3288_sdram_params *get_sdram_config(void) { u32 ramcode = ram_code(); diff --git a/src/mainboard/google/veyron_rialto/sdram_configs.c b/src/mainboard/google/veyron_rialto/sdram_configs.c index 6a97c17..91b9439 100644 --- a/src/mainboard/google/veyron_rialto/sdram_configs.c +++ b/src/mainboard/google/veyron_rialto/sdram_configs.c @@ -34,7 +34,7 @@ _Static_assert(ARRAY_SIZE(sdram_configs) == 24, "Must have 24 sdram_configs!"); -const struct rk3288_sdram_params *get_sdram_config() +const struct rk3288_sdram_params *get_sdram_config(void) { u32 ramcode = ram_code(); -- To view, visit https://review.coreboot.org/c/coreboot/+/69748 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie22231908233f2fba25d78f6c5f53940011e8158 Gerrit-Change-Number: 69748 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: arch/arm/eabi_compat.c: Add eabi_clrX and eabi_memcyX
by Arthur Heymans (Code Review) 17 Nov '22

17 Nov '22

Attention is currently required from: Julius Werner. Hello Julius Werner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69743 to look at the new patch set (#2). Change subject: arch/arm/eabi_compat.c: Add eabi_clrX and eabi_memcyX ...................................................................... arch/arm/eabi_compat.c: Add eabi_clrX and eabi_memcyX Clang generated code uses this for zero initialized variables. Change-Id: I460a0096918141c1cf8826bdf1853a3aa3aecff8 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/arch/arm/eabi_compat.c 1 file changed, 35 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/69743/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69743 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I460a0096918141c1cf8826bdf1853a3aa3aecff8 Gerrit-Change-Number: 69743 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: arch/arm: Use unified assembly syntax
by Arthur Heymans (Code Review) 17 Nov '22

17 Nov '22

Attention is currently required from: Arthur Heymans, Julius Werner. Arthur Heymans has uploaded a new patch set (#28) to the change originally created by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/63058 ) Change subject: arch/arm: Use unified assembly syntax ...................................................................... arch/arm: Use unified assembly syntax Taken from Linux which also updated these files. TESTED on qemu vexpress-a9 and verstage on google/vilboz with BUILD_TIMELESS=1, binaries remain the same. Change-Id: Ia320dc2c460c99d934b8f17dee7748a9def4e750 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/arch/arm/libgcc/lib1funcs.S M src/arch/arm/memcpy.S M src/arch/arm/memmove.S M src/arch/arm/memset.S 4 files changed, 57 insertions(+), 34 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/63058/28 -- To view, visit https://review.coreboot.org/c/coreboot/+/63058 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia320dc2c460c99d934b8f17dee7748a9def4e750 Gerrit-Change-Number: 63058 Gerrit-PatchSet: 28 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/alderlake: Update ME HFSTS register definition
by Eric Lai (Code Review) 17 Nov '22

17 Nov '22

Attention is currently required from: Tarun Tuli, Martin L Roth, Rizwan Qureshi, Paul Menzel. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69286 ) Change subject: soc/intel/alderlake: Update ME HFSTS register definition ...................................................................... Patch Set 4: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/69286/comment/5bcb43e2_774037ad PS4, Line 15: TEST= build and boot nivviks platform nit: no space. -- To view, visit https://review.coreboot.org/c/coreboot/+/69286 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9aeee7a3b41ad59c03391207930a253ffff19ae5 Gerrit-Change-Number: 69286 Gerrit-PatchSet: 4 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Thu, 17 Nov 2022 11:53:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: sb/intel/i82801dx: Improve LPC device early init
by Elyes Haouas (Code Review) 17 Nov '22

17 Nov '22

Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69671 ) Change subject: sb/intel/i82801dx: Improve LPC device early init ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Please check https://review.coreboot.org/c/coreboot/+/69717 -- To view, visit https://review.coreboot.org/c/coreboot/+/69671 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I41ad8622801dbbadafdc37359d521eed42256e63 Gerrit-Change-Number: 69671 Gerrit-PatchSet: 3 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Thu, 17 Nov 2022 11:27:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: drivers/i2c/rx6110sa/rx6110sa.c: Make log messages consistent
by Jan Samek (Code Review) 17 Nov '22

17 Nov '22

Jan Samek has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69718 ) Change subject: drivers/i2c/rx6110sa/rx6110sa.c: Make log messages consistent ...................................................................... drivers/i2c/rx6110sa/rx6110sa.c: Make log messages consistent Set the logging message prefix to the device name instead of the device path in order to make the output consistent with other logging messages in this and other drivers. Change-Id: Ib63b93d52aad220d17f1f4ee0d47a949933ec26d Signed-off-by: Jan Samek <jan.samek(a)siemens.com> --- M src/drivers/i2c/rx6110sa/rx6110sa.c 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/69718/1 diff --git a/src/drivers/i2c/rx6110sa/rx6110sa.c b/src/drivers/i2c/rx6110sa/rx6110sa.c index d30963c..02b3d9f 100644 --- a/src/drivers/i2c/rx6110sa/rx6110sa.c +++ b/src/drivers/i2c/rx6110sa/rx6110sa.c @@ -183,7 +183,7 @@ break; default: printk(BIOS_INFO, "%s: Bus speed unsupported, fall back to %d kHz!\n", - dev_path(dev), I2C_SPEED_STANDARD / 1000); + dev->chip_ops->name, I2C_SPEED_STANDARD / 1000); bus_speed = I2C_SPEED_STANDARD; break; } -- To view, visit https://review.coreboot.org/c/coreboot/+/69718 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib63b93d52aad220d17f1f4ee0d47a949933ec26d Gerrit-Change-Number: 69718 Gerrit-PatchSet: 1 Gerrit-Owner: Jan Samek <jan.samek(a)siemens.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022