Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69968 )
Change subject: soc/intel/cmn/cse: Create API to get CSE Lite WP Information
......................................................................
soc/intel/cmn/cse: Create API to get CSE Lite WP Information
This patch creates an API for CSE-Lite specific SKU to retrieve the
Write Protect (WP)Â information (`cse_log_ro_write_protection_info`)
like WP range and limit, if the region is write-protected or not etc.
BUG=none
TEST=Able to compile the cse_lite.c file for google/kano without
any error.
Signed-off-by: Subrata Banik <subratabanik(a)google.com>
Change-Id: I8f4b7880534ded5401b6f8d601ded88019c636c8
---
M src/soc/intel/common/block/cse/cse_lite.c
M src/soc/intel/common/block/include/intelblocks/cse.h
2 files changed, 44 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/69968/1
diff --git a/src/soc/intel/common/block/cse/cse_lite.c b/src/soc/intel/common/block/cse/cse_lite.c
index f051061..37640f4 100644
--- a/src/soc/intel/common/block/cse/cse_lite.c
+++ b/src/soc/intel/common/block/cse/cse_lite.c
@@ -10,6 +10,7 @@
#include <intelbasecode/debug_feature.h>
#include <intelblocks/cse.h>
#include <intelblocks/cse_layout.h>
+#include <intelblocks/spi.h>
#include <security/vboot/misc.h>
#include <security/vboot/vboot_common.h>
#include <soc/intel/common/reset.h>
@@ -133,6 +134,28 @@
static const char * const cse_regions[] = {"RO", "RW"};
+void cse_log_ro_write_protection_info(bool mfg_mode)
+{
+ bool cse_ro_wp_en = is_spi_wp_cse_ro_en();
+
+ printk(BIOS_DEBUG, "ME: WP for RO is enabled : %s\n",
+ cse_ro_wp_en ? "YES" : "NO");
+
+ if (cse_ro_wp_en) {
+ uint32_t base, limit;
+ spi_get_wp_cse_ro_range(&base, &limit);
+ printk(BIOS_DEBUG, "ME: RO write protection scope - Start=0x%X, End=0x%X\n",
+ base, limit);
+ }
+
+ /*
+ * If manufacturing mode is disabled, but CSE RO is not write protected,
+ * log error.
+ */
+ if (!mfg_mode && !cse_ro_wp_en)
+ printk(BIOS_ERR, "ME: Write protection for CSE RO is not enabled\n");
+}
+
bool cse_get_boot_performance_data(struct cse_boot_perf_rsp *boot_perf_rsp)
{
struct cse_boot_perf_req {
diff --git a/src/soc/intel/common/block/include/intelblocks/cse.h b/src/soc/intel/common/block/include/intelblocks/cse.h
index f7aae1c..cceee4f 100644
--- a/src/soc/intel/common/block/include/intelblocks/cse.h
+++ b/src/soc/intel/common/block/include/intelblocks/cse.h
@@ -555,4 +555,7 @@
*/
void cse_get_telemetry_data(void);
+/* Function to log the cse WP information like range, if WP etc. */
+void cse_log_ro_write_protection_info(bool mfg_mode);
+
#endif // SOC_INTEL_COMMON_CSE_H
--
To view, visit https://review.coreboot.org/c/coreboot/+/69968
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8f4b7880534ded5401b6f8d601ded88019c636c8
Gerrit-Change-Number: 69968
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-MessageType: newchange
Attention is currently required from: Tarun Tuli, Martin L Roth, Dtrain Hsu, Subrata Banik, Kyle Lin.
Frank Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69180 )
Change subject: mb/google/brya/var/marasov: Update gpio table
......................................................................
Patch Set 11: -Code-Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/69180
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I03b443826d39182eaf23ad3e4e0ba8d6b8a93022
Gerrit-Change-Number: 69180
Gerrit-PatchSet: 11
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Kyle Lin <kylelinck(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kyle Lin <kylelinck(a)google.com>
Gerrit-Comment-Date: Thu, 24 Nov 2022 10:13:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Ian Feng, Reka Norman.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69960 )
Change subject: mb/google/nissa/var/xivu: Update DPTF parameters
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/69960
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8539a29cab4863034a2b64d38aef4b772473246d
Gerrit-Change-Number: 69960
Gerrit-PatchSet: 2
Gerrit-Owner: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Comment-Date: Thu, 24 Nov 2022 10:01:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Ian Feng, Reka Norman, Sumeet R Pawnikar.
Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69960 )
Change subject: mb/google/nissa/var/xivu: Update DPTF parameters
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/69960
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8539a29cab4863034a2b64d38aef4b772473246d
Gerrit-Change-Number: 69960
Gerrit-PatchSet: 2
Gerrit-Owner: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Comment-Date: Thu, 24 Nov 2022 09:58:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Martin L Roth, Dtrain Hsu, Subrata Banik, Kyle Lin.
Frank Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69180 )
Change subject: mb/google/brya/var/marasov: Update gpio table
......................................................................
Patch Set 11: Code-Review+1
(1 comment)
File src/mainboard/google/brya/variants/marasov/gpio.c:
https://review.coreboot.org/c/coreboot/+/69180/comment/9c08ae6c_a2f67729
PS11, Line 74: static const struct pad_config early_gpio_table[] = {
: };
> From CB:69376, your TPM is in I2C1. […]
you mean GSC?
this GPIO porting for first SMT
--
To view, visit https://review.coreboot.org/c/coreboot/+/69180
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I03b443826d39182eaf23ad3e4e0ba8d6b8a93022
Gerrit-Change-Number: 69180
Gerrit-PatchSet: 11
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Kyle Lin <kylelinck(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kyle Lin <kylelinck(a)google.com>
Gerrit-Comment-Date: Thu, 24 Nov 2022 09:57:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Ian Feng, Reka Norman, Sumeet R Pawnikar.
Ian Feng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69960 )
Change subject: mb/google/nissa/var/xivu: Update DPTF parameters
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69960/comment/677c2325_4b3dca81
PS1, Line 9: DTT_setting_20221122_V04_PR.xlsx
> Done
This is provided by the thermal team in the issue tracker.https://partnerissuetracker.corp.google.com/issues/249446156#commen…
--
To view, visit https://review.coreboot.org/c/coreboot/+/69960
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8539a29cab4863034a2b64d38aef4b772473246d
Gerrit-Change-Number: 69960
Gerrit-PatchSet: 2
Gerrit-Owner: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Comment-Date: Thu, 24 Nov 2022 09:55:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Comment-In-Reply-To: Kangheui Won <khwon(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Ian Feng, Reka Norman, Sumeet R Pawnikar.
Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69960 )
Change subject: mb/google/nissa/var/xivu: Update DPTF parameters
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/69960
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8539a29cab4863034a2b64d38aef4b772473246d
Gerrit-Change-Number: 69960
Gerrit-PatchSet: 2
Gerrit-Owner: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Comment-Date: Thu, 24 Nov 2022 09:46:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Kangheui Won, Reka Norman, Sumeet R Pawnikar.
Ian Feng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69960 )
Change subject: mb/google/nissa/var/xivu: Update DPTF parameters
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69960/comment/da0b1f18_781251bf
PS1, Line 9: DTT_setting_20221122_V04_PR.xlsx
> What's this? Can you replace filename with more descriptive words?
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/69960
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8539a29cab4863034a2b64d38aef4b772473246d
Gerrit-Change-Number: 69960
Gerrit-PatchSet: 2
Gerrit-Owner: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Kangheui Won <khwon(a)chromium.org>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Comment-Date: Thu, 24 Nov 2022 09:39:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kangheui Won <khwon(a)chromium.org>
Gerrit-MessageType: comment