Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69878 )
Change subject: sb/intel/i82801gx: Use "sb/intel/common/tco.h" macros
......................................................................
Patch Set 4:
(1 comment)
File src/southbridge/intel/i82801gx/early_init.c:
https://review.coreboot.org/c/coreboot/+/69878/comment/8a24b96f_a082114f
PS4, Line 74: PMBASE_TCO_OFFSET
as lpc_get_pmbase() will return the pmbase, this should be :
write_pmbase16(TCO1_CNT, TCO_TMR_HLT);
--
To view, visit https://review.coreboot.org/c/coreboot/+/69878
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id281a3478051c4876ccbe26452d8744769c86654
Gerrit-Change-Number: 69878
Gerrit-PatchSet: 4
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 24 Nov 2022 08:32:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Frank Wu, John Su, Jason Nien, Matt DeVillier, Chris Wang, Martin Roth, Tim Van Patten.
Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69565 )
Change subject: mb/google/skyrim/var/frostflow: Set Package Power Parameters
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/69565
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15a69df1436aba05bc19eaffd79394e5ca9bdb3a
Gerrit-Change-Number: 69565
Gerrit-PatchSet: 5
Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com>
Gerrit-CC: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com>
Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Tim Van Patten <timvp(a)google.com>
Gerrit-Comment-Date: Thu, 24 Nov 2022 08:23:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Werner Zeh.
Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69966 )
Change subject: mb/siemens/mc_ehl2: Disable L1 prefetcher
......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69966/comment/e3ed788e_3c6c3db5
PS2, Line 10: disable
> disabled
Ack
https://review.coreboot.org/c/coreboot/+/69966/comment/4fede859_8603eb84
PS2, Line 13: more detailed description
> I’d prefer to copy the detailed description.
Done
Patchset:
PS3:
Thanks for review Paul.
File src/mainboard/siemens/mc_ehl/variants/mc_ehl2/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/69966/comment/223c6fc8_a59053ab
PS2, Line 138: # Disable L1 prefetcher
> … for real-time demands
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/69966
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I07b27dd672533e693a6c2987d16f54333850760e
Gerrit-Change-Number: 69966
Gerrit-PatchSet: 3
Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Comment-Date: Thu, 24 Nov 2022 08:23:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Mario Scheithauer, Werner Zeh.
Hello Werner Zeh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/69966
to look at the new patch set (#3).
Change subject: mb/siemens/mc_ehl2: Disable L1 prefetcher
......................................................................
mb/siemens/mc_ehl2: Disable L1 prefetcher
As for mainboard mc_ehl1, a hard real-time dependency is also required
for this mainboard. The L1 prefetcher on Elkhart Lake is too aggressive
which in the end leads to an increased number of cache misses. Disabling
the L1 prefetcher boosts up the performance (in some cases by more than
10 %) in this specific use case.
Change-Id: I07b27dd672533e693a6c2987d16f54333850760e
Signed-off-by: Mario Scheithauer <mario.scheithauer(a)siemens.com>
---
M src/mainboard/siemens/mc_ehl/variants/mc_ehl2/devicetree.cb
1 file changed, 19 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/69966/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/69966
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I07b27dd672533e693a6c2987d16f54333850760e
Gerrit-Change-Number: 69966
Gerrit-PatchSet: 3
Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tarun Tuli, Derek Huang, Paul Menzel, Zhuohao Lee.
Raymond Chung has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69964 )
Change subject: mb/google/brya/var/gaelin: Configure audio in devicetree
......................................................................
Patch Set 3: Code-Review+1
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69964/comment/58f1fbeb_964f0885
PS2, Line 7: Add audio settings
> Maybe: […]
Done
https://review.coreboot.org/c/coreboot/+/69964/comment/8eb30f7e_9f9039e3
PS2, Line 9: Add audio settings for gaelin.
> Please mention the source for the settings.
Done
https://review.coreboot.org/c/coreboot/+/69964/comment/1d730410_4c3993a8
PS2, Line 13: TEST=Able to verify audio playback on gaelin with this change.
> In the OS? Please mention the Linux kernel version.
Done
Patchset:
PS3:
I modified the commit message, please review again.
--
To view, visit https://review.coreboot.org/c/coreboot/+/69964
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc8cacce6cb4b3e55fc7332bb9eb9ac20848fc5b
Gerrit-Change-Number: 69964
Gerrit-PatchSet: 3
Gerrit-Owner: Raymond Chung <raymondchung(a)ami.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com>
Gerrit-Reviewer: Raymond Chung <raymondchung(a)ami.corp-partner.google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-CC: Bruce Chiang <brucechiang(a)msi.corp-partner.google.com>
Gerrit-CC: Eason Chang <easonchang(a)msi.corp-partner.google.com>
Gerrit-CC: Eddy Lu <eddylu(a)ami.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Derek Huang <derekhuang(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Comment-Date: Thu, 24 Nov 2022 08:19:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Raymond Chung, Derek Huang, Zhuohao Lee.
Hello Tarun Tuli, Derek Huang, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/69964
to look at the new patch set (#3).
Change subject: mb/google/brya/var/gaelin: Configure audio in devicetree
......................................................................
mb/google/brya/var/gaelin: Configure audio in devicetree
Refer to brask board to add audio settings for gaelin.
BUG=b:253177160
BRANCH=firmware-brya-14505.B
TEST=Able to verify audio playback on gaelin with kernel v5.10.
Change-Id: Ibc8cacce6cb4b3e55fc7332bb9eb9ac20848fc5b
Signed-off-by: Raymond Chung <raymondchung(a)ami.corp-partner.google.com>
---
M src/mainboard/google/brya/variants/gaelin/overridetree.cb
1 file changed, 46 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/69964/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/69964
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc8cacce6cb4b3e55fc7332bb9eb9ac20848fc5b
Gerrit-Change-Number: 69964
Gerrit-PatchSet: 3
Gerrit-Owner: Raymond Chung <raymondchung(a)ami.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com>
Gerrit-Reviewer: Raymond Chung <raymondchung(a)ami.corp-partner.google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-CC: Bruce Chiang <brucechiang(a)msi.corp-partner.google.com>
Gerrit-CC: Eason Chang <easonchang(a)msi.corp-partner.google.com>
Gerrit-CC: Eddy Lu <eddylu(a)ami.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Raymond Chung <raymondchung(a)ami.corp-partner.google.com>
Gerrit-Attention: Derek Huang <derekhuang(a)google.com>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-MessageType: newpatchset