Attention is currently required from: Tarun Tuli, Martin L Roth, Subrata Banik, Kyle Lin, Frank Chu.
Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69180 )
Change subject: mb/google/brya/var/marasov: Update gpio table
......................................................................
Patch Set 11: Code-Review+1
(1 comment)
File src/mainboard/google/brya/variants/marasov/gpio.c:
https://review.coreboot.org/c/coreboot/+/69180/comment/c998ca69_fdf8811a
PS11, Line 74: static const struct pad_config early_gpio_table[] = {
: };
From CB:69376, your TPM is in I2C1. Do you need to config I2C bus in here?
--
To view, visit https://review.coreboot.org/c/coreboot/+/69180
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I03b443826d39182eaf23ad3e4e0ba8d6b8a93022
Gerrit-Change-Number: 69180
Gerrit-PatchSet: 11
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Kyle Lin <kylelinck(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kyle Lin <kylelinck(a)google.com>
Gerrit-Attention: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 24 Nov 2022 08:53:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69878 )
Change subject: sb/intel/i82801gx: Use "sb/intel/common/tco.h" macros
......................................................................
Patch Set 4:
(1 comment)
File src/southbridge/intel/i82801gx/early_init.c:
https://review.coreboot.org/c/coreboot/+/69878/comment/0e1b3646_9984586b
PS4, Line 74: PMBASE_TCO_OFFSET
> see https://review.coreboot.org/c/coreboot/+/69979 […]
sorry for the noise.
TCOBASE is at PMBASE + 0x60
--
To view, visit https://review.coreboot.org/c/coreboot/+/69878
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id281a3478051c4876ccbe26452d8744769c86654
Gerrit-Change-Number: 69878
Gerrit-PatchSet: 4
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 24 Nov 2022 08:49:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-MessageType: comment
Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/69979 )
Change subject: sb/intel/i82801gx/early_init.c: Fix write_pmbase16() parameters
......................................................................
Abandoned
this is wrong
--
To view, visit https://review.coreboot.org/c/coreboot/+/69979
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I635ef5c5b70123d06913023a0e91724285488e4f
Gerrit-Change-Number: 69979
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: abandon
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69878 )
Change subject: sb/intel/i82801gx: Use "sb/intel/common/tco.h" macros
......................................................................
Patch Set 4:
(1 comment)
File src/southbridge/intel/i82801gx/early_init.c:
https://review.coreboot.org/c/coreboot/+/69878/comment/e7c71555_519eb444
PS4, Line 74: PMBASE_TCO_OFFSET
> as lpc_get_pmbase() will return the pmbase, this should be : […]
see https://review.coreboot.org/c/coreboot/+/69979
Thx
--
To view, visit https://review.coreboot.org/c/coreboot/+/69878
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id281a3478051c4876ccbe26452d8744769c86654
Gerrit-Change-Number: 69878
Gerrit-PatchSet: 4
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 24 Nov 2022 08:38:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-MessageType: comment