coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[M] Change in coreboot[master]: mb/intel/mtlrvp: Add bootblock and early gpio for MTL-RVP
by Harsha B R (Code Review) 26 Nov '22

26 Nov '22

Attention is currently required from: Ashish Kumar Mishra, Haribalaraman Ramasubramanian, Rizwan Qureshi, Krishna P Bhat D, Balaji Manigandan, Eric Lai, Ronak Kanabar, Usha P. Harsha B R has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69886 ) Change subject: mb/intel/mtlrvp: Add bootblock and early gpio for MTL-RVP ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > maybe just gpio. […] Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/69886 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9c0893e52036147c5f6bbfafc6d818e9d3460bed Gerrit-Change-Number: 69886 Gerrit-PatchSet: 2 Gerrit-Owner: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Reviewer: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com> Gerrit-Reviewer: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Attention: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Usha P <usha.p(a)intel.com> Gerrit-Comment-Date: Sat, 26 Nov 2022 06:51:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/intel/mtlrvp: Add bootblock and early gpio for MTL-RVP
by Harsha B R (Code Review) 26 Nov '22

26 Nov '22

Attention is currently required from: Ashish Kumar Mishra, Harsha B R, Haribalaraman Ramasubramanian, Rizwan Qureshi, Krishna P Bhat D, Balaji Manigandan, Ronak Kanabar, Usha P. Hello build bot (Jenkins), Ashish Kumar Mishra, Haribalaraman Ramasubramanian, Rizwan Qureshi, Krishna P Bhat D, Balaji Manigandan, Eric Lai, Ronak Kanabar, Usha P, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69886 to look at the new patch set (#2). Change subject: mb/intel/mtlrvp: Add bootblock and early gpio for MTL-RVP ...................................................................... mb/intel/mtlrvp: Add bootblock and early gpio for MTL-RVP This adds an initial bootblock code. This also configures required GPIOs for early board initialization. 1. Add bootblock file for MTL-RVP 2. Add early gpio config for MTL-P variant in gpio.c BRANCH=none BUG=b:224325352 TEST=FW_NAME=mtlrvp_p emerge-rex coreboot chromeos-bootimage Signed-off-by: Harsha B R <harsha.b.r(a)intel.com> Change-Id: I9c0893e52036147c5f6bbfafc6d818e9d3460bed --- M src/mainboard/intel/mtlrvp/Makefile.inc A src/mainboard/intel/mtlrvp/bootblock.c M src/mainboard/intel/mtlrvp/variants/mtlrvp_p/Makefile.inc M src/mainboard/intel/mtlrvp/variants/mtlrvp_p/gpio.c 4 files changed, 142 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/69886/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69886 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9c0893e52036147c5f6bbfafc6d818e9d3460bed Gerrit-Change-Number: 69886 Gerrit-PatchSet: 2 Gerrit-Owner: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Reviewer: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com> Gerrit-Reviewer: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Attention: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Attention: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Usha P <usha.p(a)intel.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[master]: util/crossgcc: Update binutils from 2.37 to 2.39
by Felix Singer (Code Review) 26 Nov '22

26 Nov '22

Attention is currently required from: Julius Werner, Elyes Haouas. Hello build bot (Jenkins), Martin L Roth, Julius Werner, Arthur Heymans, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/66920 to look at the new patch set (#18). Change subject: util/crossgcc: Update binutils from 2.37 to 2.39 ...................................................................... util/crossgcc: Update binutils from 2.37 to 2.39 Change-Id: I34a20a999f7ea624c1add4750fcd116166953dd8 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M util/crossgcc/buildgcc D util/crossgcc/patches/binutils-2.37_no-bfd-doc.patch D util/crossgcc/patches/binutils-2.37_no-makeinfo.patch R util/crossgcc/patches/binutils-2.39_as-ipxe.patch A util/crossgcc/patches/binutils-2.39_no-makeinfo.patch D util/crossgcc/sum/binutils-2.37.tar.xz.cksum A util/crossgcc/sum/binutils-2.39.tar.xz.cksum 7 files changed, 255 insertions(+), 250 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/66920/18 -- To view, visit https://review.coreboot.org/c/coreboot/+/66920 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I34a20a999f7ea624c1add4750fcd116166953dd8 Gerrit-Change-Number: 66920 Gerrit-PatchSet: 18 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[master]: security/tpm: resolve conflicts in TSS implementations
by Yu-Ping Wu (Code Review) 26 Nov '22

26 Nov '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Michał Żygowski, Frans Hendriks, Matt DeVillier, Christian Walter, Julius Werner, Krystian Hebel, Fred Reitberger, Sergii Dmytruk, Felix Held. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69160 ) Change subject: security/tpm: resolve conflicts in TSS implementations ...................................................................... Patch Set 10: Code-Review+1 (1 comment) File src/security/tpm/tss/tss.c: https://review.coreboot.org/c/coreboot/+/69160/comment/63d892e2_182e0fec PS8, Line 22: VB2_SUCCESS > That might be even more confusing, because these functions can also return codes from TPM (`TPM_E_*` […] Actually I was talking about this function only. This just doesn't seem to be closely related vboot. Anyway, I'm fine with keeping this as is. -- To view, visit https://review.coreboot.org/c/coreboot/+/69160 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia0ea5a917c46ada9fc3274f17240e12bca98db6a Gerrit-Change-Number: 69160 Gerrit-PatchSet: 10 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 26 Nov 2022 02:58:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Comment-In-Reply-To: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: security/tpm/: turn tis_{init,open} into tis_probe
by Yu-Ping Wu (Code Review) 26 Nov '22

26 Nov '22

Attention is currently required from: Michał Żygowski, Christian Walter, Julius Werner, Krystian Hebel, Sergii Dmytruk. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68991 ) Change subject: security/tpm/: turn tis_{init,open} into tis_probe ...................................................................... Patch Set 2: (1 comment) File src/security/tpm/tss/tcg-1.2/tss.c: https://review.coreboot.org/c/coreboot/+/68991/comment/d0abbfe3_8395b622 PS2, Line 35: tis_sendrecv > Just by assuming that API is initialized before being used like the code was already doing. Before this patch, `tis_sendrecv` was defined in each tis implementation, so it wouldn't possibly be NULL. Can we add a `die_if` check here? -- To view, visit https://review.coreboot.org/c/coreboot/+/68991 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib4ce35ada24e3959ea1a518c29d431b4ae123809 Gerrit-Change-Number: 68991 Gerrit-PatchSet: 2 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Sat, 26 Nov 2022 02:55:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Comment-In-Reply-To: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Revert "crossgcc: Upgrade IASL from 20211217 to 20220331"
by Elyes Haouas (Code Review) 26 Nov '22

26 Nov '22

Attention is currently required from: Martin L Roth, Arthur Heymans, Felix Held. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64103 ) Change subject: Revert "crossgcc: Upgrade IASL from 20211217 to 20220331" ...................................................................... Patch Set 3: -Code-Review -- To view, visit https://review.coreboot.org/c/coreboot/+/64103 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5c1b30585fdfab046a40d1721276d0fa40457a10 Gerrit-Change-Number: 64103 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 26 Nov 2022 02:51:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Update arm-trusted-firmware submodule to upstream v2.8.0
by Felix Singer (Code Review) 26 Nov '22

26 Nov '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/69946 ) Change subject: Update arm-trusted-firmware submodule to upstream v2.8.0 ...................................................................... Update arm-trusted-firmware submodule to upstream v2.8.0 Updating from commit id 61fe7826d: 2022-10-18 16:20:05 +0200 - (Merge "feat(fvp): build delegated attestation in BL31" into integration) to commit id 9881bb93a: 2022-11-21 19:12:00 +0100 - (Merge "docs(spm): update threat model" into integration) This brings in 227 new commits. Change-Id: I6c902a7360b5436df22c829c7e387457598c3b94 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/69946 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Singer <felixsinger(a)posteo.net> --- M 3rdparty/arm-trusted-firmware 1 file changed, 22 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved diff --git a/3rdparty/arm-trusted-firmware b/3rdparty/arm-trusted-firmware index 61fe782..9881bb9 160000 --- a/3rdparty/arm-trusted-firmware +++ b/3rdparty/arm-trusted-firmware @@ -1 +1 @@ -Subproject commit 61fe7826d8ae41c906b2189136a1ae482f91f84a +Subproject commit 9881bb93a3bc0a3ea37e9f093e09ab4b360a9e48 -- To view, visit https://review.coreboot.org/c/coreboot/+/69946 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6c902a7360b5436df22c829c7e387457598c3b94 Gerrit-Change-Number: 69946 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: Revert "crossgcc: Upgrade IASL from 20211217 to 20220331"
by Felix Singer (Code Review) 26 Nov '22

26 Nov '22

Attention is currently required from: Martin L Roth, Arthur Heymans, Elyes Haouas, Felix Held. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64103 ) Change subject: Revert "crossgcc: Upgrade IASL from 20211217 to 20220331" ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Can be abandoned since CB:68929 got merged -- To view, visit https://review.coreboot.org/c/coreboot/+/64103 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5c1b30585fdfab046a40d1721276d0fa40457a10 Gerrit-Change-Number: 64103 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 26 Nov 2022 01:09:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/kinox: Add ACPI DmaProperty for WLAN device
by Kapil Porwal (Code Review) 25 Nov '22

25 Nov '22

Attention is currently required from: Tarun Tuli. Kapil Porwal has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/70018 ) Change subject: mb/google/brya/var/kinox: Add ACPI DmaProperty for WLAN device ...................................................................... mb/google/brya/var/kinox: Add ACPI DmaProperty for WLAN device BUG=b:259716145 TEST=TBD Signed-off-by: Kapil Porwal <kapilporwal(a)google.com> Change-Id: Ifaa0912b38129ed2db01fb78ed39c0db89e746fb --- M src/mainboard/google/brya/variants/kinox/overridetree.cb 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/70018/1 diff --git a/src/mainboard/google/brya/variants/kinox/overridetree.cb b/src/mainboard/google/brya/variants/kinox/overridetree.cb index f340621..9bfda79 100644 --- a/src/mainboard/google/brya/variants/kinox/overridetree.cb +++ b/src/mainboard/google/brya/variants/kinox/overridetree.cb @@ -235,6 +235,7 @@ }" chip drivers/wifi/generic register "wake" = "GPE0_DW1_03" + register "add_acpi_dma_property" = "true" device pci 00.0 on end end chip soc/intel/common/block/pcie/rtd3 -- To view, visit https://review.coreboot.org/c/coreboot/+/70018 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifaa0912b38129ed2db01fb78ed39c0db89e746fb Gerrit-Change-Number: 70018 Gerrit-PatchSet: 1 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: mb/google/brya: Add ACPI DmaProperty for ethernet devices
by Kapil Porwal (Code Review) 25 Nov '22

25 Nov '22

Attention is currently required from: Tarun Tuli. Kapil Porwal has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/70017 ) Change subject: mb/google/brya: Add ACPI DmaProperty for ethernet devices ...................................................................... mb/google/brya: Add ACPI DmaProperty for ethernet devices BUG=b:259716145 TEST=TBD Signed-off-by: Kapil Porwal <kapilporwal(a)google.com> Change-Id: I647593fd02644d30cd21b60d8305c0ec55dc64cb --- M src/mainboard/google/brya/variants/agah/overridetree.cb M src/mainboard/google/brya/variants/brask/overridetree.cb M src/mainboard/google/brya/variants/kinox/overridetree.cb M src/mainboard/google/brya/variants/kuldax/overridetree.cb M src/mainboard/google/brya/variants/lisbon/overridetree.cb M src/mainboard/google/brya/variants/moli/overridetree.cb M src/mainboard/google/brya/variants/osiris/overridetree.cb 7 files changed, 20 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/70017/1 diff --git a/src/mainboard/google/brya/variants/agah/overridetree.cb b/src/mainboard/google/brya/variants/agah/overridetree.cb index 69afa24..53c60c1 100644 --- a/src/mainboard/google/brya/variants/agah/overridetree.cb +++ b/src/mainboard/google/brya/variants/agah/overridetree.cb @@ -225,6 +225,7 @@ register "customized_leds" = "0x05af" register "wake" = "GPE0_DW0_07" register "device_index" = "0" + register "add_acpi_dma_property" = "true" device pci 00.0 on end end end #RTL8111H Ethernet NIC diff --git a/src/mainboard/google/brya/variants/brask/overridetree.cb b/src/mainboard/google/brya/variants/brask/overridetree.cb index b967b53..b2169c3 100644 --- a/src/mainboard/google/brya/variants/brask/overridetree.cb +++ b/src/mainboard/google/brya/variants/brask/overridetree.cb @@ -77,6 +77,7 @@ register "customized_led0" = "0x23f" register "customized_led2" = "0x028" register "enable_aspm_l1_2" = "1" + register "add_acpi_dma_property" = "true" device pci 00.0 on end end end # RTL8125 Ethernet NIC diff --git a/src/mainboard/google/brya/variants/kinox/overridetree.cb b/src/mainboard/google/brya/variants/kinox/overridetree.cb index 01610c1..f340621 100644 --- a/src/mainboard/google/brya/variants/kinox/overridetree.cb +++ b/src/mainboard/google/brya/variants/kinox/overridetree.cb @@ -265,6 +265,7 @@ register "customized_leds" = "0x05af" register "wake" = "GPE0_DW0_07" #GPP_A7 register "device_index" = "0" + register "add_acpi_dma_property" = "true" device pci 00.0 on end end end # RTL8111K Ethernet NIC diff --git a/src/mainboard/google/brya/variants/kuldax/overridetree.cb b/src/mainboard/google/brya/variants/kuldax/overridetree.cb index a158788..e36c9f4 100644 --- a/src/mainboard/google/brya/variants/kuldax/overridetree.cb +++ b/src/mainboard/google/brya/variants/kuldax/overridetree.cb @@ -177,6 +177,7 @@ register "customized_led0" = "0x23f" register "customized_led2" = "0x028" register "enable_aspm_l1_2" = "1" + register "add_acpi_dma_property" = "true" device pci 00.0 on end end end # RTL8125 Ethernet NIC diff --git a/src/mainboard/google/brya/variants/lisbon/overridetree.cb b/src/mainboard/google/brya/variants/lisbon/overridetree.cb index fc285639..6c471b3 100644 --- a/src/mainboard/google/brya/variants/lisbon/overridetree.cb +++ b/src/mainboard/google/brya/variants/lisbon/overridetree.cb @@ -192,6 +192,7 @@ register "customized_led0" = "0x23f" register "customized_led2" = "0x028" register "enable_aspm_l1_2" = "1" + register "add_acpi_dma_property" = "true" device pci 00.0 on end end end # RTL8111 Ethernet NIC diff --git a/src/mainboard/google/brya/variants/moli/overridetree.cb b/src/mainboard/google/brya/variants/moli/overridetree.cb index f3b28c4..2c13c64 100644 --- a/src/mainboard/google/brya/variants/moli/overridetree.cb +++ b/src/mainboard/google/brya/variants/moli/overridetree.cb @@ -160,6 +160,7 @@ register "customized_leds" = "0x0482" register "wake" = "GPE0_DW0_07" register "device_index" = "0" + register "add_acpi_dma_property" = "true" device pci 00.0 on end end end # RTL8111K Ethernet NIC diff --git a/src/mainboard/google/brya/variants/osiris/overridetree.cb b/src/mainboard/google/brya/variants/osiris/overridetree.cb index be4e251..d76cf43 100644 --- a/src/mainboard/google/brya/variants/osiris/overridetree.cb +++ b/src/mainboard/google/brya/variants/osiris/overridetree.cb @@ -247,6 +247,7 @@ register "customized_led0" = "0x23f" register "customized_led2" = "0x028" register "enable_aspm_l1_2" = "1" + register "add_acpi_dma_property" = "true" device pci 00.0 on end end # Enable PCIE 7 using clk 6 -- To view, visit https://review.coreboot.org/c/coreboot/+/70017 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I647593fd02644d30cd21b60d8305c0ec55dc64cb Gerrit-Change-Number: 70017 Gerrit-PatchSet: 1 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022