coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: acpi: Create a common method to add DmaProperty
by Kapil Porwal (Code Review) 26 Nov '22

26 Nov '22

Attention is currently required from: Lance Zhao, Tim Wawrzynczak. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70022 ) Change subject: acpi: Create a common method to add DmaProperty ...................................................................... Patch Set 2: (2 comments) File src/acpi/device.c: https://review.coreboot.org/c/coreboot/+/70022/comment/10502348_a9ce83c1 PS1, Line 1194: if (prev_dsd == NULL) { > > braces {} are not necessary for single statement blocks […] Ack https://review.coreboot.org/c/coreboot/+/70022/comment/bc58caba_886bf2a7 PS1, Line 1200: if (prev_dsd == NULL) { > > braces {} are not necessary for single statement blocks […] Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/70022 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I75b3f22ad29f90f3c3b251bd0d70bae9d75f71fe Gerrit-Change-Number: 70022 Gerrit-PatchSet: 2 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Comment-Date: Sat, 26 Nov 2022 13:49:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: acpi: Create a common method to add DmaProperty
by build bot (Jenkins) (Code Review) 26 Nov '22

26 Nov '22

Attention is currently required from: Lance Zhao, Kapil Porwal, Tim Wawrzynczak. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70022 ) Change subject: acpi: Create a common method to add DmaProperty ...................................................................... Patch Set 2: (2 comments) File src/acpi/device.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164581): https://review.coreboot.org/c/coreboot/+/70022/comment/91481009_ce8ace59 PS2, Line 1194: if (prev_dsd == NULL) dsd = acpi_dp_new_table("_DSD"); trailing statements should be on next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164581): https://review.coreboot.org/c/coreboot/+/70022/comment/e60b13de_3e58bc95 PS2, Line 1198: if (prev_dsd == NULL) acpi_dp_write(dsd); trailing statements should be on next line -- To view, visit https://review.coreboot.org/c/coreboot/+/70022 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I75b3f22ad29f90f3c3b251bd0d70bae9d75f71fe Gerrit-Change-Number: 70022 Gerrit-PatchSet: 2 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Comment-Date: Sat, 26 Nov 2022 13:49:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: acpi: Create a common method to add DmaProperty
by Kapil Porwal (Code Review) 26 Nov '22

26 Nov '22

Attention is currently required from: Lance Zhao, Kapil Porwal, Tim Wawrzynczak. Hello Lance Zhao, build bot (Jenkins), Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70022 to look at the new patch set (#2). Change subject: acpi: Create a common method to add DmaProperty ...................................................................... acpi: Create a common method to add DmaProperty Create a common method to add DmaProperty. BUG=b:259716145 TEST=Verified SSDT on google/osiris. Signed-off-by: Kapil Porwal <kapilporwal(a)google.com> Change-Id: I75b3f22ad29f90f3c3b251bd0d70bae9d75f71fe --- M src/acpi/device.c M src/include/acpi/acpi_device.h 2 files changed, 38 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/70022/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70022 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I75b3f22ad29f90f3c3b251bd0d70bae9d75f71fe Gerrit-Change-Number: 70022 Gerrit-PatchSet: 2 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: acpi: Create a common method to add DmaProperty
by Kapil Porwal (Code Review) 26 Nov '22

26 Nov '22

Attention is currently required from: Lance Zhao, Kapil Porwal, Tim Wawrzynczak. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70022 ) Change subject: acpi: Create a common method to add DmaProperty ...................................................................... Patch Set 1: (2 comments) File src/acpi/device.c: https://review.coreboot.org/c/coreboot/+/70022/comment/6467648e_1b8f7b07 PS1, Line 1194: if (prev_dsd == NULL) { > braces {} are not necessary for single statement blocks Please fix. https://review.coreboot.org/c/coreboot/+/70022/comment/680da121_aba7e243 PS1, Line 1200: if (prev_dsd == NULL) { > braces {} are not necessary for single statement blocks Please fix. -- To view, visit https://review.coreboot.org/c/coreboot/+/70022 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I75b3f22ad29f90f3c3b251bd0d70bae9d75f71fe Gerrit-Change-Number: 70022 Gerrit-PatchSet: 1 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Comment-Date: Sat, 26 Nov 2022 13:47:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: acpi: Create a common method to add DmaProperty
by build bot (Jenkins) (Code Review) 26 Nov '22

26 Nov '22

Attention is currently required from: Lance Zhao, Tim Wawrzynczak. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70022 ) Change subject: acpi: Create a common method to add DmaProperty ...................................................................... Patch Set 1: (2 comments) File src/acpi/device.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164580): https://review.coreboot.org/c/coreboot/+/70022/comment/a897fd89_8ab9c04b PS1, Line 1194: if (prev_dsd == NULL) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164580): https://review.coreboot.org/c/coreboot/+/70022/comment/3222d624_de93d459 PS1, Line 1200: if (prev_dsd == NULL) { braces {} are not necessary for single statement blocks -- To view, visit https://review.coreboot.org/c/coreboot/+/70022 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I75b3f22ad29f90f3c3b251bd0d70bae9d75f71fe Gerrit-Change-Number: 70022 Gerrit-PatchSet: 1 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Comment-Date: Sat, 26 Nov 2022 13:45:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: acpi: Create a common method to add DmaProperty
by Kapil Porwal (Code Review) 26 Nov '22

26 Nov '22

Kapil Porwal has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/70022 ) Change subject: acpi: Create a common method to add DmaProperty ...................................................................... acpi: Create a common method to add DmaProperty Create a common method to add DmaProperty. BUG=b:259716145 TEST=Verified SSDT on google/osiris. Signed-off-by: Kapil Porwal <kapilporwal(a)google.com> Change-Id: I75b3f22ad29f90f3c3b251bd0d70bae9d75f71fe --- M src/acpi/device.c M src/include/acpi/acpi_device.h 2 files changed, 42 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/70022/1 diff --git a/src/acpi/device.c b/src/acpi/device.c index 2b085b6..a8dcd88 100644 --- a/src/acpi/device.c +++ b/src/acpi/device.c @@ -1183,3 +1183,21 @@ acpigen_pop_len(); /* Device */ acpigen_pop_len(); /* Scope */ } + +/* ID for the DmaProperty _DSD */ +#define ACPI_DSD_DMA_PROPERTY_UUID "70D24161-6DD5-4C9E-8070-705531292865" + +/* _DSD with DmaProperty */ +void acpi_device_add_dma_property(struct acpi_dp *dsd) +{ + struct acpi_dp *prev_dsd = dsd, *pkg; + if (prev_dsd == NULL) { + dsd = acpi_dp_new_table("_DSD"); + } + pkg = acpi_dp_new_table(ACPI_DSD_DMA_PROPERTY_UUID); + acpi_dp_add_integer(pkg, "DmaProperty", 1); + acpi_dp_add_package(dsd, pkg); + if (prev_dsd == NULL) { + acpi_dp_write(dsd); + } +} diff --git a/src/include/acpi/acpi_device.h b/src/include/acpi/acpi_device.h index 71809eb..1493cb4 100644 --- a/src/include/acpi/acpi_device.h +++ b/src/include/acpi/acpi_device.h @@ -588,4 +588,13 @@ */ void acpi_device_write_pci_dev(const struct device *dev); +/* + * Helper function to add DmaProperty to _DSD in the current scope. + * + * dsd - Pointer to a _DSD object. + * Append to existing _DSD object if not NULL. + * Create new _DSD object and flush it if NULL. + */ +void acpi_device_add_dma_property(struct acpi_dp *dsd); + #endif /* __ACPI_ACPI_DEVICE_H__ */ -- To view, visit https://review.coreboot.org/c/coreboot/+/70022 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I75b3f22ad29f90f3c3b251bd0d70bae9d75f71fe Gerrit-Change-Number: 70022 Gerrit-PatchSet: 1 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: util/crossgcc/buildgcc: Fix acpica filename
by Felix Singer (Code Review) 26 Nov '22

26 Nov '22

Attention is currently required from: Elyes Haouas. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70021 ) Change subject: util/crossgcc/buildgcc: Fix acpica filename ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > https://acpica.org/downloads […] Look at one of the links (and also click on it) and then compare it with the one from here https://acpica.org/node/201 -- To view, visit https://review.coreboot.org/c/coreboot/+/70021 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7b10dd1db4299aaef96bc29023bed874b660aba0 Gerrit-Change-Number: 70021 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sat, 26 Nov 2022 13:02:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/crossgcc/buildgcc: Fix acpica filename
by Elyes Haouas (Code Review) 26 Nov '22

26 Nov '22

Attention is currently required from: Felix Singer. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70021 ) Change subject: util/crossgcc/buildgcc: Fix acpica filename ...................................................................... Patch Set 2: Code-Review-1 (1 comment) Patchset: PS2: https://acpica.org/downloads no changes as you can see -- To view, visit https://review.coreboot.org/c/coreboot/+/70021 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7b10dd1db4299aaef96bc29023bed874b660aba0 Gerrit-Change-Number: 70021 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Sat, 26 Nov 2022 12:49:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/intel/mtlrvp: Add bootblock and early gpio for MTL-RVP
by Eric Lai (Code Review) 26 Nov '22

26 Nov '22

Attention is currently required from: Ashish Kumar Mishra, Harsha B R, Haribalaraman Ramasubramanian, Rizwan Qureshi, Krishna P Bhat D, Balaji Manigandan, Ronak Kanabar, Usha P. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69886 ) Change subject: mb/intel/mtlrvp: Add bootblock and early gpio for MTL-RVP ...................................................................... Patch Set 4: Code-Review+2 (1 comment) Patchset: PS4: Looks good now. -- To view, visit https://review.coreboot.org/c/coreboot/+/69886 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9c0893e52036147c5f6bbfafc6d818e9d3460bed Gerrit-Change-Number: 69886 Gerrit-PatchSet: 4 Gerrit-Owner: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Reviewer: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com> Gerrit-Reviewer: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Attention: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Attention: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Usha P <usha.p(a)intel.com> Gerrit-Comment-Date: Sat, 26 Nov 2022 11:23:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: util/sconfig: Remove lapic devices from devicetree parsers
by Angel Pons (Code Review) 26 Nov '22

26 Nov '22

Attention is currently required from: Martin L Roth, Arthur Heymans. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69378 ) Change subject: util/sconfig: Remove lapic devices from devicetree parsers ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/69378 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0746eb808a2956ac75f76c8189a9ecf190e33ce9 Gerrit-Change-Number: 69378 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sat, 26 Nov 2022 11:23:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022