coreboot-gerrit October 2022

coreboot-gerrit@coreboot.org

1 participants
5881 discussions

[S] Change in coreboot[master]: console/vtxprintf.c: Add <stdarg.h>
by Elyes Haouas (Code Review) 02 Oct '22

02 Oct '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68039 ) Change subject: console/vtxprintf.c: Add <stdarg.h> ...................................................................... console/vtxprintf.c: Add <stdarg.h> Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: I221a2bdb19cc7d17265c69d3fe3e1dfb490e7186 --- M src/console/vtxprintf.c 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/68039/1 diff --git a/src/console/vtxprintf.c b/src/console/vtxprintf.c index fba76bc..cfba6db 100644 --- a/src/console/vtxprintf.c +++ b/src/console/vtxprintf.c @@ -6,6 +6,7 @@ #include <console/vtxprintf.h> #include <ctype.h> +#include <stdarg.h> #include <string.h> #include <types.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/68039 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I221a2bdb19cc7d17265c69d3fe3e1dfb490e7186 Gerrit-Change-Number: 68039 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: console/vsprintf.c: Add <stdarg.h>
by Elyes Haouas (Code Review) 02 Oct '22

02 Oct '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68038 ) Change subject: console/vsprintf.c: Add <stdarg.h> ...................................................................... console/vsprintf.c: Add <stdarg.h> Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: I8c61f2a033f9630d3fa3eb5e364e6f38de5c7064 --- M src/console/vsprintf.c 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/68038/1 diff --git a/src/console/vsprintf.c b/src/console/vsprintf.c index 06b9e49..6892639 100644 --- a/src/console/vsprintf.c +++ b/src/console/vsprintf.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <console/vtxprintf.h> +#include <stdarg.h> #include <string.h> struct vsnprintf_context { -- To view, visit https://review.coreboot.org/c/coreboot/+/68038 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8c61f2a033f9630d3fa3eb5e364e6f38de5c7064 Gerrit-Change-Number: 68038 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: console/printk.c: Add <types.h>
by Elyes Haouas (Code Review) 02 Oct '22

02 Oct '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68037 ) Change subject: console/printk.c: Add <types.h> ...................................................................... console/printk.c: Add <types.h> Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: I55412395071f0fccb839c40fefda998befaddebb --- M src/console/printk.c 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/68037/1 diff --git a/src/console/printk.c b/src/console/printk.c index 1ce2fad..99710e6 100644 --- a/src/console/printk.c +++ b/src/console/printk.c @@ -11,6 +11,7 @@ #include <smp/spinlock.h> #include <smp/node.h> #include <timer.h> +#include <types.h> DECLARE_SPIN_LOCK(console_lock) -- To view, visit https://review.coreboot.org/c/coreboot/+/68037 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I55412395071f0fccb839c40fefda998befaddebb Gerrit-Change-Number: 68037 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: console/die.c: Add <stdarg.h>
by Elyes Haouas (Code Review) 02 Oct '22

02 Oct '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68036 ) Change subject: console/die.c: Add <stdarg.h> ...................................................................... console/die.c: Add <stdarg.h> Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: I2ee8ef017d8a3409cbf47f1ed252a512dead224e --- M src/console/die.c 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/68036/1 diff --git a/src/console/die.c b/src/console/die.c index 3fc88a3..d9e1dee 100644 --- a/src/console/die.c +++ b/src/console/die.c @@ -2,6 +2,7 @@ #include <console/console.h> #include <halt.h> +#include <stdarg.h> /* * The method should be overwritten in mainboard directory to signal that a -- To view, visit https://review.coreboot.org/c/coreboot/+/68036 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2ee8ef017d8a3409cbf47f1ed252a512dead224e Gerrit-Change-Number: 68036 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: console/console.c: Sorte includes and add <types.h>
by Elyes Haouas (Code Review) 02 Oct '22

02 Oct '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68035 ) Change subject: console/console.c: Sorte includes and add <types.h> ...................................................................... console/console.c: Sorte includes and add <types.h> Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: I1d2d85ff8cfca58295117b5cb625cadfc9008311 --- M src/console/console.c 1 file changed, 15 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/68035/1 diff --git a/src/console/console.c b/src/console/console.c index 1724f9d..499a336 100644 --- a/src/console/console.c +++ b/src/console/console.c @@ -1,16 +1,17 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <console/cbmem_console.h> +#include <console/flash.h> +#include <console/i2c_smbus.h> #include <console/ne2k.h> #include <console/qemu_debugcon.h> +#include <console/spi.h> #include <console/spkmodem.h> #include <console/streams.h> +#include <console/system76_ec.h> #include <console/uart.h> #include <console/usb.h> -#include <console/spi.h> -#include <console/flash.h> -#include <console/system76_ec.h> -#include <console/i2c_smbus.h> +#include <types.h> /* Note: when adding a new console, make sure you update the definition of HAS_ONLY_FAST_CONSOLES in <console.h>! */ -- To view, visit https://review.coreboot.org/c/coreboot/+/68035 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1d2d85ff8cfca58295117b5cb625cadfc9008311 Gerrit-Change-Number: 68035 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: arch/x86/mmap_boot.c: Clean up includes
by build bot (Jenkins) (Code Review) 02 Oct '22

02 Oct '22

Attention is currently required from: Paul Menzel. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68033 ) Change subject: arch/x86/mmap_boot.c: Clean up includes ...................................................................... Patch Set 3: Verified+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/68033 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85e60c189c1ec1da5cf0e5b864447ef6f7b3f548 Gerrit-Change-Number: 68033 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sun, 02 Oct 2022 10:11:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: cpu/x86/smm/smm_module_loader.c: Clean up includes
by build bot (Jenkins) (Code Review) 02 Oct '22

02 Oct '22

Attention is currently required from: Paul Menzel. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68032 ) Change subject: cpu/x86/smm/smm_module_loader.c: Clean up includes ...................................................................... Patch Set 4: Verified+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/68032 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I36c54e62797e67c1732f8deaf8843daf35610e22 Gerrit-Change-Number: 68032 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sun, 02 Oct 2022 10:11:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: arch/x86/timestamp.c: Add missing <stdint.h>
by Elyes Haouas (Code Review) 02 Oct '22

02 Oct '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68034 ) Change subject: arch/x86/timestamp.c: Add missing <stdint.h> ...................................................................... arch/x86/timestamp.c: Add missing <stdint.h> Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: I6870fb9f3d41ef5dc6599e979ce0c890a1e145ab --- M src/arch/x86/timestamp.c 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/68034/1 diff --git a/src/arch/x86/timestamp.c b/src/arch/x86/timestamp.c index 8ab10ed..0a4c9c4 100644 --- a/src/arch/x86/timestamp.c +++ b/src/arch/x86/timestamp.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <cpu/x86/tsc.h> +#include <stdint.h> #include <timestamp.h> uint64_t timestamp_get(void) -- To view, visit https://review.coreboot.org/c/coreboot/+/68034 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6870fb9f3d41ef5dc6599e979ce0c890a1e145ab Gerrit-Change-Number: 68034 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: arch/x86/mmap_boot.c: Clean up includes
by Elyes Haouas (Code Review) 02 Oct '22

02 Oct '22

Attention is currently required from: Paul Menzel. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68033 to look at the new patch set (#3). Change subject: arch/x86/mmap_boot.c: Clean up includes ...................................................................... arch/x86/mmap_boot.c: Clean up includes Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: I85e60c189c1ec1da5cf0e5b864447ef6f7b3f548 --- M src/arch/x86/mmap_boot.c 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/68033/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/68033 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85e60c189c1ec1da5cf0e5b864447ef6f7b3f548 Gerrit-Change-Number: 68033 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: cpu/x86/smm/smm_module_loader.c: Clean up includes
by Elyes Haouas (Code Review) 02 Oct '22

02 Oct '22

Attention is currently required from: Paul Menzel. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68032 to look at the new patch set (#4). Change subject: cpu/x86/smm/smm_module_loader.c: Clean up includes ...................................................................... cpu/x86/smm/smm_module_loader.c: Clean up includes Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: I36c54e62797e67c1732f8deaf8843daf35610e22 --- M src/cpu/x86/smm/smm_module_loader.c 1 file changed, 11 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/68032/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/68032 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I36c54e62797e67c1732f8deaf8843daf35610e22 Gerrit-Change-Number: 68032 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2022