coreboot-gerrit October 2022

coreboot-gerrit@coreboot.org

1 participants
5881 discussions

[M] Change in coreboot[master]: mb/google/nissa/var/xivu: Add DPTF parameters for Xivu
by Martin Roth (Code Review) 03 Oct '22

03 Oct '22

Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/67944 ) Change subject: mb/google/nissa/var/xivu: Add DPTF parameters for Xivu ...................................................................... mb/google/nissa/var/xivu: Add DPTF parameters for Xivu The DPTF parameters were verified by the thermal team. BUG=b:249446156 TEST=emerge-nissa coreboot chromeos-bootimage Signed-off-by: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Change-Id: Ic7e0c73815dd02b97d89f94fab09a241b6279830 Reviewed-on: https://review.coreboot.org/c/coreboot/+/67944 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Reka Norman <rekanorman(a)chromium.org> --- M src/mainboard/google/brya/variants/xivu/overridetree.cb 1 file changed, 69 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Reka Norman: Looks good to me, approved diff --git a/src/mainboard/google/brya/variants/xivu/overridetree.cb b/src/mainboard/google/brya/variants/xivu/overridetree.cb index 609f468..f919cef 100644 --- a/src/mainboard/google/brya/variants/xivu/overridetree.cb +++ b/src/mainboard/google/brya/variants/xivu/overridetree.cb @@ -42,6 +42,57 @@ #| I2C5 | Trackpad | #+-------------------+---------------------------+ device domain 0 on + device ref dtt on + chip drivers/intel/dptf + ## sensor information + register "options.tsr[0].desc" = ""Memory"" + register "options.tsr[1].desc" = ""Ambient"" + register "options.tsr[2].desc" = ""Charger"" + + # TODO: below values are initial reference values only + ## Passive Policy + register "policies.passive" = "{ + [0] = DPTF_PASSIVE(CPU, CPU, 90, 5000), + [1] = DPTF_PASSIVE(CPU, TEMP_SENSOR_0, 77, 5000), + [2] = DPTF_PASSIVE(CPU, TEMP_SENSOR_1, 60, 5000), + [3] = DPTF_PASSIVE(CHARGER, TEMP_SENSOR_2, 78, 5000), + }" + + ## Critical Policy + register "policies.critical" = "{ + [0] = DPTF_CRITICAL(TEMP_SENSOR_0, 87, SHUTDOWN), + [1] = DPTF_CRITICAL(TEMP_SENSOR_1, 78, SHUTDOWN), + [2] = DPTF_CRITICAL(TEMP_SENSOR_2, 88, SHUTDOWN), + }" + + register "controls.power_limits" = "{ + .pl1 = { + .min_power = 6000, + .max_power = 6000, + .time_window_min = 28 * MSECS_PER_SEC, + .time_window_max = 32 * MSECS_PER_SEC, + .granularity = 200 + }, + .pl2 = { + .min_power = 25000, + .max_power = 25000, + .time_window_min = 28 * MSECS_PER_SEC, + .time_window_max = 32 * MSECS_PER_SEC, + .granularity = 1000 + } + }" + + ## Charger Performance Control (Control, mA) + register "controls.charger_perf" = "{ + [0] = { 255, 1700 }, + [1] = { 24, 1500 }, + [2] = { 16, 1000 }, + [3] = { 8, 500 } + }" + + device generic 0 on end + end + end device ref ipu on chip drivers/intel/mipi_camera register "acpi_uid" = "0x50000" -- To view, visit https://review.coreboot.org/c/coreboot/+/67944 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic7e0c73815dd02b97d89f94fab09a241b6279830 Gerrit-Change-Number: 67944 Gerrit-PatchSet: 2 Gerrit-Owner: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-CC: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[master]: mb/google/brya: Create lisbon variant
by Martin Roth (Code Review) 03 Oct '22

03 Oct '22

Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/67900 ) Change subject: mb/google/brya: Create lisbon variant ...................................................................... mb/google/brya: Create lisbon variant Create the lisbon variant of the brask reference board by copying the template files to a new directory named for the variant. (Auto-Generated by create_coreboot_variant.sh version 4.5.0). BUG=b:246657849 BRANCH=None TEST=util/abuild/abuild -p none -t google/brya -x -a make sure the build includes GOOGLE_LISBON Signed-off-by: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Change-Id: Ia31752765657054b28ea16b046b63c38a72f95bf Reviewed-on: https://review.coreboot.org/c/coreboot/+/67900 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Zhuohao Lee <zhuohao(a)google.com> --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/Kconfig.name A src/mainboard/google/brya/variants/lisbon/include/variant/ec.h A src/mainboard/google/brya/variants/lisbon/include/variant/gpio.h A src/mainboard/google/brya/variants/lisbon/overridetree.cb 5 files changed, 51 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Zhuohao Lee: Looks good to me, approved diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index 5934071..9e41cad 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -210,6 +210,7 @@ default "Xivu" if BOARD_GOOGLE_XIVU default "Gaelin4ADL" if BOARD_GOOGLE_GAELIN4ADL default "Yaviks" if BOARD_GOOGLE_YAVIKS + default "Lisbon" if BOARD_GOOGLE_LISBON config VARIANT_DIR default "brya0" if BOARD_GOOGLE_BRYA0 @@ -247,6 +248,7 @@ default "xivu" if BOARD_GOOGLE_XIVU default "gaelin" if BOARD_GOOGLE_GAELIN4ADL default "yaviks" if BOARD_GOOGLE_YAVIKS + default "lisbon" if BOARD_GOOGLE_LISBON config VBOOT select VBOOT_EARLY_EC_SYNC if !BOARD_GOOGLE_BASEBOARD_NISSA diff --git a/src/mainboard/google/brya/Kconfig.name b/src/mainboard/google/brya/Kconfig.name index 2d031da..df94b20 100644 --- a/src/mainboard/google/brya/Kconfig.name +++ b/src/mainboard/google/brya/Kconfig.name @@ -267,3 +267,7 @@ bool "-> Yaviks" select BOARD_GOOGLE_BASEBOARD_NISSA select DRIVERS_GENESYSLOGIC_GL9750 + +config BOARD_GOOGLE_LISBON + bool "-> Lisbon" + select BOARD_GOOGLE_BASEBOARD_BRASK diff --git a/src/mainboard/google/brya/variants/lisbon/include/variant/ec.h b/src/mainboard/google/brya/variants/lisbon/include/variant/ec.h new file mode 100644 index 0000000..7a2a6ff --- /dev/null +++ b/src/mainboard/google/brya/variants/lisbon/include/variant/ec.h @@ -0,0 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#ifndef __VARIANT_EC_H__ +#define __VARIANT_EC_H__ + +#include <baseboard/ec.h> + +#endif diff --git a/src/mainboard/google/brya/variants/lisbon/include/variant/gpio.h b/src/mainboard/google/brya/variants/lisbon/include/variant/gpio.h new file mode 100644 index 0000000..c4fe342 --- /dev/null +++ b/src/mainboard/google/brya/variants/lisbon/include/variant/gpio.h @@ -0,0 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#ifndef VARIANT_GPIO_H +#define VARIANT_GPIO_H + +#include <baseboard/gpio.h> + +#endif diff --git a/src/mainboard/google/brya/variants/lisbon/overridetree.cb b/src/mainboard/google/brya/variants/lisbon/overridetree.cb new file mode 100644 index 0000000..4f2c04a --- /dev/null +++ b/src/mainboard/google/brya/variants/lisbon/overridetree.cb @@ -0,0 +1,6 @@ +chip soc/intel/alderlake + + device domain 0 on + end + +end -- To view, visit https://review.coreboot.org/c/coreboot/+/67900 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia31752765657054b28ea16b046b63c38a72f95bf Gerrit-Change-Number: 67900 Gerrit-PatchSet: 3 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[L] Change in coreboot[master]: drivers/ipmi: prepare for adding more interfaces
by Martin Roth (Code Review) 03 Oct '22

03 Oct '22

Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/67056 ) Change subject: drivers/ipmi: prepare for adding more interfaces ...................................................................... drivers/ipmi: prepare for adding more interfaces De-duplicate common initialization code (self-test and device identification) and put it in a new ipmi_if.c unit, which is supposed to work with any underlying IPMI interface. Change-Id: Ia99da6fb63adb7bf556d3d6f7964b34831be8a2f Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/67056 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Krystian Hebel <krystian.hebel(a)3mdeb.com> --- M Documentation/drivers/ipmi_kcs.md M src/drivers/ipmi/Makefile.inc M src/drivers/ipmi/chip.h M src/drivers/ipmi/ipmi_fru.c A src/drivers/ipmi/ipmi_if.c R src/drivers/ipmi/ipmi_if.h M src/drivers/ipmi/ipmi_kcs.c M src/drivers/ipmi/ipmi_kcs_ops.c D src/drivers/ipmi/ipmi_kcs_ops_premem.c M src/drivers/ipmi/ipmi_ops.c M src/drivers/ipmi/ipmi_ops.h A src/drivers/ipmi/ipmi_ops_premem.c M src/drivers/ipmi/ocp/ipmi_ocp.c M src/drivers/ipmi/ocp/ipmi_ocp_romstage.c M src/drivers/ipmi/supermicro_oem.c M src/mainboard/ocp/deltalake/ipmi.c M src/mainboard/ocp/deltalake/romstage.c M src/mainboard/ocp/tiogapass/ipmi.c M src/mainboard/ocp/tiogapass/romstage.c 19 files changed, 262 insertions(+), 246 deletions(-) Approvals: build bot (Jenkins): Verified Krystian Hebel: Looks good to me, approved diff --git a/Documentation/drivers/ipmi_kcs.md b/Documentation/drivers/ipmi_kcs.md index f6f0fb9..c4db492 100644 --- a/Documentation/drivers/ipmi_kcs.md +++ b/Documentation/drivers/ipmi_kcs.md @@ -42,6 +42,15 @@ * `gpe_interrupt` * Integer * The bit in GPE (SCI) used to notify about a change on the KCS. +* `wait_for_bmc` + * Boolean + * Wait for BMC to boot. This can be used if the BMC takes a long time to boot + after PoR: + - AST2400 on Supermicro X11SSH: 34 s +* `bmc_boot_timeout` + * Integer + * The timeout in seconds to wait for the IPMI service to be loaded. + Will be used if wait_for_bmc is true. [IPMI]: https://www.intel.com/content/dam/www/public/us/en/documents/product-briefs… diff --git a/src/drivers/ipmi/Makefile.inc b/src/drivers/ipmi/Makefile.inc index e4bcf31..85f3dde 100644 --- a/src/drivers/ipmi/Makefile.inc +++ b/src/drivers/ipmi/Makefile.inc @@ -1,8 +1,10 @@ +ramstage-$(CONFIG_IPMI_KCS) += ipmi_if.c ramstage-$(CONFIG_IPMI_KCS) += ipmi_kcs.c ramstage-$(CONFIG_IPMI_KCS) += ipmi_kcs_ops.c ramstage-$(CONFIG_IPMI_KCS) += ipmi_ops.c ramstage-$(CONFIG_IPMI_KCS) += ipmi_fru.c ramstage-$(CONFIG_DRIVERS_IPMI_SUPERMICRO_OEM) += supermicro_oem.c -romstage-$(CONFIG_IPMI_KCS_ROMSTAGE) += ipmi_kcs_ops_premem.c +romstage-$(CONFIG_IPMI_KCS_ROMSTAGE) += ipmi_if.c +romstage-$(CONFIG_IPMI_KCS_ROMSTAGE) += ipmi_ops_premem.c romstage-$(CONFIG_IPMI_KCS_ROMSTAGE) += ipmi_kcs.c romstage-$(CONFIG_IPMI_KCS_ROMSTAGE) += ipmi_ops.c diff --git a/src/drivers/ipmi/chip.h b/src/drivers/ipmi/chip.h index 4e9d9e1..3b970c9 100644 --- a/src/drivers/ipmi/chip.h +++ b/src/drivers/ipmi/chip.h @@ -8,6 +8,7 @@ #include <stdint.h> struct drivers_ipmi_config { +#if CONFIG(IPMI_KCS) u8 bmc_i2c_address; u8 have_nv_storage; u8 nv_storage_device_address; @@ -25,6 +26,9 @@ /* "POST complete" GPIO and polarity */ u32 post_complete_gpio; bool post_complete_invert; + unsigned int uid; /* Auto-filled by ipmi_ssdt() */ +#endif + /* * Wait for BMC to boot. * This can be used if the BMC takes a long time to boot after PoR: @@ -36,7 +40,6 @@ * Will be used if wait_for_bmc is true. */ u16 bmc_boot_timeout; - unsigned int uid; /* Auto-filled by ipmi_ssdt() */ }; #endif /* _IMPI_CHIP_H_ */ diff --git a/src/drivers/ipmi/ipmi_fru.c b/src/drivers/ipmi/ipmi_fru.c index 822e5bf..f165307 100644 --- a/src/drivers/ipmi/ipmi_fru.c +++ b/src/drivers/ipmi/ipmi_fru.c @@ -5,6 +5,7 @@ #include <delay.h> #include <stdlib.h> +#include "ipmi_if.h" #include "ipmi_ops.h" #define MAX_FRU_BUSY_RETRY 5 @@ -34,7 +35,7 @@ req->count = CONFIG_IPMI_FRU_SINGLE_RW_SZ; while (retry_count <= MAX_FRU_BUSY_RETRY) { - ret = ipmi_kcs_message(port, IPMI_NETFN_STORAGE, 0x0, + ret = ipmi_message(port, IPMI_NETFN_STORAGE, 0x0, IPMI_READ_FRU_DATA, (const unsigned char *) req, sizeof(*req), (unsigned char *) &rsp, sizeof(rsp)); if (rsp.resp.completion_code == 0x81) { diff --git a/src/drivers/ipmi/ipmi_if.c b/src/drivers/ipmi/ipmi_if.c new file mode 100644 index 0000000..4ff9004 --- /dev/null +++ b/src/drivers/ipmi/ipmi_if.c @@ -0,0 +1,101 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include "ipmi_if.h" + +#include <console/console.h> +#include <delay.h> + +#include "chip.h" + +int ipmi_get_device_id(const struct device *dev, struct ipmi_devid_rsp *rsp) +{ + int ret; + + ret = ipmi_message(dev->path.pnp.port, IPMI_NETFN_APPLICATION, 0, + IPMI_BMC_GET_DEVICE_ID, NULL, 0, (u8 *)rsp, + sizeof(*rsp)); + if (ret < sizeof(struct ipmi_rsp) || rsp->resp.completion_code) { + printk(BIOS_ERR, "IPMI: %s command failed (ret=%d resp=0x%x)\n", + __func__, ret, rsp->resp.completion_code); + return 1; + } + if (ret != sizeof(*rsp)) { + printk(BIOS_ERR, "IPMI: %s response truncated\n", __func__); + return 1; + } + return 0; +} + +static int ipmi_get_bmc_self_test_result(const struct device *dev, + struct ipmi_selftest_rsp *rsp) +{ + int ret; + + ret = ipmi_message(dev->path.pnp.port, IPMI_NETFN_APPLICATION, 0, + IPMI_BMC_GET_SELFTEST_RESULTS, NULL, 0, (u8 *)rsp, + sizeof(*rsp)); + + if (ret < sizeof(struct ipmi_rsp) || rsp->resp.completion_code) { + printk(BIOS_ERR, "IPMI: %s command failed (ret=%d resp=0x%x)\n", + __func__, ret, rsp->resp.completion_code); + return 1; + } + if (ret != sizeof(*rsp)) { + printk(BIOS_ERR, "IPMI: %s response truncated\n", __func__); + return 1; + } + + return 0; +} + +int ipmi_process_self_test_result(const struct device *dev) +{ + int failure = 0; + uint8_t retry_count = 0; + struct ipmi_selftest_rsp selftestrsp = {0}; + + const struct drivers_ipmi_config *conf = dev->chip_info; + uint8_t retry_limit = 0; + + if (conf && conf->wait_for_bmc) + retry_limit = conf->bmc_boot_timeout; + + if (retry_limit == 0) + /* Try to get self-test results at least once */ + retry_limit = 1; + + printk(BIOS_INFO, "Get BMC self test result..."); + for (retry_count = 0; retry_count < retry_limit; retry_count++) { + if (!ipmi_get_bmc_self_test_result(dev, &selftestrsp)) + break; + + mdelay(1000); + } + + switch (selftestrsp.result) { + case IPMI_APP_SELFTEST_NO_ERROR: /* 0x55 */ + printk(BIOS_DEBUG, "No Error\n"); + break; + case IPMI_APP_SELFTEST_NOT_IMPLEMENTED: /* 0x56 */ + printk(BIOS_DEBUG, "Function Not Implemented\n"); + break; + case IPMI_APP_SELFTEST_ERROR: /* 0x57 */ + printk(BIOS_ERR, "BMC: Corrupted or inaccessible data or device\n"); + failure = 1; + break; + case IPMI_APP_SELFTEST_FATAL_HW_ERROR: /* 0x58 */ + printk(BIOS_ERR, "BMC: Fatal Hardware Error\n"); + failure = 1; + break; + case IPMI_APP_SELFTEST_RESERVED: /* 0xFF */ + printk(BIOS_DEBUG, "Reserved\n"); + break; + + default: /* Other Device Specific Hardware Error */ + printk(BIOS_ERR, "BMC: Device Specific Error: 0x%02x\n", selftestrsp.result); + failure = 1; + break; + } + + return failure; +} diff --git a/src/drivers/ipmi/ipmi_kcs.h b/src/drivers/ipmi/ipmi_if.h similarity index 68% rename from src/drivers/ipmi/ipmi_kcs.h rename to src/drivers/ipmi/ipmi_if.h index 33ddd5f..984b469 100644 --- a/src/drivers/ipmi/ipmi_kcs.h +++ b/src/drivers/ipmi/ipmi_if.h @@ -1,7 +1,11 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#ifndef __IPMI_KCS_H -#define __IPMI_KCS_H +#ifndef __IPMI_IF_H +#define __IPMI_IF_H + +/* Common API and code for different IPMI interfaces in different stages */ + +#include <stdint.h> #define IPMI_NETFN_CHASSIS 0x00 #define IPMI_NETFN_BRIDGE 0x02 @@ -25,16 +29,6 @@ #define IPMI_CMD_ACPI_POWERON 0x06 -extern int ipmi_kcs_message(int port, int netfn, int lun, int cmd, - const unsigned char *inmsg, int inlen, - unsigned char *outmsg, int outlen); - -/* Run basic IPMI init functions in romstage from the provided PnP device, - * returns CB_SUCCESS on success and CB_ERR if an error occurred. */ -enum cb_err ipmi_kcs_premem_init(const u16 port, const u16 device); - -void ipmi_bmc_version(uint8_t *ipmi_bmc_major_revision, uint8_t *ipmi_bmc_minor_revision); - struct ipmi_rsp { uint8_t lun; uint8_t cmd; @@ -61,4 +55,25 @@ uint8_t param; } __packed; -#endif +struct device; + +/* + * Sends a command and reads its response. Input buffer is for payload, but + * output includes `struct ipmi_rsp` as a header. Returns number of bytes copied + * into the buffer or -1. + */ +int ipmi_message(int port, int netfn, int lun, int cmd, + const unsigned char *inmsg, int inlen, + unsigned char *outmsg, int outlen); + +/* Run basic IPMI init functions in romstage from the provided PnP device, + * returns CB_SUCCESS on success and CB_ERR if an error occurred. */ +enum cb_err ipmi_premem_init(const uint16_t port, const uint16_t device); + +int ipmi_get_device_id(const struct device *dev, struct ipmi_devid_rsp *rsp); + +int ipmi_process_self_test_result(const struct device *dev); + +void ipmi_bmc_version(uint8_t *ipmi_bmc_major_revision, uint8_t *ipmi_bmc_minor_revision); + +#endif /* __IPMI_IF_H */ diff --git a/src/drivers/ipmi/ipmi_kcs.c b/src/drivers/ipmi/ipmi_kcs.c index 12cbe82f1..6678272 100644 --- a/src/drivers/ipmi/ipmi_kcs.c +++ b/src/drivers/ipmi/ipmi_kcs.c @@ -4,7 +4,7 @@ #include <device/device.h> #include <arch/io.h> #include <timer.h> -#include "ipmi_kcs.h" +#include "ipmi_if.h" #define IPMI_KCS_STATE(_x) ((_x) >> 6) @@ -219,9 +219,9 @@ return ret; } -int ipmi_kcs_message(int port, int netfn, int lun, int cmd, - const unsigned char *inmsg, int inlen, - unsigned char *outmsg, int outlen) +int ipmi_message(int port, int netfn, int lun, int cmd, + const unsigned char *inmsg, int inlen, + unsigned char *outmsg, int outlen) { if (ipmi_kcs_send_message(port, netfn, lun, cmd, inmsg, inlen)) { printk(BIOS_ERR, "ipmi_kcs_send_message failed\n"); diff --git a/src/drivers/ipmi/ipmi_kcs_ops.c b/src/drivers/ipmi/ipmi_kcs_ops.c index 4ffa91f..a2ad7ab 100644 --- a/src/drivers/ipmi/ipmi_kcs_ops.c +++ b/src/drivers/ipmi/ipmi_kcs_ops.c @@ -24,7 +24,7 @@ #include <version.h> #include <delay.h> #include <timer.h> -#include "ipmi_kcs.h" +#include "ipmi_if.h" #include "ipmi_supermicro_oem.h" #include "chip.h" @@ -37,46 +37,6 @@ static struct boot_state_callback bscb_post_complete; -static int ipmi_get_device_id(struct device *dev, struct ipmi_devid_rsp *rsp) -{ - int ret; - - ret = ipmi_kcs_message(dev->path.pnp.port, IPMI_NETFN_APPLICATION, 0, - IPMI_BMC_GET_DEVICE_ID, NULL, 0, (u8 *)rsp, - sizeof(*rsp)); - if (ret < sizeof(struct ipmi_rsp) || rsp->resp.completion_code) { - printk(BIOS_ERR, "IPMI: %s command failed (ret=%d resp=0x%x)\n", - __func__, ret, rsp->resp.completion_code); - return 1; - } - if (ret != sizeof(*rsp)) { - printk(BIOS_ERR, "IPMI: %s response truncated\n", __func__); - return 1; - } - return 0; -} - -static int ipmi_get_bmc_self_test_result(struct device *dev, struct ipmi_selftest_rsp *rsp) -{ - int ret; - - ret = ipmi_kcs_message(dev->path.pnp.port, IPMI_NETFN_APPLICATION, 0, - IPMI_BMC_GET_SELFTEST_RESULTS, NULL, 0, (u8 *)rsp, - sizeof(*rsp)); - - if (ret < sizeof(struct ipmi_rsp) || rsp->resp.completion_code) { - printk(BIOS_ERR, "IPMI: %s command failed (ret=%d resp=0x%x)\n", - __func__, ret, rsp->resp.completion_code); - return 1; - } - if (ret != sizeof(*rsp)) { - printk(BIOS_ERR, "IPMI: %s response truncated\n", __func__); - return 1; - } - - return 0; -} - static void bmc_set_post_complete_gpio_callback(void *arg) { struct drivers_ipmi_config *conf = arg; @@ -103,8 +63,6 @@ uint32_t man_id = 0, prod_id = 0; struct drivers_ipmi_config *conf = dev->chip_info; const struct gpio_operations *gpio_ops; - struct ipmi_selftest_rsp selftestrsp = {0}; - uint8_t retry_count; if (!conf) { printk(BIOS_WARNING, "IPMI: chip_info is missing! Skip init.\n"); @@ -154,41 +112,9 @@ } } - printk(BIOS_INFO, "Get BMC self test result..."); - for (retry_count = 0; retry_count < conf->bmc_boot_timeout; retry_count++) { - if (!ipmi_get_bmc_self_test_result(dev, &selftestrsp)) - break; - - mdelay(1000); - } - - switch (selftestrsp.result) { - case IPMI_APP_SELFTEST_NO_ERROR: /* 0x55 */ - printk(BIOS_DEBUG, "No Error\n"); - break; - case IPMI_APP_SELFTEST_NOT_IMPLEMENTED: /* 0x56 */ - printk(BIOS_DEBUG, "Function Not Implemented\n"); - break; - case IPMI_APP_SELFTEST_ERROR: /* 0x57 */ - printk(BIOS_ERR, "BMC: Corrupted or inaccessible data or device\n"); + if (ipmi_process_self_test_result(dev)) /* Don't write tables if communication failed */ dev->enabled = 0; - break; - case IPMI_APP_SELFTEST_FATAL_HW_ERROR: /* 0x58 */ - printk(BIOS_ERR, "BMC: Fatal Hardware Error\n"); - /* Don't write tables if communication failed */ - dev->enabled = 0; - break; - case IPMI_APP_SELFTEST_RESERVED: /* 0xFF */ - printk(BIOS_DEBUG, "Reserved\n"); - break; - - default: /* Other Device Specific Hardware Error */ - printk(BIOS_ERR, "BMC: Device Specific Error\n"); - /* Don't write tables if communication failed */ - dev->enabled = 0; - break; - } if (!ipmi_get_device_id(dev, &rsp)) { /* Queried the IPMI revision from BMC */ diff --git a/src/drivers/ipmi/ipmi_kcs_ops_premem.c b/src/drivers/ipmi/ipmi_kcs_ops_premem.c deleted file mode 100644 index e1ae0dc..0000000 --- a/src/drivers/ipmi/ipmi_kcs_ops_premem.c +++ /dev/null @@ -1,113 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include <arch/io.h> -#include <console/console.h> -#include <device/pnp.h> -#include <delay.h> -#include <timer.h> - -#include "ipmi_kcs.h" -#include "chip.h" - -static int ipmi_get_bmc_self_test_result(const struct device *dev, - struct ipmi_selftest_rsp *rsp) -{ - int ret; - - ret = ipmi_kcs_message(dev->path.pnp.port, IPMI_NETFN_APPLICATION, 0, - IPMI_BMC_GET_SELFTEST_RESULTS, NULL, 0, (u8 *)rsp, - sizeof(*rsp)); - - if (ret < sizeof(struct ipmi_rsp) || rsp->resp.completion_code) { - printk(BIOS_ERR, "IPMI: %s command failed (ret=%d resp=0x%x)\n", - __func__, ret, rsp->resp.completion_code); - return 1; - } - if (ret != sizeof(*rsp)) { - printk(BIOS_ERR, "IPMI: %s response truncated\n", __func__); - return 1; - } - - return 0; -} - -enum cb_err ipmi_kcs_premem_init(const u16 port, const u16 device) -{ - const struct drivers_ipmi_config *conf = NULL; - struct ipmi_selftest_rsp selftestrsp = {0}; - uint8_t retry_count; - const struct device *dev; - - /* Find IPMI PNP device from devicetree in romstage */ - dev = dev_find_slot_pnp(port, device); - - if (!dev) { - printk(BIOS_ERR, "IPMI: Cannot find PNP device port: %x, device %x\n", - port, device); - return CB_ERR; - } - if (!dev->enabled) { - printk(BIOS_ERR, "IPMI: device is not enabled\n"); - return CB_ERR; - } - printk(BIOS_DEBUG, "IPMI: romstage PNP KCS 0x%x\n", dev->path.pnp.port); - if (dev->chip_info) - conf = dev->chip_info; - - if (conf && conf->wait_for_bmc && conf->bmc_boot_timeout) { - struct stopwatch sw; - stopwatch_init_msecs_expire(&sw, conf->bmc_boot_timeout * 1000); - printk(BIOS_DEBUG, "IPMI: Waiting for BMC...\n"); - - while (!stopwatch_expired(&sw)) { - if (inb(dev->path.pnp.port) != 0xff) - break; - mdelay(100); - } - if (stopwatch_expired(&sw)) { - printk(BIOS_INFO, "IPMI: Waiting for BMC timed out\n"); - return CB_ERR; - } - } - - printk(BIOS_INFO, "Get BMC self test result..."); - if (conf && conf->bmc_boot_timeout) { - for (retry_count = 0; retry_count < conf->bmc_boot_timeout; retry_count++) { - if (!ipmi_get_bmc_self_test_result(dev, &selftestrsp)) - break; - - mdelay(1000); - } - } else { - /* At least run once */ - ipmi_get_bmc_self_test_result(dev, &selftestrsp); - } - - int ret = CB_ERR; - switch (selftestrsp.result) { - case IPMI_APP_SELFTEST_NO_ERROR: /* 0x55 */ - printk(BIOS_DEBUG, "No Error\n"); - ret = CB_SUCCESS; - break; - case IPMI_APP_SELFTEST_NOT_IMPLEMENTED: /* 0x56 */ - printk(BIOS_DEBUG, "Function Not Implemented\n"); - ret = CB_SUCCESS; - break; - case IPMI_APP_SELFTEST_ERROR: /* 0x57 */ - printk(BIOS_ERR, "Corrupted or inaccessible data or device\n"); - break; - case IPMI_APP_SELFTEST_FATAL_HW_ERROR: /* 0x58 */ - printk(BIOS_ERR, "Fatal Hardware Error\n"); - break; - case IPMI_APP_SELFTEST_RESERVED: /* 0xFF */ - printk(BIOS_DEBUG, "Reserved\n"); - ret = CB_SUCCESS; - break; - - default: /* Other Device Specific Hardware Error */ - printk(BIOS_ERR, "Device Specific Error 0x%x 0x%x\n", selftestrsp.result, - selftestrsp.param); - break; - } - return ret; -} diff --git a/src/drivers/ipmi/ipmi_ops.c b/src/drivers/ipmi/ipmi_ops.c index 73a02e1..d9b3256 100644 --- a/src/drivers/ipmi/ipmi_ops.c +++ b/src/drivers/ipmi/ipmi_ops.c @@ -2,6 +2,7 @@ #include <console/console.h> #include "ipmi_ops.h" +#include "ipmi_if.h" #include <string.h> #include <types.h> @@ -18,7 +19,7 @@ /* clear BIOS FRB2 expiration flag */ req.timer_use_expiration_flags_clr = 2; req.initial_countdown_val = countdown; - ret = ipmi_kcs_message(port, IPMI_NETFN_APPLICATION, 0x0, + ret = ipmi_message(port, IPMI_NETFN_APPLICATION, 0x0, IPMI_BMC_SET_WDG_TIMER, (const unsigned char *) &req, sizeof(req), (unsigned char *) &rsp, sizeof(rsp)); @@ -32,7 +33,7 @@ } /* Reset command to start timer */ - ret = ipmi_kcs_message(port, IPMI_NETFN_APPLICATION, 0x0, + ret = ipmi_message(port, IPMI_NETFN_APPLICATION, 0x0, IPMI_BMC_RESET_WDG_TIMER, NULL, 0, (unsigned char *) &rsp, sizeof(rsp)); @@ -56,7 +57,7 @@ struct ipmi_rsp resp; /* Get current timer first */ - ret = ipmi_kcs_message(port, IPMI_NETFN_APPLICATION, 0x0, + ret = ipmi_message(port, IPMI_NETFN_APPLICATION, 0x0, IPMI_BMC_GET_WDG_TIMER, NULL, 0, (unsigned char *) &rsp, sizeof(rsp)); @@ -76,7 +77,7 @@ rsp.data.timer_use &= ~(1 << 6); rsp.data.initial_countdown_val = 0; req = rsp.data; - ret = ipmi_kcs_message(port, IPMI_NETFN_APPLICATION, 0x0, + ret = ipmi_message(port, IPMI_NETFN_APPLICATION, 0x0, IPMI_BMC_SET_WDG_TIMER, (const unsigned char *) &req, sizeof(req), (unsigned char *) &resp, sizeof(resp)); @@ -104,7 +105,7 @@ return CB_ERR; } - ret = ipmi_kcs_message(port, IPMI_NETFN_APPLICATION, 0x0, + ret = ipmi_message(port, IPMI_NETFN_APPLICATION, 0x0, IPMI_BMC_GET_SYSTEM_GUID, NULL, 0, (unsigned char *) &rsp, sizeof(rsp)); @@ -128,7 +129,7 @@ return CB_ERR; } - ret = ipmi_kcs_message(port, IPMI_NETFN_STORAGE, 0x0, + ret = ipmi_message(port, IPMI_NETFN_STORAGE, 0x0, IPMI_ADD_SEL_ENTRY, (const unsigned char *) sel, 16, (unsigned char *) &rsp, sizeof(rsp)); diff --git a/src/drivers/ipmi/ipmi_ops.h b/src/drivers/ipmi/ipmi_ops.h index d900272..7a92a28 100644 --- a/src/drivers/ipmi/ipmi_ops.h +++ b/src/drivers/ipmi/ipmi_ops.h @@ -4,7 +4,7 @@ #define __IPMI_OPS_H #include <types.h> -#include "ipmi_kcs.h" +#include "ipmi_if.h" #define IPMI_BMC_RESET_WDG_TIMER 0x22 #define IPMI_BMC_SET_WDG_TIMER 0x24 #define IPMI_BMC_GET_WDG_TIMER 0x25 diff --git a/src/drivers/ipmi/ipmi_ops_premem.c b/src/drivers/ipmi/ipmi_ops_premem.c new file mode 100644 index 0000000..99c5842 --- /dev/null +++ b/src/drivers/ipmi/ipmi_ops_premem.c @@ -0,0 +1,53 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <arch/io.h> +#include <console/console.h> +#include <device/pnp.h> +#include <delay.h> +#include <timer.h> + +#include "ipmi_if.h" +#include "chip.h" + +enum cb_err ipmi_premem_init(const u16 port, const u16 device) +{ + const struct drivers_ipmi_config *conf = NULL; + const struct device *dev; + + /* Find IPMI PNP device from devicetree in romstage */ + dev = dev_find_slot_pnp(port, device); + + if (!dev) { + printk(BIOS_ERR, "IPMI: Cannot find PNP device port: %x, device %x\n", + port, device); + return CB_ERR; + } + if (!dev->enabled) { + printk(BIOS_ERR, "IPMI: device is not enabled\n"); + return CB_ERR; + } + printk(BIOS_DEBUG, "IPMI: romstage PNP KCS 0x%x\n", dev->path.pnp.port); + if (dev->chip_info) + conf = dev->chip_info; + + if (conf && conf->wait_for_bmc && conf->bmc_boot_timeout) { + struct stopwatch sw; + stopwatch_init_msecs_expire(&sw, conf->bmc_boot_timeout * 1000); + printk(BIOS_DEBUG, "IPMI: Waiting for BMC...\n"); + + while (!stopwatch_expired(&sw)) { + if (inb(dev->path.pnp.port) != 0xff) + break; + mdelay(100); + } + if (stopwatch_expired(&sw)) { + printk(BIOS_INFO, "IPMI: Waiting for BMC timed out\n"); + return CB_ERR; + } + } + + if (ipmi_process_self_test_result(dev)) + return CB_ERR; + + return CB_SUCCESS; +} diff --git a/src/drivers/ipmi/ocp/ipmi_ocp.c b/src/drivers/ipmi/ocp/ipmi_ocp.c index 11161a8..9f583be 100644 --- a/src/drivers/ipmi/ocp/ipmi_ocp.c +++ b/src/drivers/ipmi/ocp/ipmi_ocp.c @@ -10,7 +10,7 @@ #include <console/console.h> #include <device/device.h> #include <device/pnp.h> -#include <drivers/ipmi/ipmi_kcs.h> +#include <drivers/ipmi/ipmi_if.h> #include <drivers/ocp/dmi/ocp_dmi.h> #include <types.h> @@ -28,8 +28,9 @@ req.cpu1_lo = xeon_sp_ppin[1].lo; req.cpu1_hi = xeon_sp_ppin[1].hi; } - ret = ipmi_kcs_message(dev->path.pnp.port, IPMI_NETFN_OEM, 0x0, IPMI_OEM_SET_PPIN, - (const unsigned char *) &req, sizeof(req), (unsigned char *) &rsp, sizeof(rsp)); + ret = ipmi_message(dev->path.pnp.port, IPMI_NETFN_OEM, 0x0, IPMI_OEM_SET_PPIN, + (const unsigned char *) &req, sizeof(req), + (unsigned char *) &rsp, sizeof(rsp)); if (ret < sizeof(struct ipmi_rsp) || rsp.completion_code) { printk(BIOS_ERR, "IPMI: %s command failed (ret=%d resp=0x%x)\n", diff --git a/src/drivers/ipmi/ocp/ipmi_ocp_romstage.c b/src/drivers/ipmi/ocp/ipmi_ocp_romstage.c index 8e43d8d..7b0b9ea 100644 --- a/src/drivers/ipmi/ocp/ipmi_ocp_romstage.c +++ b/src/drivers/ipmi/ocp/ipmi_ocp_romstage.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ #include <console/console.h> -#include <drivers/ipmi/ipmi_kcs.h> +#include <drivers/ipmi/ipmi_if.h> #include "ipmi_ocp.h" @@ -10,9 +10,9 @@ int ret; struct ipmi_rsp rsp; - ret = ipmi_kcs_message(port, IPMI_NETFN_OEM, 0x0, - IPMI_BMC_SET_POST_START, NULL, 0, (u8 *) &rsp, - sizeof(rsp)); + ret = ipmi_message(port, IPMI_NETFN_OEM, 0x0, + IPMI_BMC_SET_POST_START, NULL, 0, (u8 *) &rsp, + sizeof(rsp)); if (ret < sizeof(struct ipmi_rsp) || rsp.completion_code) { printk(BIOS_ERR, "IPMI: %s command failed (ret=%d rsp=0x%x)\n", @@ -42,10 +42,10 @@ /* IPMI OEM get bios boot order command to check if the valid bit and the CMOS clear bit are both set from the response BootMode byte. */ - ret = ipmi_kcs_message(CONFIG_BMC_KCS_BASE, IPMI_NETFN_OEM, 0x0, - IPMI_OEM_GET_BIOS_BOOT_ORDER, - NULL, 0, - (unsigned char *) &rsp, sizeof(rsp)); + ret = ipmi_message(CONFIG_BMC_KCS_BASE, IPMI_NETFN_OEM, 0x0, + IPMI_OEM_GET_BIOS_BOOT_ORDER, + NULL, 0, + (unsigned char *) &rsp, sizeof(rsp)); if (ret < sizeof(struct ipmi_rsp) || rsp.resp.completion_code) { printk(BIOS_ERR, "IPMI: %s command failed (read ret=%d resp=0x%x)\n", @@ -56,10 +56,10 @@ if (!IS_CMOS_AND_VALID_BIT(rsp.data.boot_mode)) { req = rsp.data; SET_CMOS_AND_VALID_BIT(req.boot_mode); - ret = ipmi_kcs_message(CONFIG_BMC_KCS_BASE, IPMI_NETFN_OEM, 0x0, - IPMI_OEM_SET_BIOS_BOOT_ORDER, - (const unsigned char *) &req, sizeof(req), - (unsigned char *) &rsp, sizeof(rsp)); + ret = ipmi_message(CONFIG_BMC_KCS_BASE, IPMI_NETFN_OEM, 0x0, + IPMI_OEM_SET_BIOS_BOOT_ORDER, + (const unsigned char *) &req, sizeof(req), + (unsigned char *) &rsp, sizeof(rsp)); if (ret < sizeof(struct ipmi_rsp) || rsp.resp.completion_code) { printk(BIOS_ERR, "IPMI: %s command failed (sent ret=%d resp=0x%x)\n", diff --git a/src/drivers/ipmi/supermicro_oem.c b/src/drivers/ipmi/supermicro_oem.c index 9d5ffc7..7af4e3b 100644 --- a/src/drivers/ipmi/supermicro_oem.c +++ b/src/drivers/ipmi/supermicro_oem.c @@ -3,7 +3,7 @@ #include <types.h> #include <console/console.h> -#include <drivers/ipmi/ipmi_kcs.h> +#include <drivers/ipmi/ipmi_if.h> #include <string.h> #include <build.h> #include "ipmi_supermicro_oem.h" @@ -35,9 +35,9 @@ bios_ver.str[i] = 0; bios_ver.ver = IPMI_LUN0_AC_SET_BIOS_VER; - ret = ipmi_kcs_message(kcs_port, IPMI_NETFN_OEM, 0, IPMI_LUN0_SET_BIOS_STRING, - (const unsigned char *) &bios_ver, sizeof(bios_ver), - (unsigned char *) &rsp, sizeof(rsp)); + ret = ipmi_message(kcs_port, IPMI_NETFN_OEM, 0, IPMI_LUN0_SET_BIOS_STRING, + (const unsigned char *) &bios_ver, sizeof(bios_ver), + (unsigned char *) &rsp, sizeof(rsp)); if (ret < sizeof(rsp) || rsp.completion_code) { printk(BIOS_ERR, "BMC_IPMI: %s command failed (ret=%d resp=0x%x)\n", __func__, ret, rsp.completion_code); @@ -54,9 +54,9 @@ bios_ver.str[15] = 0; bios_ver.ver = IPMI_LUN0_AC_SET_BIOS_DATE; - ret = ipmi_kcs_message(kcs_port, IPMI_NETFN_OEM, 0, IPMI_LUN0_SET_BIOS_STRING, - (const unsigned char *) &bios_ver, sizeof(bios_ver), - (unsigned char *) &rsp, sizeof(rsp)); + ret = ipmi_message(kcs_port, IPMI_NETFN_OEM, 0, IPMI_LUN0_SET_BIOS_STRING, + (const unsigned char *) &bios_ver, sizeof(bios_ver), + (unsigned char *) &rsp, sizeof(rsp)); if (ret < sizeof(rsp) || rsp.completion_code) { printk(BIOS_ERR, "BMC_IPMI: %s command failed (ret=%d resp=0x%x)\n", __func__, ret, rsp.completion_code); diff --git a/src/mainboard/ocp/deltalake/ipmi.c b/src/mainboard/ocp/deltalake/ipmi.c index 25a5a27..d990b87 100644 --- a/src/mainboard/ocp/deltalake/ipmi.c +++ b/src/mainboard/ocp/deltalake/ipmi.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ #include <console/console.h> -#include <drivers/ipmi/ipmi_kcs.h> +#include <drivers/ipmi/ipmi_if.h> #include <drivers/ipmi/ipmi_ops.h> #include <drivers/ipmi/ocp/ipmi_ocp.h> #include <drivers/vpd/vpd.h> @@ -18,7 +18,7 @@ } __packed; struct ipmi_config_rsp rsp; - ret = ipmi_kcs_message(CONFIG_BMC_KCS_BASE, IPMI_NETFN_OEM, 0x0, + ret = ipmi_message(CONFIG_BMC_KCS_BASE, IPMI_NETFN_OEM, 0x0, IPMI_OEM_GET_PCIE_CONFIG, NULL, 0, (unsigned char *) &rsp, sizeof(rsp)); @@ -44,7 +44,7 @@ } __packed; struct ipmi_config_rsp rsp; - ret = ipmi_kcs_message(CONFIG_BMC_KCS_BASE, IPMI_NETFN_OEM, 0x0, IPMI_OEM_GET_BOARD_ID, + ret = ipmi_message(CONFIG_BMC_KCS_BASE, IPMI_NETFN_OEM, 0x0, IPMI_OEM_GET_BOARD_ID, NULL, 0, (unsigned char *) &rsp, sizeof(rsp)); if (ret < sizeof(struct ipmi_rsp) || rsp.resp.completion_code) { diff --git a/src/mainboard/ocp/deltalake/romstage.c b/src/mainboard/ocp/deltalake/romstage.c index 05a7188..2efed1c 100644 --- a/src/mainboard/ocp/deltalake/romstage.c +++ b/src/mainboard/ocp/deltalake/romstage.c @@ -2,7 +2,7 @@ #include <console/console.h> #include <console/uart.h> -#include <drivers/ipmi/ipmi_kcs.h> +#include <drivers/ipmi/ipmi_if.h> #include <drivers/ipmi/ocp/ipmi_ocp.h> #include <drivers/vpd/vpd.h> #include <fsp/api.h> @@ -188,7 +188,7 @@ /* Since it's the first IPMI command, it's better to run get BMC selftest result first */ - if (ipmi_kcs_premem_init(CONFIG_BMC_KCS_BASE, 0) == CB_SUCCESS) { + if (ipmi_premem_init(CONFIG_BMC_KCS_BASE, 0) == CB_SUCCESS) { ipmi_set_post_start(CONFIG_BMC_KCS_BASE); init_frb2_wdt(); } diff --git a/src/mainboard/ocp/tiogapass/ipmi.c b/src/mainboard/ocp/tiogapass/ipmi.c index 74f96fe..e97341b 100644 --- a/src/mainboard/ocp/tiogapass/ipmi.c +++ b/src/mainboard/ocp/tiogapass/ipmi.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <console/console.h> -#include <drivers/ipmi/ipmi_kcs.h> +#include <drivers/ipmi/ipmi_if.h> #include <drivers/ipmi/ipmi_ops.h> #include <drivers/ipmi/ocp/ipmi_ocp.h> #include <drivers/vpd/vpd.h> diff --git a/src/mainboard/ocp/tiogapass/romstage.c b/src/mainboard/ocp/tiogapass/romstage.c index 20c7466..842e977 100644 --- a/src/mainboard/ocp/tiogapass/romstage.c +++ b/src/mainboard/ocp/tiogapass/romstage.c @@ -2,7 +2,7 @@ #include <fsp/api.h> #include <FspmUpd.h> -#include <drivers/ipmi/ipmi_kcs.h> +#include <drivers/ipmi/ipmi_if.h> #include <drivers/ipmi/ocp/ipmi_ocp.h> #include <soc/romstage.h> #include <string.h> @@ -54,7 +54,7 @@ void mainboard_memory_init_params(FSPM_UPD *mupd) { /* It's better to run get BMC selftest result first */ - if (ipmi_kcs_premem_init(CONFIG_BMC_KCS_BASE, 0) == CB_SUCCESS) { + if (ipmi_premem_init(CONFIG_BMC_KCS_BASE, 0) == CB_SUCCESS) { ipmi_set_post_start(CONFIG_BMC_KCS_BASE); init_frb2_wdt(); } -- To view, visit https://review.coreboot.org/c/coreboot/+/67056 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia99da6fb63adb7bf556d3d6f7964b34831be8a2f Gerrit-Change-Number: 67056 Gerrit-PatchSet: 4 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jingle Hsu <jingle_hsu(a)wiwynn.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Shelly Chang <Shelly_Chang(a)wiwynn.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: vboot: change name of the GCVD root pub key file
by Vadim Bendebury (Code Review) 02 Oct '22

02 Oct '22

Attention is currently required from: Julius Werner, Yu-Ping Wu. Vadim Bendebury has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68057 ) Change subject: vboot: change name of the GCVD root pub key file ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/68057 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia98438719adcb4b9b99b8823c8d5c04a0f381a0e Gerrit-Change-Number: 68057 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Sun, 02 Oct 2022 20:56:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: vboot: change name of the GCVD root pub key file
by Vadim Bendebury (Code Review) 02 Oct '22

02 Oct '22

Attention is currently required from: Julius Werner, Yu-Ping Wu. Hello Julius Werner, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68057 to look at the new patch set (#2). Change subject: vboot: change name of the GCVD root pub key file ...................................................................... vboot: change name of the GCVD root pub key file The file name of the root keys generated by the HSM starts with the root_key_ prefix. This name change is propagated into the test keys directory of vboot reference, coreboot should use the changed file name. BRANCH=none BUG=b/248317123 TEST=invoking 'emerge-nissa coreboot' succeeds Change-Id: Ia98438719adcb4b9b99b8823c8d5c04a0f381a0e Signed-off-by: Vadim Bendebury <vbendeb(a)chromium.org> --- M src/security/vboot/Kconfig 1 file changed, 20 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/68057/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68057 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia98438719adcb4b9b99b8823c8d5c04a0f381a0e Gerrit-Change-Number: 68057 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: vboot: change name of the GCVD root pub key file
by Vadim Bendebury (Code Review) 02 Oct '22

02 Oct '22

Vadim Bendebury has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68057 ) Change subject: vboot: change name of the GCVD root pub key file ...................................................................... vboot: change name of the GCVD root pub key file The file name of the root keys generated by the HSM starts with the root_key_ prefix. This name change is propagated into the test keys directory of vboot reference, coreboot should use the changed file name. BRANCH=none BUG=none TEST=invoking 'emerge-nissa coreboot' succeeds Change-Id: Ia98438719adcb4b9b99b8823c8d5c04a0f381a0e Signed-off-by: Vadim Bendebury <vbendeb(a)chromium.org> --- M src/security/vboot/Kconfig 1 file changed, 20 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/68057/1 diff --git a/src/security/vboot/Kconfig b/src/security/vboot/Kconfig index a36510d..3c0af95 100644 --- a/src/security/vboot/Kconfig +++ b/src/security/vboot/Kconfig @@ -429,7 +429,7 @@ config VBOOT_GSCVD_ROOT_PUBKEY string "GSCVD root key (public)" - default "\$(VBOOT_SOURCE)/tests/devkeys/arv_root.vbpubk" + default "\$(VBOOT_SOURCE)/tests/devkeys/root_key_arv_root.vbpubk" config VBOOT_GSCVD_PLATFORM_PRIVKEY string "GSCVD platform key (private)" -- To view, visit https://review.coreboot.org/c/coreboot/+/68057 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia98438719adcb4b9b99b8823c8d5c04a0f381a0e Gerrit-Change-Number: 68057 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-MessageType: newchange

1 0

[XL] Change in coreboot[master]: RFC: Add initial support for the bootguarded framework tigerlake lapt...
by Paul Menzel (Code Review) 02 Oct '22

02 Oct '22

Attention is currently required from: Felix Singer, Jonathan Neuschäfer, Mimoja, Keith Hui, Christoph Pomaska. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62569 ) Change subject: RFC: Add initial support for the bootguarded framework tigerlake laptop (hx20) ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: > Framework is launching a Chromebook edition: […] In #coreboot(a)libera.chat, it was said, that the code is already in the tree, and it’s `src/mainboard/google/brya/variants/banshee/`. -- To view, visit https://review.coreboot.org/c/coreboot/+/62569 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifaf215cccae8836d691392e3e584f49f675f8456 Gerrit-Change-Number: 62569 Gerrit-PatchSet: 6 Gerrit-Owner: Mimoja <coreboot(a)mimoja.de> Gerrit-Reviewer: Christoph Pomaska <github(a)slrie.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Keith Hui <buurin(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Attention: Mimoja <coreboot(a)mimoja.de> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Attention: Christoph Pomaska <github(a)slrie.de> Gerrit-Comment-Date: Sun, 02 Oct 2022 20:43:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Keith Hui <buurin(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: src/mb/google/skyrim: Adjust Makefile to look for SPD
by Paul Menzel (Code Review) 02 Oct '22

02 Oct '22

Attention is currently required from: Raul Rangel, Jason Nien, Jon Murphy, Martin Roth, Karthik Ramasubramanian. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68018 ) Change subject: src/mb/google/skyrim: Adjust Makefile to look for SPD ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/68018/comment/89d9ee36_96801765 PS3, Line 7: src/ Please remove. -- To view, visit https://review.coreboot.org/c/coreboot/+/68018 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9cf13acb1188309ea6a1e6bdacc37d80b01f70a8 Gerrit-Change-Number: 68018 Gerrit-PatchSet: 3 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Sun, 02 Oct 2022 20:20:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Makefile.inc: Decrease minimal pagesize from 4 kB to 1 kB
by Paul Menzel (Code Review) 02 Oct '22

02 Oct '22

Attention is currently required from: Nico Huber, Martin L Roth, Angel Pons, Julius Werner. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62830 ) Change subject: Makefile.inc: Decrease minimal pagesize from 4 kB to 1 kB ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > Let's just try the 1024? I don't think we want to disable the warning. I also successfully tested this, and implemented that in `Makefile.inc`. -- To view, visit https://review.coreboot.org/c/coreboot/+/62830 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e36633f42cb4dc5af53212c10c919a86e451ee0 Gerrit-Change-Number: 62830 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Sun, 02 Oct 2022 18:40:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: lib/prog_loaders.c: Clean up includes
by Elyes Haouas (Code Review) 02 Oct '22

02 Oct '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68052 ) Change subject: lib/prog_loaders.c: Clean up includes ...................................................................... lib/prog_loaders.c: Clean up includes Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: I00e9636fa49c402f38119ba0bfc85c8c193fec12 --- M src/lib/prog_loaders.c 1 file changed, 12 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/68052/1 diff --git a/src/lib/prog_loaders.c b/src/lib/prog_loaders.c index 01775b9..81ae710 100644 --- a/src/lib/prog_loaders.c +++ b/src/lib/prog_loaders.c @@ -9,11 +9,9 @@ #include <program_loading.h> #include <reset.h> #include <rmodule.h> -#include <stage_cache.h> -#include <symbols.h> -#include <thread.h> -#include <timestamp.h> #include <security/vboot/vboot_common.h> +#include <stage_cache.h> +#include <timestamp.h> void run_romstage(void) { -- To view, visit https://review.coreboot.org/c/coreboot/+/68052 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I00e9636fa49c402f38119ba0bfc85c8c193fec12 Gerrit-Change-Number: 68052 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2022