coreboot-gerrit October 2022

coreboot-gerrit@coreboot.org

1 participants
5881 discussions

[S] Change in coreboot[master]: arch/x86/mmap_boot.c: Clean up includes
by Elyes Haouas (Code Review) 02 Oct '22

02 Oct '22

Attention is currently required from: Paul Menzel. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68033 ) Change subject: arch/x86/mmap_boot.c: Clean up includes ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/68033/comment/79adcb19_e9a73864 PS1, Line 7: Cleanup > Clean up Done -- To view, visit https://review.coreboot.org/c/coreboot/+/68033 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85e60c189c1ec1da5cf0e5b864447ef6f7b3f548 Gerrit-Change-Number: 68033 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sun, 02 Oct 2022 10:00:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: arch/x86/mmap_boot.c: Clean up includes
by Elyes Haouas (Code Review) 02 Oct '22

02 Oct '22

Attention is currently required from: Elyes Haouas. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68033 to look at the new patch set (#2). Change subject: arch/x86/mmap_boot.c: Clean up includes ...................................................................... arch/x86/mmap_boot.c: Clean up includes Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: I85e60c189c1ec1da5cf0e5b864447ef6f7b3f548 --- M src/arch/x86/mmap_boot.c 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/68033/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68033 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85e60c189c1ec1da5cf0e5b864447ef6f7b3f548 Gerrit-Change-Number: 68033 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: cpu/x86/smm/smm_module_loader.c: Clean up includes
by Elyes Haouas (Code Review) 02 Oct '22

02 Oct '22

Attention is currently required from: Paul Menzel. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68032 ) Change subject: cpu/x86/smm/smm_module_loader.c: Clean up includes ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/68032/comment/08c6764c_7281a82f PS2, Line 7: Cleanup > The verb is spelled with space: Clean up. https://www.collinsdictionary.com/dictionary/english/cleanup -- To view, visit https://review.coreboot.org/c/coreboot/+/68032 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I36c54e62797e67c1732f8deaf8843daf35610e22 Gerrit-Change-Number: 68032 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sun, 02 Oct 2022 09:59:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: cpu/x86/smm/smm_module_loader.c: Clean up includes
by Elyes Haouas (Code Review) 02 Oct '22

02 Oct '22

Attention is currently required from: Elyes Haouas. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68032 to look at the new patch set (#3). Change subject: cpu/x86/smm/smm_module_loader.c: Clean up includes ...................................................................... cpu/x86/smm/smm_module_loader.c: Clean up includes Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: I36c54e62797e67c1732f8deaf8843daf35610e22 --- M src/cpu/x86/smm/smm_module_loader.c 1 file changed, 11 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/68032/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/68032 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I36c54e62797e67c1732f8deaf8843daf35610e22 Gerrit-Change-Number: 68032 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: soc/intel/alderlake: VR Fast VMODE support
by Paul Menzel (Code Review) 02 Oct '22

02 Oct '22

Attention is currently required from: Zhixing Ma, Anil Kumar K, Cliff Huang, Jérémy Compostella, Selma Bensaid, Tim Wawrzynczak. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66917 ) Change subject: soc/intel/alderlake: VR Fast VMODE support ...................................................................... Patch Set 5: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/66917/comment/b5e8e586_ab269f49 PS5, Line 7: soc/intel/alderlake: VR Fast VMODE support Please make it a statement [1]. [1]: https://cbea.ms/git-commit/ -- To view, visit https://review.coreboot.org/c/coreboot/+/66917 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I313acf01c534d0d32620a9dedba7cf3b304ed2ee Gerrit-Change-Number: 66917 Gerrit-PatchSet: 5 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Comment-Date: Sun, 02 Oct 2022 09:58:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: 3rdparty/amd_blobs:Advance submodule pointer
by Paul Menzel (Code Review) 02 Oct '22

02 Oct '22

Attention is currently required from: Jason Glenesk. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68022 ) Change subject: 3rdparty/amd_blobs:Advance submodule pointer ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/68022/comment/bbb08a80_820136a9 PS2, Line 7: :Advance Nit: Missing space. -- To view, visit https://review.coreboot.org/c/coreboot/+/68022 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9ff0b581e831ca7190df194c7d1f5162d2641d12 Gerrit-Change-Number: 68022 Gerrit-PatchSet: 2 Gerrit-Owner: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Sun, 02 Oct 2022 09:58:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: arch/x86/mmap_boot.c: Cleanup includes
by Paul Menzel (Code Review) 02 Oct '22

02 Oct '22

Attention is currently required from: Elyes Haouas. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68033 ) Change subject: arch/x86/mmap_boot.c: Cleanup includes ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/68033/comment/f289343e_7caa0050 PS1, Line 7: Cleanup Clean up -- To view, visit https://review.coreboot.org/c/coreboot/+/68033 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85e60c189c1ec1da5cf0e5b864447ef6f7b3f548 Gerrit-Change-Number: 68033 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 02 Oct 2022 09:50:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: cpu/x86/smm/smm_module_loader.c: Cleanup includes
by Paul Menzel (Code Review) 02 Oct '22

02 Oct '22

Attention is currently required from: Elyes Haouas. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68032 ) Change subject: cpu/x86/smm/smm_module_loader.c: Cleanup includes ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/68032/comment/4d163b8e_7b68b0ca PS2, Line 7: Cleanup The verb is spelled with space: Clean up. -- To view, visit https://review.coreboot.org/c/coreboot/+/68032 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I36c54e62797e67c1732f8deaf8843daf35610e22 Gerrit-Change-Number: 68032 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 02 Oct 2022 09:50:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: arch/x86/mmap_boot.c: Cleanup includes
by Elyes Haouas (Code Review) 02 Oct '22

02 Oct '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68033 ) Change subject: arch/x86/mmap_boot.c: Cleanup includes ...................................................................... arch/x86/mmap_boot.c: Cleanup includes Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: I85e60c189c1ec1da5cf0e5b864447ef6f7b3f548 --- M src/arch/x86/mmap_boot.c 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/68033/1 diff --git a/src/arch/x86/mmap_boot.c b/src/arch/x86/mmap_boot.c index f0ccc86..0e9812f 100644 --- a/src/arch/x86/mmap_boot.c +++ b/src/arch/x86/mmap_boot.c @@ -1,8 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <boot_device.h> -#include <endian.h> #include <spi_flash.h> +#include <stdint.h> /* The ROM is memory mapped just below 4GiB. Form a pointer for the base. */ #define rom_base ((void *)(uintptr_t)(0x100000000ULL-CONFIG_ROM_SIZE)) -- To view, visit https://review.coreboot.org/c/coreboot/+/68033 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85e60c189c1ec1da5cf0e5b864447ef6f7b3f548 Gerrit-Change-Number: 68033 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: cpu/x86/smm/smm_module_loader.c: Cleanup includes
by Elyes Haouas (Code Review) 02 Oct '22

02 Oct '22

Elyes Haouas has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/68032 ) Change subject: cpu/x86/smm/smm_module_loader.c: Cleanup includes ...................................................................... cpu/x86/smm/smm_module_loader.c: Cleanup includes Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: I36c54e62797e67c1732f8deaf8843daf35610e22 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/cpu/x86/smm/smm_module_loader.c 1 file changed, 12 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/68032/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68032 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I36c54e62797e67c1732f8deaf8843daf35610e22 Gerrit-Change-Number: 68032 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2022