coreboot-gerrit October 2022

coreboot-gerrit@coreboot.org

1 participants
5881 discussions

[S] Change in libgfxinit[master]: gma skylake: Avoid aliasing of Config.State
by Angel Pons (Code Review) 04 Oct '22

04 Oct '22

Attention is currently required from: Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/68109 ) Change subject: gma skylake: Avoid aliasing of Config.State ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/68109 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: I721dea522afba9342d92f44aa0fd7708cc079436 Gerrit-Change-Number: 68109 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Tue, 04 Oct 2022 13:45:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libgfxinit[master]: gma: Shuffle warning justifications to support old and new tooling
by Angel Pons (Code Review) 04 Oct '22

04 Oct '22

Attention is currently required from: Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/68108 ) Change subject: gma: Shuffle warning justifications to support old and new tooling ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/68108 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: I8f879e73b3ea43de7e10532fba6a9b2bb9eecfcf Gerrit-Change-Number: 68108 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Tue, 04 Oct 2022 13:45:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libgfxinit[master]: display probing: Update warning justification
by Angel Pons (Code Review) 04 Oct '22

04 Oct '22

Attention is currently required from: Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/68107 ) Change subject: display probing: Update warning justification ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/68107 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: I832d40a8e515eff63be2b196b18ca7b6f0114914 Gerrit-Change-Number: 68107 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Tue, 04 Oct 2022 13:44:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libgfxinit[master]: framebuffer filler: Extend loop invariant to assist prover
by Angel Pons (Code Review) 04 Oct '22

04 Oct '22

Attention is currently required from: Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/68106 ) Change subject: framebuffer filler: Extend loop invariant to assist prover ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/68106 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: I34d5b4d5840fd2b45c4bf3d72abba88487dda2dd Gerrit-Change-Number: 68106 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Tue, 04 Oct 2022 13:44:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libgfxinit[master]: dp info: Provide Link_Status'Object_Size and padding
by Angel Pons (Code Review) 04 Oct '22

04 Oct '22

Attention is currently required from: Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/68105 ) Change subject: dp info: Provide Link_Status'Object_Size and padding ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File common/hw-gfx-dp_info.ads: https://review.coreboot.org/c/libgfxinit/+/68105/comment/6144a229_6ad67954 PS1, Line 77: Adjust_Requests at 16#04# range 0 .. 15; Are these three 16-bit registers? ``` struct __packed link_status { uint16_t lanes; /* Offset 0x00 */ struct __packed { /* Offset 0x02 */ uint16_t interlane_align_done : 1; /* Bits 0:0 */ uint16_t padding : 15; /* Bits 15:1 */ }; uint16_t adjust_requests; /* Offset 0x04 */ }; ``` -- To view, visit https://review.coreboot.org/c/libgfxinit/+/68105 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: Id7f6b9f50105d9357adcb60fd551b719d9eccd30 Gerrit-Change-Number: 68105 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Tue, 04 Oct 2022 13:43:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libgfxinit[master]: gma: Work around GNATprove issue with nested loops
by Angel Pons (Code Review) 04 Oct '22

04 Oct '22

Attention is currently required from: Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/68112 ) Change subject: gma: Work around GNATprove issue with nested loops ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/libgfxinit/+/68112/comment/c8ba8ef6_022c1926 PS1, Line 10: weird check messages. Do these messages have something in common? Is it worth providing an example? -- To view, visit https://review.coreboot.org/c/libgfxinit/+/68112 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: I5430081767c760b85401300e0db4d26fd78270d7 Gerrit-Change-Number: 68112 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Tue, 04 Oct 2022 13:35:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/amd/*: Move emmc disabling to device ops
by Arthur Heymans (Code Review) 04 Oct '22

04 Oct '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger, Felix Held. Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68113 ) Change subject: soc/amd/*: Move emmc disabling to device ops ...................................................................... soc/amd/*: Move emmc disabling to device ops This allows for reduced use of chip_operations in the followup patch and allows the allocator to skip over the used mmio. Change-Id: I4052438185e7861792733b96a1298201c73fc3ff Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/soc/amd/cezanne/Makefile.inc M src/soc/amd/cezanne/chip.c A src/soc/amd/cezanne/emmc.c M src/soc/amd/mendocino/Makefile.inc M src/soc/amd/mendocino/chip.c A src/soc/amd/mendocino/emmc.c 6 files changed, 68 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/68113/1 diff --git a/src/soc/amd/cezanne/Makefile.inc b/src/soc/amd/cezanne/Makefile.inc index 205b349..8c3227d 100644 --- a/src/soc/amd/cezanne/Makefile.inc +++ b/src/soc/amd/cezanne/Makefile.inc @@ -44,6 +44,7 @@ ramstage-y += root_complex.c ramstage-y += uart.c ramstage-y += xhci.c +ramstage-y += emmc.c smm-y += gpio.c smm-y += smihandler.c diff --git a/src/soc/amd/cezanne/chip.c b/src/soc/amd/cezanne/chip.c index f184cb5..86aaf6c 100644 --- a/src/soc/amd/cezanne/chip.c +++ b/src/soc/amd/cezanne/chip.c @@ -1,12 +1,10 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <amdblocks/aoac.h> #include <console/console.h> #include <device/device.h> #include <device/pci.h> #include <fsp/api.h> #include <soc/acpi.h> -#include <soc/aoac_defs.h> #include <soc/cpu.h> #include <soc/data_fabric.h> #include <soc/pci_devs.h> @@ -18,6 +16,8 @@ extern struct device_operations soc_amd_i2c_mmio_ops; /* Supplied by uart.c */ extern struct device_operations cezanne_uart_mmio_ops; +/* Supplied by emmc.c */ +extern struct device_operations cezanne_emmc_mmio_ops; struct device_operations cpu_bus_ops = { .read_resources = noop_read_resources, @@ -60,8 +60,7 @@ dev->ops = &cezanne_uart_mmio_ops; break; case APU_EMMC_BASE: - if (!dev->enabled) - power_off_aoac_device(FCH_AOAC_DEV_EMMC); + dev->ops = &cezanne_emmc_mmio_ops; break; } } diff --git a/src/soc/amd/cezanne/emmc.c b/src/soc/amd/cezanne/emmc.c new file mode 100644 index 0000000..a699b20 --- /dev/null +++ b/src/soc/amd/cezanne/emmc.c @@ -0,0 +1,23 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <amdblocks/aoac.h> +#include <device/device.h> +#include <soc/aoac_defs.h> + +static void emmc_read_resources(struct device *dev) +{ + mmio_resource_kb(dev, 0, dev->path.mmio.addr / KiB, 4); +} + +static void emmc_enable(struct device *dev) +{ + if (!dev->enabled) + power_off_aoac_device(FCH_AOAC_DEV_EMMC); +} + +struct device_operations cezanne_emmc_mmio_ops = { + .read_resources = emmc_read_resources, + .set_resources = noop_set_resources, + .scan_bus = scan_static_bus, + .enable = emmc_enable, +}; diff --git a/src/soc/amd/mendocino/Makefile.inc b/src/soc/amd/mendocino/Makefile.inc index bdc1a7a..b81be8d 100644 --- a/src/soc/amd/mendocino/Makefile.inc +++ b/src/soc/amd/mendocino/Makefile.inc @@ -46,6 +46,7 @@ ramstage-y += root_complex.c ramstage-y += uart.c ramstage-y += xhci.c +ramstage-y += emmc.c smm-y += gpio.c smm-y += smihandler.c diff --git a/src/soc/amd/mendocino/chip.c b/src/soc/amd/mendocino/chip.c index 41b2446..f71c285 100644 --- a/src/soc/amd/mendocino/chip.c +++ b/src/soc/amd/mendocino/chip.c @@ -2,13 +2,11 @@ /* TODO: Check if this is still correct */ -#include <amdblocks/aoac.h> #include <console/console.h> #include <device/device.h> #include <device/pci.h> #include <fsp/api.h> #include <soc/acpi.h> -#include <soc/aoac_defs.h> #include <soc/cpu.h> #include <soc/data_fabric.h> #include <soc/pci_devs.h> @@ -20,6 +18,9 @@ extern struct device_operations soc_amd_i2c_mmio_ops; /* Supplied by uart.c */ extern struct device_operations mendocino_uart_mmio_ops; +/* Supplied by emmc.c */ +extern struct device_operations mendocino_emmc_mmio_ops; + struct device_operations cpu_bus_ops = { .read_resources = noop_read_resources, @@ -65,8 +66,7 @@ dev->ops = &mendocino_uart_mmio_ops; break; case APU_EMMC_BASE: - if (!dev->enabled) - power_off_aoac_device(FCH_AOAC_DEV_EMMC); + dev->ops = &mendocino_emmc_mmio_ops; break; } } diff --git a/src/soc/amd/mendocino/emmc.c b/src/soc/amd/mendocino/emmc.c new file mode 100644 index 0000000..ae01a14 --- /dev/null +++ b/src/soc/amd/mendocino/emmc.c @@ -0,0 +1,23 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <amdblocks/aoac.h> +#include <device/device.h> +#include <soc/aoac_defs.h> + +static void emmc_read_resources(struct device *dev) +{ + mmio_resource_kb(dev, 0, dev->path.mmio.addr / KiB, 4); +} + +static void emmc_enable(struct device *dev) +{ + if (!dev->enabled) + power_off_aoac_device(FCH_AOAC_DEV_EMMC); +} + +struct device_operations mendocino_emmc_mmio_ops = { + .read_resources = emmc_read_resources, + .set_resources = noop_set_resources, + .scan_bus = scan_static_bus, + .enable = emmc_enable, +}; -- To view, visit https://review.coreboot.org/c/coreboot/+/68113 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4052438185e7861792733b96a1298201c73fc3ff Gerrit-Change-Number: 68113 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: soc/amd/picasso: Use devicetree ops over pci driver
by Arthur Heymans (Code Review) 04 Oct '22

04 Oct '22

Attention is currently required from: Jason Glenesk, Matt DeVillier, Fred Reitberger, Felix Held. Hello Jason Glenesk, Matt DeVillier, Fred Reitberger, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/67743 to look at the new patch set (#2). Change subject: soc/amd/picasso: Use devicetree ops over pci driver ...................................................................... soc/amd/picasso: Use devicetree ops over pci driver Picasso is a SoC so it makes sense to statically use ops instead of matching them to PCI DID/VID at runtime. Change-Id: Ide747c9d386731af89b27630b200676c6e439910 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/soc/amd/picasso/chipset.cb M src/soc/amd/picasso/data_fabric.c M src/soc/amd/picasso/root_complex.c 3 files changed, 25 insertions(+), 35 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/67743/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67743 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ide747c9d386731af89b27630b200676c6e439910 Gerrit-Change-Number: 67743 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: soc/amd/*: Hook up device_operations in chipset.cb
by Arthur Heymans (Code Review) 04 Oct '22

04 Oct '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Arthur Heymans, Fred Reitberger. Hello Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/67738 to look at the new patch set (#2). Change subject: soc/amd/*: Hook up device_operations in chipset.cb ...................................................................... soc/amd/*: Hook up device_operations in chipset.cb This removes the need for a lot of boilerplate code in the soc code to hook up device_operations to devices. Change-Id: I2afc1855407910f1faa9bdd4e9416dd46474658e Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/soc/amd/cezanne/chip.c M src/soc/amd/cezanne/chipset.cb M src/soc/amd/mendocino/chip.c M src/soc/amd/mendocino/chipset_mendocino.cb M src/soc/amd/mendocino/chipset_rembrandt.cb M src/soc/amd/picasso/chip.c M src/soc/amd/picasso/chipset.cb 7 files changed, 60 insertions(+), 174 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/67738/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67738 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2afc1855407910f1faa9bdd4e9416dd46474658e Gerrit-Change-Number: 67738 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in libgfxinit[master]: gma: Work around GNATprove issue with nested loops
by Nico Huber (Code Review) 04 Oct '22

04 Oct '22

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/libgfxinit/+/68112 ) Change subject: gma: Work around GNATprove issue with nested loops ...................................................................... gma: Work around GNATprove issue with nested loops Add some explicit `Loop_Invariant (True)` to work around weird check messages. Change-Id: I5430081767c760b85401300e0db4d26fd78270d7 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M common/g45/hw-gfx-gma-plls.adb M common/ironlake/hw-gfx-gma-plls.adb 2 files changed, 17 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/12/68112/1 diff --git a/common/g45/hw-gfx-gma-plls.adb b/common/g45/hw-gfx-gma-plls.adb index 67242f2..5db76d6 100644 --- a/common/g45/hw-gfx-gma-plls.adb +++ b/common/g45/hw-gfx-gma-plls.adb @@ -322,8 +322,10 @@ -- reverse loops as hardware prefers higher values for M1 in reverse M1_Range range Limits.M1_Lower .. Limits.M1_Upper loop + pragma Loop_Invariant (True); for M2 in reverse M2_Range range Limits.M2_Lower .. Int64'Min (Limits.M2_Upper, M1) loop + pragma Loop_Invariant (True); for P1 in reverse P1_Range range Limits.P1_Lower .. Limits.P1_Upper loop Verify_Parameters diff --git a/common/ironlake/hw-gfx-gma-plls.adb b/common/ironlake/hw-gfx-gma-plls.adb index 10e9ff2..8b6ca36 100644 --- a/common/ironlake/hw-gfx-gma-plls.adb +++ b/common/ironlake/hw-gfx-gma-plls.adb @@ -291,8 +291,10 @@ -- reverse loops as hardware prefers higher values for M1 in reverse M1_Range range Limits.M1_Lower .. Limits.M1_Upper loop + pragma Loop_Invariant (True); for M2 in reverse M2_Range range Limits.M2_Lower .. Limits.M2_Upper loop + pragma Loop_Invariant (True); for P1 in reverse P1_Range range Limits.P1_Lower .. Limits.P1_Upper loop Verify_Parameters -- To view, visit https://review.coreboot.org/c/libgfxinit/+/68112 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: I5430081767c760b85401300e0db4d26fd78270d7 Gerrit-Change-Number: 68112 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2022