coreboot-gerrit October 2022

coreboot-gerrit@coreboot.org

1 participants
5881 discussions

[L] Change in coreboot[master]: util/inteltool: Add support for Alderlake P in inteltool
by Kacper Stojek (Code Review) 04 Oct '22

04 Oct '22

Attention is currently required from: Michał Żygowski, Maximilian Brune. Kacper Stojek has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66825 ) Change subject: util/inteltool: Add support for Alderlake P in inteltool ...................................................................... Patch Set 15: (1 comment) File util/inteltool/gpio_names/alderlake_p.h: https://review.coreboot.org/c/coreboot/+/66825/comment/cdd34be9_14f22f5a PS14, Line 193: "GPP_F13", "GSXSLOAD" , "n/a", "THC1_SPI2_IO1", "GSPI1_MISIO", "I2C1A_SDA", "USB_C_GPP_F13", > Not MISIO but MISO Done -- To view, visit https://review.coreboot.org/c/coreboot/+/66825 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2ba4ef7eee33d4dd762a05dd755de5e4d2e566dd Gerrit-Change-Number: 66825 Gerrit-PatchSet: 15 Gerrit-Owner: Kacper Stojek Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Tue, 04 Oct 2022 14:42:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: pc80/i8254: Add speaker beep function
by Michał Żygowski (Code Review) 04 Oct '22

04 Oct '22

Attention is currently required from: Angel Pons. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68100 ) Change subject: pc80/i8254: Add speaker beep function ...................................................................... Patch Set 2: (2 comments) File src/drivers/pc80/pc/i8254.c: https://review.coreboot.org/c/coreboot/+/68100/comment/b5902c1a_5fdeebf9 PS1, Line 7: #include <delay.h> > nit: existing includes seem to be sorted alphabetically Done https://review.coreboot.org/c/coreboot/+/68100/comment/e30ff5f0_cb271d22 PS1, Line 129: /* Block for specified miliseconds */ > > 'miliseconds' may be misspelled - perhaps 'milliseconds'? […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/68100 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8189b3462bb5140af352fa786db3a6a2a45076f2 Gerrit-Change-Number: 68100 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 04 Oct 2022 14:42:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: util/inteltool: Add support for Alderlake P in inteltool
by Kacper Stojek (Code Review) 04 Oct '22

04 Oct '22

Attention is currently required from: Kacper Stojek, Maximilian Brune. Hello build bot (Jenkins), Michał Kopeć, Stefan Reinauer, Maximilian Brune, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/66825 to look at the new patch set (#15). Change subject: util/inteltool: Add support for Alderlake P in inteltool ...................................................................... util/inteltool: Add support for Alderlake P in inteltool TEST=Dump registers on Clevo NS70PU with Intel® Core™ i7-1260P Document number: 626817, 630094, 655258 Change-Id: I2ba4ef7eee33d4dd762a05dd755de5e4d2e566dd Signed-off-by: Kacper Stojek <kacper.stojek(a)3mdeb.com> --- M util/inteltool/gpio.c M util/inteltool/gpio_groups.c A util/inteltool/gpio_names/alderlake_p.h M util/inteltool/inteltool.c M util/inteltool/inteltool.h M util/inteltool/pcr.c 6 files changed, 658 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/66825/15 -- To view, visit https://review.coreboot.org/c/coreboot/+/66825 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2ba4ef7eee33d4dd762a05dd755de5e4d2e566dd Gerrit-Change-Number: 66825 Gerrit-PatchSet: 15 Gerrit-Owner: Kacper Stojek Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Kacper Stojek Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-MessageType: newpatchset

1 0

[XL] Change in coreboot[master]: mb/protectli/vault_cml: Add Comet Lake 6 port board support
by build bot (Jenkins) (Code Review) 04 Oct '22

04 Oct '22

Attention is currently required from: Angel Pons, Piotr Król. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67940 ) Change subject: mb/protectli/vault_cml: Add Comet Lake 6 port board support ...................................................................... Patch Set 14: Verified+1 (1 comment) File src/mainboard/protectli/vault_cml/die.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159653): https://review.coreboot.org/c/coreboot/+/67940/comment/6c205917_5cb5622b PS14, Line 12: static uint8_t beep_count = 0;; Statements terminations use 1 semicolon -- To view, visit https://review.coreboot.org/c/coreboot/+/67940 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If1b4f9c8245a082ff875ae9c6102a1c45e677d0b Gerrit-Change-Number: 67940 Gerrit-PatchSet: 14 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Comment-Date: Tue, 04 Oct 2022 14:41:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: pc80/i8254: Add speaker beep function
by Michał Żygowski (Code Review) 04 Oct '22

04 Oct '22

Attention is currently required from: Michał Żygowski. Hello build bot (Jenkins), Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68100 to look at the new patch set (#2). Change subject: pc80/i8254: Add speaker beep function ...................................................................... pc80/i8254: Add speaker beep function Some platforms have an onboard speaker which could be used as an indicator of successful boot or critical error, e.g. in die_notify function. The function assumes that SPKR GPIO is properly configured by the platform code. Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: I8189b3462bb5140af352fa786db3a6a2a45076f2 --- M src/drivers/pc80/pc/i8254.c M src/include/pc80/i8254.h 2 files changed, 38 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/68100/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68100 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8189b3462bb5140af352fa786db3a6a2a45076f2 Gerrit-Change-Number: 68100 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[master]: util/inteltool: Add support for Alderlake P in inteltool
by Michał Żygowski (Code Review) 04 Oct '22

04 Oct '22

Attention is currently required from: Kacper Stojek, Maximilian Brune. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66825 ) Change subject: util/inteltool: Add support for Alderlake P in inteltool ...................................................................... Patch Set 14: (1 comment) File util/inteltool/gpio_names/alderlake_p.h: https://review.coreboot.org/c/coreboot/+/66825/comment/49416019_5c0758d9 PS14, Line 193: "GPP_F13", "GSXSLOAD" , "n/a", "THC1_SPI2_IO1", "GSPI1_MISIO", "I2C1A_SDA", "USB_C_GPP_F13", Not MISIO but MISO -- To view, visit https://review.coreboot.org/c/coreboot/+/66825 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2ba4ef7eee33d4dd762a05dd755de5e4d2e566dd Gerrit-Change-Number: 66825 Gerrit-PatchSet: 14 Gerrit-Owner: Kacper Stojek Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Kacper Stojek Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Tue, 04 Oct 2022 14:35:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: pc80/i8254: Add speaker beep function
by Angel Pons (Code Review) 04 Oct '22

04 Oct '22

Attention is currently required from: Michał Żygowski. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68100 ) Change subject: pc80/i8254: Add speaker beep function ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File src/drivers/pc80/pc/i8254.c: https://review.coreboot.org/c/coreboot/+/68100/comment/387c2eff_3f9c1942 PS1, Line 7: #include <delay.h> nit: existing includes seem to be sorted alphabetically https://review.coreboot.org/c/coreboot/+/68100/comment/7b2ddcf0_3599bc77 PS1, Line 129: /* Block for specified miliseconds */ > 'miliseconds' may be misspelled - perhaps 'milliseconds'? Please fix. -- To view, visit https://review.coreboot.org/c/coreboot/+/68100 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8189b3462bb5140af352fa786db3a6a2a45076f2 Gerrit-Change-Number: 68100 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Comment-Date: Tue, 04 Oct 2022 14:27:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libgfxinit[master]: hw-gfx-gma: Update BDSM register offset for TGL onwards
by Nico Huber (Code Review) 04 Oct '22

04 Oct '22

Attention is currently required from: Tim Wawrzynczak, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/65178 ) Change subject: hw-gfx-gma: Update BDSM register offset for TGL onwards ...................................................................... Patch Set 6: Verified+1 (1 comment) File common/hw-gfx-gma.adb: https://review.coreboot.org/c/libgfxinit/+/65178/comment/c662fe6c_f3593bf9 PS6, Line 861: Dev.Read32 It's 64 bits now. -- To view, visit https://review.coreboot.org/c/libgfxinit/+/65178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: I0a3e7a92dcb08ea33e08c9f2c5135d4269c9e0b9 Gerrit-Change-Number: 65178 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 04 Oct 2022 14:08:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libgfxinit[master]: Fix "unnecessary with of ancestor [-gnatwr]"
by Angel Pons (Code Review) 04 Oct '22

04 Oct '22

Angel Pons has submitted this change. ( https://review.coreboot.org/c/libgfxinit/+/67833 ) Change subject: Fix "unnecessary with of ancestor [-gnatwr]" ...................................................................... Fix "unnecessary with of ancestor [-gnatwr]" These warnings are a bit overeager as some of them only apply once unnecessary `use type ...` clauses are adapted. So we do both in one patch. This partially fixes building with GCC 12. Change-Id: Id7e88fe9a3ef7cb10cbc427a052e21f12578a3fd Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Signed-off-by: Nico Huber <nico.h(a)gmx.de> Reviewed-on: https://review.coreboot.org/c/libgfxinit/+/67833 Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M common/hw-gfx-dp_aux_ch.adb M common/hw-gfx-edid.adb M common/hw-gfx-framebuffer_filler.ads M common/hw-gfx-gma-config_helpers.ads M common/hw-gfx-gma-registers.ads M common/hw-gfx-gma.ads M common/hw-gfx.ads 7 files changed, 20 insertions(+), 13 deletions(-) Approvals: Nico Huber: Verified; Looks good to me, approved Angel Pons: Looks good to me, approved diff --git a/common/hw-gfx-dp_aux_ch.adb b/common/hw-gfx-dp_aux_ch.adb index 5b4fde4..20c2c3c 100644 --- a/common/hw-gfx-dp_aux_ch.adb +++ b/common/hw-gfx-dp_aux_ch.adb @@ -16,6 +16,7 @@ with HW.GFX.DP_Defs; use type HW.Word8; +use type HW.Word32; use type HW.GFX.DP_Defs.Aux_Message_Command; package body HW.GFX.DP_Aux_Ch is diff --git a/common/hw-gfx-edid.adb b/common/hw-gfx-edid.adb index f1fae58..d8dba1d 100644 --- a/common/hw-gfx-edid.adb +++ b/common/hw-gfx-edid.adb @@ -12,8 +12,6 @@ -- GNU General Public License for more details. -- -with HW; - with HW.Debug; with GNAT.Source_Info; diff --git a/common/hw-gfx-framebuffer_filler.ads b/common/hw-gfx-framebuffer_filler.ads index 7ad3b79..ff3d343 100644 --- a/common/hw-gfx-framebuffer_filler.ads +++ b/common/hw-gfx-framebuffer_filler.ads @@ -14,10 +14,6 @@ with System; -with HW; - -use type HW.Int32; - package HW.GFX.Framebuffer_Filler with Abstract_State => ((State with External), Base_Address), diff --git a/common/hw-gfx-gma-config_helpers.ads b/common/hw-gfx-gma-config_helpers.ads index b9f1d70..ffac9d4 100644 --- a/common/hw-gfx-gma-config_helpers.ads +++ b/common/hw-gfx-gma-config_helpers.ads @@ -12,7 +12,6 @@ -- GNU General Public License for more details. -- -with HW; with HW.GFX.GMA.Config; private package HW.GFX.GMA.Config_Helpers diff --git a/common/hw-gfx-gma-registers.ads b/common/hw-gfx-gma-registers.ads index 3318ab1..c8ada33 100644 --- a/common/hw-gfx-gma-registers.ads +++ b/common/hw-gfx-gma-registers.ads @@ -13,7 +13,6 @@ -- with System; -with HW.GFX.GMA; with HW.GFX.GMA.Config; private package HW.GFX.GMA.Registers diff --git a/common/hw-gfx-gma.ads b/common/hw-gfx-gma.ads index afd1512..1282e89 100644 --- a/common/hw-gfx-gma.ads +++ b/common/hw-gfx-gma.ads @@ -19,6 +19,8 @@ with HW.Port_IO; with HW.GFX.Framebuffer_Filler; +use type HW.Word32; + package HW.GFX.GMA with Abstract_State => diff --git a/common/hw-gfx.ads b/common/hw-gfx.ads index 2cfc017..f09f9dc 100644 --- a/common/hw-gfx.ads +++ b/common/hw-gfx.ads @@ -13,11 +13,6 @@ -- GNU General Public License for more details. -- -with HW; - -use type HW.Pos64; -use type HW.Word32; - package HW.GFX is -- such that the count of pixels in any framebuffer may fit -- To view, visit https://review.coreboot.org/c/libgfxinit/+/67833 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: Id7e88fe9a3ef7cb10cbc427a052e21f12578a3fd Gerrit-Change-Number: 67833 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: merged

1 0

[S] Change in libgfxinit[master]: Fix "unnecessary with of ancestor [-gnatwr]"
by Angel Pons (Code Review) 04 Oct '22

04 Oct '22

Attention is currently required from: Nico Huber, Elyes Haouas. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/67833 ) Change subject: Fix "unnecessary with of ancestor [-gnatwr]" ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > Most files compile with this, but I'm running into a bug with my host GCC 12: […] We also ran into this bug with Arch Linux's gcc-ada package (based on GCC 12). GCC 11 from Ubuntu works fine. -- To view, visit https://review.coreboot.org/c/libgfxinit/+/67833 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: Id7e88fe9a3ef7cb10cbc427a052e21f12578a3fd Gerrit-Change-Number: 67833 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Tue, 04 Oct 2022 14:03:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2022