coreboot-gerrit October 2022

coreboot-gerrit@coreboot.org

1 participants
5881 discussions

[S] Change in libhwbase[master]: Fix "unnecessary with of ancestor [-gnatwr]"
by Angel Pons (Code Review) 04 Oct '22

04 Oct '22

Angel Pons has submitted this change. ( https://review.coreboot.org/c/libhwbase/+/67832 ) Change subject: Fix "unnecessary with of ancestor [-gnatwr]" ...................................................................... Fix "unnecessary with of ancestor [-gnatwr]" Change-Id: I3a8a161a5fd6f8f261d101f1752b452d3706a2df Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/libhwbase/+/67832 Tested-by: Nico Huber <nico.h(a)gmx.de> Reviewed-by: Nico Huber <nico.h(a)gmx.de> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M common/hw-time.adb M debug/hw-debug.adb 2 files changed, 14 insertions(+), 2 deletions(-) Approvals: Nico Huber: Verified; Looks good to me, approved Angel Pons: Looks good to me, approved diff --git a/common/hw-time.adb b/common/hw-time.adb index b81d343..42c63f6 100644 --- a/common/hw-time.adb +++ b/common/hw-time.adb @@ -12,7 +12,6 @@ -- GNU General Public License for more details. -- -with HW; with HW.Time.Timer; use type HW.Word64; diff --git a/debug/hw-debug.adb b/debug/hw-debug.adb index 2f1fed9..e28eb17 100644 --- a/debug/hw-debug.adb +++ b/debug/hw-debug.adb @@ -12,7 +12,6 @@ -- GNU General Public License for more details. -- -with HW; with HW.Time; with HW.Debug_Sink; -- To view, visit https://review.coreboot.org/c/libhwbase/+/67832 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libhwbase Gerrit-Branch: master Gerrit-Change-Id: I3a8a161a5fd6f8f261d101f1752b452d3706a2df Gerrit-Change-Number: 67832 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: merged

1 0

[S] Change in libhwbase[master]: Fix "unnecessary with of ancestor [-gnatwr]"
by Angel Pons (Code Review) 04 Oct '22

04 Oct '22

Attention is currently required from: Thomas Heijligen, Elyes Haouas. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libhwbase/+/67832 ) Change subject: Fix "unnecessary with of ancestor [-gnatwr]" ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/libhwbase/+/67832 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libhwbase Gerrit-Branch: master Gerrit-Change-Id: I3a8a161a5fd6f8f261d101f1752b452d3706a2df Gerrit-Change-Number: 67832 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Tue, 04 Oct 2022 14:00:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libgfxinit[master]: Fix "unnecessary with of ancestor [-gnatwr]"
by Angel Pons (Code Review) 04 Oct '22

04 Oct '22

Attention is currently required from: Nico Huber, Elyes Haouas. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/67833 ) Change subject: Fix "unnecessary with of ancestor [-gnatwr]" ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/67833 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: Id7e88fe9a3ef7cb10cbc427a052e21f12578a3fd Gerrit-Change-Number: 67833 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Tue, 04 Oct 2022 14:00:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/lenovo/t440p: Enable PCI 00:01.1 bridge for dGPU
by Angel Pons (Code Review) 04 Oct '22

04 Oct '22

Attention is currently required from: Nico Huber, Alexander Couzens. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68099 ) Change subject: mb/lenovo/t440p: Enable PCI 00:01.1 bridge for dGPU ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68099 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieab7a7bf3b31b4ee9d9f12b5d827d866c87356e1 Gerrit-Change-Number: 68099 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 04 Oct 2022 13:53:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in libgfxinit[master]: common: Begin Tiger Lake integration
by Nico Huber (Code Review) 04 Oct '22

04 Oct '22

Attention is currently required from: Tim Wawrzynczak, Angel Pons, Arthur Heymans. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/65087 ) Change subject: common: Begin Tiger Lake integration ...................................................................... Patch Set 8: Verified+1 Code-Review+1 (10 comments) Commit Message: https://review.coreboot.org/c/libgfxinit/+/65087/comment/d513030a_c67f052b PS8, Line 10: . Nit, the period should be after the quotation. Patchset: PS8: Looks good overall and verification passes (with warnings because nothing is implemented of course). Will probably have to get back to this change once I've looked into everything. File common/hw-gfx-gma-config.ads.template: https://review.coreboot.org/c/libgfxinit/+/65087/comment/f9327735_21cef9c3 PS8, Line 38: => Please align up. https://review.coreboot.org/c/libgfxinit/+/65087/comment/74579d39_bc1921cb PS8, Line 186: hswsklbool I supposse this and the next are `hswskltglbool` as well then. https://review.coreboot.org/c/libgfxinit/+/65087/comment/c2dcbe5c_ab3c706b PS8, Line 327: tglhswvar I think this one should stay `hswvar`. Meaning, if the generation is Haswell, this can be variable at runtime. But for Tiger Lake it's always 6. https://review.coreboot.org/c/libgfxinit/+/65087/comment/f028d648_722375ec PS8, Line 504: function Is_Tiger_Lake (Device_Id : Word16) return Boolean is : (Is_Tiger_Lake_U (Device_Id) or Is_Tiger_Lake_H (Device_Id)); Do we need this function? https://review.coreboot.org/c/libgfxinit/+/65087/comment/3fb20b1d_c8b7c6cd PS8, Line 545: Is_Tiger_Lake_U (Device_Id))); No tabs, please. File common/hw-gfx-gma-config_helpers.adb: https://review.coreboot.org/c/libgfxinit/+/65087/comment/3084ddef_c504a7ba PS8, Line 53: ???? You couldn't test or you are unsure or...? File common/hw-gfx-gma.adb: https://review.coreboot.org/c/libgfxinit/+/65087/comment/b7e003d5_a85847ff PS8, Line 58: A little spurious indentation https://review.coreboot.org/c/libgfxinit/+/65087/comment/d2a68324_470189e7 PS8, Line 59: => Please align up -- To view, visit https://review.coreboot.org/c/libgfxinit/+/65087 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: Ic8d32598e5611453ce53f1deaeab981b9f2a952f Gerrit-Change-Number: 65087 Gerrit-PatchSet: 8 Gerrit-Owner: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 04 Oct 2022 13:52:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/kontron/bsl6: Set board type to mobile for memory config
by Angel Pons (Code Review) 04 Oct '22

04 Oct '22

Attention is currently required from: Felix Singer, Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67399 ) Change subject: mb/kontron/bsl6: Set board type to mobile for memory config ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67399 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia27f1e4dec0a0d06be3d8c08bfe82becd41a2149 Gerrit-Change-Number: 67399 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Tue, 04 Oct 2022 13:51:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libgfxinit[master]: gma: Correct Global annotation for Initialize()
by Angel Pons (Code Review) 04 Oct '22

04 Oct '22

Attention is currently required from: Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/68111 ) Change subject: gma: Correct Global annotation for Initialize() ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File common/hw-gfx-gma.adb: https://review.coreboot.org/c/libgfxinit/+/68111/comment/0cc3c34b_22d38aac PS1, Line 443: below Where is below? Seems to be after the procedure. -- To view, visit https://review.coreboot.org/c/libgfxinit/+/68111 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: I7086b024d96f0a17f19f46f60ceac6757eb91867 Gerrit-Change-Number: 68111 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Tue, 04 Oct 2022 13:47:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[master]: mb/protectli/vault_cml: Add Comet Lake 6 port board support
by build bot (Jenkins) (Code Review) 04 Oct '22

04 Oct '22

Attention is currently required from: Angel Pons, Piotr Król. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67940 ) Change subject: mb/protectli/vault_cml: Add Comet Lake 6 port board support ...................................................................... Patch Set 13: (1 comment) File src/mainboard/protectli/vault_cml/die.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159651): https://review.coreboot.org/c/coreboot/+/67940/comment/a07533d7_e578cd77 PS13, Line 12: static uint8_t beep_count = 0;; Statements terminations use 1 semicolon -- To view, visit https://review.coreboot.org/c/coreboot/+/67940 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If1b4f9c8245a082ff875ae9c6102a1c45e677d0b Gerrit-Change-Number: 67940 Gerrit-PatchSet: 13 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Comment-Date: Tue, 04 Oct 2022 13:47:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[master]: mb/protectli/vault_cml: Add Comet Lake 6 port board support
by Michał Żygowski (Code Review) 04 Oct '22

04 Oct '22

Attention is currently required from: Angel Pons, Piotr Król. Hello build bot (Jenkins), Angel Pons, Piotr Król, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/67940 to look at the new patch set (#13). Change subject: mb/protectli/vault_cml: Add Comet Lake 6 port board support ...................................................................... mb/protectli/vault_cml: Add Comet Lake 6 port board support Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: If1b4f9c8245a082ff875ae9c6102a1c45e677d0b --- M Documentation/mainboard/index.md A Documentation/mainboard/protectli/vp46xx.md A Documentation/mainboard/protectli/vp46xx_back.jpg A Documentation/mainboard/protectli/vp46xx_flash.jpg A Documentation/mainboard/protectli/vp46xx_front.jpg A src/mainboard/protectli/vault_cml/Kconfig A src/mainboard/protectli/vault_cml/Kconfig.name A src/mainboard/protectli/vault_cml/Makefile.inc A src/mainboard/protectli/vault_cml/acpi/ec.asl A src/mainboard/protectli/vault_cml/acpi/superio.asl A src/mainboard/protectli/vault_cml/board.fmd A src/mainboard/protectli/vault_cml/board_info.txt A src/mainboard/protectli/vault_cml/bootblock.c A src/mainboard/protectli/vault_cml/cmos.default A src/mainboard/protectli/vault_cml/cmos.layout A src/mainboard/protectli/vault_cml/data.vbt A src/mainboard/protectli/vault_cml/devicetree.cb A src/mainboard/protectli/vault_cml/die.c A src/mainboard/protectli/vault_cml/dsdt.asl A src/mainboard/protectli/vault_cml/gma-mainboard.ads A src/mainboard/protectli/vault_cml/gpio.c A src/mainboard/protectli/vault_cml/gpio.h A src/mainboard/protectli/vault_cml/hda_verb.c A src/mainboard/protectli/vault_cml/mainboard.c A src/mainboard/protectli/vault_cml/romstage.c A src/mainboard/protectli/vault_cml/vboot-rwa.fmd 26 files changed, 1,306 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/67940/13 -- To view, visit https://review.coreboot.org/c/coreboot/+/67940 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If1b4f9c8245a082ff875ae9c6102a1c45e677d0b Gerrit-Change-Number: 67940 Gerrit-PatchSet: 13 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in libgfxinit[master]: gma: Make HW.GFX.GMA.SPLL package private
by Angel Pons (Code Review) 04 Oct '22

04 Oct '22

Attention is currently required from: Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/68110 ) Change subject: gma: Make HW.GFX.GMA.SPLL package private ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/68110 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: I8a8258fecc5433510555f9a1165356a769c02be7 Gerrit-Change-Number: 68110 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Tue, 04 Oct 2022 13:46:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2022