Attention is currently required from: Jason Nien, Matt DeVillier, Martin Roth.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68123 )
Change subject: mb/google/guybrush: Fix SMMSTORE size, alignment
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/68123
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78cb873a5634c659067367260cc7063fbd60d77a
Gerrit-Change-Number: 68123
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 05 Oct 2022 07:18:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Reka Norman, Shou-Chieh Hsu.
Leo Chou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68098 )
Change subject: mb/google/nissa/pujjo: Change TPM I2C freqeuncy to 1 MHz
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68098/comment/16c39889_3526c70e
PS1, Line 12: TEST=On pujjo, all timing requirements in the spec are met.
> Could you please add the measured frequency here for reference?
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/68098
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If99b5022a9b67e9c63c440a1e398d56bb2c467e2
Gerrit-Change-Number: 68098
Gerrit-PatchSet: 3
Gerrit-Owner: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-CC: Jynn Chen <jynn.chen(a)lcfc.corp-partner.google.com>
Gerrit-CC: Leanne1 Chen <leanne1.chen(a)lcfc.corp-partner.google.com>
Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Comment-Date: Wed, 05 Oct 2022 05:42:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Reka Norman <rekanorman(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Reka Norman, Shou-Chieh Hsu.
Leo Chou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68098 )
Change subject: mb/google/nissa/pujjo: Change TPM I2C freqeuncy to 1 MHz
......................................................................
Patch Set 3:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/68098
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If99b5022a9b67e9c63c440a1e398d56bb2c467e2
Gerrit-Change-Number: 68098
Gerrit-PatchSet: 3
Gerrit-Owner: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-CC: Jynn Chen <jynn.chen(a)lcfc.corp-partner.google.com>
Gerrit-CC: Leanne1 Chen <leanne1.chen(a)lcfc.corp-partner.google.com>
Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Comment-Date: Wed, 05 Oct 2022 05:42:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67820 )
Change subject: util/xcompile: Add --no-warn-rwx-segments to arm64 LD params
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
It seems this is still not hooked up https://qa.coreboot.org/job/coreboot-toolchain/1259/
--
To view, visit https://review.coreboot.org/c/coreboot/+/67820
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5ca9f0cc6cdc45161b0edf892c4b4a76d50e57bf
Gerrit-Change-Number: 67820
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Wed, 05 Oct 2022 05:23:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, YH Lin, Subrata Banik, Paul Menzel, Tim Wawrzynczak, Nick Vaccaro.
John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67920 )
Change subject: mb/google/brya/var/mithrax: adjust I2C5 times for TP
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
Hi Google
Would you help to submit this CL?
--
To view, visit https://review.coreboot.org/c/coreboot/+/67920
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5977f0dbba8924cc8a1c72c36358d6ba6f2de940
Gerrit-Change-Number: 67920
Gerrit-PatchSet: 5
Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com>
Gerrit-CC: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com>
Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: YH Lin <yueherngl(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Wed, 05 Oct 2022 03:07:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Kangheui Won, Chen Wisley, Reka Norman, Tim Wawrzynczak, Shou-Chieh Hsu.
Hello build bot (Jenkins), Kangheui Won, Reka Norman, Tim Wawrzynczak, Wisley Chen, Shou-Chieh Hsu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/68082
to look at the new patch set (#6).
Change subject: mb/google/nissa/var/yaviks: Config I2C frequency
......................................................................
mb/google/nissa/var/yaviks: Config I2C frequency
Update parameters for all I2C devices.
After applied this patch, the measured the I2C frequency meets spec
BUG=b:249953708
TEST=FW_NAME=yaviks emerge-nissa coreboot
flash and measure the all I2C devices
1. I2C0 (TPM): 980.6 Khz
2. I2C1 (TouchScreen); 392.6 Khz
3. I2C3 (Audio): 394.9 Khz
4. I2C5 (Touchpad): 391.6 Khz
Signed-off-by: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Change-Id: I33c2891f17bc3c572bbfcbf30bbbdef9eb850ce7
---
M src/mainboard/google/brya/variants/yaviks/overridetree.cb
1 file changed, 46 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/68082/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/68082
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I33c2891f17bc3c572bbfcbf30bbbdef9eb850ce7
Gerrit-Change-Number: 68082
Gerrit-PatchSet: 6
Gerrit-Owner: Chen Wisley <wisley.chen%quantatw.com(a)gtempaccount.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Kangheui Won <khwon(a)chromium.org>
Gerrit-Attention: Chen Wisley <wisley.chen%quantatw.com(a)gtempaccount.com>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jamie Chen, Reka Norman, Tim Wawrzynczak, Shou-Chieh Hsu.
Hello build bot (Jenkins), Jamie Chen, Reka Norman, Tim Wawrzynczak, Shou-Chieh Hsu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/68095
to look at the new patch set (#4).
Change subject: mb/google/nissa/pujjo: Tuning eMMC DLL value for eMMC initialization error
......................................................................
mb/google/nissa/pujjo: Tuning eMMC DLL value for eMMC initialization error
Configure eMMC DLL tuning values for Pujjo board.
BUG=b:241854926
TEST=Use the value to boot on Pujjo successfully.
Signed-off-by: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com>
Change-Id: Ic36c817fa546741e394668297ca43db3a45ee105
---
M src/mainboard/google/brya/variants/pujjo/overridetree.cb
1 file changed, 60 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/68095/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/68095
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic36c817fa546741e394668297ca43db3a45ee105
Gerrit-Change-Number: 68095
Gerrit-PatchSet: 4
Gerrit-Owner: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Jamie Chen <jamie.chen(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-CC: Jynn Chen <jynn.chen(a)lcfc.corp-partner.google.com>
Gerrit-CC: Leanne1 Chen <leanne1.chen(a)lcfc.corp-partner.google.com>
Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Jamie Chen <jamie.chen(a)intel.corp-partner.google.com>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jamie Chen, Reka Norman, Tim Wawrzynczak, Shou-Chieh Hsu.
Leo Chou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68095 )
Change subject: mb/google/nissa/pujjo: Tuning eMMC DLL value for eMMC initialization error
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68095/comment/9137ec0c_753cf4e4
PS1, Line 12: "Use the value to boot on Pujjo successfully."
> nti: remove the quotes
Done
File src/mainboard/google/brya/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/68095/comment/68e29f03_2ba95bf2
PS1, Line 254: select SOC_INTEL_COMMON_MMC_OVERRIDE
> Don't need this because it's already selected for the baseboard.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/68095
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic36c817fa546741e394668297ca43db3a45ee105
Gerrit-Change-Number: 68095
Gerrit-PatchSet: 3
Gerrit-Owner: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Jamie Chen <jamie.chen(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-CC: Jynn Chen <jynn.chen(a)lcfc.corp-partner.google.com>
Gerrit-CC: Leanne1 Chen <leanne1.chen(a)lcfc.corp-partner.google.com>
Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Jamie Chen <jamie.chen(a)intel.corp-partner.google.com>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Comment-Date: Wed, 05 Oct 2022 01:17:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Reka Norman <rekanorman(a)chromium.org>
Gerrit-MessageType: comment