coreboot-gerrit October 2022

coreboot-gerrit@coreboot.org

1 participants
5881 discussions

[S] Change in coreboot[master]: treewide: use predicates to check for enabled pci devices
by Angel Pons (Code Review) 05 Oct '22

05 Oct '22

Attention is currently required from: Jeff Daly, Fabio Aiuto, Mariusz Szafrański, Suresh Bellampalli, Stefan Reinauer, Vanessa Eusebio. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68102 ) Change subject: treewide: use predicates to check for enabled pci devices ...................................................................... Patch Set 3: Code-Review+2 (1 comment) File src/southbridge/intel/lynxpoint/lpc.c: https://review.coreboot.org/c/coreboot/+/68102/comment/9b7db632_e6671f38 PS2, Line 123: if (!is_enabled_pci(irq_dev)) > Ack Fixed in CB:68101 -- To view, visit https://review.coreboot.org/c/coreboot/+/68102 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idb992904112db611119b2d33c8b1dd912b2c8539 Gerrit-Change-Number: 68102 Gerrit-PatchSet: 3 Gerrit-Owner: Fabio Aiuto <fabioaiuto83(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Attention: Fabio Aiuto <fabioaiuto83(a)gmail.com> Gerrit-Attention: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Attention: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Comment-Date: Wed, 05 Oct 2022 08:14:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Fabio Aiuto <fabioaiuto83(a)gmail.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: include/device/device_util.c: add predicates for pci devices
by Angel Pons (Code Review) 05 Oct '22

05 Oct '22

Attention is currently required from: Fabio Aiuto, Paul Menzel, Tim Wawrzynczak, Felix Held. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68101 ) Change subject: include/device/device_util.c: add predicates for pci devices ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68101 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3257c8404017372f6cdd9f6cf9453502447343a0 Gerrit-Change-Number: 68101 Gerrit-PatchSet: 2 Gerrit-Owner: Fabio Aiuto <fabioaiuto83(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Fabio Aiuto <fabioaiuto83(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 05 Oct 2022 08:14:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: treewide: use predicates to check for enabled pci devices
by Fabio Aiuto (Code Review) 05 Oct '22

05 Oct '22

Attention is currently required from: Jeff Daly, Mariusz Szafrański, Suresh Bellampalli, Stefan Reinauer, Vanessa Eusebio, Angel Pons. Fabio Aiuto has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68102 ) Change subject: treewide: use predicates to check for enabled pci devices ...................................................................... Patch Set 3: (2 comments) Patchset: PS3: thanks for review File src/southbridge/intel/lynxpoint/lpc.c: https://review.coreboot.org/c/coreboot/+/68102/comment/dbdd12c5_58ac785a PS2, Line 123: if (!is_enabled_pci(irq_dev)) > This is equivalent to: […] Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/68102 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idb992904112db611119b2d33c8b1dd912b2c8539 Gerrit-Change-Number: 68102 Gerrit-PatchSet: 3 Gerrit-Owner: Fabio Aiuto <fabioaiuto83(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Attention: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Attention: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 05 Oct 2022 08:07:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: treewide: use predicate to check if pci device is on n-th bus
by Fabio Aiuto (Code Review) 05 Oct '22

05 Oct '22

Attention is currently required from: Damien Zammit, Angel Pons. Fabio Aiuto has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68103 ) Change subject: treewide: use predicate to check if pci device is on n-th bus ...................................................................... Patch Set 3: (2 comments) Patchset: PS3: thanks for review File src/mainboard/emulation/qemu-i440fx/northbridge.c: https://review.coreboot.org/c/coreboot/+/68103/comment/d1e242d5_51bd14aa PS2, Line 222: if (!is_pci_dev_on_bus(dev, 0)) > This is equivalent to: […] Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/68103 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4a3e96381c29056de71953ea2c39cd540f3df191 Gerrit-Change-Number: 68103 Gerrit-PatchSet: 3 Gerrit-Owner: Fabio Aiuto <fabioaiuto83(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Damien Zammit Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 05 Oct 2022 08:06:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: include/device/device_util.c: add predicates for pci devices
by Fabio Aiuto (Code Review) 05 Oct '22

05 Oct '22

Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Angel Pons, Felix Held. Fabio Aiuto has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68101 ) Change subject: include/device/device_util.c: add predicates for pci devices ...................................................................... Patch Set 2: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/68101/comment/b6adf1c1_adadd4a4 PS1, Line 7: add helpers to check pci device enabled > Hmmm, this is a bit confusing, how about: […] Ack Patchset: PS2: thanks for review File src/device/device_util.c: https://review.coreboot.org/c/coreboot/+/68101/comment/60c6e548_2658ad4d PS1, Line 971: pci->bus->dev->path.type > Why does this access the bus info? Can any of these pointers be NULL? The parameter itself can be NU […] Ops, you are right, fixed -- To view, visit https://review.coreboot.org/c/coreboot/+/68101 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3257c8404017372f6cdd9f6cf9453502447343a0 Gerrit-Change-Number: 68101 Gerrit-PatchSet: 2 Gerrit-Owner: Fabio Aiuto <fabioaiuto83(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 05 Oct 2022 08:06:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: treewide: use predicate to check if pci device is on n-th bus
by Fabio Aiuto (Code Review) 05 Oct '22

05 Oct '22

Attention is currently required from: Fabio Aiuto, Damien Zammit. Hello build bot (Jenkins), Damien Zammit, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68103 to look at the new patch set (#3). Change subject: treewide: use predicate to check if pci device is on n-th bus ...................................................................... treewide: use predicate to check if pci device is on n-th bus use function to check if pci device is on a particular bus number. TEST: compiled and qemu run successfully Signed-off-by: Fabio Aiuto <fabioaiuto83(a)gmail.com> Change-Id: I4a3e96381c29056de71953ea2c39cd540f3df191 --- M src/mainboard/emulation/qemu-i440fx/northbridge.c M src/northbridge/intel/gm45/northbridge.c M src/northbridge/intel/haswell/northbridge.c M src/northbridge/intel/i945/northbridge.c M src/northbridge/intel/ironlake/northbridge.c M src/northbridge/intel/pineview/northbridge.c M src/northbridge/intel/x4x/northbridge.c 7 files changed, 22 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/68103/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/68103 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4a3e96381c29056de71953ea2c39cd540f3df191 Gerrit-Change-Number: 68103 Gerrit-PatchSet: 3 Gerrit-Owner: Fabio Aiuto <fabioaiuto83(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Fabio Aiuto <fabioaiuto83(a)gmail.com> Gerrit-Attention: Damien Zammit Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: treewide: use predicates to check for enabled pci devices
by Fabio Aiuto (Code Review) 05 Oct '22

05 Oct '22

Attention is currently required from: Jeff Daly, Fabio Aiuto, Mariusz Szafrański, Suresh Bellampalli, Stefan Reinauer, Vanessa Eusebio. Hello build bot (Jenkins), Jeff Daly, Mariusz Szafrański, Stefan Reinauer, Suresh Bellampalli, Vanessa Eusebio, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68102 to look at the new patch set (#3). Change subject: treewide: use predicates to check for enabled pci devices ...................................................................... treewide: use predicates to check for enabled pci devices use functions to check for pci devices instead of open-coded solution. TEST: compiled and qemu run successfully Signed-off-by: Fabio Aiuto <fabioaiuto83(a)gmail.com> Change-Id: Idb992904112db611119b2d33c8b1dd912b2c8539 --- M src/arch/x86/mpspec.c M src/soc/intel/broadwell/pch/lpc.c M src/soc/intel/common/block/lpc/lpc_lib.c M src/soc/intel/denverton_ns/lpc.c M src/southbridge/intel/bd82x6x/lpc.c M src/southbridge/intel/i82801gx/lpc.c M src/southbridge/intel/i82801ix/lpc.c M src/southbridge/intel/i82801jx/lpc.c M src/southbridge/intel/ibexpeak/lpc.c M src/southbridge/intel/lynxpoint/lpc.c 10 files changed, 26 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/68102/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/68102 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idb992904112db611119b2d33c8b1dd912b2c8539 Gerrit-Change-Number: 68102 Gerrit-PatchSet: 3 Gerrit-Owner: Fabio Aiuto <fabioaiuto83(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Attention: Fabio Aiuto <fabioaiuto83(a)gmail.com> Gerrit-Attention: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Attention: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: include/device/device_util.c: add predicates for pci devices
by Fabio Aiuto (Code Review) 05 Oct '22

05 Oct '22

Attention is currently required from: Fabio Aiuto, Paul Menzel, Tim Wawrzynczak, Felix Held. Hello build bot (Jenkins), Stefan Reinauer, Paul Menzel, Tim Wawrzynczak, Angel Pons, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68101 to look at the new patch set (#2). Change subject: include/device/device_util.c: add predicates for pci devices ...................................................................... include/device/device_util.c: add predicates for pci devices add functions to check whether a device is enabled pci device or a pci device on a specific bus number. TEST: compile and qemu run successfully Signed-off-by: Fabio Aiuto <fabioaiuto83(a)gmail.com> Change-Id: I3257c8404017372f6cdd9f6cf9453502447343a0 --- M src/device/device_util.c M src/include/device/device.h 2 files changed, 33 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/68101/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68101 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3257c8404017372f6cdd9f6cf9453502447343a0 Gerrit-Change-Number: 68101 Gerrit-PatchSet: 2 Gerrit-Owner: Fabio Aiuto <fabioaiuto83(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Fabio Aiuto <fabioaiuto83(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: [test for gcc-12 build] update libgfxinit and libhwbase
by Elyes Haouas (Code Review) 05 Oct '22

05 Oct '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68128 ) Change subject: [test for gcc-12 build] update libgfxinit and libhwbase ...................................................................... [test for gcc-12 build] update libgfxinit and libhwbase Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: I962b9acd310c596c0b8c312583aefe5dd1f76e49 --- M 3rdparty/libgfxinit M 3rdparty/libhwbase 2 files changed, 12 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/68128/1 diff --git a/3rdparty/libgfxinit b/3rdparty/libgfxinit index 1b04c51..066e52e 160000 --- a/3rdparty/libgfxinit +++ b/3rdparty/libgfxinit @@ -1 +1 @@ -Subproject commit 1b04c517b377468b3b470d38607fb539187391dd +Subproject commit 066e52eeaa329d782ccee96265a6a351fc395bf1 diff --git a/3rdparty/libhwbase b/3rdparty/libhwbase index fc2102f..8be5a82 160000 --- a/3rdparty/libhwbase +++ b/3rdparty/libhwbase @@ -1 +1 @@ -Subproject commit fc2102f560f25e0f2e5be91ec36646dcb69e6e1b +Subproject commit 8be5a82b85ceb3ee8a1c4fbf36c75a4bfbda8900 -- To view, visit https://review.coreboot.org/c/coreboot/+/68128 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I962b9acd310c596c0b8c312583aefe5dd1f76e49 Gerrit-Change-Number: 68128 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: mb/google/skyrim: Fix SMMSTORE size, alignment
by Arthur Heymans (Code Review) 05 Oct '22

05 Oct '22

Attention is currently required from: Jason Nien, Matt DeVillier, Martin Roth. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68124 ) Change subject: mb/google/skyrim: Fix SMMSTORE size, alignment ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68124 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3501b6036df9ee1049a92e26a7b72e53b4604f60 Gerrit-Change-Number: 68124 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Wed, 05 Oct 2022 07:18:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2022