coreboot-gerrit October 2022

coreboot-gerrit@coreboot.org

1 participants
5881 discussions

[M] Change in coreboot[master]: mb/google/skyrim: Override SPI flash bus speed
by Raul Rangel (Code Review) 05 Oct '22

05 Oct '22

Attention is currently required from: Jason Nien, Jon Murphy, Martin Roth, Tim Van Patten, Karthik Ramasubramanian. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68116 ) Change subject: mb/google/skyrim: Override SPI flash bus speed ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68116 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5e8db22151fbc2db1f9e81b3644338348160736d Gerrit-Change-Number: 68116 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 05 Oct 2022 15:25:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[master]: payloads/cbui: Add new payload CBUI
by Iman Bingi (Code Review) 05 Oct '22

05 Oct '22

Attention is currently required from: Martin L Roth, Julius Werner, Patrick Rudolph. Iman Bingi has uploaded a new patch set (#46) to the change originally created by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/23586 ) Change subject: payloads/cbui: Add new payload CBUI ...................................................................... payloads/cbui: Add new payload CBUI Depends on libpayload and nuklear. Features: * Graphical menus with scrolling. * Text rendering engine (atm only bitmap font) * Support for keyboard and mouse * Support for USB and PS/2 devices * Ported coreinfo and nvramcui * Allows to modify NVRAM and RTC * Works as ELF payload * Works as Seabios secondary payload * Basic support for multiple languages * Hacky support for BIOS calls (depends on NASM) * Runs in qemu and on real hardware * Use linker script to allocate low memory Shortcomings: * Doesn't work in VGA text mode * Untested on UEFI * int32 relocates itself to low memory Licenses: * GPLv2 (CBUI + libpayload) * BSD (libpayload) * MIT (nuklear) TODO: * Test on as much platforms as possible * Link int32 into low memory This is Patrick Rudolph's original patch, updated by Ben Adu-Boahen to: * Add Read/Write module * This module allows read/write to any hardware component that is readable/writeable Note: This is work in progress Change-Id: Ib9a1a07c1065880aa675380625021750d5cab7d1 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> Signed-off-by: Ben Adu-Boahen <imanbingy(a)gmail.com> --- M payloads/Kconfig M payloads/Makefile.inc A payloads/cbui/.gitignore A payloads/cbui/Kconfig A payloads/cbui/Makefile A payloads/cbui/NuklearUI/NuklearCombo.c A payloads/cbui/NuklearUI/NuklearCombo.h A payloads/cbui/NuklearUI/NuklearCommon.h A payloads/cbui/NuklearUI/NuklearDataGrid.c A payloads/cbui/NuklearUI/NuklearDataGrid.h A payloads/cbui/NuklearUI/NuklearDatePicker.c A payloads/cbui/NuklearUI/NuklearDatePicker.h A payloads/cbui/NuklearUI/NuklearFieldHex.c A payloads/cbui/NuklearUI/NuklearFieldHex.h A payloads/cbui/NuklearUI/NuklearFileChooser.c A payloads/cbui/NuklearUI/NuklearFileChooser.h A payloads/cbui/NuklearUI/NuklearGroup.c A payloads/cbui/NuklearUI/NuklearGroup.h A payloads/cbui/NuklearUI/NuklearHex.c A payloads/cbui/NuklearUI/NuklearHex.h A payloads/cbui/NuklearUI/NuklearIntegerRange.c A payloads/cbui/NuklearUI/NuklearIntegerRange.h A payloads/cbui/NuklearUI/NuklearLabel.c A payloads/cbui/NuklearUI/NuklearLabel.h A payloads/cbui/NuklearUI/NuklearObject.c A payloads/cbui/NuklearUI/NuklearObject.h A payloads/cbui/NuklearUI/NuklearPciHeader.c A payloads/cbui/NuklearUI/NuklearPciHeader.h A payloads/cbui/NuklearUI/NuklearRW.c A payloads/cbui/NuklearUI/NuklearRW.h A payloads/cbui/NuklearUI/NuklearRoot.c A payloads/cbui/NuklearUI/NuklearStyle.c A payloads/cbui/NuklearUI/NuklearStyle.h A payloads/cbui/NuklearUI/NuklearTabView.c A payloads/cbui/NuklearUI/NuklearTextView.c A payloads/cbui/NuklearUI/NuklearTextView.h A payloads/cbui/NuklearUI/NuklearTextfield.c A payloads/cbui/NuklearUI/NuklearTextfield.h A payloads/cbui/NuklearUI/NuklearTimePicker.c A payloads/cbui/NuklearUI/NuklearTimePicker.h A payloads/cbui/NuklearUI/NuklearUI.h A payloads/cbui/NuklearUI/NuklearVector.c A payloads/cbui/NuklearUI/NuklearVector.h A payloads/cbui/arch/x86/cpuid.c A payloads/cbui/arch/x86/cpuid.h A payloads/cbui/arch/x86/int32.h A payloads/cbui/arch/x86/int32.ld A payloads/cbui/arch/x86/int32.nasm A payloads/cbui/arch/x86/memcpy.c A payloads/cbui/arch/x86/memcpy.h A payloads/cbui/arch/x86/vga.c A payloads/cbui/arch/x86/vga.h A payloads/cbui/cbui.c A payloads/cbui/cbui.h A payloads/cbui/fsys/usbstorage.c A payloads/cbui/fsys/usbstorage.h A payloads/cbui/gfx/coreboot.c A payloads/cbui/gfx/coreboot.h A payloads/cbui/gfx/gfx.c A payloads/cbui/gfx/gfx.h A payloads/cbui/gfx/splash.c A payloads/cbui/gfx/splash.h A payloads/cbui/gfx/vbe.c A payloads/cbui/gfx/vbe.h A payloads/cbui/lang/de.c A payloads/cbui/lang/en.c A payloads/cbui/lang/lang.c A payloads/cbui/lang/lang.h A payloads/cbui/logo/cbui.png A payloads/cbui/lp.config A payloads/cbui/modules/bootlog_module.c A payloads/cbui/modules/cbfs_module.c A payloads/cbui/modules/cmos_module.c A payloads/cbui/modules/coreboot_module.c A payloads/cbui/modules/cpuinfo_module.c A payloads/cbui/modules/license_module.c A payloads/cbui/modules/modules.c A payloads/cbui/modules/modules.h A payloads/cbui/modules/nvram_module.c A payloads/cbui/modules/pci_module.c A payloads/cbui/modules/reboot_module.c A payloads/cbui/modules/rtc_module.c A payloads/cbui/modules/rw_module.c A payloads/cbui/modules/timestamps_module.c A payloads/cbui/modules/usb_module.c A payloads/libpayload/configs/defconfig-cbui 86 files changed, 12,126 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/23586/46 -- To view, visit https://review.coreboot.org/c/coreboot/+/23586 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib9a1a07c1065880aa675380625021750d5cab7d1 Gerrit-Change-Number: 23586 Gerrit-PatchSet: 46 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Iman Bingi <imanbingy(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: lib/gnat: Remove unrecognized pragma "Compiler_Unit_Warning"
by Angel Pons (Code Review) 05 Oct '22

05 Oct '22

Attention is currently required from: Elyes Haouas. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67828 ) Change subject: lib/gnat: Remove unrecognized pragma "Compiler_Unit_Warning" ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/67828 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia55304da1e3b2db1532300c4f1a2dd958f1975c4 Gerrit-Change-Number: 67828 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Wed, 05 Oct 2022 14:33:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libgfxinit[master]: Fix "unnecessary with of ancestor [-gnatwr]"
by Angel Pons (Code Review) 05 Oct '22

05 Oct '22

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/67833 ) Change subject: Fix "unnecessary with of ancestor [-gnatwr]" ...................................................................... Patch Set 4: (1 comment) Patchset: PS3: > got a same error with gcc-12: […] Do you have any ideas? It seems to be a problem with the compiler. -- To view, visit https://review.coreboot.org/c/libgfxinit/+/67833 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: Id7e88fe9a3ef7cb10cbc427a052e21f12578a3fd Gerrit-Change-Number: 67833 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Wed, 05 Oct 2022 13:53:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: comment

1 0

[S] Change in libgfxinit[master]: Fix "unnecessary with of ancestor [-gnatwr]"
by Elyes Haouas (Code Review) 05 Oct '22

05 Oct '22

Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/67833 ) Change subject: Fix "unnecessary with of ancestor [-gnatwr]" ...................................................................... Patch Set 4: (1 comment) Patchset: PS3: > We also ran into this bug with Arch Linux's gcc-ada package (based on GCC 12). […] got a same error with gcc-12: "coreboot/util/crossgcc/xgcc/bin/i386-elf-gcc --RTS=build/libgnat-x86_32/ -gnatp -Wuninitialized -Wall -Werror -pipe -g -nostdinc -Wstrict-aliasing -Wshadow -fno-common -fomit-frame-pointer -ffunction-sections -fdata-sections -fno-pie -gnatwa.eeD.HHTU.U.W.Y -gnatyN -Os -m32 -fuse-ld=bfd -fno-stack-protector -Wl,--build-id=none -I3rdparty/libgfxinit/common/ -I3rdparty/libgfxinit/common/dyncpu/ -I3rdparty/libgfxinit/common/ironlake/ -I3rdparty/libhwbase/ada/dynamic_mmio/ -I3rdparty/libhwbase/common/ -I3rdparty/libhwbase/common/direct/ -I3rdparty/libhwbase/debug/ -Ibuild/libgfxinit/common/ -Ibuild/libhwbase/common/ -Ibuild/ramstage/ -Isrc/console/ -Isrc/drivers/intel/gma/ -Isrc/drivers/intel/gma/text_fb/ -Isrc/lib/ -Isrc/mainboard/gigabyte/ga-b75m-d3h/variants/ga-b75m-d3h/ -D__RAMSTAGE__ -c -o build/ramstage/libgfxinit/common/hw-gfx-gma-pch-transcoder.o 3rdparty/libgfxinit/common/hw-gfx-gma-pch-transcoder.adb raised STORAGE_ERROR : stack overflow or erroneous memory access make: *** [Makefile:387 : build/ramstage/libgfxinit/common/hw-gfx-gma-pch-transcoder.o] Erreur 1 " see also: https://qa.coreboot.org/job/coreboot-toolchain/1265/testReport/junit/(root)… -- To view, visit https://review.coreboot.org/c/libgfxinit/+/67833 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: Id7e88fe9a3ef7cb10cbc427a052e21f12578a3fd Gerrit-Change-Number: 67833 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Wed, 05 Oct 2022 13:42:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: util/superiotool/nuvoton.c: Add NCT6687D-W register definitions
by Michał Żygowski (Code Review) 05 Oct '22

05 Oct '22

Attention is currently required from: Felix Held. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63868 ) Change subject: util/superiotool/nuvoton.c: Add NCT6687D-W register definitions ...................................................................... Patch Set 6: (1 comment) File util/superiotool/superiotool.c: https://review.coreboot.org/c/coreboot/+/63868/comment/d29074fa_e68462d9 PS5, Line 22: /* For Nuvoton EC space */ > Probably Nuvoton-specific. Moved set_page and dump_page_index_data to nuvoton.c -- To view, visit https://review.coreboot.org/c/coreboot/+/63868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I38db1de0f3d3b6de14bcb758afc9804c072c1895 Gerrit-Change-Number: 63868 Gerrit-PatchSet: 6 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 05 Oct 2022 12:44:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: util/superiotool/nuvoton.c: Add NCT6687D-W register definitions
by Michał Żygowski (Code Review) 05 Oct '22

05 Oct '22

Attention is currently required from: Felix Held. Hello build bot (Jenkins), Krystian Hebel, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63868 to look at the new patch set (#6). Change subject: util/superiotool/nuvoton.c: Add NCT6687D-W register definitions ...................................................................... util/superiotool/nuvoton.c: Add NCT6687D-W register definitions Based on public NCT6686D hardware datasheet revision 0.5 which should be similar to NCT6687D. TEST=Dump NCT6687D, GPIO and EC registers on MSI PRO Z690-A WIFI DDR4 Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: I38db1de0f3d3b6de14bcb758afc9804c072c1895 --- M util/superiotool/nuvoton.c 1 file changed, 196 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/63868/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/63868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I38db1de0f3d3b6de14bcb758afc9804c072c1895 Gerrit-Change-Number: 63868 Gerrit-PatchSet: 6 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: include/device/device_util.c: add predicates for pci devices
by Stefan Reinauer (Code Review) 05 Oct '22

05 Oct '22

Attention is currently required from: Fabio Aiuto, Paul Menzel, Tim Wawrzynczak, Felix Held. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68101 ) Change subject: include/device/device_util.c: add predicates for pci devices ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: thanks for catching this Angel -- To view, visit https://review.coreboot.org/c/coreboot/+/68101 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3257c8404017372f6cdd9f6cf9453502447343a0 Gerrit-Change-Number: 68101 Gerrit-PatchSet: 2 Gerrit-Owner: Fabio Aiuto <fabioaiuto83(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Fabio Aiuto <fabioaiuto83(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 05 Oct 2022 12:14:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/chromeos/gen_test_hwid.sh: Replace usage of hexdump
by Michał Żygowski (Code Review) 05 Oct '22

05 Oct '22

Michał Żygowski has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68133 ) Change subject: util/chromeos/gen_test_hwid.sh: Replace usage of hexdump ...................................................................... util/chromeos/gen_test_hwid.sh: Replace usage of hexdump Hexdump command is not available in coreboot-sdk. Replace it with equivalent implementation using commands that are present in the container. TEST=Passed "VP46XX" as prefix variable and it produced the same crc32 result before and after the change. Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: Icad93933335b8c5ebd8fee74cc9aaed36bb56482 --- M util/chromeos/gen_test_hwid.sh 1 file changed, 18 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/68133/1 diff --git a/util/chromeos/gen_test_hwid.sh b/util/chromeos/gen_test_hwid.sh index 9dfbce5..5599806 100755 --- a/util/chromeos/gen_test_hwid.sh +++ b/util/chromeos/gen_test_hwid.sh @@ -13,7 +13,7 @@ local prefix="$(echo "${board}" | tr a-z A-Z) TEST" # gzip has second-to-last 4 bytes in CRC32. local crc32="$(printf "${prefix}" | gzip -1 | tail -c 8 | head -c 4 | \ - hexdump -e '1/4 "%04u" ""' | tail -c 4)" + od -An -vtu4 | xargs | tr -d '\n' | tail -c 4)" echo "${prefix}" "${crc32}" } -- To view, visit https://review.coreboot.org/c/coreboot/+/68133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icad93933335b8c5ebd8fee74cc9aaed36bb56482 Gerrit-Change-Number: 68133 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-MessageType: newchange

1 0

[XL] Change in coreboot[master]: mb/protectli/vault_cml: Add Comet Lake 6 port board support
by Michał Żygowski (Code Review) 05 Oct '22

05 Oct '22

Attention is currently required from: Angel Pons, Piotr Król. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67940 ) Change subject: mb/protectli/vault_cml: Add Comet Lake 6 port board support ...................................................................... Patch Set 16: (7 comments) File src/mainboard/protectli/vault_cml/devicetree.cb: https://review.coreboot.org/c/coreboot/+/67940/comment/40603c72_c3646191 PS7, Line 287: device pci 1f.1 on end # P2SB : device pci 1f.2 on end # Power Management Controller > > Marked them both as hidden. Is that fine for you? […] It still works. I don't think having these devices set to 'ON' had anything to do with those issues, as these devices were simply not visible at all. In fact, I recall not including the VBT actually helped, so I could have a buggy VBT earlier. File src/mainboard/protectli/vault_cml/devicetree.cb: https://review.coreboot.org/c/coreboot/+/67940/comment/4a1403bd_a260f258 PS13, Line 55: register "SataMode" = "0" > This should be dropped too. SATA mode should be a Kconfig option instead, anyway. Done https://review.coreboot.org/c/coreboot/+/67940/comment/1845cf7a_167a5640 PS13, Line 67: register "PcieRpEnable[13]" = "1" : register "PcieRpEnable[14]" = "1" : register "PcieRpEnable[15]" = "1" > As root port 13 (array index 12) is x4, these three root ports do not have any lanes associated to t […] Done https://review.coreboot.org/c/coreboot/+/67940/comment/d9818a92_e787a0fa PS13, Line 80: register "PcieRpAdvancedErrorReporting[13]" = "1" : register "PcieRpAdvancedErrorReporting[14]" = "1" : register "PcieRpAdvancedErrorReporting[15]" = "1" > Same as above Done https://review.coreboot.org/c/coreboot/+/67940/comment/c2cdb44d_ed9981b2 PS13, Line 93: register "PcieRpLtrEnable[13]" = "1" : register "PcieRpLtrEnable[14]" = "1" : register "PcieRpLtrEnable[15]" = "1" > Same as above Done https://review.coreboot.org/c/coreboot/+/67940/comment/27f7703c_7b799d07 PS13, Line 202: device pci 1d.5 on end # PCI Express Port 14 : device pci 1d.6 on end # PCI Express Port 15 : device pci 1d.7 on end # PCI Express Port 16 > Same as the FSP settings. These root ports have no lanes associated to them (`device pci 1d. […] Done File src/mainboard/protectli/vault_cml/die.c: https://review.coreboot.org/c/coreboot/+/67940/comment/65ace1e2_7d0e6a08 PS13, Line 12: static uint8_t beep_count = 0;; > > Statements terminations use 1 semicolon […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/67940 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If1b4f9c8245a082ff875ae9c6102a1c45e677d0b Gerrit-Change-Number: 67940 Gerrit-PatchSet: 16 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Comment-Date: Wed, 05 Oct 2022 11:36:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2022