Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Matt DeVillier, Paul Menzel, Fred Reitberger, Felix Held.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64495 )
Change subject: cpu/amd/family14: Use parallel mp init
......................................................................
Patch Set 28:
(1 comment)
Patchset:
PS28:
Looks like a toolchain issue. Rebased to fix it (assuming master has the fix)
--
To view, visit https://review.coreboot.org/c/coreboot/+/64495
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I73a866462b0cb6fcaeb0a47eef7a1b16747240fb
Gerrit-Change-Number: 64495
Gerrit-PatchSet: 28
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 06 Oct 2022 11:42:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Matt DeVillier, Paul Menzel, Arthur Heymans, Fred Reitberger, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64495 )
Change subject: cpu/amd/family14: Use parallel mp init
......................................................................
Patch Set 28:
(1 comment)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159828):
https://review.coreboot.org/c/coreboot/+/64495/comment/3c8a251a_28556d38
PS28, Line 12:
Possible unwrapped commit description (prefer a maximum 72 chars per line)
--
To view, visit https://review.coreboot.org/c/coreboot/+/64495
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I73a866462b0cb6fcaeb0a47eef7a1b16747240fb
Gerrit-Change-Number: 64495
Gerrit-PatchSet: 28
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 06 Oct 2022 11:42:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/68016 )
Change subject: mainboard/starlabs/starbook: Update the EC binaries for StarLabs
......................................................................
Patch Set 4:
(2 comments)
File mainboard/starlabs/starbook/adl/README.md:
https://review.coreboot.org/c/blobs/+/68016/comment/5936b5fe_1735fa1b
PS2, Line 6: ITE128
> What does `ITE128` mean?
It's just a way to differentiate the ones that span 128k in different blocks.
File mainboard/starlabs/starbook/adl/README.md:
https://review.coreboot.org/c/blobs/+/68016/comment/aa264999_755d77ef
PS3, Line 6: MkV
> Is it the same EC firmware as TGL?
Done
--
To view, visit https://review.coreboot.org/c/blobs/+/68016
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: blobs
Gerrit-Branch: master
Gerrit-Change-Id: I2130852554388baf61b44091bfa827cb2b2f09e3
Gerrit-Change-Number: 68016
Gerrit-PatchSet: 4
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Thu, 06 Oct 2022 11:41:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Raul Rangel, Michał Żygowski, Marshall Dawson, Matt DeVillier, Angel Pons, Fred Reitberger, Felix Held.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64891 )
Change subject: cpu/amd/pi00730F01: Use common code for mp_init
......................................................................
Patch Set 24:
(1 comment)
Patchset:
PS24:
> Maybe 3mdeb can test this?
Very little code is actually changed. I don't think testing is needed.
--
To view, visit https://review.coreboot.org/c/coreboot/+/64891
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia9f0eb3df8fd2dfe395f616da981cc3a0cd3b29d
Gerrit-Change-Number: 64891
Gerrit-PatchSet: 24
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 06 Oct 2022 11:40:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Henry Sun, Simon Yang, Ivan Chen, Teddy Shih.
Simon Yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68129 )
Change subject: mb/google/dedede/var/beadrix: Update SoC gpio pin of USB camera
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/68129
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id00cb85cdad900c03842ad69707966aa62410efd
Gerrit-Change-Number: 68129
Gerrit-PatchSet: 2
Gerrit-Owner: Teddy Shih <teddyshih(a)ami.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com>
Gerrit-Reviewer: Simon Yang <simon1.yang(a)intel.com>
Gerrit-Reviewer: Simon Yang <simon1.yang(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Super Ni <super.ni(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Teddy Shih <teddyshih(a)ami.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Eddy Lu <eddylu(a)ami.corp-partner.google.com>
Gerrit-CC: Jack Cheng <jack.cheng(a)ecs.corp-partner.google.com>
Gerrit-CC: Raymond Chung <raymondchung(a)ami.corp-partner.google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Simon Yang <simon1.yang(a)intel.corp-partner.google.com>
Gerrit-Attention: Ivan Chen <yulunchen(a)google.com>
Gerrit-Attention: Teddy Shih <teddyshih(a)ami.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 06 Oct 2022 11:39:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Sean Rhodes.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/68016 )
Change subject: mainboard/starlabs/starbook: Update the EC binaries for StarLabs
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File mainboard/starlabs/starbook/adl/README.md:
https://review.coreboot.org/c/blobs/+/68016/comment/34e61aec_3fad0cc1
PS3, Line 6: MkV
Is it the same EC firmware as TGL?
--
To view, visit https://review.coreboot.org/c/blobs/+/68016
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: blobs
Gerrit-Branch: master
Gerrit-Change-Id: I2130852554388baf61b44091bfa827cb2b2f09e3
Gerrit-Change-Number: 68016
Gerrit-PatchSet: 3
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Comment-Date: Thu, 06 Oct 2022 11:34:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/68016 )
Change subject: mainboard/starlabs/starbook: Update the EC binaries for StarLabs
......................................................................
Patch Set 3:
(3 comments)
File mainboard/starlabs/starbook/cml/README.md:
https://review.coreboot.org/c/blobs/+/68016/comment/92a078f8_a73af106
PS2, Line 14: doesnt
> `doesn't` ?
Done
File mainboard/starlabs/starbook/tgl/README.md:
https://review.coreboot.org/c/blobs/+/68016/comment/63a1da80_b32c9972
PS2, Line 6: https://github.com/StarLabsLtd/firmware/raw/master/StarBook/MkVI/ITE128/1.0…
> Seems invalid
Done
https://review.coreboot.org/c/blobs/+/68016/comment/74063e9f_6da7027d
PS2, Line 7: VI
> Is this correct? The READMEs for TGL and ADL seem to be mixed up.
Done
--
To view, visit https://review.coreboot.org/c/blobs/+/68016
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: blobs
Gerrit-Branch: master
Gerrit-Change-Id: I2130852554388baf61b44091bfa827cb2b2f09e3
Gerrit-Change-Number: 68016
Gerrit-PatchSet: 3
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Thu, 06 Oct 2022 11:31:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Sean Rhodes.
Hello Matt DeVillier, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/blobs/+/68016
to look at the new patch set (#3).
Change subject: mainboard/starlabs/starbook: Update the EC binaries for StarLabs
......................................................................
mainboard/starlabs/starbook: Update the EC binaries for StarLabs
Add changelogs for the EC updates and update the versions to:
[ADL] 1.00:
Initial release firmware
[TGL] 1.03:
Initial release firmware for the StarBook Mk VI
[CML] 1.07:
Add support to set the maximum charge level of the battery
Signed-off-by: Sean Rhodes <sean(a)starlabs.systems>
Change-Id: I2130852554388baf61b44091bfa827cb2b2f09e3
---
A mainboard/starlabs/starbook/adl/README.md
A mainboard/starlabs/starbook/adl/ec.bin
A mainboard/starlabs/starbook/cml/README.md
A mainboard/starlabs/starbook/tgl/README.md
4 files changed, 74 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/blobs refs/changes/16/68016/3
--
To view, visit https://review.coreboot.org/c/blobs/+/68016
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: blobs
Gerrit-Branch: master
Gerrit-Change-Id: I2130852554388baf61b44091bfa827cb2b2f09e3
Gerrit-Change-Number: 68016
Gerrit-PatchSet: 3
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-MessageType: newpatchset