coreboot-gerrit October 2022

coreboot-gerrit@coreboot.org

1 participants
5881 discussions

[M] Change in blobs[master]: mainboard/starlabs/starbook: Update the EC binaries for StarLabs
by Sean Rhodes (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Angel Pons. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/68016 ) Change subject: mainboard/starlabs/starbook: Update the EC binaries for StarLabs ...................................................................... Patch Set 3: (3 comments) File mainboard/starlabs/starbook/cml/README.md: https://review.coreboot.org/c/blobs/+/68016/comment/92a078f8_a73af106 PS2, Line 14: doesnt > `doesn't` ? Done File mainboard/starlabs/starbook/tgl/README.md: https://review.coreboot.org/c/blobs/+/68016/comment/63a1da80_b32c9972 PS2, Line 6: https://github.com/StarLabsLtd/firmware/raw/master/StarBook/MkVI/ITE128/1.0… > Seems invalid Done https://review.coreboot.org/c/blobs/+/68016/comment/74063e9f_6da7027d PS2, Line 7: VI > Is this correct? The READMEs for TGL and ADL seem to be mixed up. Done -- To view, visit https://review.coreboot.org/c/blobs/+/68016 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: master Gerrit-Change-Id: I2130852554388baf61b44091bfa827cb2b2f09e3 Gerrit-Change-Number: 68016 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 06 Oct 2022 11:31:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya: Enable DRIVERS_GENESYSLOGIC_GL9750 for lisbon
by Kevin Chiu (Code Review) 06 Oct '22

06 Oct '22

Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68168 ) Change subject: mb/google/brya: Enable DRIVERS_GENESYSLOGIC_GL9750 for lisbon ...................................................................... mb/google/brya: Enable DRIVERS_GENESYSLOGIC_GL9750 for lisbon Enable DRIVERS_GENESYSLOGIC_GL9750 for lisbon BUG=b:246657849 TEST=FW_NAME=lisbon emerge-brask coreboot Signed-off-by: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Change-Id: I74cd634700b2de16ae471e0a738b67a14fd82a50 --- M src/mainboard/google/brya/Kconfig.name 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/68168/1 diff --git a/src/mainboard/google/brya/Kconfig.name b/src/mainboard/google/brya/Kconfig.name index b19bdc5..ec1b602 100644 --- a/src/mainboard/google/brya/Kconfig.name +++ b/src/mainboard/google/brya/Kconfig.name @@ -272,3 +272,4 @@ config BOARD_GOOGLE_LISBON bool "-> Lisbon" select BOARD_GOOGLE_BASEBOARD_BRASK + select DRIVERS_GENESYSLOGIC_GL9750 -- To view, visit https://review.coreboot.org/c/coreboot/+/68168 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I74cd634700b2de16ae471e0a738b67a14fd82a50 Gerrit-Change-Number: 68168 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-MessageType: newchange

1 0

[M] Change in blobs[master]: mainboard/starlabs/starbook: Update the EC binaries for StarLabs
by Sean Rhodes (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Sean Rhodes. Hello Matt DeVillier, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/blobs/+/68016 to look at the new patch set (#3). Change subject: mainboard/starlabs/starbook: Update the EC binaries for StarLabs ...................................................................... mainboard/starlabs/starbook: Update the EC binaries for StarLabs Add changelogs for the EC updates and update the versions to: [ADL] 1.00: Initial release firmware [TGL] 1.03: Initial release firmware for the StarBook Mk VI [CML] 1.07: Add support to set the maximum charge level of the battery Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I2130852554388baf61b44091bfa827cb2b2f09e3 --- A mainboard/starlabs/starbook/adl/README.md A mainboard/starlabs/starbook/adl/ec.bin A mainboard/starlabs/starbook/cml/README.md A mainboard/starlabs/starbook/tgl/README.md 4 files changed, 74 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/blobs refs/changes/16/68016/3 -- To view, visit https://review.coreboot.org/c/blobs/+/68016 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: master Gerrit-Change-Id: I2130852554388baf61b44091bfa827cb2b2f09e3 Gerrit-Change-Number: 68016 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/brya: enable PCIe RP12 for lisbon eMMC support
by Kevin Chiu (Code Review) 06 Oct '22

06 Oct '22

Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68167 ) Change subject: mb/google/brya: enable PCIe RP12 for lisbon eMMC support ...................................................................... mb/google/brya: enable PCIe RP12 for lisbon eMMC support BUG=b:246657849 TEST=FW_NAME=lisbon emerge-brask coreboot Signed-off-by: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Change-Id: Ief8ca9cf845156ac761556d0eb49edb65894c001 --- M src/mainboard/google/brya/variants/lisbon/overridetree.cb 1 file changed, 21 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/68167/1 diff --git a/src/mainboard/google/brya/variants/lisbon/overridetree.cb b/src/mainboard/google/brya/variants/lisbon/overridetree.cb index a2a4043..67b0d9b 100644 --- a/src/mainboard/google/brya/variants/lisbon/overridetree.cb +++ b/src/mainboard/google/brya/variants/lisbon/overridetree.cb @@ -200,6 +200,14 @@ device generic 0 on end end end #PCIE8 SD card + device ref pcie_rp12 on + # Enable PCIE eMMC bridge 12 using clk 4 + register "pch_pcie_rp[PCH_RP(12)]" = "{ + .clk_src = 4, + .clk_req = 4, + .flags = PCIE_RP_HOTPLUG | PCIE_RP_AER, + }" + end #PCIE12 EMMC device ref gspi1 off end device ref pch_espi on chip ec/google/chromeec -- To view, visit https://review.coreboot.org/c/coreboot/+/68167 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ief8ca9cf845156ac761556d0eb49edb65894c001 Gerrit-Change-Number: 68167 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-MessageType: newchange

1 0

[M] Change in blobs[master]: mainboard/starlabs/starbook: Update the EC binaries for StarLabs
by Angel Pons (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Sean Rhodes. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/68016 ) Change subject: mainboard/starlabs/starbook: Update the EC binaries for StarLabs ...................................................................... Patch Set 2: (4 comments) File mainboard/starlabs/starbook/adl/README.md: https://review.coreboot.org/c/blobs/+/68016/comment/5701d4b4_8518726d PS2, Line 6: ITE128 What does `ITE128` mean? File mainboard/starlabs/starbook/cml/README.md: https://review.coreboot.org/c/blobs/+/68016/comment/fb4c71af_0d0f9eb9 PS2, Line 14: doesnt `doesn't` ? File mainboard/starlabs/starbook/tgl/README.md: https://review.coreboot.org/c/blobs/+/68016/comment/1ef6ce05_5bef5e6d PS2, Line 6: https://github.com/StarLabsLtd/firmware/raw/master/StarBook/MkVI/ITE128/1.0… Seems invalid https://review.coreboot.org/c/blobs/+/68016/comment/ae60711a_6f32813d PS2, Line 7: VI Is this correct? The READMEs for TGL and ADL seem to be mixed up. -- To view, visit https://review.coreboot.org/c/blobs/+/68016 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: master Gerrit-Change-Id: I2130852554388baf61b44091bfa827cb2b2f09e3 Gerrit-Change-Number: 68016 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Thu, 06 Oct 2022 11:12:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in blobs[master]: mainboard/starlabs/starbook: Update the EC binaries for StarLabs
by Sean Rhodes (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Sean Rhodes. Hello Matt DeVillier, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/blobs/+/68016 to look at the new patch set (#2). Change subject: mainboard/starlabs/starbook: Update the EC binaries for StarLabs ...................................................................... mainboard/starlabs/starbook: Update the EC binaries for StarLabs Add changelogs for the EC updates and update the versions to: [ADL] 1.00: Initial release firmware [TGL] 1.03: Initial release firmware for the StarBook Mk VI [CML] 1.07: Add support to set the maximum charge level of the battery Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I2130852554388baf61b44091bfa827cb2b2f09e3 --- A mainboard/starlabs/starbook/adl/README.md A mainboard/starlabs/starbook/adl/ec.bin A mainboard/starlabs/starbook/cml/README.md A mainboard/starlabs/starbook/tgl/README.md 4 files changed, 74 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/blobs refs/changes/16/68016/2 -- To view, visit https://review.coreboot.org/c/blobs/+/68016 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: master Gerrit-Change-Id: I2130852554388baf61b44091bfa827cb2b2f09e3 Gerrit-Change-Number: 68016 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/siemens/mc_ehl2: Use preset driver strength for SD-Card
by Mario Scheithauer (Code Review) 06 Oct '22

06 Oct '22

Mario Scheithauer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68166 ) Change subject: mb/siemens/mc_ehl2: Use preset driver strength for SD-Card ...................................................................... mb/siemens/mc_ehl2: Use preset driver strength for SD-Card The intention of predefining driver strength is to avoid that the OS SD-Card driver changes this setting. Change-Id: I02fdac94462da1cd77f8dc972faf16f28d94c946 Signed-off-by: Mario Scheithauer <mario.scheithauer(a)siemens.com> --- M src/mainboard/siemens/mc_ehl/variants/mc_ehl2/mainboard.c 1 file changed, 21 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/68166/1 diff --git a/src/mainboard/siemens/mc_ehl/variants/mc_ehl2/mainboard.c b/src/mainboard/siemens/mc_ehl/variants/mc_ehl2/mainboard.c index a798398..3395160 100644 --- a/src/mainboard/siemens/mc_ehl/variants/mc_ehl2/mainboard.c +++ b/src/mainboard/siemens/mc_ehl/variants/mc_ehl2/mainboard.c @@ -9,6 +9,8 @@ #include <soc/pci_devs.h> #include <soc/pcr_ids.h> +#define HOSTCTRL2 0x3E +#define HOSTCTRL2_PRESET (1 << 15) #define SD_CAP_BYP 0x810 #define SD_CAP_BYP_EN 0x5A #define SD_CAP_BYP_REG1 0x814 @@ -34,6 +36,7 @@ dev = pcidev_path_on_root(PCH_DEVFN_SDCARD); if (dev) { uint32_t reg; + uint16_t reg16; struct resource *res = probe_resource(dev, PCI_BASE_ADDRESS_0); if (!res) return; @@ -43,6 +46,11 @@ reg &= ~(SD_CAP_BYP_SDR104 | SD_CAP_BYP_SDR50); reg |= SD_CAP_BYP_DDR50; write32(res2mmio(res, SD_CAP_BYP_REG1, 0), reg); + + /* Use preset driver strength from preset value registers. */ + reg16 = read16(res2mmio(res, HOSTCTRL2, 0)); + reg16 |= HOSTCTRL2_PRESET; + write16(res2mmio(res, HOSTCTRL2, 0), reg16); } } -- To view, visit https://review.coreboot.org/c/coreboot/+/68166 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I02fdac94462da1cd77f8dc972faf16f28d94c946 Gerrit-Change-Number: 68166 Gerrit-PatchSet: 1 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-MessageType: newchange

1 0

[S] Change in blobs[master]: mainboard/starlabs/starbook: Add EC binary for ADL
by Patrick Georgi (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Sean Rhodes. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/68016 ) Change subject: mainboard/starlabs/starbook: Add EC binary for ADL ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Could you add the data as described on https://review.coreboot.org/plugins/gitiles/blobs/+/refs/heads/master/READM… -- To view, visit https://review.coreboot.org/c/blobs/+/68016 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: master Gerrit-Change-Id: I2130852554388baf61b44091bfa827cb2b2f09e3 Gerrit-Change-Number: 68016 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Thu, 06 Oct 2022 10:32:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in blobs[master]: mainboard/starlabs/starbook: Add EC binary for ADL
by Angel Pons (Code Review) 06 Oct '22

06 Oct '22

1 0

[L] Change in coreboot[master]: ec/starlabs/merlin: Add EC related files for Alder Lake boards
by Sean Rhodes (Code Review) 06 Oct '22

06 Oct '22

Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67398 ) Change subject: ec/starlabs/merlin: Add EC related files for Alder Lake boards ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/67398 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8cea386ba91d076084002738fe7041834deea311 Gerrit-Change-Number: 67398 Gerrit-PatchSet: 5 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 06 Oct 2022 10:26:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2022