coreboot-gerrit October 2022

coreboot-gerrit@coreboot.org

1 participants
5881 discussions

[L] Change in coreboot[master]: [WIP] mb/prodrive/atlas: Populate smbios table with VPD from ECs EMI
by build bot (Jenkins) (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Christian Walter, Lean Sheng Tan, David.Milosevic(a)9elements.com. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68137 ) Change subject: [WIP] mb/prodrive/atlas: Populate smbios table with VPD from ECs EMI ...................................................................... Patch Set 2: (44 comments) File src/mainboard/prodrive/atlas/emi.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/1301fcca_1a08f0e3 PS2, Line 75: const EMI_ACCESS access, code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/f819c713_4a54239a PS2, Line 75: const EMI_ACCESS access, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/dd23df36_7bb8ac06 PS2, Line 76: const u16 addr, code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/52120e97_7231e651 PS2, Line 76: const u16 addr, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/554ce961_a5bc0885 PS2, Line 77: u8 *buff); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/47b265db_c65c00d9 PS2, Line 77: u8 *buff); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/1a9e8d1e_371c9c99 PS2, Line 89: const EMI_ACCESS access, code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/8aaa9801_7433cf0c PS2, Line 89: const EMI_ACCESS access, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/8c1317f0_339db71e PS2, Line 90: const u16 addr, code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/d06bc0e8_541d4a87 PS2, Line 90: const u16 addr, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/99de8802_5f82d2dc PS2, Line 91: u8 *bytes); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/c107cc6d_45fac682 PS2, Line 91: u8 *bytes); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/eb07dc64_3666efb5 PS2, Line 102: const u16 addr, code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/592a3e93_23dd2fca PS2, Line 102: const u16 addr, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/153ad8b5_fe831341 PS2, Line 103: const u16 n, code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/fd2ce52f_51326931 PS2, Line 103: const u16 n, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/5cacd0d4_8c932e29 PS2, Line 104: u8 *buff); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/d55f6fc7_77265139 PS2, Line 104: u8 *buff); please, no spaces at the start of a line File src/mainboard/prodrive/atlas/emi.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/0489033a_e55ef781 PS2, Line 42: const EMI_ACCESS access, code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/d788f4ea_b3b591f6 PS2, Line 42: const EMI_ACCESS access, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/f625b213_3c003ebb PS2, Line 43: const u16 addr, code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/f62fba75_7f04704e PS2, Line 43: const u16 addr, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/7b09b88a_a6d21993 PS2, Line 44: u8 *buff) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/fea303c3_f7207b79 PS2, Line 44: u8 *buff) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/14c0702c_382e7144 PS2, Line 51: switch (access) { switch and case should be at the same indent Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/5f78492e_5cd1d21c PS2, Line 80: const EMI_ACCESS access, code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/9c3093b6_4da31e07 PS2, Line 80: const EMI_ACCESS access, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/29e2fdd0_a377c55c PS2, Line 81: const u16 addr, code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/55f73071_e62d2b86 PS2, Line 81: const u16 addr, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/c8165fff_768505b4 PS2, Line 82: u8 *bytes) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/ec5e31dc_f09a8f36 PS2, Line 82: u8 *bytes) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/7a316a4c_b91a436d PS2, Line 89: switch(access) { switch and case should be at the same indent Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/c6acd78d_3f54f85f PS2, Line 89: switch(access) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/d19f5fb0_5bbbeeb6 PS2, Line 118: const u16 addr, code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/53a4fc3b_7b9f7937 PS2, Line 118: const u16 addr, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/06f156c2_2c3c2b16 PS2, Line 119: const u16 n, code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/9c71008a_5b632110 PS2, Line 119: const u16 n, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/1aefb117_3f40daf7 PS2, Line 120: u8 *buff) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/d9e1075f_fd34b0b0 PS2, Line 120: u8 *buff) please, no spaces at the start of a line File src/mainboard/prodrive/atlas/mainboard.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/c7c01c36_bf999157 PS2, Line 14: static const char* get_smbios_part_number(void); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/04e3cedf_fcb66dff PS2, Line 41: static const char* get_smbios_part_number(void) "foo* bar" should be "foo *bar" File src/mainboard/prodrive/atlas/smbios.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/5cfff868_1a1a98ab PS2, Line 8: const char* smbios_mainboard_serial_number(void) "foo* bar" should be "foo *bar" File src/mainboard/prodrive/atlas/vpd.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/493f724b_b8227b67 PS2, Line 34: switch(vpd) { switch and case should be at the same indent Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/2ebb6233_fdb967e8 PS2, Line 34: switch(vpd) { space required before the open parenthesis '(' -- To view, visit https://review.coreboot.org/c/coreboot/+/68137 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I47bb4883c43ff344a9bda92c3106dd025533b391 Gerrit-Change-Number: 68137 Gerrit-PatchSet: 2 Gerrit-Owner: David.Milosevic(a)9elements.com Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: David.Milosevic(a)9elements.com Gerrit-Comment-Date: Thu, 06 Oct 2022 12:37:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: [WIP] mb/prodrive/atlas: Populate smbios table with VPD from ECs EMI
by Name of user not set (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Christian Walter, Lean Sheng Tan, David.Milosevic(a)9elements.com. Hello build bot (Jenkins), Christian Walter, Angel Pons, Lean Sheng Tan, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68137 to look at the new patch set (#2). Change subject: [WIP] mb/prodrive/atlas: Populate smbios table with VPD from ECs EMI ...................................................................... [WIP] mb/prodrive/atlas: Populate smbios table with VPD from ECs EMI The embedded controller stores serial-number and part-number within an EEPROM which is unreachable to the Host CPU. Therefore, on the EC side, we set up a shared memory region with the help of EMI and copy the VPDs to it. On the coreboot side, we can read those back and populate the SMBios table type 1 with the serial-number and type 11 with the part-number. emi.*: small interface to access the EMI regions vpd.*: uses the emi interface in order to read the VPDs smbios.c: populates smbios type 1 with the serial-number by using vpd.h mainboard.c: uses vpd.h to add a string to smbios type 11 ld_config.*: offers functionality to configure logical devices devicetree.cb: enables address range 0xc00-0xcff for the EMI runtime registers Makefile.inc: adds emi.c, vpd.c, smbios.c, ld_config.c to the ramstage compilation TODO: ld_config.* is redundant. We can replace this with pnp_device.h or pnp_ops.h Signed-off-by: Milo-D <David.Milosevic(a)9elements.com> Change-Id: I47bb4883c43ff344a9bda92c3106dd025533b391 --- M src/mainboard/prodrive/atlas/Makefile.inc M src/mainboard/prodrive/atlas/devicetree.cb A src/mainboard/prodrive/atlas/emi.c A src/mainboard/prodrive/atlas/emi.h A src/mainboard/prodrive/atlas/ld_config.c A src/mainboard/prodrive/atlas/ld_config.h M src/mainboard/prodrive/atlas/mainboard.c A src/mainboard/prodrive/atlas/smbios.c A src/mainboard/prodrive/atlas/vpd.c A src/mainboard/prodrive/atlas/vpd.h 10 files changed, 528 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/68137/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68137 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I47bb4883c43ff344a9bda92c3106dd025533b391 Gerrit-Change-Number: 68137 Gerrit-PatchSet: 2 Gerrit-Owner: David.Milosevic(a)9elements.com Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: David.Milosevic(a)9elements.com Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: mb/starlabs/starbook/tgl: Use chipset.cb aliases
by Angel Pons (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Sean Rhodes. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67027 ) Change subject: mb/starlabs/starbook/tgl: Use chipset.cb aliases ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67027 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie9655406c7afe7a22f131d35633a697c5bbde4e3 Gerrit-Change-Number: 67027 Gerrit-PatchSet: 5 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Ben McMillen <ben(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Thu, 06 Oct 2022 12:36:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/starlabs/starbook/kbl: Use chipset.cb aliases
by Angel Pons (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Sean Rhodes. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67421 ) Change subject: mb/starlabs/starbook/kbl: Use chipset.cb aliases ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67421 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2da15db3d7fba4396c74800e531476c108cafe17 Gerrit-Change-Number: 67421 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Thu, 06 Oct 2022 12:36:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/starlabs/starbook/kbl: Use chipset.cb aliases
by Sean Rhodes (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Angel Pons. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67421 ) Change subject: mb/starlabs/starbook/kbl: Use chipset.cb aliases ...................................................................... Patch Set 2: (1 comment) File src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb: https://review.coreboot.org/c/coreboot/+/67421/comment/1f437455_379ab221 PS1, Line 150: device ref fast_spi on end > What about SMBus? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/67421 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2da15db3d7fba4396c74800e531476c108cafe17 Gerrit-Change-Number: 67421 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 06 Oct 2022 12:28:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/starlabs/starbook/tgl: Use chipset.cb aliases
by Sean Rhodes (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Angel Pons. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67027 ) Change subject: mb/starlabs/starbook/tgl: Use chipset.cb aliases ...................................................................... Patch Set 5: (2 comments) File src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb: https://review.coreboot.org/c/coreboot/+/67027/comment/366b0ee4_0b79e63c PS1, Line 88: device ref north_xhci on > nit: one tab too many Done File src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb: https://review.coreboot.org/c/coreboot/+/67027/comment/828dd911_2cd8671e PS3, Line 88: device ref south_xhci on > nit: one tab too many Done -- To view, visit https://review.coreboot.org/c/coreboot/+/67027 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie9655406c7afe7a22f131d35633a697c5bbde4e3 Gerrit-Change-Number: 67027 Gerrit-PatchSet: 5 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Ben McMillen <ben(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 06 Oct 2022 12:25:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/starlabs/starbook/tgl: Remove PCIEXP_HOTPLUG_PREFETCH_MEM_BELOW_4G
by Angel Pons (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Sean Rhodes. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68084 ) Change subject: mb/starlabs/starbook/tgl: Remove PCIEXP_HOTPLUG_PREFETCH_MEM_BELOW_4G ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68084 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I82841c2114ceb5e7a46ce228fce63d24822098d2 Gerrit-Change-Number: 68084 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Thu, 06 Oct 2022 12:08:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/starlabs/starbook/tgl: Configure PMC mux
by Angel Pons (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Sean Rhodes. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68083 ) Change subject: mb/starlabs/starbook/tgl: Configure PMC mux ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68083 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I297d5446e43357d97357f345668cf40dcd28502d Gerrit-Change-Number: 68083 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Thu, 06 Oct 2022 12:08:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/starlabs/starbook/kbl: Use chipset.cb aliases
by Angel Pons (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Sean Rhodes. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67421 ) Change subject: mb/starlabs/starbook/kbl: Use chipset.cb aliases ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb: https://review.coreboot.org/c/coreboot/+/67421/comment/c4eb139c_9ba5fa70 PS1, Line 150: device ref fast_spi on end What about SMBus? -- To view, visit https://review.coreboot.org/c/coreboot/+/67421 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2da15db3d7fba4396c74800e531476c108cafe17 Gerrit-Change-Number: 67421 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Thu, 06 Oct 2022 12:08:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/starlabs/starbook/cml: Enable SRAM
by Angel Pons (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Sean Rhodes. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67420 ) Change subject: mb/starlabs/starbook/cml: Enable SRAM ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67420 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1d7ee4f950b31f2be6fb7bd107b5fe54785ed81a Gerrit-Change-Number: 67420 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Thu, 06 Oct 2022 11:58:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2022