Attention is currently required from: Sean Rhodes.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67027 )
Change subject: mb/starlabs/starbook/tgl: Use chipset.cb aliases
......................................................................
Patch Set 6:
(2 comments)
File src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/67027/comment/5b7a74c3_61216fa1
PS5, Line 88: device ref north_xhci on
> Shouldn't this be the PCH one?
Done
https://review.coreboot.org/c/coreboot/+/67027/comment/0a40c5e6_3cd015cc
PS5, Line 110: device ref north_xdci on end
> Why turn it on?
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/67027
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie9655406c7afe7a22f131d35633a697c5bbde4e3
Gerrit-Change-Number: 67027
Gerrit-PatchSet: 6
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Ben McMillen <ben(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Comment-Date: Thu, 06 Oct 2022 12:52:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Gerrit-MessageType: comment
Attention is currently required from: Lean Sheng Tan, David.Milosevic(a)9elements.com.
Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68137 )
Change subject: [WIP] mb/prodrive/atlas: Populate smbios table with VPD from ECs EMI
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Please use your real name in Gerrit.
--
To view, visit https://review.coreboot.org/c/coreboot/+/68137
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47bb4883c43ff344a9bda92c3106dd025533b391
Gerrit-Change-Number: 68137
Gerrit-PatchSet: 2
Gerrit-Owner: David.Milosevic(a)9elements.com
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: David.Milosevic(a)9elements.com
Gerrit-Comment-Date: Thu, 06 Oct 2022 12:46:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Iman Bingi, Martin L Roth, Julius Werner, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23586 )
Change subject: payloads/cbui: Add new payload CBUI
......................................................................
Patch Set 49:
(32 comments)
File payloads/cbui/NuklearUI/NuklearDatePicker.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841):
https://review.coreboot.org/c/coreboot/+/23586/comment/aed581c1_588857fd
PS49, Line 36: case 6: /* fallthrough */
Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841):
https://review.coreboot.org/c/coreboot/+/23586/comment/5d6bb8f5_cc327ae9
PS49, Line 37: case 9: /* fallthrough */
Prefer 'fallthrough;' over fallthrough comment
File payloads/cbui/NuklearUI/NuklearRW.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841):
https://review.coreboot.org/c/coreboot/+/23586/comment/ce32e8d4_db064a1f
PS49, Line 289: static const char *titles[] = { "Hex-View", "Header", "Index/Data" };
static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841):
https://review.coreboot.org/c/coreboot/+/23586/comment/fd21455d_9c074b68
PS49, Line 323: static const char *entries[] = { "NVRAM" };
static const char * array should probably be static const char * const
File payloads/cbui/arch/x86/int32.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841):
https://review.coreboot.org/c/coreboot/+/23586/comment/c72c9676_42506769
PS49, Line 20: typedef struct __attribute__ ((packed)) {
Prefer __packed over __attribute__((packed))
File payloads/cbui/arch/x86/int32.nasm:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841):
https://review.coreboot.org/c/coreboot/+/23586/comment/5a2db9ba_29b30262
PS49, Line 38: struc regs16_t
'struc' may be misspelled - perhaps 'struct'?
File payloads/cbui/gfx/vbe.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841):
https://review.coreboot.org/c/coreboot/+/23586/comment/230d3835_0c0492f0
PS49, Line 24: static u8 low_mem[0x1000] __attribute__ ((section(".lowmem")));
Prefer __section(".lowmem") over __attribute__((section(".lowmem")))
File payloads/cbui/lang/de.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841):
https://review.coreboot.org/c/coreboot/+/23586/comment/ea3eeacb_f5cd2f05
PS49, Line 39: "Kein Framebuffer gefunden. CBUI funktioniert nicht" \
Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841):
https://review.coreboot.org/c/coreboot/+/23586/comment/7c8c503f_c267a23e
PS49, Line 44: "Der coreboot framebuffer hat keine physikalische " \
Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841):
https://review.coreboot.org/c/coreboot/+/23586/comment/76eefc9a_66fab5aa
PS49, Line 47: "Kein Platz auf dem Heap.\nBitte vergroBere den" \
Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841):
https://review.coreboot.org/c/coreboot/+/23586/comment/bb345721_d871bf62
PS49, Line 50: "Konnte die nuklear Bibliothek nicht intitialisieren.\nBitte" \
Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841):
https://review.coreboot.org/c/coreboot/+/23586/comment/5aecdb0e_2cb87f59
PS49, Line 52: "stelle sicher, das der Framebuffer entweder das RGBX8 oder " \
Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841):
https://review.coreboot.org/c/coreboot/+/23586/comment/aad2f205_f5769b8f
PS49, Line 65: "Fehler: Keine CMOS Eintrage gefunden. Bitte schalte die " \
Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841):
https://review.coreboot.org/c/coreboot/+/23586/comment/1a1830db_043efce6
PS49, Line 86: "Fehler: Keine Zeitstempel gefunden. Bitte schalte die " \
Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841):
https://review.coreboot.org/c/coreboot/+/23586/comment/c7b6d173_9cce5369
PS49, Line 89: "Fehler: Bootlog nicht gefunden. Bitte schalte die Kconfig " \
Avoid unnecessary line continuations
File payloads/cbui/lang/en.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841):
https://review.coreboot.org/c/coreboot/+/23586/comment/d8375284_a2bb73f9
PS49, Line 38: "No framebuffer found. CBUI doesn't work in text mode.\n" \
Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841):
https://review.coreboot.org/c/coreboot/+/23586/comment/761b2fd0_9e1712d1
PS49, Line 46: "Failed to init nuklear library.\nMake sure you have enough " \
Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841):
https://review.coreboot.org/c/coreboot/+/23586/comment/51d52db6_85d73515
PS49, Line 60: "ERROR: No CMOS options found. Please make sure to enable " \
Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841):
https://review.coreboot.org/c/coreboot/+/23586/comment/c7bc0fd5_db865d24
PS49, Line 81: "ERROR: No timestamps found. Please make sure to enable " \
Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841):
https://review.coreboot.org/c/coreboot/+/23586/comment/979da98e_5153f5d6
PS49, Line 84: "ERROR: Bootlog not found. Please make sure to enable " \
Avoid unnecessary line continuations
File payloads/cbui/modules/bootlog_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841):
https://review.coreboot.org/c/coreboot/+/23586/comment/bb0f63c6_b37b7e73
PS49, Line 28: } __attribute__ ((__packed__));
Prefer __packed over __attribute__((__packed__))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841):
https://review.coreboot.org/c/coreboot/+/23586/comment/fa0a52df_74dd3f43
PS49, Line 82: }
void function return statements are not generally useful
File payloads/cbui/modules/cbfs_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841):
https://review.coreboot.org/c/coreboot/+/23586/comment/d28bb932_b48d9ebc
PS49, Line 50: } __attribute__ ((packed));
Prefer __packed over __attribute__((packed))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841):
https://review.coreboot.org/c/coreboot/+/23586/comment/e51566ee_b8379ffe
PS49, Line 59: } __attribute__ ((packed));
Prefer __packed over __attribute__((packed))
File payloads/cbui/modules/cpuinfo_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841):
https://review.coreboot.org/c/coreboot/+/23586/comment/eeb720f5_29880817
PS49, Line 35: static const char *intel_cap_edx_flags[] = {
static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841):
https://review.coreboot.org/c/coreboot/+/23586/comment/084cc850_7daf6688
PS49, Line 43: static const char *amd_cap_edx_flags[] = {
static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841):
https://review.coreboot.org/c/coreboot/+/23586/comment/9bccb53d_0f4cb30b
PS49, Line 51: static const char *intel_cap_ecx_flags[] = {
static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841):
https://review.coreboot.org/c/coreboot/+/23586/comment/7c0a97be_4f1a6822
PS49, Line 59: static const char *amd_cap_ecx_flags[] = {
static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841):
https://review.coreboot.org/c/coreboot/+/23586/comment/74da22ee_b8570161
PS49, Line 67: static const char *intel_cap_extended_edx_flags[] = {
static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841):
https://review.coreboot.org/c/coreboot/+/23586/comment/dd72cdfe_8747d9de
PS49, Line 75: static const char *intel_cap_extended_ecx_flags[] = {
static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841):
https://review.coreboot.org/c/coreboot/+/23586/comment/8a69ec0c_90e76faa
PS49, Line 83: static const char *amd_cap_extended_edx_flags[] = {
static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841):
https://review.coreboot.org/c/coreboot/+/23586/comment/9b50c73d_ef97aab9
PS49, Line 92: static const char *amd_cap_extended_ecx_flags[] = {
static const char * array should probably be static const char * const
--
To view, visit https://review.coreboot.org/c/coreboot/+/23586
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib9a1a07c1065880aa675380625021750d5cab7d1
Gerrit-Change-Number: 23586
Gerrit-PatchSet: 49
Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Iman Bingi <imanbingy(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Iman Bingi <imanbingy(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Thu, 06 Oct 2022 12:43:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Iman Bingi, Martin L Roth, Julius Werner, Patrick Rudolph.
Iman Bingi has uploaded a new patch set (#49) to the change originally created by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/23586 )
Change subject: payloads/cbui: Add new payload CBUI
......................................................................
payloads/cbui: Add new payload CBUI
Depends on libpayload and nuklear.
Features:
* Graphical menus with scrolling.
* Text rendering engine (atm only bitmap font)
* Support for keyboard and mouse
* Support for USB and PS/2 devices
* Ported coreinfo and nvramcui
* Allows to modify NVRAM and RTC
* Works as ELF payload
* Works as Seabios secondary payload
* Basic support for multiple languages
* Hacky support for BIOS calls (depends on NASM)
* Runs in qemu and on real hardware
* Use linker script to allocate low memory
Shortcomings:
* Doesn't work in VGA text mode
* Untested on UEFI
* int32 relocates itself to low memory
Licenses:
* GPLv2 (CBUI + libpayload)
* BSD (libpayload)
* MIT (nuklear)
TODO:
* Test on as much platforms as possible
* Link int32 into low memory
This is Patrick Rudolph's original patch, updated by
Ben Adu-Boahen to:
* Add Read/Write module
* This module allows read/write to any hardware
component that is readable/writeable
Note:
This is work in progress
Change-Id: Ib9a1a07c1065880aa675380625021750d5cab7d1
Signed-off-by: Patrick Rudolph <siro(a)das-labor.org>
Signed-off-by: Ben Adu-Boahen <imanbingy(a)gmail.com>
---
M payloads/Kconfig
M payloads/Makefile.inc
A payloads/cbui/.gitignore
A payloads/cbui/Kconfig
A payloads/cbui/Makefile
A payloads/cbui/NuklearUI/NuklearCombo.c
A payloads/cbui/NuklearUI/NuklearCombo.h
A payloads/cbui/NuklearUI/NuklearCommon.h
A payloads/cbui/NuklearUI/NuklearDataGrid.c
A payloads/cbui/NuklearUI/NuklearDataGrid.h
A payloads/cbui/NuklearUI/NuklearDatePicker.c
A payloads/cbui/NuklearUI/NuklearDatePicker.h
A payloads/cbui/NuklearUI/NuklearFieldFile.c
A payloads/cbui/NuklearUI/NuklearFieldFile.h
A payloads/cbui/NuklearUI/NuklearFieldHex.c
A payloads/cbui/NuklearUI/NuklearFieldHex.h
A payloads/cbui/NuklearUI/NuklearFileChooser.c
A payloads/cbui/NuklearUI/NuklearFileChooser.h
A payloads/cbui/NuklearUI/NuklearGroup.c
A payloads/cbui/NuklearUI/NuklearGroup.h
A payloads/cbui/NuklearUI/NuklearHex.c
A payloads/cbui/NuklearUI/NuklearHex.h
A payloads/cbui/NuklearUI/NuklearIntegerRange.c
A payloads/cbui/NuklearUI/NuklearIntegerRange.h
A payloads/cbui/NuklearUI/NuklearLabel.c
A payloads/cbui/NuklearUI/NuklearLabel.h
A payloads/cbui/NuklearUI/NuklearObject.c
A payloads/cbui/NuklearUI/NuklearObject.h
A payloads/cbui/NuklearUI/NuklearPciHeader.c
A payloads/cbui/NuklearUI/NuklearPciHeader.h
A payloads/cbui/NuklearUI/NuklearRW.c
A payloads/cbui/NuklearUI/NuklearRW.h
A payloads/cbui/NuklearUI/NuklearRoot.c
A payloads/cbui/NuklearUI/NuklearStyle.c
A payloads/cbui/NuklearUI/NuklearStyle.h
A payloads/cbui/NuklearUI/NuklearTabView.c
A payloads/cbui/NuklearUI/NuklearTextView.c
A payloads/cbui/NuklearUI/NuklearTextView.h
A payloads/cbui/NuklearUI/NuklearTextfield.c
A payloads/cbui/NuklearUI/NuklearTextfield.h
A payloads/cbui/NuklearUI/NuklearTimePicker.c
A payloads/cbui/NuklearUI/NuklearTimePicker.h
A payloads/cbui/NuklearUI/NuklearUI.h
A payloads/cbui/NuklearUI/NuklearVector.c
A payloads/cbui/NuklearUI/NuklearVector.h
A payloads/cbui/arch/x86/cpuid.c
A payloads/cbui/arch/x86/cpuid.h
A payloads/cbui/arch/x86/int32.h
A payloads/cbui/arch/x86/int32.ld
A payloads/cbui/arch/x86/int32.nasm
A payloads/cbui/arch/x86/memcpy.c
A payloads/cbui/arch/x86/memcpy.h
A payloads/cbui/arch/x86/vga.c
A payloads/cbui/arch/x86/vga.h
A payloads/cbui/cbui.c
A payloads/cbui/cbui.h
A payloads/cbui/fsys/usbstorage.c
A payloads/cbui/fsys/usbstorage.h
A payloads/cbui/gfx/coreboot.c
A payloads/cbui/gfx/coreboot.h
A payloads/cbui/gfx/gfx.c
A payloads/cbui/gfx/gfx.h
A payloads/cbui/gfx/splash.c
A payloads/cbui/gfx/splash.h
A payloads/cbui/gfx/vbe.c
A payloads/cbui/gfx/vbe.h
A payloads/cbui/lang/de.c
A payloads/cbui/lang/en.c
A payloads/cbui/lang/lang.c
A payloads/cbui/lang/lang.h
A payloads/cbui/logo/cbui.png
A payloads/cbui/lp.config
A payloads/cbui/modules/bootlog_module.c
A payloads/cbui/modules/cbfs_module.c
A payloads/cbui/modules/cmos_module.c
A payloads/cbui/modules/coreboot_module.c
A payloads/cbui/modules/cpuinfo_module.c
A payloads/cbui/modules/license_module.c
A payloads/cbui/modules/modules.c
A payloads/cbui/modules/modules.h
A payloads/cbui/modules/nvram_module.c
A payloads/cbui/modules/pci_module.c
A payloads/cbui/modules/reboot_module.c
A payloads/cbui/modules/rtc_module.c
A payloads/cbui/modules/rw_module.c
A payloads/cbui/modules/timestamps_module.c
A payloads/cbui/modules/usb_module.c
A payloads/libpayload/configs/defconfig-cbui
88 files changed, 12,395 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/23586/49
--
To view, visit https://review.coreboot.org/c/coreboot/+/23586
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib9a1a07c1065880aa675380625021750d5cab7d1
Gerrit-Change-Number: 23586
Gerrit-PatchSet: 49
Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Iman Bingi <imanbingy(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Iman Bingi <imanbingy(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Sean Rhodes.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67027 )
Change subject: mb/starlabs/starbook/tgl: Use chipset.cb aliases
......................................................................
Patch Set 5:
(3 comments)
Patchset:
PS5:
Shouldn't this keep things the same? You could compare the `build/mainboard/*/*/static.c`.
File src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/67027/comment/2d994f38_48b2d1ea
PS5, Line 88: device ref north_xhci on
Shouldn't this be the PCH one?
https://review.coreboot.org/c/coreboot/+/67027/comment/4c580ebc_417025ec
PS5, Line 110: device ref north_xdci on end
Why turn it on?
--
To view, visit https://review.coreboot.org/c/coreboot/+/67027
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie9655406c7afe7a22f131d35633a697c5bbde4e3
Gerrit-Change-Number: 67027
Gerrit-PatchSet: 5
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Ben McMillen <ben(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Comment-Date: Thu, 06 Oct 2022 12:38:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Christian Walter, Lean Sheng Tan, David.Milosevic(a)9elements.com.
Hello build bot (Jenkins), Christian Walter, Angel Pons, Lean Sheng Tan,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/68137
to look at the new patch set (#2).
Change subject: [WIP] mb/prodrive/atlas: Populate smbios table with VPD from ECs EMI
......................................................................
[WIP] mb/prodrive/atlas: Populate smbios table with VPD from ECs EMI
The embedded controller stores serial-number and part-number within
an EEPROM which is unreachable to the Host CPU. Therefore, on the
EC side, we set up a shared memory region with the help of EMI
and copy the VPDs to it. On the coreboot side, we can read those
back and populate the SMBios table type 1 with the serial-number and
type 11 with the part-number.
emi.*: small interface to access the EMI regions
vpd.*: uses the emi interface in order to read the VPDs
smbios.c: populates smbios type 1 with the serial-number by using
vpd.h
mainboard.c: uses vpd.h to add a string to smbios type 11
ld_config.*: offers functionality to configure logical devices
devicetree.cb: enables address range 0xc00-0xcff for the EMI runtime
registers
Makefile.inc: adds emi.c, vpd.c, smbios.c, ld_config.c to the ramstage
compilation
TODO: ld_config.* is redundant. We can replace this with pnp_device.h
or pnp_ops.h
Signed-off-by: Milo-D <David.Milosevic(a)9elements.com>
Change-Id: I47bb4883c43ff344a9bda92c3106dd025533b391
---
M src/mainboard/prodrive/atlas/Makefile.inc
M src/mainboard/prodrive/atlas/devicetree.cb
A src/mainboard/prodrive/atlas/emi.c
A src/mainboard/prodrive/atlas/emi.h
A src/mainboard/prodrive/atlas/ld_config.c
A src/mainboard/prodrive/atlas/ld_config.h
M src/mainboard/prodrive/atlas/mainboard.c
A src/mainboard/prodrive/atlas/smbios.c
A src/mainboard/prodrive/atlas/vpd.c
A src/mainboard/prodrive/atlas/vpd.h
10 files changed, 528 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/68137/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/68137
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47bb4883c43ff344a9bda92c3106dd025533b391
Gerrit-Change-Number: 68137
Gerrit-PatchSet: 2
Gerrit-Owner: David.Milosevic(a)9elements.com
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: David.Milosevic(a)9elements.com
Gerrit-MessageType: newpatchset
Attention is currently required from: Sean Rhodes.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67027 )
Change subject: mb/starlabs/starbook/tgl: Use chipset.cb aliases
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/67027
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie9655406c7afe7a22f131d35633a697c5bbde4e3
Gerrit-Change-Number: 67027
Gerrit-PatchSet: 5
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Ben McMillen <ben(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Comment-Date: Thu, 06 Oct 2022 12:36:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Sean Rhodes.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67421 )
Change subject: mb/starlabs/starbook/kbl: Use chipset.cb aliases
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/67421
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2da15db3d7fba4396c74800e531476c108cafe17
Gerrit-Change-Number: 67421
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Comment-Date: Thu, 06 Oct 2022 12:36:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment