coreboot-gerrit October 2022

coreboot-gerrit@coreboot.org

1 participants
5881 discussions

[L] Change in coreboot[master]: [WIP] mb/prodrive/atlas: Populate smbios table with VPD from ECs EMI
by build bot (Jenkins) (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Patrick Rudolph, Christian Walter, Angel Pons, Lean Sheng Tan. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68137 ) Change subject: [WIP] mb/prodrive/atlas: Populate smbios table with VPD from ECs EMI ...................................................................... Patch Set 5: (6 comments) File src/mainboard/prodrive/atlas/emi.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159864): https://review.coreboot.org/c/coreboot/+/68137/comment/3b31797e_48f92f4c PS5, Line 51: switch (access) { switch and case should be at the same indent Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159864): https://review.coreboot.org/c/coreboot/+/68137/comment/1ad7e4b8_347f908c PS5, Line 89: switch (access) { switch and case should be at the same indent File src/mainboard/prodrive/atlas/mainboard.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159864): https://review.coreboot.org/c/coreboot/+/68137/comment/ffaba98a_f1359106 PS5, Line 14: static const char* get_smbios_part_number(void); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159864): https://review.coreboot.org/c/coreboot/+/68137/comment/ee70bc3c_f3e844de PS5, Line 41: static const char* get_smbios_part_number(void) "foo* bar" should be "foo *bar" File src/mainboard/prodrive/atlas/smbios.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159864): https://review.coreboot.org/c/coreboot/+/68137/comment/ed0f7cf7_55bbf920 PS5, Line 8: const char* smbios_mainboard_serial_number(void) "foo* bar" should be "foo *bar" File src/mainboard/prodrive/atlas/vpd.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159864): https://review.coreboot.org/c/coreboot/+/68137/comment/fd102c78_cbbf620a PS5, Line 34: switch (vpd) { switch and case should be at the same indent -- To view, visit https://review.coreboot.org/c/coreboot/+/68137 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I47bb4883c43ff344a9bda92c3106dd025533b391 Gerrit-Change-Number: 68137 Gerrit-PatchSet: 5 Gerrit-Owner: David.Milosevic(a)9elements.com Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Thu, 06 Oct 2022 16:42:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: [WIP] mb/prodrive/atlas: Populate smbios table with VPD from ECs EMI
by Name of user not set (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Patrick Rudolph, Christian Walter, Angel Pons, Lean Sheng Tan. Hello build bot (Jenkins), Christian Walter, Angel Pons, Lean Sheng Tan, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68137 to look at the new patch set (#5). Change subject: [WIP] mb/prodrive/atlas: Populate smbios table with VPD from ECs EMI ...................................................................... [WIP] mb/prodrive/atlas: Populate smbios table with VPD from ECs EMI The embedded controller stores serial-number and part-number within an EEPROM which is unreachable to the Host CPU. Therefore, on the EC side, we set up a shared memory region with the help of EMI and copy the VPDs to it. On the coreboot side, we can read those back and populate the SMBios table type 1 with the serial-number and type 11 with the part-number. emi.*: small interface to access the EMI regions vpd.*: uses the emi interface in order to read the VPDs smbios.c: populates smbios type 1 with the serial-number by using vpd.h mainboard.c: uses vpd.h to add a string to smbios type 11 ld_config.*: offers functionality to configure logical devices devicetree.cb: enables address range 0xc00-0xcff for the EMI runtime registers Makefile.inc: adds emi.c, vpd.c, smbios.c, ld_config.c to the ramstage compilation TODO: ld_config.* is redundant. We can replace this with pnp_device.h or pnp_ops.h Signed-off-by: David Milosevic <David.Milosevic(a)9elements.com> Change-Id: I47bb4883c43ff344a9bda92c3106dd025533b391 --- M 3rdparty/blobs M src/mainboard/prodrive/atlas/Makefile.inc M src/mainboard/prodrive/atlas/devicetree.cb A src/mainboard/prodrive/atlas/emi.c A src/mainboard/prodrive/atlas/emi.h A src/mainboard/prodrive/atlas/ld_config.c A src/mainboard/prodrive/atlas/ld_config.h M src/mainboard/prodrive/atlas/mainboard.c A src/mainboard/prodrive/atlas/smbios.c A src/mainboard/prodrive/atlas/vpd.c A src/mainboard/prodrive/atlas/vpd.h 11 files changed, 529 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/68137/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/68137 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I47bb4883c43ff344a9bda92c3106dd025533b391 Gerrit-Change-Number: 68137 Gerrit-PatchSet: 5 Gerrit-Owner: David.Milosevic(a)9elements.com Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: 3rdparty/amd_blobs:Advance submodule pointer
by Jon Murphy (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Jason Glenesk, Karthik Ramasubramanian. Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68115 ) Change subject: 3rdparty/amd_blobs:Advance submodule pointer ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68115 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia28bba399ed527863f18ecd790c7096254873298 Gerrit-Change-Number: 68115 Gerrit-PatchSet: 2 Gerrit-Owner: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 06 Oct 2022 15:56:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: 3rdparty/amd_blobs:Advance submodule pointer
by Jason Glenesk (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Jason Glenesk, Karthik Ramasubramanian. Hello build bot (Jenkins), Jon Murphy, Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68115 to look at the new patch set (#2). Change subject: 3rdparty/amd_blobs:Advance submodule pointer ...................................................................... 3rdparty/amd_blobs:Advance submodule pointer This picks up the following changes: 84928ce2 mendocino: Upgrade SMU to 90.35.0 12ca1df1 mendocino: Add all blobs from PI 1.0.0.2 Change-Id: Ia28bba399ed527863f18ecd790c7096254873298 Signed-off-by: Jason Glenesk <jason.glenesk(a)amd.com> --- M 3rdparty/amd_blobs 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/68115/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68115 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia28bba399ed527863f18ecd790c7096254873298 Gerrit-Change-Number: 68115 Gerrit-PatchSet: 2 Gerrit-Owner: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/qualcomm: Update the wait time for checking PCIe link up
by mturney mturney (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Shelley Chen, Tim Wawrzynczak, Julius Werner. mturney mturney has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67884 ) Change subject: soc/qualcomm: Update the wait time for checking PCIe link up ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Patchset: PS4: Proxy +1 for Veera who has reviewed and OKed these changes -- To view, visit https://review.coreboot.org/c/coreboot/+/67884 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic67e7207c1e9f589b34705dc24f5d1ea423e2d56 Gerrit-Change-Number: 67884 Gerrit-PatchSet: 4 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: mturney mturney <quic_mturney(a)quicinc.com> Gerrit-CC: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-CC: Veerabhadrarao Badiganti <vbadigan(a)qualcomm.corp-partner.google.com> Gerrit-CC: Venkat Thogaru <thogaru(a)qualcomm.corp-partner.google.com> Gerrit-CC: mturney mturney <mturney(a)codeaurora.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Thu, 06 Oct 2022 15:47:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: [WIP] mb/prodrive/atlas: Populate smbios table with VPD from ECs EMI
by Name of user not set (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Patrick Rudolph, Christian Walter, Angel Pons, Lean Sheng Tan. David.Milosevic(a)9elements.com has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68137 ) Change subject: [WIP] mb/prodrive/atlas: Populate smbios table with VPD from ECs EMI ...................................................................... Patch Set 4: (8 comments) Patchset: PS1: > Would be nice to make the build bot happy in progress :) Patchset: PS2: > Please use your real name in Gerrit. Done File src/mainboard/prodrive/atlas/emi.c: https://review.coreboot.org/c/coreboot/+/68137/comment/180f484e_0d4d938c PS1, Line 15: #define EMI_1_BASE EMI_0_BASE + APPLICATION_ID + 0x1 > > Macros with complex values should be enclosed in parentheses […] APPLICATION_ID is the last EMI runtime register (see page 223 of http://ww1.microchip.com/downloads/en/DeviceDoc/MEC152x-Data-Sheet-DS000034…). Each EMI instance (0 and 1) has its own set of runtime registers which are mapped at address 0xc00. EMI-0's runtime registers are located at 0xc00-0xc0c and EMI-1's registers at 0xc0d-0xc19. Therefore, EMI_1_BASE = EMI_0_BASE + APPLICATION_ID + 0x1 File src/mainboard/prodrive/atlas/vpd.h: https://review.coreboot.org/c/coreboot/+/68137/comment/3517d2a2_3cee3729 PS2, Line 3: #ifndef __VPD_H__ > It's a good idea to "namespace" include guards, to avoid funky issues when two different headers use […] Done https://review.coreboot.org/c/coreboot/+/68137/comment/f99f9ef5_117f85a0 PS2, Line 6: #include <stddef.h> > You use u16 and u8 below, so you'd need <stdint.h>. But you can just #include <types. […] Done https://review.coreboot.org/c/coreboot/+/68137/comment/bea6c0b5_ac00846a PS2, Line 24: * */ > nit: Coding style says that these comments should end like this: […] Done https://review.coreboot.org/c/coreboot/+/68137/comment/d5900019_9872b4e5 PS2, Line 32: extern > We typically don't use `extern` in declarations inside a header. Done https://review.coreboot.org/c/coreboot/+/68137/comment/566d1626_a1379556 PS2, Line 36: > There are two trailing newlines, we only need one. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/68137 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I47bb4883c43ff344a9bda92c3106dd025533b391 Gerrit-Change-Number: 68137 Gerrit-PatchSet: 4 Gerrit-Owner: David.Milosevic(a)9elements.com Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Thu, 06 Oct 2022 15:43:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Christian Walter <christian.walter(a)9elements.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[master]: payloads/cbui: Add new payload CBUI
by build bot (Jenkins) (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Iman Bingi, Martin L Roth, Julius Werner, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23586 ) Change subject: payloads/cbui: Add new payload CBUI ...................................................................... Patch Set 56: (45 comments) File payloads/cbui/NuklearUI/NuklearDatePicker.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/28d3f09c_06a0d1a6 PS56, Line 36: case 6: /* fallthrough */ Prefer 'fallthrough;' over fallthrough comment Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/57b23435_ce119b23 PS56, Line 37: case 9: /* fallthrough */ Prefer 'fallthrough;' over fallthrough comment File payloads/cbui/NuklearUI/NuklearRW.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/a8aceebe_be94245b PS56, Line 289: static const char *titles[] = { "Hex-View", "Header", "Index/Data" }; static const char * array should probably be static const char * const Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/ac4760ac_2c9575c4 PS56, Line 323: static const char *entries[] = { "NVRAM" }; static const char * array should probably be static const char * const File payloads/cbui/NuklearUI/NuklearRwAcpi.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/4e41ae81_655da886 PS56, Line 40: static const char *tools[] = { lang_translate(LANG_SAVE, 0), lang_translate( static const char * array should probably be static const char * const Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/c8bd3b15_6f6634c5 PS56, Line 43: static const char *tabs[] = { "RSDP", "XSDT", "RSDT", "FACP", "HPET", "APIC", "MCFG", static const char * array should probably be static const char * const File payloads/cbui/NuklearUI/NuklearRwAtaAtapi.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/e2027fef_cf72432a PS56, Line 23: static const char *tools[] = { lang_translate(LANG_SAVE, 0), lang_translate( static const char * array should probably be static const char * const Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/9a8cd8eb_5f31e6c6 PS56, Line 26: static const char *tabs[] = { "Hex-View", "Info", "Summary" }; static const char * array should probably be static const char * const File payloads/cbui/NuklearUI/NuklearRwClock.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/ebf38eaa_a218258d PS56, Line 53: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/07c45d24_883b54f3 PS56, Line 56: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const File payloads/cbui/NuklearUI/NuklearRwCpuMsr.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/4b1f410c_2231edee PS56, Line 20: static const char *tools[] = { lang_translate(LANG_SAVE, 0) }; static const char * array should probably be static const char * const Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/88499b82_7b5fe652 PS56, Line 22: static const char *tabs[] = { "MTRR", "User", "Summary" }; static const char * array should probably be static const char * const File payloads/cbui/NuklearUI/NuklearRwDimmSpd.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/35da6393_6b12a62e PS56, Line 61: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save all", "Save bin", static const char * array should probably be static const char * const Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/7fa4b83a_e5adf72f PS56, Line 65: static const char *tabs[] = { "Hex-View", "Info", "Text", "Summary" }; static const char * array should probably be static const char * const File payloads/cbui/NuklearUI/NuklearRwE820.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/6e76734e_9e17a9d2 PS56, Line 20: static const char *tools[] = { lang_translate(LANG_SAVE, 0) }; static const char * array should probably be static const char * const File payloads/cbui/NuklearUI/NuklearRwEc.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/6173bf9d_613d7bf7 PS56, Line 49: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/da728232_43c718e4 PS56, Line 52: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const File payloads/cbui/arch/x86/int32.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/f90eabea_058580c8 PS56, Line 20: typedef struct __attribute__ ((packed)) { Prefer __packed over __attribute__((packed)) File payloads/cbui/arch/x86/int32.nasm: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/80a47834_74eff8c6 PS56, Line 38: struc regs16_t 'struc' may be misspelled - perhaps 'struct'? File payloads/cbui/gfx/vbe.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/6ab86f69_579d39a8 PS56, Line 24: static u8 low_mem[0x1000] __attribute__ ((section(".lowmem"))); Prefer __section(".lowmem") over __attribute__((section(".lowmem"))) File payloads/cbui/lang/de.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/fb39fd7c_cc9364eb PS56, Line 39: "Kein Framebuffer gefunden. CBUI funktioniert nicht" \ Avoid unnecessary line continuations Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/0e443c01_5f686be1 PS56, Line 44: "Der coreboot framebuffer hat keine physikalische " \ Avoid unnecessary line continuations Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/2c7f9e35_6c523cbc PS56, Line 47: "Kein Platz auf dem Heap.\nBitte vergroBere den" \ Avoid unnecessary line continuations Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/d8ffbe42_134348e6 PS56, Line 50: "Konnte die nuklear Bibliothek nicht intitialisieren.\nBitte" \ Avoid unnecessary line continuations Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/6c229b79_73a7cda6 PS56, Line 52: "stelle sicher, das der Framebuffer entweder das RGBX8 oder " \ Avoid unnecessary line continuations Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/2629d8f1_abe62d66 PS56, Line 65: "Fehler: Keine CMOS Eintrage gefunden. Bitte schalte die " \ Avoid unnecessary line continuations Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/09910b3f_50c6ee14 PS56, Line 86: "Fehler: Keine Zeitstempel gefunden. Bitte schalte die " \ Avoid unnecessary line continuations Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/212f55c0_5d8ffd31 PS56, Line 89: "Fehler: Bootlog nicht gefunden. Bitte schalte die Kconfig " \ Avoid unnecessary line continuations File payloads/cbui/lang/en.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/479ee03d_246d01fe PS56, Line 38: "No framebuffer found. CBUI doesn't work in text mode.\n" \ Avoid unnecessary line continuations Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/d426eeb0_5ba92c55 PS56, Line 46: "Failed to init nuklear library.\nMake sure you have enough " \ Avoid unnecessary line continuations Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/8736add3_46a5f38a PS56, Line 60: "ERROR: No CMOS options found. Please make sure to enable " \ Avoid unnecessary line continuations Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/5d00cfd0_cfa43d15 PS56, Line 81: "ERROR: No timestamps found. Please make sure to enable " \ Avoid unnecessary line continuations Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/a194c0cc_3f0d1110 PS56, Line 84: "ERROR: Bootlog not found. Please make sure to enable " \ Avoid unnecessary line continuations File payloads/cbui/modules/bootlog_module.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/8bca37a4_16ddafc9 PS56, Line 28: } __attribute__ ((__packed__)); Prefer __packed over __attribute__((__packed__)) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/4518ff0b_184bcd7e PS56, Line 82: } void function return statements are not generally useful File payloads/cbui/modules/cbfs_module.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/3841f0af_f33b63d9 PS56, Line 50: } __attribute__ ((packed)); Prefer __packed over __attribute__((packed)) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/894011d7_d614b076 PS56, Line 59: } __attribute__ ((packed)); Prefer __packed over __attribute__((packed)) File payloads/cbui/modules/cpuinfo_module.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/206740ad_9608a9f7 PS56, Line 35: static const char *intel_cap_edx_flags[] = { static const char * array should probably be static const char * const Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/0b793d48_f755c0c2 PS56, Line 43: static const char *amd_cap_edx_flags[] = { static const char * array should probably be static const char * const Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/9c0f402f_130447a3 PS56, Line 51: static const char *intel_cap_ecx_flags[] = { static const char * array should probably be static const char * const Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/76d5e9cb_e1a59c26 PS56, Line 59: static const char *amd_cap_ecx_flags[] = { static const char * array should probably be static const char * const Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/542b7762_4f506278 PS56, Line 67: static const char *intel_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/fa7ca3a1_1032421f PS56, Line 75: static const char *intel_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/7ffe1442_c398708a PS56, Line 83: static const char *amd_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/42f3fb18_206b8491 PS56, Line 92: static const char *amd_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const -- To view, visit https://review.coreboot.org/c/coreboot/+/23586 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib9a1a07c1065880aa675380625021750d5cab7d1 Gerrit-Change-Number: 23586 Gerrit-PatchSet: 56 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Iman Bingi <imanbingy(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Iman Bingi <imanbingy(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 06 Oct 2022 15:43:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: [WIP] mb/prodrive/atlas: Populate smbios table with VPD from ECs EMI
by build bot (Jenkins) (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Patrick Rudolph, Lean Sheng Tan, David.Milosevic(a)9elements.com. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68137 ) Change subject: [WIP] mb/prodrive/atlas: Populate smbios table with VPD from ECs EMI ...................................................................... Patch Set 4: (7 comments) File src/mainboard/prodrive/atlas/emi.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159861): https://review.coreboot.org/c/coreboot/+/68137/comment/3cf59641_bc7630df PS4, Line 51: switch (access) { switch and case should be at the same indent Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159861): https://review.coreboot.org/c/coreboot/+/68137/comment/bee7dcd8_b3495af1 PS4, Line 89: switch(access) { switch and case should be at the same indent Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159861): https://review.coreboot.org/c/coreboot/+/68137/comment/51225faa_a5a68b2e PS4, Line 89: switch(access) { space required before the open parenthesis '(' File src/mainboard/prodrive/atlas/mainboard.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159861): https://review.coreboot.org/c/coreboot/+/68137/comment/ad97ada8_0f6fc5db PS4, Line 14: static const char* get_smbios_part_number(void); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159861): https://review.coreboot.org/c/coreboot/+/68137/comment/0d09fb1c_8ce93bf4 PS4, Line 41: static const char* get_smbios_part_number(void) "foo* bar" should be "foo *bar" File src/mainboard/prodrive/atlas/smbios.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159861): https://review.coreboot.org/c/coreboot/+/68137/comment/7f5ed9de_7f95a972 PS4, Line 8: const char* smbios_mainboard_serial_number(void) "foo* bar" should be "foo *bar" File src/mainboard/prodrive/atlas/vpd.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159861): https://review.coreboot.org/c/coreboot/+/68137/comment/71f8323f_adeff023 PS4, Line 34: switch (vpd) { switch and case should be at the same indent -- To view, visit https://review.coreboot.org/c/coreboot/+/68137 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I47bb4883c43ff344a9bda92c3106dd025533b391 Gerrit-Change-Number: 68137 Gerrit-PatchSet: 4 Gerrit-Owner: David.Milosevic(a)9elements.com Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: David.Milosevic(a)9elements.com Gerrit-Comment-Date: Thu, 06 Oct 2022 15:43:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[master]: payloads/cbui: Add new payload CBUI
by Iman Bingi (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Iman Bingi, Martin L Roth, Julius Werner, Patrick Rudolph. Iman Bingi has uploaded a new patch set (#56) to the change originally created by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/23586 ) Change subject: payloads/cbui: Add new payload CBUI ...................................................................... payloads/cbui: Add new payload CBUI Depends on libpayload and nuklear. Features: * Graphical menus with scrolling. * Text rendering engine (atm only bitmap font) * Support for keyboard and mouse * Support for USB and PS/2 devices * Ported coreinfo and nvramcui * Allows to modify NVRAM and RTC * Works as ELF payload * Works as Seabios secondary payload * Basic support for multiple languages * Hacky support for BIOS calls (depends on NASM) * Runs in qemu and on real hardware * Use linker script to allocate low memory Shortcomings: * Doesn't work in VGA text mode * Untested on UEFI * int32 relocates itself to low memory Licenses: * GPLv2 (CBUI + libpayload) * BSD (libpayload) * MIT (nuklear) TODO: * Test on as much platforms as possible * Link int32 into low memory This is Patrick Rudolph's original patch, updated by Ben Adu-Boahen to: * Add Read/Write module * This module allows read/write to any hardware component that is readable/writeable Note: This is work in progress Change-Id: Ib9a1a07c1065880aa675380625021750d5cab7d1 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> Signed-off-by: Ben Adu-Boahen <imanbingy(a)gmail.com> --- M payloads/Kconfig M payloads/Makefile.inc A payloads/cbui/.gitignore A payloads/cbui/Kconfig A payloads/cbui/Makefile A payloads/cbui/NuklearUI/NuklearCombo.c A payloads/cbui/NuklearUI/NuklearCombo.h A payloads/cbui/NuklearUI/NuklearCommon.h A payloads/cbui/NuklearUI/NuklearDataGrid.c A payloads/cbui/NuklearUI/NuklearDataGrid.h A payloads/cbui/NuklearUI/NuklearDatePicker.c A payloads/cbui/NuklearUI/NuklearDatePicker.h A payloads/cbui/NuklearUI/NuklearFieldFile.c A payloads/cbui/NuklearUI/NuklearFieldFile.h A payloads/cbui/NuklearUI/NuklearFieldHex.c A payloads/cbui/NuklearUI/NuklearFieldHex.h A payloads/cbui/NuklearUI/NuklearFileChooser.c A payloads/cbui/NuklearUI/NuklearFileChooser.h A payloads/cbui/NuklearUI/NuklearGroup.c A payloads/cbui/NuklearUI/NuklearGroup.h A payloads/cbui/NuklearUI/NuklearHex.c A payloads/cbui/NuklearUI/NuklearHex.h A payloads/cbui/NuklearUI/NuklearIntegerRange.c A payloads/cbui/NuklearUI/NuklearIntegerRange.h A payloads/cbui/NuklearUI/NuklearLabel.c A payloads/cbui/NuklearUI/NuklearLabel.h A payloads/cbui/NuklearUI/NuklearObject.c A payloads/cbui/NuklearUI/NuklearObject.h A payloads/cbui/NuklearUI/NuklearPciHeader.c A payloads/cbui/NuklearUI/NuklearPciHeader.h A payloads/cbui/NuklearUI/NuklearRW.c A payloads/cbui/NuklearUI/NuklearRW.h A payloads/cbui/NuklearUI/NuklearRoot.c A payloads/cbui/NuklearUI/NuklearRwAcpi.c A payloads/cbui/NuklearUI/NuklearRwAcpi.h A payloads/cbui/NuklearUI/NuklearRwAtaAtapi.c A payloads/cbui/NuklearUI/NuklearRwAtaAtapi.h A payloads/cbui/NuklearUI/NuklearRwClock.c A payloads/cbui/NuklearUI/NuklearRwClock.h A payloads/cbui/NuklearUI/NuklearRwCpuMsr.c A payloads/cbui/NuklearUI/NuklearRwCpuMsr.h A payloads/cbui/NuklearUI/NuklearRwDimmSpd.c A payloads/cbui/NuklearUI/NuklearRwDimmSpd.h A payloads/cbui/NuklearUI/NuklearRwE820.c A payloads/cbui/NuklearUI/NuklearRwE820.h A payloads/cbui/NuklearUI/NuklearRwEc.c A payloads/cbui/NuklearUI/NuklearRwEc.h A payloads/cbui/NuklearUI/NuklearStyle.c A payloads/cbui/NuklearUI/NuklearStyle.h A payloads/cbui/NuklearUI/NuklearTabView.c A payloads/cbui/NuklearUI/NuklearTextView.c A payloads/cbui/NuklearUI/NuklearTextView.h A payloads/cbui/NuklearUI/NuklearTextfield.c A payloads/cbui/NuklearUI/NuklearTextfield.h A payloads/cbui/NuklearUI/NuklearTimePicker.c A payloads/cbui/NuklearUI/NuklearTimePicker.h A payloads/cbui/NuklearUI/NuklearUI.h A payloads/cbui/NuklearUI/NuklearVector.c A payloads/cbui/NuklearUI/NuklearVector.h A payloads/cbui/arch/x86/cpuid.c A payloads/cbui/arch/x86/cpuid.h A payloads/cbui/arch/x86/int32.h A payloads/cbui/arch/x86/int32.ld A payloads/cbui/arch/x86/int32.nasm A payloads/cbui/arch/x86/memcpy.c A payloads/cbui/arch/x86/memcpy.h A payloads/cbui/arch/x86/vga.c A payloads/cbui/arch/x86/vga.h A payloads/cbui/cbui.c A payloads/cbui/cbui.h A payloads/cbui/fsys/usbstorage.c A payloads/cbui/fsys/usbstorage.h A payloads/cbui/gfx/coreboot.c A payloads/cbui/gfx/coreboot.h A payloads/cbui/gfx/gfx.c A payloads/cbui/gfx/gfx.h A payloads/cbui/gfx/splash.c A payloads/cbui/gfx/splash.h A payloads/cbui/gfx/vbe.c A payloads/cbui/gfx/vbe.h A payloads/cbui/lang/de.c A payloads/cbui/lang/en.c A payloads/cbui/lang/lang.c A payloads/cbui/lang/lang.h A payloads/cbui/logo/cbui.png A payloads/cbui/lp.config A payloads/cbui/modules/bootlog_module.c A payloads/cbui/modules/cbfs_module.c A payloads/cbui/modules/cmos_module.c A payloads/cbui/modules/coreboot_module.c A payloads/cbui/modules/cpuinfo_module.c A payloads/cbui/modules/license_module.c A payloads/cbui/modules/modules.c A payloads/cbui/modules/modules.h A payloads/cbui/modules/nvram_module.c A payloads/cbui/modules/pci_module.c A payloads/cbui/modules/reboot_module.c A payloads/cbui/modules/rtc_module.c A payloads/cbui/modules/rw_module.c A payloads/cbui/modules/timestamps_module.c A payloads/cbui/modules/usb_module.c A payloads/libpayload/configs/defconfig-cbui 102 files changed, 13,387 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/23586/56 -- To view, visit https://review.coreboot.org/c/coreboot/+/23586 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib9a1a07c1065880aa675380625021750d5cab7d1 Gerrit-Change-Number: 23586 Gerrit-PatchSet: 56 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Iman Bingi <imanbingy(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Iman Bingi <imanbingy(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[master]: [WIP] mb/prodrive/atlas: Populate smbios table with VPD from ECs EMI
by Name of user not set (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Patrick Rudolph, Lean Sheng Tan, David.Milosevic(a)9elements.com. Hello build bot (Jenkins), Christian Walter, Angel Pons, Lean Sheng Tan, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68137 to look at the new patch set (#4). Change subject: [WIP] mb/prodrive/atlas: Populate smbios table with VPD from ECs EMI ...................................................................... [WIP] mb/prodrive/atlas: Populate smbios table with VPD from ECs EMI The embedded controller stores serial-number and part-number within an EEPROM which is unreachable to the Host CPU. Therefore, on the EC side, we set up a shared memory region with the help of EMI and copy the VPDs to it. On the coreboot side, we can read those back and populate the SMBios table type 1 with the serial-number and type 11 with the part-number. emi.*: small interface to access the EMI regions vpd.*: uses the emi interface in order to read the VPDs smbios.c: populates smbios type 1 with the serial-number by using vpd.h mainboard.c: uses vpd.h to add a string to smbios type 11 ld_config.*: offers functionality to configure logical devices devicetree.cb: enables address range 0xc00-0xcff for the EMI runtime registers Makefile.inc: adds emi.c, vpd.c, smbios.c, ld_config.c to the ramstage compilation TODO: ld_config.* is redundant. We can replace this with pnp_device.h or pnp_ops.h Signed-off-by: David Milosevic <David.Milosevic(a)9elements.com> Change-Id: I47bb4883c43ff344a9bda92c3106dd025533b391 --- M src/mainboard/prodrive/atlas/Makefile.inc M src/mainboard/prodrive/atlas/devicetree.cb A src/mainboard/prodrive/atlas/emi.c A src/mainboard/prodrive/atlas/emi.h A src/mainboard/prodrive/atlas/ld_config.c A src/mainboard/prodrive/atlas/ld_config.h M src/mainboard/prodrive/atlas/mainboard.c A src/mainboard/prodrive/atlas/smbios.c A src/mainboard/prodrive/atlas/vpd.c A src/mainboard/prodrive/atlas/vpd.h 10 files changed, 528 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/68137/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/68137 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I47bb4883c43ff344a9bda92c3106dd025533b391 Gerrit-Change-Number: 68137 Gerrit-PatchSet: 4 Gerrit-Owner: David.Milosevic(a)9elements.com Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: David.Milosevic(a)9elements.com Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2022